110256 2013-02-19 13:27:16 -0800 [BlackBerry] Move posting and scrollbar updates to the page client 2013-02-21 08:51:52 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jpetsovits jpetsovits anilsson anlo gmak mifenton mlattanzio rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 836719 0 jpetsovits 2013-02-19 13:27:16 -0800 In blitVisibleContents(), we were calling the WebKit thread functions BackingStorePrivate::isScrollingOrZooming() and WebPage::isVisible(). This is not the right spot to do it. Furthermore, we want to move away from direct window access in WebKit and leave that kind of dirtywork to the client. The patch below removes invalidateWindow() as well as the two virtual scrollbar drawing functions and replaces it with one new virtual, WebPageClient::postToSurface(). This clears up threading issues and gets us another step further towards pure WebPageCompositor rendering. 836728 1 189153 jpetsovits 2013-02-19 13:33:12 -0800 Created attachment 189153 Patch 837176 2 189153 anilsson 2013-02-19 22:31:59 -0800 Comment on attachment 189153 Patch I feel the "Post" terminology is a QNXism, it should be possible to find a term that makes more sense from a WebKit perspective. The method will eventually call eglSwapBuffers (or a subrect swapping extension). But I guess "Swap" would be an EGLism. So LGTM. 837199 3 jpetsovits 2013-02-19 23:01:56 -0800 I guess "Post" is strong in QNX land, but not exclusive to it. The EGL_NV_post_sub_buffer extension for instance adopted the same nomenclature for the same functionality after also considering "Present" or "Copy" as alternatives. In my understanding, "Swap" refers more to the concept of replacing the full buffer rather than presenting a portion of the buffer in the target window or parent container. I guess a "Post" will usually flush commands and swap surfaces like eglSwapBuffers() would, but at least the swapping part seems like it could be optional in some implementations and the focus is on propagating the contents to the screen or parent container, which is more the intention of this patch. Thanks for your input! 838430 4 189153 rwlbuis 2013-02-21 08:05:03 -0800 Comment on attachment 189153 Patch Ok. 838472 5 189153 webkit.review.bot 2013-02-21 08:51:48 -0800 Comment on attachment 189153 Patch Clearing flags on attachment: 189153 Committed r143610: <http://trac.webkit.org/changeset/143610> 838473 6 webkit.review.bot 2013-02-21 08:51:52 -0800 All reviewed patches have been landed. Closing bug. 189153 2013-02-19 13:33:12 -0800 2013-02-21 08:51:48 -0800 Patch bug-110256-20130219162917.patch text/plain 6496 jpetsovits U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzMzc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBhN2I3MTQxOWRmOTRlOGRkZGU5N2RjZWMyZWU0ODVlMzU5ZmE2M2JlLi5lYTFhMDQ2NTdm N2Q0OGE0ZjAyMDM4MmRiZGE0NGJlNTNkYjNiMDM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyOSBAQAorMjAxMy0wMi0xOSAgSmFrb2IgUGV0c292aXRzICA8anBl dHNvdml0c0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBNb3ZlIHBvc3RpbmcgYW5k IHNjcm9sbGJhciB1cGRhdGVzIHRvIHRoZSBwYWdlIGNsaWVudC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDI1NgorICAgICAgICBJbnRlcm5hbCBQ UiAyOTcwOTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBJbiBibGl0VmlzaWJsZUNvbnRlbnRzKCksIHdlIHdlcmUgY2FsbGluZyB0aGUgV2ViS2l0IHRo cmVhZAorICAgICAgICBmdW5jdGlvbnMgQmFja2luZ1N0b3JlUHJpdmF0ZTo6aXNTY3JvbGxpbmdP clpvb21pbmcoKSBhbmQKKyAgICAgICAgV2ViUGFnZTo6aXNWaXNpYmxlKCkuIFRoaXMgaXMgbm90 IHRoZSByaWdodCBzcG90IHRvIGRvIGl0LgorICAgICAgICBGdXJ0aGVybW9yZSwgd2Ugd2FudCB0 byBtb3ZlIGF3YXkgZnJvbSBkaXJlY3Qgd2luZG93IGFjY2VzcworICAgICAgICBpbiBXZWJLaXQg YW5kIGxlYXZlIHRoYXQga2luZCBvZiBkaXJ0eXdvcmsgdG8gdGhlIGNsaWVudC4KKworICAgICAg ICBUaGlzIHBhdGNoIHJlbW92ZXMgaW52YWxpZGF0ZVdpbmRvdygpIGFzIHdlbGwgYXMgdGhlIHR3 bworICAgICAgICB2aXJ0dWFsIHNjcm9sbGJhciBkcmF3aW5nIGZ1bmN0aW9ucyBhbmQgcmVwbGFj ZXMgaXQgd2l0aAorICAgICAgICBvbmUgbmV3IHZpcnR1YWwsIFdlYlBhZ2VDbGllbnQ6OnBvc3RU b1N1cmZhY2UoKS4KKyAgICAgICAgVGhpcyBjbGVhcnMgdXAgdGhyZWFkaW5nIGlzc3VlcyBhbmQg Z2V0cyB1cyBhbm90aGVyIHN0ZXAKKyAgICAgICAgZnVydGhlciB0b3dhcmRzIHB1cmUgV2ViUGFn ZUNvbXBvc2l0b3IgcmVuZGVyaW5nLgorCisgICAgICAgICogQXBpL0JhY2tpbmdTdG9yZS5jcHA6 CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OkJhY2tpbmdTdG9yZVByaXZhdGU6OmJsaXRW aXNpYmxlQ29udGVudHMpOgorICAgICAgICAqIEFwaS9CYWNraW5nU3RvcmVfcC5oOgorICAgICAg ICAoQmFja2luZ1N0b3JlUHJpdmF0ZSk6CisgICAgICAgICogQXBpL1dlYlBhZ2VDbGllbnQuaDoK KwogMjAxMy0wMi0xNCAgSmFrb2IgUGV0c292aXRzICA8anBldHNvdml0c0ByaW0uY29tPgogCiAg ICAgICAgIFtCbGFja0JlcnJ5XSBNYWtlIHN1cmUgdG8gYWx3YXlzIHN5bmMgYmVmb3JlIHJldXNp bmcgYmFja2luZ3N0b3JlIHRpbGVzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2Jl cnJ5L0FwaS9CYWNraW5nU3RvcmUuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9C YWNraW5nU3RvcmUuY3BwCmluZGV4IDkwNmUwZTU0MDUzNGVlNzZhMDg1YWI0YWFlYjU4ZTI1MGI1 NzMyNzkuLjM3NzJiMzdkM2Q3YWNlMWI4ZjYzZmI4Yjk4YTFiYzQ5ZGMzZDVmMmYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0b3JlLmNwcAorKysgYi9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0JhY2tpbmdTdG9yZS5jcHAKQEAgLTEyNTcsNyAr MTI1Nyw3IEBAIHZvaWQgQmFja2luZ1N0b3JlUHJpdmF0ZTo6YmxpdFZpc2libGVDb250ZW50cyhi b29sIGZvcmNlKQogICAgICAgICBpZiAoIXRyYW5zZm9ybWVkQ29udGVudHNSZWN0LmlzRW1wdHko KSkgewogICAgICAgICAgICAgY2xpcHBlZFRyYW5zZm9ybWVkU3JjUmVjdC5pbnRlcnNlY3QodHJh bnNmb3JtZWRDb250ZW50c1JlY3QpOwogICAgICAgICAgICAgaWYgKGNsaXBwZWRUcmFuc2Zvcm1l ZFNyY1JlY3QuaXNFbXB0eSgpKSB7Ci0gICAgICAgICAgICAgICAgaW52YWxpZGF0ZVdpbmRvdyhk c3RSZWN0KTsKKyAgICAgICAgICAgICAgICBtX3dlYlBhZ2UtPmNsaWVudCgpLT5wb3N0VG9TdXJm YWNlKGRzdFJlY3QpOwogICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgIH0KIApA QCAtMTM1OSwxMyArMTM1OSw2IEBAIHZvaWQgQmFja2luZ1N0b3JlUHJpdmF0ZTo6YmxpdFZpc2li bGVDb250ZW50cyhib29sIGZvcmNlKQogICAgIH0KICNlbmRpZgogCi0jaWYgRU5BQkxFX1NDUk9M TEJBUlMKLSAgICBpZiAoaXNTY3JvbGxpbmdPclpvb21pbmcoKSAmJiBtX2NsaWVudC0+aXNNYWlu RnJhbWUoKSkgewotICAgICAgICBibGl0SG9yaXpvbnRhbFNjcm9sbGJhcigpOwotICAgICAgICBi bGl0VmVydGljYWxTY3JvbGxiYXIoKTsKLSAgICB9Ci0jZW5kaWYKLQogI2lmIERFQlVHX1ZJU1VB TElaRQogICAgIGlmIChkZWJ1Z1ZpZXdwb3J0QWNjZXNzb3IpIHsKICAgICAgICAgUGxhdGZvcm06 OkdyYXBoaWNzOjpCdWZmZXIqIHRhcmdldEJ1ZmZlciA9IGJ1ZmZlcigpOwpAQCAtMTQwOCw3ICsx NDAxLDcgQEAgdm9pZCBCYWNraW5nU3RvcmVQcml2YXRlOjpibGl0VmlzaWJsZUNvbnRlbnRzKGJv b2wgZm9yY2UpCiAgICAgfQogI2VuZGlmCiAKLSAgICBpbnZhbGlkYXRlV2luZG93KGRzdFJlY3Qp OworICAgIG1fd2ViUGFnZS0+Y2xpZW50KCktPnBvc3RUb1N1cmZhY2UoZHN0UmVjdCk7CiB9CiAK ICNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCkBAIC0xNTA4LDIyICsxNTAxLDYgQEAg UGxhdGZvcm06OkludFJlY3QgQmFja2luZ1N0b3JlUHJpdmF0ZTo6YmxpdFRpbGVSZWN0KFRpbGVC dWZmZXIqIHRpbGVCdWZmZXIsCiAgICAgcmV0dXJuIGRzdFJlY3Q7CiB9CiAKLXZvaWQgQmFja2lu Z1N0b3JlUHJpdmF0ZTo6YmxpdEhvcml6b250YWxTY3JvbGxiYXIoKQotewotICAgIGlmICghbV93 ZWJQYWdlLT5pc1Zpc2libGUoKSkKLSAgICAgICAgcmV0dXJuOwotCi0gICAgbV93ZWJQYWdlLT5j bGllbnQoKS0+ZHJhd0hvcml6b250YWxTY3JvbGxiYXIoKTsKLX0KLQotdm9pZCBCYWNraW5nU3Rv cmVQcml2YXRlOjpibGl0VmVydGljYWxTY3JvbGxiYXIoKQotewotICAgIGlmICghbV93ZWJQYWdl LT5pc1Zpc2libGUoKSkKLSAgICAgICAgcmV0dXJuOwotCi0gICAgbV93ZWJQYWdlLT5jbGllbnQo KS0+ZHJhd1ZlcnRpY2FsU2Nyb2xsYmFyKCk7Ci19Ci0KIGJvb2wgQmFja2luZ1N0b3JlUHJpdmF0 ZTo6aXNUaWxlVmlzaWJsZShjb25zdCBUaWxlSW5kZXgmIGluZGV4LCBCYWNraW5nU3RvcmVHZW9t ZXRyeSogZ2VvbWV0cnkpIGNvbnN0CiB7CiAgICAgcmV0dXJuIGlzVGlsZVZpc2libGUoZ2VvbWV0 cnktPm9yaWdpbk9mVGlsZShpbmRleCkpOwpAQCAtMjAxMiwzNyArMTk4OSw2IEBAIHZvaWQgQmFj a2luZ1N0b3JlUHJpdmF0ZTo6c2V0V2ViUGFnZUJhY2tncm91bmRDb2xvcihjb25zdCBXZWJDb3Jl OjpDb2xvciYgY29sb3IpCiAgICAgbV93ZWJQYWdlQmFja2dyb3VuZENvbG9yID0gY29sb3I7CiB9 CiAKLXZvaWQgQmFja2luZ1N0b3JlUHJpdmF0ZTo6aW52YWxpZGF0ZVdpbmRvdyhjb25zdCBQbGF0 Zm9ybTo6SW50UmVjdCYgZHN0KQotewotICAgIEFTU0VSVChCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6 dXNlckludGVyZmFjZVRocmVhZE1lc3NhZ2VDbGllbnQoKS0+aXNDdXJyZW50VGhyZWFkKCkpOwot Ci0gICAgaWYgKGRzdC5pc0VtcHR5KCkpCi0gICAgICAgIHJldHVybjsKLQotI2lmIERFQlVHX0JB Q0tJTkdTVE9SRQotICAgIFBsYXRmb3JtOjpsb2dBbHdheXMoUGxhdGZvcm06OkxvZ0xldmVsQ3Jp dGljYWwsCi0gICAgICAgICJCYWNraW5nU3RvcmVQcml2YXRlOjppbnZhbGlkYXRlV2luZG93IGRz dCA9ICVzIiwKLSAgICAgICAgZHN0LnRvU3RyaW5nKCkuY19zdHIoKSk7Ci0jZW5kaWYKLQotICAg IFBsYXRmb3JtOjpJbnRSZWN0IGRzdFJlY3QgPSBkc3Q7Ci0KLSAgICBQbGF0Zm9ybTo6SW50UmVj dCBzdXJmYWNlUmVjdChQbGF0Zm9ybTo6SW50UG9pbnQoMCwgMCksIHN1cmZhY2VTaXplKCkpOwot ICAgIGRzdFJlY3QuaW50ZXJzZWN0KHN1cmZhY2VSZWN0KTsKLQotICAgIGlmIChkc3RSZWN0Lndp ZHRoKCkgPD0gMCB8fCBkc3RSZWN0LmhlaWdodCgpIDw9IDApCi0gICAgICAgIHJldHVybjsKLQot I2lmIERFQlVHX0JBQ0tJTkdTVE9SRQotICAgIFBsYXRmb3JtOjpsb2dBbHdheXMoUGxhdGZvcm06 OkxvZ0xldmVsQ3JpdGljYWwsCi0gICAgICAgICJCYWNraW5nU3RvcmVQcml2YXRlOjppbnZhbGlk YXRlV2luZG93IHBvc3RpbmcgPSAlcyIsCi0gICAgICAgIGRzdFJlY3QudG9TdHJpbmcoKS5jX3N0 cigpKTsKLSNlbmRpZgotCi0gICAgaWYgKFdpbmRvdyogd2luZG93ID0gbV93ZWJQYWdlLT5jbGll bnQoKS0+d2luZG93KCkpCi0gICAgICAgIHdpbmRvdy0+cG9zdChkc3RSZWN0KTsKLX0KLQogdm9p ZCBCYWNraW5nU3RvcmVQcml2YXRlOjpjbGVhcldpbmRvdyhjb25zdCBQbGF0Zm9ybTo6SW50UmVj dCYgcmVjdCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQg Y2hhciByZWQsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVk IGNoYXIgZ3JlZW4sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0Jh Y2tpbmdTdG9yZV9wLmggYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0JhY2tpbmdTdG9y ZV9wLmgKaW5kZXggMzFlMTFmMmUyOWU4ODU0OGJkYWM1ZjA3ZTEwOTc1NjMyODE5ZTM3Yy4uZjQ4 ZDlkY2Q3NGJiOTAzZWNmY2M1MTM4ZjI4OWYxNTVhZGZhYWVlZiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L0FwaS9CYWNraW5nU3RvcmVfcC5oCisrKyBiL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0b3JlX3AuaApAQCAtMjgzLDcgKzI4Myw2IEBAIHB1 YmxpYzoKICAgICBXZWJDb3JlOjpDb2xvciB3ZWJQYWdlQmFja2dyb3VuZENvbG9yVXNlckludGVy ZmFjZVRocmVhZCgpIGNvbnN0OyAvLyB1c2UgV2ViU2V0dGluZ3M6OmJhY2tncm91bmRDb2xvcigp IGZvciB0aGUgV2ViS2l0IHRocmVhZAogICAgIHZvaWQgc2V0V2ViUGFnZUJhY2tncm91bmRDb2xv cihjb25zdCBXZWJDb3JlOjpDb2xvciYpOwogCi0gICAgdm9pZCBpbnZhbGlkYXRlV2luZG93KGNv bnN0IFBsYXRmb3JtOjpJbnRSZWN0JiBkc3QpOwogICAgIHZvaWQgY2xlYXJXaW5kb3coY29uc3Qg UGxhdGZvcm06OkludFJlY3QmLCB1bnNpZ25lZCBjaGFyIHJlZCwgdW5zaWduZWQgY2hhciBncmVl biwgdW5zaWduZWQgY2hhciBibHVlLCB1bnNpZ25lZCBjaGFyIGFscGhhID0gMjU1KTsKIAogICAg IGJvb2wgaXNTY3JvbGxpbmdPclpvb21pbmcoKSBjb25zdDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZUNsaWVudC5oIGIvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L0FwaS9XZWJQYWdlQ2xpZW50LmgKaW5kZXggMWY4M2YxZTNmYjkzNzExMjM4NDRlMmFl ZGI5ZDA1ODM1OWJkYzhhMC4uM2YwYTgxZWVkZDEzMmYzYmI2MmU3NzliZjA5YWE2ZGJiNDZiZjRj ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlQ2xpZW50 LmgKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlQ2xpZW50LmgKQEAg LTEzOCw2ICsxMzgsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHNldFBhZ2VUaXRsZShj b25zdCB1bnNpZ25lZCBzaG9ydCogdGl0bGUsIHVuc2lnbmVkIHRpdGxlTGVuZ3RoKSA9IDA7CiAK ICAgICB2aXJ0dWFsIFBsYXRmb3JtOjpHcmFwaGljczo6V2luZG93KiB3aW5kb3coKSBjb25zdCA9 IDA7CisgICAgdmlydHVhbCB2b2lkIHBvc3RUb1N1cmZhY2UoY29uc3QgUGxhdGZvcm06OkludFJl Y3QmKSA9IDA7CiAKICAgICB2aXJ0dWFsIHZvaWQgbm90aWZ5UGl4ZWxDb250ZW50UmVuZGVyZWQo Y29uc3QgUGxhdGZvcm06OkludFJlY3QmKSA9IDA7CiAKQEAgLTIzNiw4ICsyMzcsNiBAQCBwdWJs aWM6CiAKICAgICB2aXJ0dWFsIGludCBmdWxsc2NyZWVuU2V0V2luZG93UmVjdChjb25zdCBCbGFj a0JlcnJ5OjpQbGF0Zm9ybTo6SW50UmVjdCYgbmV3V2luZG93U2NyZWVuUmVjdCkgPSAwOwogCi0g ICAgdmlydHVhbCB2b2lkIGRyYXdWZXJ0aWNhbFNjcm9sbGJhcigpID0gMDsKLSAgICB2aXJ0dWFs IHZvaWQgZHJhd0hvcml6b250YWxTY3JvbGxiYXIoKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIHBv cHVsYXRlQ3VzdG9tSGVhZGVycyhQbGF0Zm9ybTo6TmV0d29ya1JlcXVlc3QmKSA9IDA7CiAKICAg ICB2aXJ0dWFsIHZvaWQgbm90aWZ5V2lsbFVwZGF0ZUFwcGxpY2F0aW9uQ2FjaGUoKSA9IDA7Cg==