110254 2013-02-19 12:42:15 -0800 [V8] ScriptRunner::runCompiledScript() should return Handle<Value>() when OOM occurs 2013-02-19 15:03:06 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 836680 0 haraken 2013-02-19 12:42:15 -0800 Chromium bug: https://code.google.com/p/chromium/issues/detail?id=176951 Currently ScriptRunner::runCompiledScript() calls ASSERT(script.IsEmpty()) when OOM occurs. The Chromium bug is hitting the ASSERT(). The ASSERT() does not make sense at all. Instead, we should return an empty handle when OOM occurs. 836683 1 189145 haraken 2013-02-19 12:44:08 -0800 Created attachment 189145 Patch 836809 2 189145 webkit.review.bot 2013-02-19 15:03:02 -0800 Comment on attachment 189145 Patch Clearing flags on attachment: 189145 Committed r143387: <http://trac.webkit.org/changeset/143387> 836810 3 webkit.review.bot 2013-02-19 15:03:06 -0800 All reviewed patches have been landed. Closing bug. 189145 2013-02-19 12:44:08 -0800 2013-02-19 15:03:02 -0800 Patch bug-110254-20130219124031.patch text/plain 1779 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzMzA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDIwZGMzMTQ0YTNjN2Ew NDQ2NjRhZDA0NWEwZWMyM2E1ODQ3ZTg0ZS4uMDc1ZjkyMjc5ZWM5MzY3M2VkODIxM2RkOGMwYjAy Nzg1Y2E0YWNlOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAyLTE5ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGdvb2dsZS5jb20+CisKKyAgICAgICAgW1Y4XSBTY3JpcHRSdW5u ZXI6OnJ1bkNvbXBpbGVkU2NyaXB0KCkgc2hvdWxkIHJldHVybiBIYW5kbGU8VmFsdWU+KCkgd2hl biBPT00gb2NjdXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTAyNTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBDaHJvbWl1bSBidWc6IGh0dHBzOi8vY29kZS5nb29nbGUuY29tL3AvY2hyb21pdW0vaXNz dWVzL2RldGFpbD9pZD0xNzY5NTEKKworICAgICAgICBDdXJyZW50bHkgU2NyaXB0UnVubmVyOjpy dW5Db21waWxlZFNjcmlwdCgpIGNhbGxzCisgICAgICAgIEFTU0VSVChzY3JpcHQuSXNFbXB0eSgp KSB3aGVuIE9PTSBvY2N1cnMuIFRoZSBDaHJvbWl1bSBidWcgaXMKKyAgICAgICAgaGl0dGluZyB0 aGUgQVNTRVJUKCkuIFRoZSBBU1NFUlQoKSBkb2VzIG5vdCBtYWtlIHNlbnNlIGF0IGFsbC4KKyAg ICAgICAgSW5zdGVhZCwgd2Ugc2hvdWxkIHJldHVybiBhbiBlbXB0eSBoYW5kbGUgd2hlbiBPT00g b2NjdXJzLgorCisgICAgICAgIE5vIHRlc3RzLiBUaGUgYnVnIGhhcHBlbnMgb25seSB3aGVuIE9P TSBvY2N1cnMuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9TY3JpcHRSdW5uZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6U2NyaXB0UnVubmVyOjpydW5Db21waWxlZFNjcmlwdCk6CisKIDIwMTMt MDItMTkgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVu cmV2aWV3ZWQgYnVpbGQgZml4IGFmdGVyIHIxNDMzMDQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9TY3JpcHRSdW5uZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvU2NyaXB0UnVubmVyLmNwcAppbmRleCBiNDUzYmFhMGI0NWNhM2FmYzJmMjQ3OTkyM2Jl MjA0YTAzZTYzMjFmLi4yMzRmYzBhNjZlMWUwMmFkYmMyMWE0MmUxMjg0MDg0NmViZDBmNjZmIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRSdW5uZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdFJ1bm5lci5jcHAKQEAgLTQzLDcg KzQzLDcgQEAgdjg6OkxvY2FsPHY4OjpWYWx1ZT4gU2NyaXB0UnVubmVyOjpydW5Db21waWxlZFNj cmlwdCh2ODo6SGFuZGxlPHY4OjpTY3JpcHQ+IHNjcmkKICAgICAgICAgcmV0dXJuIGhhbmRsZU1h eFJlY3Vyc2lvbkRlcHRoRXhjZWVkZWQoKTsKIAogICAgIGlmIChoYW5kbGVPdXRPZk1lbW9yeSgp KQotICAgICAgICBBU1NFUlQoc2NyaXB0LklzRW1wdHkoKSk7CisgICAgICAgIHJldHVybiB2ODo6 TG9jYWw8djg6OlZhbHVlPigpOwogCiAgICAgLy8gUnVuIHRoZSBzY3JpcHQgYW5kIGtlZXAgdHJh Y2sgb2YgdGhlIGN1cnJlbnQgcmVjdXJzaW9uIGRlcHRoLgogICAgIHY4OjpMb2NhbDx2ODo6VmFs dWU+IHJlc3VsdDsK