110233 2013-02-19 09:39:01 -0800 HeapBlock::destroy should issue warning if result is unused 2013-02-19 10:41:50 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg webkit.review.bot oldest_to_newest 836487 0 mhahnenberg 2013-02-19 09:39:01 -0800 To enforce the fact that we need to return blocks to the BlockAllocator after calling destroy, we should add WARN_UNUSED_RETURN to HeapBlock::destroy and any other destroy functions in its subclasses. 836517 1 189109 mhahnenberg 2013-02-19 10:22:43 -0800 Created attachment 189109 Patch 836534 2 189109 webkit.review.bot 2013-02-19 10:41:48 -0800 Comment on attachment 189109 Patch Clearing flags on attachment: 189109 Committed r143354: <http://trac.webkit.org/changeset/143354> 836535 3 webkit.review.bot 2013-02-19 10:41:50 -0800 All reviewed patches have been landed. Closing bug. 189109 2013-02-19 10:22:43 -0800 2013-02-19 10:41:47 -0800 Patch bug-110233-20130219101905.patch text/plain 1380 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQzMzUxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEzLTAyLTE5ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgSGVhcEJsb2NrOjpkZXN0cm95IHNob3VsZCBpc3N1ZSB3YXJuaW5nIGlmIHJlc3Vs dCBpcyB1bnVzZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTExMDIzMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRvIGVuZm9yY2UgdGhlIGZhY3QgdGhhdCB3ZSBuZWVkIHRvIHJldHVybiBibG9ja3MgdG8g dGhlIEJsb2NrQWxsb2NhdG9yIGFmdGVyIGNhbGxpbmcgZGVzdHJveSwgCisgICAgICAgIHdlIHNo b3VsZCBhZGQgV0FSTl9VTlVTRURfUkVUVVJOIHRvIEhlYXBCbG9jazo6ZGVzdHJveSBhbmQgYW55 IG90aGVyIGRlc3Ryb3kgZnVuY3Rpb25zIGluIGl0cyBzdWJjbGFzc2VzLgorCisgICAgICAgICog aGVhcC9IZWFwQmxvY2suaDoKKwogMjAxMy0wMi0xOSAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5l bmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYWtTZXQ6OnJlbW92ZUFsbG9jYXRvciBsZWFr cyBXZWFrQmxvY2tzCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwQmxvY2su aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwQmxvY2suaAko cmV2aXNpb24gMTQzMzUxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcEJsb2Nr LmgJKHdvcmtpbmcgY29weSkKQEAgLTQ1LDcgKzQ1LDcgQEAgdGVtcGxhdGU8dHlwZW5hbWUgVD4K IGNsYXNzIEhlYXBCbG9jayA6IHB1YmxpYyBEb3VibHlMaW5rZWRMaXN0Tm9kZTxUPiB7CiAgICAg ZnJpZW5kIENMQVNTX0lGX0dDQyBEb3VibHlMaW5rZWRMaXN0Tm9kZTxUPjsKIHB1YmxpYzoKLSAg ICBzdGF0aWMgSGVhcEJsb2NrKiBkZXN0cm95KEhlYXBCbG9jayogYmxvY2spCisgICAgc3RhdGlj IEhlYXBCbG9jayogZGVzdHJveShIZWFwQmxvY2sqIGJsb2NrKSBXQVJOX1VOVVNFRF9SRVRVUk4K ICAgICB7CiAgICAgICAgIHN0YXRpY19jYXN0PFQqPihibG9jayktPn5UKCk7CiAgICAgICAgIHJl dHVybiBibG9jazsK