110224 2013-02-19 07:25:57 -0800 Web Inspector: View.markAsRoot should never be invoked on attached view. 2013-02-20 01:22:56 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 eustas eustas apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 836375 0 eustas 2013-02-19 07:25:57 -0800 TL;DR View.markAsRoot should never be invoked on attached view. This will cause CSS loading problems after "show". Let view A be inner view of C. A and B share the same CSS. C.show -> A loads CSS, counter = 1 B.show -> counter = 2 C.detach -> causes A.processWasHidden; counter = 1 A.markAsRoot A.show causes A.detach; A was marked as root, so it thinks that it is visible and calls A.processWasHidden -> counter = 0; after that we get A.processWillShow -> counter = 1 A.detach -> counter = 0 -> unload CSS But B is still shown. Epic fail. 836377 1 189087 eustas 2013-02-19 07:28:03 -0800 Created attachment 189087 Patch 836381 2 189087 pfeldman 2013-02-19 07:35:01 -0800 Comment on attachment 189087 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189087&action=review > Source/WebCore/inspector/front-end/Drawer.js:89 > + this._view.detach(); Please add a test. 837248 3 189087 webkit.review.bot 2013-02-20 01:22:52 -0800 Comment on attachment 189087 Patch Clearing flags on attachment: 189087 Committed r143437: <http://trac.webkit.org/changeset/143437> 837249 4 webkit.review.bot 2013-02-20 01:22:56 -0800 All reviewed patches have been landed. Closing bug. 189087 2013-02-19 07:28:03 -0800 2013-02-20 01:22:52 -0800 Patch bug-110224-20130219192425.patch text/plain 2201 eustas U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzMzA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDU1MDc0NmM0Y2FiYzI5 NjlkOGNkMDI0YWZjYzkzMzlhYzIzNTNkMy4uODFkNTFhNjk0ZWFmNGFiYTkxMjdkOGMyOWU5YzYz Yjc5NmE2ZjFjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAyLTE5ICBFdWdl bmUgS2x5dWNobmlrb3YgIDxldXN0YXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFZpZXcubWFya0FzUm9vdCBzaG91bGQgbmV2ZXIgYmUgaW52b2tlZCBvbiBhdHRhY2hl ZCB2aWV3LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTEwMjI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGhpcyB3aWxsIGNhdXNlIENTUyBsb2FkaW5nIHByb2JsZW1zIGFmdGVyICJzaG93Ii4KKworICAg ICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvRHJhd2VyLmpzOgorICAgICAgICBFbnN1cmUgY2hp bGQgdmlldyBpcyBkZXRhY2hlZCBiZWZvcmUgbWFya2VkIGFzIHJvb3QuCisgICAgICAgICogaW5z cGVjdG9yL2Zyb250LWVuZC9WaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlZpZXcucHJv dG90eXBlLm1hcmtBc1Jvb3QpOiBBZGRlZCBhc3NlcnRpb24uCisKIDIwMTMtMDItMTkgIFJ5b3N1 a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgWWV0IGFudGhlciBKU0MgYnVp bGQgZml4IGFmdGVyIHIxNDMzMDQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL0RyYXdlci5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvRHJhd2VyLmpzCmluZGV4IGEzNjJjZDIwZjNjNTcwYmNmMTc3YjMyNzY1Zjg3MGJkNzJjOTlm NWMuLjk5N2U1MTJiMWVlNThlMDUxZTEyNDg4ZWMyMTk2YzI2NTBkNDk3NDMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRHJhd2VyLmpzCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRHJhd2VyLmpzCkBAIC04Niw2ICs4Niw3IEBA IFdlYkluc3BlY3Rvci5EcmF3ZXIucHJvdG90eXBlID0gewogICAgICAgICBkb2N1bWVudC5ib2R5 LmFkZFN0eWxlQ2xhc3MoImRyYXdlci12aXNpYmxlIik7CiAgICAgICAgIHRoaXMuX2Zsb2F0aW5n U3RhdHVzQmFyQ29udGFpbmVyLmluc2VydEJlZm9yZShkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgi cGFuZWwtc3RhdHVzLWJhciIpLCB0aGlzLl9mbG9hdGluZ1N0YXR1c0JhckNvbnRhaW5lci5maXJz dEVsZW1lbnRDaGlsZCk7CiAgICAgICAgIHRoaXMuX2JvdHRvbVN0YXR1c0Jhci5hcHBlbmRDaGls ZCh0aGlzLl92aWV3U3RhdHVzQmFyKTsKKyAgICAgICAgdGhpcy5fdmlldy5kZXRhY2goKTsKICAg ICAgICAgdGhpcy5fdmlldy5tYXJrQXNSb290KCk7CiAgICAgICAgIHRoaXMuX3ZpZXcuc2hvdyh0 aGlzLl9kcmF3ZXJDb250ZW50c0VsZW1lbnQpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1ZpZXcuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL1ZpZXcuanMKaW5kZXggNzM4YmVkNDRmMmIzZjNlMDkwZTBkMTkxNDM1N2YyMzIy NGVlM2I3NS4uYTllNjc5MDIxN2IxOThjZmE5NjRjODExMTI4NjE1MDlkNjVmMDg0YyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9WaWV3LmpzCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVmlldy5qcwpAQCAtNDcsNiArNDcsNyBA QCBXZWJJbnNwZWN0b3IuVmlldy5fY3NzRmlsZVRvU3R5bGVFbGVtZW50ID0ge307CiBXZWJJbnNw ZWN0b3IuVmlldy5wcm90b3R5cGUgPSB7CiAgICAgbWFya0FzUm9vdDogZnVuY3Rpb24oKQogICAg IHsKKyAgICAgICAgV2ViSW5zcGVjdG9yLlZpZXcuX2Fzc2VydCghdGhpcy5lbGVtZW50LnBhcmVu dEVsZW1lbnQsICJBdHRlbXB0IHRvIG1hcmsgYXMgcm9vdCBhdHRhY2hlZCBub2RlIik7CiAgICAg ICAgIHRoaXMuX2lzUm9vdCA9IHRydWU7CiAgICAgfSwKIAo=