110223 2013-02-19 07:19:38 -0800 Web Inspector: release backtrace object group on each step 2013-02-19 08:14:36 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 podivilov podivilov aandrey apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 836368 0 podivilov 2013-02-19 07:19:38 -0800 Web Inspector: release backtrace object group on each step 836371 1 189085 podivilov 2013-02-19 07:21:56 -0800 Created attachment 189085 Patch 836391 2 189085 webkit.review.bot 2013-02-19 07:46:57 -0800 Comment on attachment 189085 Patch Rejecting attachment 189085 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-02', 'validate-changelog', '--non-interactive', 189085, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/16614839 836400 3 aandrey 2013-02-19 07:57:17 -0800 Could you plz say more about the problem you are fixing? Is it memory leaks? What's a background of this problem (how did you find it)? 836405 4 podivilov 2013-02-19 08:07:37 -0800 Yes, it's a memory leak. I found it using about:memory page and then heap snapshots in inspector profiler. 836406 5 aandrey 2013-02-19 08:09:41 -0800 (In reply to comment #4) > Yes, it's a memory leak. I found it using about:memory page and then heap snapshots in inspector profiler. Nice! Thanks. 836407 6 podivilov 2013-02-19 08:14:36 -0800 Committed r143334: <http://trac.webkit.org/changeset/143334> 189085 2013-02-19 07:21:56 -0800 2013-02-19 07:46:57 -0800 Patch bug-110223-20130219191817.patch text/plain 2625 podivilov U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyNzMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWJkOGUwMWU1NGEzZWFh YWZhOGU1ZGZkNmMwMzBkOGI3MTI0NzZhOS4uNjA0YzkxMzNjZjE3ODU4YzZjMGNkMzU1ODdjZTUy YmJiOGYwYTdmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTAyLTE5ICBQYXZl bCBQb2Rpdmlsb3YgIDxwb2Rpdmlsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IHJlbGVhc2UgYmFja3RyYWNlIG9iamVjdCBncm91cCBvbiBlYWNoIHN0ZXAuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTAyMjMKKworICAg ICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JEZWJ1Z2dlckFnZW50LmNwcDoKKyAgICAgICAgKFdl YkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yRGVidWdnZXJBZ2VudDo6c3RlcE92 ZXIpOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yRGVidWdnZXJBZ2VudDo6c3RlcEludG8p OgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yRGVidWdnZXJBZ2VudDo6c3RlcE91dCk6CisK IDIwMTMtMDItMTIgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFtWOF0gR2VuZXJhdGUgd3JhcHBlciBtZXRob2RzIGZvciBjdXN0b20gZ2V0dGVycy9zZXR0 ZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRGVidWdn ZXJBZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRGVidWdnZXJB Z2VudC5jcHAKaW5kZXggMzdmY2U1YjM4M2I3ZjQ2OGZhNGY0NWQ4MDYyYTQ0MmJjZjVkMzM5Zi4u MjgwYWZiNGY0MTdjMTZiZTM4NmQ0ZGE0NzI5MDI4YzI1NjY3N2ZlYiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRlYnVnZ2VyQWdlbnQuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JEZWJ1Z2dlckFnZW50LmNwcApAQCAtNjAs NyArNjAsNyBAQCBzdGF0aWMgY29uc3QgY2hhciBqYXZhU2NyaXB0QnJlYWtwb2ludHNbXSA9ICJq YXZhU2NyaXB0QnJlYWtvcGludHMiOwogc3RhdGljIGNvbnN0IGNoYXIgcGF1c2VPbkV4Y2VwdGlv bnNTdGF0ZVtdID0gInBhdXNlT25FeGNlcHRpb25zU3RhdGUiOwogfTsKIAotY29uc3QgY2hhciog SW5zcGVjdG9yRGVidWdnZXJBZ2VudDo6YmFja3RyYWNlT2JqZWN0R3JvdXAgPSAiYmFja3RyYWNl LW9iamVjdC1ncm91cCI7Citjb25zdCBjaGFyKiBJbnNwZWN0b3JEZWJ1Z2dlckFnZW50OjpiYWNr dHJhY2VPYmplY3RHcm91cCA9ICJiYWNrdHJhY2UiOwogCiBJbnNwZWN0b3JEZWJ1Z2dlckFnZW50 OjpJbnNwZWN0b3JEZWJ1Z2dlckFnZW50KEluc3RydW1lbnRpbmdBZ2VudHMqIGluc3RydW1lbnRp bmdBZ2VudHMsIEluc3BlY3RvckNvbXBvc2l0ZVN0YXRlKiBpbnNwZWN0b3JTdGF0ZSwgSW5qZWN0 ZWRTY3JpcHRNYW5hZ2VyKiBpbmplY3RlZFNjcmlwdE1hbmFnZXIpCiAgICAgOiBJbnNwZWN0b3JC YXNlQWdlbnQ8SW5zcGVjdG9yRGVidWdnZXJBZ2VudD4oIkRlYnVnZ2VyIiwgaW5zdHJ1bWVudGlu Z0FnZW50cywgaW5zcGVjdG9yU3RhdGUpCkBAIC00NTUsNiArNDU1LDcgQEAgdm9pZCBJbnNwZWN0 b3JEZWJ1Z2dlckFnZW50OjpzdGVwT3ZlcihFcnJvclN0cmluZyogZXJyb3JTdHJpbmcpCiB7CiAg ICAgaWYgKCFhc3NlcnRQYXVzZWQoZXJyb3JTdHJpbmcpKQogICAgICAgICByZXR1cm47CisgICAg bV9pbmplY3RlZFNjcmlwdE1hbmFnZXItPnJlbGVhc2VPYmplY3RHcm91cChJbnNwZWN0b3JEZWJ1 Z2dlckFnZW50OjpiYWNrdHJhY2VPYmplY3RHcm91cCk7CiAgICAgc2NyaXB0RGVidWdTZXJ2ZXIo KS5zdGVwT3ZlclN0YXRlbWVudCgpOwogfQogCkBAIC00NjIsNiArNDYzLDcgQEAgdm9pZCBJbnNw ZWN0b3JEZWJ1Z2dlckFnZW50OjpzdGVwSW50byhFcnJvclN0cmluZyogZXJyb3JTdHJpbmcpCiB7 CiAgICAgaWYgKCFhc3NlcnRQYXVzZWQoZXJyb3JTdHJpbmcpKQogICAgICAgICByZXR1cm47Cisg ICAgbV9pbmplY3RlZFNjcmlwdE1hbmFnZXItPnJlbGVhc2VPYmplY3RHcm91cChJbnNwZWN0b3JE ZWJ1Z2dlckFnZW50OjpiYWNrdHJhY2VPYmplY3RHcm91cCk7CiAgICAgc2NyaXB0RGVidWdTZXJ2 ZXIoKS5zdGVwSW50b1N0YXRlbWVudCgpOwogICAgIG1fbGlzdGVuZXItPnN0ZXBJbnRvKCk7CiB9 CkBAIC00NzAsNiArNDcyLDcgQEAgdm9pZCBJbnNwZWN0b3JEZWJ1Z2dlckFnZW50OjpzdGVwT3V0 KEVycm9yU3RyaW5nKiBlcnJvclN0cmluZykKIHsKICAgICBpZiAoIWFzc2VydFBhdXNlZChlcnJv clN0cmluZykpCiAgICAgICAgIHJldHVybjsKKyAgICBtX2luamVjdGVkU2NyaXB0TWFuYWdlci0+ cmVsZWFzZU9iamVjdEdyb3VwKEluc3BlY3RvckRlYnVnZ2VyQWdlbnQ6OmJhY2t0cmFjZU9iamVj dEdyb3VwKTsKICAgICBzY3JpcHREZWJ1Z1NlcnZlcigpLnN0ZXBPdXRPZkZ1bmN0aW9uKCk7CiB9 CiAK