110213 2013-02-19 05:39:04 -0800 Web Inspector: [Canvas] do not replace replay image with spinner icon 2013-02-19 06:33:30 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 aandrey aandrey apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs yurys oldest_to_newest 836276 0 aandrey 2013-02-19 05:39:04 -0800 Otherwise it's visually hard to see changes in the replay image. Instead show a small spinner icon in the bottom right corner. Patch to follow. 836279 1 189067 aandrey 2013-02-19 05:41:01 -0800 Created attachment 189067 Patch 836327 2 aandrey 2013-02-19 06:33:30 -0800 Committed r143325: <http://trac.webkit.org/changeset/143325> 189067 2013-02-19 05:41:01 -0800 2013-02-19 06:13:05 -0800 Patch bug-110213-20130219173722.patch text/plain 4079 aandrey U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzMzA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDIwZGMzMTQ0YTNjN2Ew NDQ2NjRhZDA0NWEwZWMyM2E1ODQ3ZTg0ZS4uNDk2OTY5N2I2ZjJiODVjNDljZmEyZThkMzQ0MjIx ZTRmZWNhYTE5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAyLTE5ICBBbmRy ZXkgQWRhaWtpbiAgPGFhbmRyZXlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFtDYW52YXNdIGRvIG5vdCByZXBsYWNlIHJlcGxheSBpbWFnZSB3aXRoIHNwaW5uZXIgaWNv bgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwMjEz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT3RoZXJ3 aXNlIGl0J3MgdmlzdWFsbHkgaGFyZCB0byBzZWUgY2hhbmdlcyBpbiB0aGUgcmVwbGF5IGltYWdl LiBJbnN0ZWFkIHNob3cgYSBzbWFsbCBzcGlubmVyIGljb24gaW4gdGhlIGJvdHRvbSByaWdodCBj b3JuZXIuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0NhbnZhc1Byb2ZpbGVWaWV3 LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNhbnZhc1Byb2ZpbGVWaWV3KToKKyAgICAgICAg KFdlYkluc3BlY3Rvci5DYW52YXNQcm9maWxlVmlldy5wcm90b3R5cGUuX2VuYWJsZVdhaXRJY29u KToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL2NhbnZhc1Byb2ZpbGVyLmNzczoKKyAg ICAgICAgKCNjYW52YXMtcmVwbGF5LWltYWdlLWNvbnRhaW5lcik6CisgICAgICAgICguY2FudmFz LWRlYnVnLWluZm8pOgorICAgICAgICAoLmNhbnZhcy1zcGlubmVyLWljb24pOgorCiAyMDEzLTAy LTE5ICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJl dmlld2VkIGJ1aWxkIGZpeCBhZnRlciByMTQzMzA0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9DYW52YXNQcm9maWxlVmlldy5qcyBiL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ2FudmFzUHJvZmlsZVZpZXcuanMKaW5kZXggNjgyMDk1 MTVmMjNjMjg3MjQ3ZTBhYWI5YjEyZGI2ZDUxNDM2YzI2Yi4uMTdlOTlmYTkyYmMwNjg3MmVkZTc1 N2UyYzc5NTI3OGYyNWY3ODdjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9DYW52YXNQcm9maWxlVmlldy5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL0NhbnZhc1Byb2ZpbGVWaWV3LmpzCkBAIC00Nyw3ICs0Nyw4IEBAIFdl Ykluc3BlY3Rvci5DYW52YXNQcm9maWxlVmlldyA9IGZ1bmN0aW9uKHByb2ZpbGUpCiAgICAgdmFy IHJlcGxheUltYWdlQ29udGFpbmVyID0gdGhpcy5fc3BsaXRWaWV3LmZpcnN0RWxlbWVudCgpOwog ICAgIHJlcGxheUltYWdlQ29udGFpbmVyLmlkID0gImNhbnZhcy1yZXBsYXktaW1hZ2UtY29udGFp bmVyIjsKICAgICB0aGlzLl9yZXBsYXlJbWFnZUVsZW1lbnQgPSByZXBsYXlJbWFnZUNvbnRhaW5l ci5jcmVhdGVDaGlsZCgiaW1hZ2UiLCAiY2FudmFzLXJlcGxheS1pbWFnZSIpOwotICAgIHRoaXMu X2RlYnVnSW5mb0VsZW1lbnQgPSByZXBsYXlJbWFnZUNvbnRhaW5lci5jcmVhdGVDaGlsZCgiZGl2 Iik7CisgICAgdGhpcy5fZGVidWdJbmZvRWxlbWVudCA9IHJlcGxheUltYWdlQ29udGFpbmVyLmNy ZWF0ZUNoaWxkKCJkaXYiLCAiY2FudmFzLWRlYnVnLWluZm8gaGlkZGVuIik7CisgICAgdGhpcy5f c3Bpbm5lckljb24gPSByZXBsYXlJbWFnZUNvbnRhaW5lci5jcmVhdGVDaGlsZCgiaW1nIiwgImNh bnZhcy1zcGlubmVyLWljb24gaGlkZGVuIik7CiAKICAgICB2YXIgcmVwbGF5SW5mb0NvbnRhaW5l ciA9IHRoaXMuX3NwbGl0Vmlldy5zZWNvbmRFbGVtZW50KCk7CiAgICAgdmFyIGNvbnRyb2xzQ29u dGFpbmVyID0gcmVwbGF5SW5mb0NvbnRhaW5lci5jcmVhdGVDaGlsZCgiZGl2IiwgInN0YXR1cy1i YXIiKTsKQEAgLTIxOSwyMyArMjIwLDggQEAgV2ViSW5zcGVjdG9yLkNhbnZhc1Byb2ZpbGVWaWV3 LnByb3RvdHlwZSA9IHsKICAgICAgKi8KICAgICBfZW5hYmxlV2FpdEljb246IGZ1bmN0aW9uKGVu YWJsZSkKICAgICB7Ci0gICAgICAgIGZ1bmN0aW9uIHNob3dXYWl0SWNvbigpCi0gICAgICAgIHsK LSAgICAgICAgICAgIHRoaXMuX3JlcGxheUltYWdlRWxlbWVudC5hZGRTdHlsZUNsYXNzKCJ3YWl0 Iik7Ci0gICAgICAgICAgICB0aGlzLl9kZWJ1Z0luZm9FbGVtZW50LmFkZFN0eWxlQ2xhc3MoImhp ZGRlbiIpOwotICAgICAgICAgICAgZGVsZXRlIHRoaXMuX3Nob3dXYWl0SWNvblRpbWVyOwotICAg ICAgICB9Ci0KLSAgICAgICAgaWYgKGVuYWJsZSAmJiB0aGlzLl9yZXBsYXlJbWFnZUVsZW1lbnQu c3JjICYmICF0aGlzLl9zaG93V2FpdEljb25UaW1lcikKLSAgICAgICAgICAgIHRoaXMuX3Nob3dX YWl0SWNvblRpbWVyID0gc2V0VGltZW91dChzaG93V2FpdEljb24uYmluZCh0aGlzKSwgMjUwKTsK LSAgICAgICAgZWxzZSB7Ci0gICAgICAgICAgICBpZiAodGhpcy5fc2hvd1dhaXRJY29uVGltZXIp IHsKLSAgICAgICAgICAgICAgICBjbGVhclRpbWVvdXQodGhpcy5fc2hvd1dhaXRJY29uVGltZXIp OwotICAgICAgICAgICAgICAgIGRlbGV0ZSB0aGlzLl9zaG93V2FpdEljb25UaW1lcjsKLSAgICAg ICAgICAgIH0KLSAgICAgICAgICAgIHRoaXMuX3JlcGxheUltYWdlRWxlbWVudC5lbmFibGVTdHls ZUNsYXNzKCJ3YWl0IiwgZW5hYmxlKTsKLSAgICAgICAgICAgIHRoaXMuX2RlYnVnSW5mb0VsZW1l bnQuZW5hYmxlU3R5bGVDbGFzcygiaGlkZGVuIiwgZW5hYmxlKTsKLSAgICAgICAgfQorICAgICAg ICB0aGlzLl9zcGlubmVySWNvbi5lbmFibGVTdHlsZUNsYXNzKCJoaWRkZW4iLCAhZW5hYmxlKTsK KyAgICAgICAgdGhpcy5fZGVidWdJbmZvRWxlbWVudC5lbmFibGVTdHlsZUNsYXNzKCJoaWRkZW4i LCBlbmFibGUpOwogICAgIH0sCiAKICAgICBfcmVwbGF5VHJhY2VMb2c6IGZ1bmN0aW9uKCkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvY2FudmFzUHJvZmls ZXIuY3NzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9jYW52YXNQcm9maWxl ci5jc3MKaW5kZXggMDUyNzg4NTYwNDM0NGU2N2JhY2RkMmRmZTViZmUxNmNmMWUyNjk5Yi4uZTE0 ZDE2NTQ5MDE3NTQ0ZjUwM2E1OGZlYTczNDM1MzllMWE2YmNjOSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9jYW52YXNQcm9maWxlci5jc3MKKysrIGIvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9jYW52YXNQcm9maWxlci5jc3MKQEAgLTQx LDcgKzQxLDcgQEAKICAgICB0ZXh0LWFsaWduOiBjZW50ZXI7CiAgICAgYmFja2dyb3VuZC1jb2xv cjogYmxhY2s7CiAgICAgb3ZlcmZsb3c6IGhpZGRlbjsKLSAgICBwYWRkaW5nOiA1cHg7CisgICAg cGFkZGluZzogNXB4IDVweCAxMHB4IDVweDsKICAgICBjb2xvcjogd2hpdGU7CiB9CiAKQEAgLTU1 LDEzICs1NSwxOSBAQAogICAgIGRpc3BsYXk6IGJsb2NrOwogfQogCi0uY2FudmFzLXJlcGxheS1p bWFnZS53YWl0IHsKKy5jYW52YXMtZGVidWctaW5mbyB7CisgICAgcG9zaXRpb246IGFic29sdXRl OworICAgIGxlZnQ6IDA7CisgICAgcmlnaHQ6IDA7CisgICAgYm90dG9tOiA2cHg7Cit9CisKKy5j YW52YXMtc3Bpbm5lci1pY29uIHsKICAgICBjb250ZW50OiB1cmwoSW1hZ2VzL3NwaW5uZXJBY3Rp dmVTZWxlY3RlZC5naWYpOwotICAgIHpvb206IGluaGVyaXQ7CiAgICAgcG9zaXRpb246IGFic29s dXRlOwotICAgIHRvcDogNTAlOwotICAgIGxlZnQ6IDUwJTsKLSAgICBtYXJnaW46IC0xNnB4IDAg MCAtMTZweDsKKyAgICB3aWR0aDogMTZweDsKKyAgICByaWdodDogNHB4OworICAgIGJvdHRvbTog NHB4OwogfQogCiAuY2FudmFzLXJlcGxheS1sb2cgewo=