110202 2013-02-19 03:23:05 -0800 Web Inspector: Cleanup and add JSDocs to SuggestBox 2013-02-19 21:26:20 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 eustas eustas apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 836191 0 eustas 2013-02-19 03:23:05 -0800 SuggestBox contains some obsolete/unused code and not fully covered with JSDocs. 836195 1 189042 eustas 2013-02-19 03:26:44 -0800 Created attachment 189042 Patch 837118 2 189042 webkit.review.bot 2013-02-19 21:26:17 -0800 Comment on attachment 189042 Patch Clearing flags on attachment: 189042 Committed r143427: <http://trac.webkit.org/changeset/143427> 837119 3 webkit.review.bot 2013-02-19 21:26:20 -0800 All reviewed patches have been landed. Closing bug. 189042 2013-02-19 03:26:44 -0800 2013-02-19 21:26:17 -0800 Patch bug-110202-20130219152305.patch text/plain 6635 eustas U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzMzA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDU1MDc0NmM0Y2FiYzI5 NjlkOGNkMDI0YWZjYzkzMzlhYzIzNTNkMy4uMTQzMjU5MWQ3OTFjNzI3ZGZhMTY2Y2NmNzQ3NWMw ZDQ0YmYwMmI2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEzLTAyLTE5ICBFdWdl bmUgS2x5dWNobmlrb3YgIDxldXN0YXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IENsZWFudXAgYW5kIGFkZCBKU0RvY3MgdG8gU3VnZ2VzdEJveAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwMjAyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3VnZ2VzdEJveCBjb250YWlucyBz b21lIG9ic29sZXRlL3VudXNlZCBjb2RlIGFuZCBub3QgZnVsbHkKKyAgICAgICAgY292ZXJlZCB3 aXRoIEpTRG9jcy4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU3VnZ2VzdEJveC5q czoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TdWdnZXN0Qm94LnByb3RvdHlwZS52aXNpYmxlKToK KyAgICAgICAgUmVwbGFjZWQgZ2V0dGVyIHdpdGggZnVuY3Rpb24uCisgICAgICAgIChXZWJJbnNw ZWN0b3IuU3VnZ2VzdEJveC5wcm90b3R5cGUuX29uU2Nyb2xsT3JSZXNpemUpOgorICAgICAgICBV c2UgY2FtZWwtY2FzZSBmb3IgZnVuY3Rpb24gbmFtZXMuCisgICAgICAgIChXZWJJbnNwZWN0b3Iu U3VnZ2VzdEJveC5wcm90b3R5cGUuX29uQm94TW91c2VEb3duKTogRGl0dG8uCisgICAgICAgIChX ZWJJbnNwZWN0b3IuU3VnZ2VzdEJveC5wcm90b3R5cGUudXBkYXRlU3VnZ2VzdGlvbnMpOgorICAg ICAgICBSZW1vdmVkIHVudXNlZCBjb2RlLgorICAgICAgICAoV2ViSW5zcGVjdG9yLlN1Z2dlc3RC b3gucHJvdG90eXBlLmhpZGUpOiBBZG9wdCBjaGFuZ2VzLgorICAgICAgICAoV2ViSW5zcGVjdG9y LlN1Z2dlc3RCb3gucHJvdG90eXBlLl9hcHBseVN1Z2dlc3Rpb24pOiBEaXR0by4KKyAgICAgICAg KiBpbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRQcm9tcHQuanM6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuVGV4dFByb21wdC5wcm90b3R5cGUuaXNTdWdnZXN0Qm94VmlzaWJsZSk6IERpdHRvLgorCiAy MDEzLTAyLTE5ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFll dCBhbnRoZXIgSlNDIGJ1aWxkIGZpeCBhZnRlciByMTQzMzA0LgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TdWdnZXN0Qm94LmpzIGIvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TdWdnZXN0Qm94LmpzCmluZGV4IGQ2ODk5NjVkNjE3NmFl YzUzOTg3ZDMzMjBmN2JiMjAzYTllOTk3ZjcuLmI5M2JlZDhiNzZlOTU2MTNhODczZmU0MWZjNDI0 ZTFlODQ1ZmNkOGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvU3VnZ2VzdEJveC5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L1N1Z2dlc3RCb3guanMKQEAgLTY2LDMzICs2NiwzNSBAQCBXZWJJbnNwZWN0b3IuU3VnZ2VzdEJv eCA9IGZ1bmN0aW9uKHN1Z2dlc3RCb3hEZWxlZ2F0ZSwgaW5wdXRFbGVtZW50LCBjbGFzc05hbWUp CiAgICAgdGhpcy5fbGVuZ3RoID0gMDsKICAgICB0aGlzLl9zZWxlY3RlZEluZGV4ID0gLTE7CiAg ICAgdGhpcy5fc2VsZWN0ZWRFbGVtZW50ID0gbnVsbDsKLSAgICB0aGlzLl9ib3VuZE9uU2Nyb2xs ID0gdGhpcy5fb25zY3JvbGxyZXNpemUuYmluZCh0aGlzLCB0cnVlKTsKLSAgICB0aGlzLl9ib3Vu ZE9uUmVzaXplID0gdGhpcy5fb25zY3JvbGxyZXNpemUuYmluZCh0aGlzLCBmYWxzZSk7CisgICAg dGhpcy5fYm91bmRPblNjcm9sbCA9IHRoaXMuX29uU2Nyb2xsT3JSZXNpemUuYmluZCh0aGlzLCB0 cnVlKTsKKyAgICB0aGlzLl9ib3VuZE9uUmVzaXplID0gdGhpcy5fb25TY3JvbGxPclJlc2l6ZS5i aW5kKHRoaXMsIGZhbHNlKTsKICAgICB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcigic2Nyb2xsIiwg dGhpcy5fYm91bmRPblNjcm9sbCwgdHJ1ZSk7CiAgICAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIo InJlc2l6ZSIsIHRoaXMuX2JvdW5kT25SZXNpemUsIHRydWUpOwogCiAgICAgdGhpcy5fYm9keUVs ZW1lbnQgPSBpbnB1dEVsZW1lbnQub3duZXJEb2N1bWVudC5ib2R5OwogICAgIHRoaXMuX2VsZW1l bnQgPSBpbnB1dEVsZW1lbnQub3duZXJEb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKICAg ICB0aGlzLl9lbGVtZW50LmNsYXNzTmFtZSA9ICJzdWdnZXN0LWJveCAiICsgKGNsYXNzTmFtZSB8 fCAiIik7Ci0gICAgdGhpcy5fZWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJtb3VzZWRvd24iLCB0 aGlzLl9vbmJveG1vdXNlZG93bi5iaW5kKHRoaXMpLCB0cnVlKTsKKyAgICB0aGlzLl9lbGVtZW50 LmFkZEV2ZW50TGlzdGVuZXIoIm1vdXNlZG93biIsIHRoaXMuX29uQm94TW91c2VEb3duLmJpbmQo dGhpcyksIHRydWUpOwogICAgIHRoaXMuY29udGFpbmVyRWxlbWVudCA9IHRoaXMuX2VsZW1lbnQu Y3JlYXRlQ2hpbGQoImRpdiIsICJjb250YWluZXIiKTsKICAgICB0aGlzLmNvbnRlbnRFbGVtZW50 ID0gdGhpcy5jb250YWluZXJFbGVtZW50LmNyZWF0ZUNoaWxkKCJkaXYiLCAiY29udGVudCIpOwog fQogCiBXZWJJbnNwZWN0b3IuU3VnZ2VzdEJveC5wcm90b3R5cGUgPSB7Ci0gICAgZ2V0IHZpc2li bGUoKQorICAgIC8qKgorICAgICAqIEByZXR1cm4ge2Jvb2xlYW59CisgICAgICovCisgICAgdmlz aWJsZTogZnVuY3Rpb24oKQogICAgIHsKICAgICAgICAgcmV0dXJuICEhdGhpcy5fZWxlbWVudC5w YXJlbnRFbGVtZW50OwogICAgIH0sCiAKLSAgICBnZXQgaGFzU2VsZWN0aW9uKCkKLSAgICB7Ci0g ICAgICAgIHJldHVybiAhIXRoaXMuX3NlbGVjdGVkRWxlbWVudDsKLSAgICB9LAotCi0gICAgX29u c2Nyb2xscmVzaXplOiBmdW5jdGlvbihpc1Njcm9sbCwgZXZlbnQpCisgICAgLyoqCisgICAgICog QHBhcmFtIHtib29sZWFufSBpc1Njcm9sbAorICAgICAqIEBwYXJhbSB7RXZlbnR9IGV2ZW50Cisg ICAgICovCisgICAgX29uU2Nyb2xsT3JSZXNpemU6IGZ1bmN0aW9uKGlzU2Nyb2xsLCBldmVudCkK ICAgICB7Ci0gICAgICAgIGlmIChpc1Njcm9sbCAmJiB0aGlzLl9lbGVtZW50LmlzQW5jZXN0b3Io ZXZlbnQudGFyZ2V0KSB8fCAhdGhpcy52aXNpYmxlKQorICAgICAgICBpZiAoaXNTY3JvbGwgJiYg dGhpcy5fZWxlbWVudC5pc0FuY2VzdG9yKGV2ZW50LnRhcmdldCkgfHwgIXRoaXMudmlzaWJsZSgp KQogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB0aGlzLl91cGRhdGVCb3hQb3NpdGlvbldp dGhFeGlzdGluZ0FuY2hvcigpOwogICAgIH0sCkBAIC0xNTUsMTQgKzE1NywxNyBAQCBXZWJJbnNw ZWN0b3IuU3VnZ2VzdEJveC5wcm90b3R5cGUgPSB7CiAgICAgICAgIHRoaXMuX2VsZW1lbnQuc3R5 bGUuaGVpZ2h0ID0gaGVpZ2h0ICsgInB4IjsKICAgICB9LAogCi0gICAgX29uYm94bW91c2Vkb3du OiBmdW5jdGlvbihldmVudCkKKyAgICAvKioKKyAgICAgKiBAcGFyYW0ge0V2ZW50fSBldmVudAor ICAgICAqLworICAgIF9vbkJveE1vdXNlRG93bjogZnVuY3Rpb24oZXZlbnQpCiAgICAgewogICAg ICAgICBldmVudC5wcmV2ZW50RGVmYXVsdCgpOwogICAgIH0sCiAKICAgICBoaWRlOiBmdW5jdGlv bigpCiAgICAgewotICAgICAgICBpZiAoIXRoaXMudmlzaWJsZSkKKyAgICAgICAgaWYgKCF0aGlz LnZpc2libGUoKSkKICAgICAgICAgICAgIHJldHVybjsKIAogICAgICAgICB0aGlzLl9lbGVtZW50 LnBhcmVudEVsZW1lbnQucmVtb3ZlQ2hpbGQodGhpcy5fZWxlbWVudCk7CkBAIC0xODIsNyArMTg3 LDcgQEAgV2ViSW5zcGVjdG9yLlN1Z2dlc3RCb3gucHJvdG90eXBlID0gewogICAgICAqLwogICAg IF9hcHBseVN1Z2dlc3Rpb246IGZ1bmN0aW9uKHRleHQsIGlzSW50ZXJtZWRpYXRlU3VnZ2VzdGlv bikKICAgICB7Ci0gICAgICAgIGlmICghdGhpcy52aXNpYmxlIHx8ICEodGV4dCB8fCB0aGlzLl9z ZWxlY3RlZEVsZW1lbnQpKQorICAgICAgICBpZiAoIXRoaXMudmlzaWJsZSgpIHx8ICEodGV4dCB8 fCB0aGlzLl9zZWxlY3RlZEVsZW1lbnQpKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAg ICAgICAgIHZhciBzdWdnZXN0aW9uID0gdGV4dCB8fCB0aGlzLl9zZWxlY3RlZEVsZW1lbnQudGV4 dENvbnRlbnQ7CkBAIC0yMzEsMjYgKzIzNiwxOSBAQCBXZWJJbnNwZWN0b3IuU3VnZ2VzdEJveC5w cm90b3R5cGUgPSB7CiAgICAgfSwKIAogICAgIC8qKgotICAgICAqIEBwYXJhbSB7QW5jaG9yQm94 fSBhbmNob3JCb3gKLSAgICAgKiBAcGFyYW0ge0FycmF5LjxzdHJpbmc+PX0gY29tcGxldGlvbnMK LSAgICAgKiBAcGFyYW0ge251bWJlcj19IHNlbGVjdGVkSW5kZXgKLSAgICAgKiBAcGFyYW0ge2Jv b2xlYW49fSBjYW5TaG93Rm9yU2luZ2xlSXRlbQorICAgICAqIEBwYXJhbSB7c3RyaW5nfSB0ZXh0 CisgICAgICogQHBhcmFtIHtFdmVudH0gZXZlbnQKICAgICAgKi8KLSAgICB1cGRhdGVTdWdnZXN0 aW9uczogZnVuY3Rpb24oYW5jaG9yQm94LCBjb21wbGV0aW9ucywgc2VsZWN0ZWRJbmRleCwgY2Fu U2hvd0ZvclNpbmdsZUl0ZW0pCi0gICAgewotICAgICAgICBpZiAodGhpcy5fc3VnZ2VzdFRpbWVv dXQpIHsKLSAgICAgICAgICAgIGNsZWFyVGltZW91dCh0aGlzLl9zdWdnZXN0VGltZW91dCk7Ci0g ICAgICAgICAgICBkZWxldGUgdGhpcy5fc3VnZ2VzdFRpbWVvdXQ7Ci0gICAgICAgIH0KLSAgICAg ICAgdGhpcy5fY29tcGxldGlvbnNSZWFkeShhbmNob3JCb3gsIGNvbXBsZXRpb25zLCBzZWxlY3Rl ZEluZGV4LCBjYW5TaG93Rm9yU2luZ2xlSXRlbSk7Ci0gICAgfSwKLQogICAgIF9vbkl0ZW1Nb3Vz ZURvd246IGZ1bmN0aW9uKHRleHQsIGV2ZW50KQogICAgIHsKICAgICAgICAgdGhpcy5hY2NlcHRT dWdnZXN0aW9uKHRleHQpOwogICAgICAgICBldmVudC5jb25zdW1lKHRydWUpOwogICAgIH0sCiAK KyAgICAvKioKKyAgICAgKiBAcGFyYW0ge3N0cmluZ30gcHJlZml4CisgICAgICogQHBhcmFtIHtz dHJpbmd9IHRleHQKKyAgICAgKi8KICAgICBfY3JlYXRlSXRlbUVsZW1lbnQ6IGZ1bmN0aW9uKHBy ZWZpeCwgdGV4dCkKICAgICB7CiAgICAgICAgIHZhciBlbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRl RWxlbWVudCgiZGl2Iik7CkBAIC0zMzUsMTIgKzMzMywxMiBAQCBXZWJJbnNwZWN0b3IuU3VnZ2Vz dEJveC5wcm90b3R5cGUgPSB7CiAgICAgICogQHBhcmFtIHtudW1iZXI9fSBzZWxlY3RlZEluZGV4 CiAgICAgICogQHBhcmFtIHtib29sZWFuPX0gY2FuU2hvd0ZvclNpbmdsZUl0ZW0KICAgICAgKi8K LSAgICBfY29tcGxldGlvbnNSZWFkeTogZnVuY3Rpb24oYW5jaG9yQm94LCBjb21wbGV0aW9ucywg c2VsZWN0ZWRJbmRleCwgY2FuU2hvd0ZvclNpbmdsZUl0ZW0pCisgICAgdXBkYXRlU3VnZ2VzdGlv bnM6IGZ1bmN0aW9uKGFuY2hvckJveCwgY29tcGxldGlvbnMsIHNlbGVjdGVkSW5kZXgsIGNhblNo b3dGb3JTaW5nbGVJdGVtKQogICAgIHsKICAgICAgICAgaWYgKHRoaXMuX2NhblNob3dCb3goY29t cGxldGlvbnMsIGNhblNob3dGb3JTaW5nbGVJdGVtKSkgewogICAgICAgICAgICAgdGhpcy5fdXBk YXRlSXRlbXMoY29tcGxldGlvbnMsIHNlbGVjdGVkSW5kZXgpOwogICAgICAgICAgICAgdGhpcy5f dXBkYXRlQm94UG9zaXRpb24oYW5jaG9yQm94KTsKLSAgICAgICAgICAgIGlmICghdGhpcy52aXNp YmxlKQorICAgICAgICAgICAgaWYgKCF0aGlzLnZpc2libGUoKSkKICAgICAgICAgICAgICAgICB0 aGlzLl9ib2R5RWxlbWVudC5hcHBlbmRDaGlsZCh0aGlzLl9lbGVtZW50KTsKICAgICAgICAgICAg IHRoaXMuX3JlbWVtYmVyUm93Q291bnRQZXJWaWV3cG9ydCgpOwogICAgICAgICB9IGVsc2UKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGV4dFByb21wdC5q cyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGV4dFByb21wdC5qcwppbmRl eCAxZmU5MTI4OTBiODg2MTgwYzk0NzAyOWVjMmVhYjQ5YWUzZmUyYThiLi5lNTFmMDgzZjYxNmVi YTA0YTU1NzQ2NWVmMGU0MTVmYzE4NjFmZDY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL1RleHRQcm9tcHQuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9UZXh0UHJvbXB0LmpzCkBAIC02MzAsNyArNjMwLDcgQEAgV2ViSW5z cGVjdG9yLlRleHRQcm9tcHQucHJvdG90eXBlID0gewogCiAgICAgaXNTdWdnZXN0Qm94VmlzaWJs ZTogZnVuY3Rpb24oKQogICAgIHsKLSAgICAgICAgcmV0dXJuIHRoaXMuX3N1Z2dlc3RCb3ggJiYg dGhpcy5fc3VnZ2VzdEJveC52aXNpYmxlOworICAgICAgICByZXR1cm4gdGhpcy5fc3VnZ2VzdEJv eCAmJiB0aGlzLl9zdWdnZXN0Qm94LnZpc2libGUoKTsKICAgICB9LAogCiAgICAgaXNDYXJldElu c2lkZVByb21wdDogZnVuY3Rpb24oKQo=