11020 2006-09-25 05:31:48 -0700 REGRESSION: No-SVG build broken since r16549 2006-09-26 04:29:13 -0700 1 1 1 Unclassified WebKit New Bugs 420+ Mac OS X 10.4 RESOLVED FIXED P1 Normal --- 1 Graham.Dennis Graham.Dennis dwood oldest_to_newest 56416 0 Graham.Dennis 2006-09-25 05:31:48 -0700 From the build-bot: CompileC /Users/buildbot/Desktop/BuildData/WebKit-BuildSlave/periodic-powerpc-mac-os-x-no-svg/build/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/ppc/FrameView.o /Users/buildbot/Desktop/BuildData/WebKit-BuildSlave/periodic-powerpc-mac-os-x-no-svg/build/WebCore/page/FrameView.cpp normal ppc c++ com.apple.compilers.gcc.4_0 cd /Users/buildbot/Desktop/BuildData/WebKit-BuildSlave/periodic-powerpc-mac-os-x-no-svg/build/WebCore /usr/bin/gcc-4.0 -x c++ -arch ppc -pipe -Wno-trigraphs -fno-exceptions -fno-rtti -fpascal-strings -fasm-blocks -gfull -O2 -Werror -Wnon-virtual-dtor -Wnewline-eof -DNDEBUG -fmessage-length=0 -mtune=G5 -fvisibility-inlines-hidden -fno-threadsafe-statics -Wno-invalid-offsetof -mmacosx-version-min=10.4 -I/Users/buildbot/Desktop/BuildData/WebKit-BuildSlave/periodic-powerpc-mac-os-x-no-svg/build/WebKitBuild/WebCore.build/Release/WebCore.build/WebCore.hmap -Wall -W -Wcast-align -Wchar-subscripts -Wformat-security -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings -Wno-format-y2k -Wno-unused-parameter -Wno-long-double -Wundef -Wshorten-64-to-32 -F/Users/buildbot/Desktop/BuildData/WebKit-BuildSlave/periodic-powerpc-mac-os-x-no-svg/build/WebKitBuild/Release -I/Users/buildbot/Desktop/BuildData/WebKit-BuildSlave/periodic-powerpc-mac-os-x-no-svg/build/WebKitBuild/Release/include -IForwardingHeaders -I. -Iicu -I/usr/include/libxslt -I/usr/include/libxml2 -I/Users/buildbot/Desktop/BuildData/WebKit-BuildSlave/periodic-powerpc-mac-os-x-no-svg/build/WebKitBuild/Release/DerivedSources/WebCore -I/Users/buildbot/Desktop/BuildData/WebKit-BuildSlave/periodic-powerpc-mac-os-x-no-svg/build/WebKitBuild/WebCore.build/Release/WebCore.build/DerivedSources -include /Library/Caches/com.apple.Xcode.502/SharedPrecompiledHeaders/WebCorePrefix-eitivqzvgdsjxidjzlxdczyozvwx/WebCorePrefix.h -c /Users/buildbot/Desktop/BuildData/WebKit-BuildSlave/periodic-powerpc-mac-os-x-no-svg/build/WebCore/page/FrameView.cpp -o /Users/buildbot/Desktop/BuildData/WebKit-BuildSlave/periodic-powerpc-mac-os-x-no-svg/build/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/ppc/FrameView.o /Users/buildbot/Desktop/BuildData/WebKit-BuildSlave/periodic-powerpc-mac-os-x-no-svg/build/WebCore/page/FrameView.cpp:51:5: error: "SVG_SUPPORT" is not defined /Users/buildbot/Desktop/BuildData/WebKit-BuildSlave/periodic-powerpc-mac-os-x-no-svg/build/WebCore/page/FrameView.cpp:62:5: error: "SVG_SUPPORT" is not defined /Users/buildbot/Desktop/BuildData/WebKit-BuildSlave/periodic-powerpc-mac-os-x-no-svg/build/WebCore/page/FrameView.cpp:664:5: error: "SVG_SUPPORT" is not defined ** BUILD FAILED ** The new #if SVG_SUPPORT lines added in r16549 should be #ifdefs (See bug #10896) 56421 1 Graham.Dennis 2006-09-25 06:29:55 -0700 Regression -> p1 56425 2 10757 Graham.Dennis 2006-09-25 07:20:28 -0700 Created attachment 10757 patch Patch. Changes #if SVG_SUPPORT to #ifdef SVG_SUPPORT. 56457 3 10757 mitz 2006-09-25 14:21:27 -0700 Comment on attachment 10757 patch r=me 56521 4 mrowe 2006-09-26 04:29:13 -0700 Landed as r16571. 10757 2006-09-25 07:20:28 -0700 2006-09-25 14:21:27 -0700 patch patch-11020.diff text/plain 3760 Graham.Dennis SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxNjU1NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDYtMDktMjYgIEdyYWhhbSBEZW5uaXMgIDxncmFoYW0uZGVubmlz QGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAtIGZpeCBodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lk PTExMDIwCisgICAgICAgIE5vLVNWRyBidWlsZCBicm9rZW4gc2luY2UgcjE2NTQ5CisgICAgICAg IAorICAgICAgICBDaGFuZ2UgI2lmIFNWR19TVVBQT1JUIHRvICNpZmRlZiBTVkdfU1VQUE9SVAor CisgICAgICAgICogY3NzL2Nzc3BhcnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NQYXJz ZXI6OnBhcnNlVmFsdWUpOgorICAgICAgICAqIGNzcy9jc3NzdHlsZXNlbGVjdG9yLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkNTU1N0eWxlU2VsZWN0b3I6OmFwcGx5UHJvcGVydHkpOgorICAgICAg ICAqIHBhZ2UvRnJhbWVWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnNlbGVjdEN1cnNvcik6 CisgICAgICAgICogcGxhdGZvcm0vcXQvR3JhcGhpY3NDb250ZXh0UXQuY3BwOgorCiAyMDA2LTA5 LTI1ICBFcmljIFNlaWRlbCAgPGVyaWNAZXNlaWRlbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgbWpzLgpJbmRleDogV2ViQ29yZS9jc3MvY3NzcGFyc2VyLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL2Nzcy9jc3NwYXJzZXIuY3BwCShyZXZpc2lvbiAxNjU1NykKKysrIFdlYkNvcmUvY3Nz L2Nzc3BhcnNlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTcxOCw3ICs3MTgsNyBAQCBib29sIENT U1BhcnNlcjo6cGFyc2VWYWx1ZShpbnQgcHJvcElkLCBiCiAgICAgICAgICAgICB9IGVsc2UgaWYo c3RyaWN0ICYmIG5yY29vcmRzID09IDIpCiAgICAgICAgICAgICAgICAgaG90c3BvdCA9IEludFBv aW50KGNvb3Jkc1swXSwgY29vcmRzWzFdKTsKICAgICAgICAgICAgIGlmIChzdHJpY3QgfHwgY29v cmRzLnNpemUoKSA9PSAwKSB7Ci0jaWYgU1ZHX1NVUFBPUlQKKyNpZmRlZiBTVkdfU1VQUE9SVAog ICAgICAgICAgICAgaWYgKHVyaS5zdGFydHNXaXRoKCIjIikpIHsKICAgICAgICAgICAgICAgICBp ZiAoIWxpc3QpCiAgICAgICAgICAgICAgICAgICAgIGxpc3QgPSBuZXcgQ1NTVmFsdWVMaXN0OyAK SW5kZXg6IFdlYkNvcmUvY3NzL2Nzc3N0eWxlc2VsZWN0b3IuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvY3NzL2Nzc3N0eWxlc2VsZWN0b3IuY3BwCShyZXZpc2lvbiAxNjU1NykKKysrIFdlYkNv cmUvY3NzL2Nzc3N0eWxlc2VsZWN0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNDQwLDcgKzI0 NDAsNyBAQCB2b2lkIENTU1N0eWxlU2VsZWN0b3I6OmFwcGx5UHJvcGVydHkoaW50CiAgICAgICAg ICAgICAgICAgcHJpbWl0aXZlVmFsdWUgPSBzdGF0aWNfY2FzdDxDU1NQcmltaXRpdmVWYWx1ZSo+ KGl0ZW0pOwogICAgICAgICAgICAgICAgIGludCB0eXBlID0gcHJpbWl0aXZlVmFsdWUtPnByaW1p dGl2ZVR5cGUoKTsKICAgICAgICAgICAgICAgICBpZiAodHlwZSA9PSBDU1NQcmltaXRpdmVWYWx1 ZTo6Q1NTX1VSSSkgewotI2lmIFNWR19TVVBQT1JUCisjaWZkZWYgU1ZHX1NVUFBPUlQKICAgICAg ICAgICAgICAgICAgICAgaWYgKHByaW1pdGl2ZVZhbHVlLT5nZXRTdHJpbmdWYWx1ZSgpLmZpbmQo IiMiKSA9PSAwKQogICAgICAgICAgICAgICAgICAgICAgICAgc3R5bGUtPmFkZFNWR0N1cnNvcihw cmltaXRpdmVWYWx1ZS0+Z2V0U3RyaW5nVmFsdWUoKS5zdWJzdHJpbmcoMSkpOwogICAgICAgICAg ICAgICAgICAgICBlbHNlCkluZGV4OiBXZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAkocmV2aXNpb24gMTY1NTcpCisrKyBX ZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDgsNyArNDgsNyBA QAogI2luY2x1ZGUgIlNlbGVjdGlvbkNvbnRyb2xsZXIuaCIKICNpbmNsdWRlICJjc3NzdHlsZXNl bGVjdG9yLmgiCiAKLSNpZiBTVkdfU1VQUE9SVAorI2lmZGVmIFNWR19TVVBQT1JUCiAjaW5jbHVk ZSAiWExpbmtOYW1lcy5oIgogI2luY2x1ZGUgIlNWR05hbWVzLmgiCiAjaW5jbHVkZSAiU1ZHQ3Vy c29yRWxlbWVudC5oIgpAQCAtNTksNyArNTksNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIHVz aW5nIG5hbWVzcGFjZSBFdmVudE5hbWVzOwogdXNpbmcgbmFtZXNwYWNlIEhUTUxOYW1lczsKLSNp ZiBTVkdfU1VQUE9SVAorI2lmZGVmIFNWR19TVVBQT1JUCiB1c2luZyBuYW1lc3BhY2UgU1ZHTmFt ZXM7CiAjZW5kaWYKIApAQCAtNjYxLDcgKzY2MSw3IEBAIHN0YXRpYyBDdXJzb3Igc2VsZWN0Q3Vy c29yKGNvbnN0IE1vdXNlRXYKICAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IGN1cnNv cnMtPnNpemUoKTsgKytpKSB7CiAgICAgICAgICAgICBDYWNoZWRJbWFnZSogY2ltYWdlID0gKCpj dXJzb3JzKVtpXS5jdXJzb3JJbWFnZTsKICAgICAgICAgICAgIEludFBvaW50IGhvdFNwb3QgPSAo KmN1cnNvcnMpW2ldLmhvdFNwb3Q7Ci0jaWYgU1ZHX1NVUFBPUlQKKyNpZmRlZiBTVkdfU1VQUE9S VAogICAgICAgICAgICAgaWYgKCFjaW1hZ2UpIHsKICAgICAgICAgICAgICAgICBFbGVtZW50KiBl ID0gbm9kZS0+ZG9jdW1lbnQoKS0+Z2V0RWxlbWVudEJ5SWQoKCpjdXJzb3JzKVtpXS5jdXJzb3JG cmFnbWVudElkKTsKICAgICAgICAgICAgICAgICBpZiAoZSAmJiBlLT5oYXNUYWdOYW1lKGN1cnNv clRhZykpIHsKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vcXQvR3JhcGhpY3NDb250ZXh0UXQuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vcXQvR3JhcGhpY3NDb250ZXh0UXQuY3Bw CShyZXZpc2lvbiAxNjU1NykKKysrIFdlYkNvcmUvcGxhdGZvcm0vcXQvR3JhcGhpY3NDb250ZXh0 UXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00Niw3ICs0Niw3IEBACiAjZGVmaW5lIE1fUEkgMy4x NDE1OTI2NTM1ODk3OTMyMzg0NgogI2VuZGlmCiAKLSNpZiBTVkdfU1VQUE9SVAorI2lmZGVmIFNW R19TVVBQT1JUCiAjaW5jbHVkZSAiS1JlbmRlcmluZ0RldmljZVF0LmgiCiAjZW5kaWYKIApAQCAt Nzc3LDcgKzc3Nyw3IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0Ojpjb25jYXRDVE0oY29uc3QgQWYK ICAgICBtX2RhdGEtPnAoKS5zZXRNYXRyaXgodHJhbnNmb3JtLCB0cnVlKTsKIH0KIAotI2lmIFNW R19TVVBQT1JUCisjaWZkZWYgU1ZHX1NVUFBPUlQKIEtSZW5kZXJpbmdEZXZpY2VDb250ZXh0KiBH cmFwaGljc0NvbnRleHQ6OmNyZWF0ZVJlbmRlcmluZ0RldmljZUNvbnRleHQoKQogewogICAgIHJl dHVybiBuZXcgS1JlbmRlcmluZ0RldmljZUNvbnRleHRRdChwbGF0Zm9ybUNvbnRleHQoKSk7Cg==