110196 2013-02-19 02:24:39 -0800 RenderTable::paintBoxDecorations sometimes draws box-shadow twice. 2013-02-21 22:27:33 -0800 1 1 1 Unclassified WebKit Tables 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tasak tasak eric jchaffraix ojan.autocc simon.fraser webkit.review.bot oldest_to_newest 836160 0 tasak 2013-02-19 02:24:39 -0800 Since RenderTable::paintBoxDecorations doesn't provide correct bleedAvoidance parameter for paintBackground, both RenderTable::paintBoxDecorations and RenderBox::paintBackground (~RenderBoxModelObject::paintFillLayerExtended) draw box-shadow. 836163 1 189032 tasak 2013-02-19 02:31:41 -0800 Created attachment 189032 Patch 839160 2 jchaffraix 2013-02-21 19:56:42 -0800 This is really a patch for Simon, I don't know much about bleedAvoidance. 839241 3 189032 webkit.review.bot 2013-02-21 22:27:29 -0800 Comment on attachment 189032 Patch Clearing flags on attachment: 189032 Committed r143690: <http://trac.webkit.org/changeset/143690> 839242 4 webkit.review.bot 2013-02-21 22:27:33 -0800 All reviewed patches have been landed. Closing bug. 189032 2013-02-19 02:31:41 -0800 2013-02-21 22:27:29 -0800 Patch bug-110196-20130219192803.patch text/plain 4550 tasak U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzMjc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmM2YTRlNTk3NDNiYmY2 OGNkOTM1NjZkNWJjMTc2MjIwZjZlZGIyMi4uMTc2YmFkNGM4MzE5ODY3YTA2ZTJhODg4MjMxNGRj YWZhODI5YTQ5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAyLTE5ICBUYWth c2hpIFNha2Ftb3RvICA8dGFzYWtAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZW5kZXJUYWJsZTo6 cGFpbnRCb3hEZWNvcmF0aW9ucyBzb21ldGltZXMgZHJhd3MgYm94LXNoYWRvdyB0d2ljZS4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDE5NgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gUmVuZGVy VGFibGU6OnBhaW50Qm94RGVjb3JhdGlvbnMgZHJhd3MgYm94LXNoYWRvdywgcGFpbnRCYWNrZ3Jv dW5kCisgICAgICAgIHNob3VsZCBub3QgZHJhdyBib3gtc2hhZG93LiBTbyB3ZSBoYXZlIHRvIHBy b3ZpZGUgYmxlZWRBdm9pZGFuY2UKKyAgICAgICAgcGFyYW1ldGVyIGZvciBSZW5kZXJCb3g6OnBh aW50QmFja2dyb3VuZC4KKworICAgICAgICBUZXN0OiBmYXN0L2Nzcy90YWJsZS1ib3JkZXItcmFk aXVzLXdpdGgtYm94LXNoYWRvdy5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGFi bGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGFibGU6OnBhaW50Qm94RGVjb3JhdGlv bnMpOgorICAgICAgICBQcm92aWRlIGJsZWVkQXZvaWRhbmNlLCB3aGljaCBkZXRlcm1pbmVCYWNr Z3JvdW5kQmxlZWRBdm9pZGFuY2UKKyAgICAgICAgcmV0dXJucywgZm9yIHBhaW50QmFja2dyb3Vu ZC4KKwogMjAxMy0wMi0xOCAgcGVhdm9Ab3V0bG9vay5jb20gIDxwZWF2b0BvdXRsb29rLmNvbT4K IAogICAgICAgICBbQ3VybF0gVGhlIGZ1bmN0aW9uIGNvb2tpZXNGb3JET00oKSBkb2VzIG5vdCBi ZWhhdmUgY29ycmVjdGx5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlclRhYmxlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZS5jcHAK aW5kZXggNDUxYjc0NWNhYTI3MTJiNmE5YTVlNjRhMTRiOTM0MDkzOTgyY2M4Ny4uZWY1ZmY5YTIy MDNjZjhhM2NhNGEwOTk3YWZjMmIyZTIxNDU1YjJlOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyVGFibGUuY3BwCkBAIC02OTMsOSArNjkzLDEwIEBAIHZvaWQgUmVuZGVyVGFibGU6 OnBhaW50Qm94RGVjb3JhdGlvbnMoUGFpbnRJbmZvJiBwYWludEluZm8sIGNvbnN0IExheW91dFBv aW50JiBwCiAgICAgTGF5b3V0UmVjdCByZWN0KHBhaW50T2Zmc2V0LCBzaXplKCkpOwogICAgIHN1 YnRyYWN0Q2FwdGlvblJlY3QocmVjdCk7CiAKLSAgICBpZiAoIWJveFNoYWRvd1Nob3VsZEJlQXBw bGllZFRvQmFja2dyb3VuZChkZXRlcm1pbmVCYWNrZ3JvdW5kQmxlZWRBdm9pZGFuY2UocGFpbnRJ bmZvLmNvbnRleHQpKSkKKyAgICBCYWNrZ3JvdW5kQmxlZWRBdm9pZGFuY2UgYmxlZWRBdm9pZGFu Y2UgPSBkZXRlcm1pbmVCYWNrZ3JvdW5kQmxlZWRBdm9pZGFuY2UocGFpbnRJbmZvLmNvbnRleHQp OworICAgIGlmICghYm94U2hhZG93U2hvdWxkQmVBcHBsaWVkVG9CYWNrZ3JvdW5kKGJsZWVkQXZv aWRhbmNlKSkKICAgICAgICAgcGFpbnRCb3hTaGFkb3cocGFpbnRJbmZvLCByZWN0LCBzdHlsZSgp LCBOb3JtYWwpOwotICAgIHBhaW50QmFja2dyb3VuZChwYWludEluZm8sIHJlY3QpOworICAgIHBh aW50QmFja2dyb3VuZChwYWludEluZm8sIHJlY3QsIGJsZWVkQXZvaWRhbmNlKTsKICAgICBwYWlu dEJveFNoYWRvdyhwYWludEluZm8sIHJlY3QsIHN0eWxlKCksIEluc2V0KTsKIAogICAgIGlmIChz dHlsZSgpLT5oYXNCb3JkZXIoKSAmJiAhY29sbGFwc2VCb3JkZXJzKCkpCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOTRiYWYw MTM5Y2E0ZGZjN2EwMDFjNjhlM2NmMzQ5NmFiYTY2YjczMi4uMThjNzRiNWNiMzYwNWE1MDgyOWM3 ZmE2NmNmNTk3ZDI0ZmZjNmY5NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisr KyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAyLTE5ICBU YWthc2hpIFNha2Ftb3RvICA8dGFzYWtAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZW5kZXJUYWJs ZTo6cGFpbnRCb3hEZWNvcmF0aW9ucyBzb21ldGltZXMgZHJhd3MgYm94LXNoYWRvdyB0d2ljZS4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDE5Ngor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9j c3MvdGFibGUtYm9yZGVyLXJhZGl1cy13aXRoLWJveC1zaGFkb3ctZXhwZWN0ZWQuaHRtbDogQWRk ZWQuCisgICAgICAgICogZmFzdC9jc3MvdGFibGUtYm9yZGVyLXJhZGl1cy13aXRoLWJveC1zaGFk b3cuaHRtbDogQWRkZWQuCisKIDIwMTMtMDItMTggIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxl LmNvbT4KIAogICAgICAgICBTdHJ1Y3R1cmU6OmZsYXR0ZW5EaWN0aW9uYXJ5U3RydWN0dXJlIHNo b3VsZCBjb21wdXRlIG1heCBvZmZzZXQgaW4gYSBtYW5uZXIgdGhhdCBzb3VuZGx5IGhhbmRsZXMg dGhlIGNhc2Ugd2hlcmUgdGhlIHByb3BlcnR5IGxpc3QgYmVjb21lcyBlbXB0eQpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MvdGFibGUtYm9yZGVyLXJhZGl1cy13aXRoLWJveC1zaGFk b3ctZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL3RhYmxlLWJvcmRlci1yYWRp dXMtd2l0aC1ib3gtc2hhZG93LWV4cGVjdGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOTIzNzE5NWRlYWZk MDk0NDZmNDcxNWNjMDc3NTZlZWQ0ZTM3Y2Q1ZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRl c3RzL2Zhc3QvY3NzL3RhYmxlLWJvcmRlci1yYWRpdXMtd2l0aC1ib3gtc2hhZG93LWV4cGVjdGVk Lmh0bWwKQEAgLTAsMCArMSwyNCBAQAorPCFkb2N0eXBlIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgor ICA8c3R5bGU+CisgICAgZGl2IHsKKyAgICAgIHdpZHRoOiAxOThweDsKKyAgICAgIGhlaWdodDog OThweDsKKyAgICB9CisgICAgLnJvdW5kIHsKKyAgICAgIGJvcmRlci1yYWRpdXM6IDEwcHg7Cisg ICAgfQorICAgIC5zaGFkb3cgeworICAgICAgYm94LXNoYWRvdzogMCAxMHB4IDJweCByZ2JhKDAs IDAsIDAsIDAuNSk7CisgICAgfQorICAgIC5ib3JkZXIgeworICAgICAgYm9yZGVyOiAxcHggc29s aWQgYmx1ZTsKKyAgICB9CisgIDwvc3R5bGU+Cis8L2hlYWQ+Cis8Ym9keT4KKyAgPGRpdiBjbGFz cz0ic2hhZG93IGJvcmRlciByb3VuZCI+CisgIDwvZGl2PgorPC9ib2R5PgorPC9odG1sPgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MvdGFibGUtYm9yZGVyLXJhZGl1cy13aXRoLWJv eC1zaGFkb3cuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL3RhYmxlLWJvcmRlci1yYWRpdXMt d2l0aC1ib3gtc2hhZG93Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMGY1ZGIwZDBmZGY4NTY5Y2UzNjRkZDM4 ZGNlYzgzNjI3NjhmYzJlNQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3Nz L3RhYmxlLWJvcmRlci1yYWRpdXMtd2l0aC1ib3gtc2hhZG93Lmh0bWwKQEAgLTAsMCArMSwyNyBA QAorPCFkb2N0eXBlIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorICA8c3R5bGU+CisgICAgdGFibGUg eworICAgICAgd2lkdGg6IDIwMHB4OworICAgICAgaGVpZ2h0OiAxMDBweDsKKyAgICAgIGJvcmRl ci1zcGFjaW5nOiAwcHg7CisgICAgfQorICAgIC5yb3VuZCB7CisgICAgICBib3JkZXItcmFkaXVz OiAxMHB4OworICAgIH0KKyAgICAuc2hhZG93IHsKKyAgICAgIGJveC1zaGFkb3c6IDAgMTBweCAy cHggcmdiYSgwLCAwLCAwLCAwLjUpOworICAgIH0KKyAgICAuYm9yZGVyIHsKKyAgICAgIGJvcmRl cjogMXB4IHNvbGlkIGJsdWU7CisgICAgfQorICA8L3N0eWxlPgorPC9oZWFkPgorPGJvZHk+Cisg IDwhLS0gW2J1ZyAxMTAxOTZdIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTAxOTYgLS0+CisgIDwhLS0gUmVuZGVyVGFibGU6OnBhaW50Qm94RGVjb3JhdGlvbnMgc29t ZXRpbWVzIGRyYXdzIGJveC1zaGFkb3cgdHdpY2UuIC0tPgorICA8dGFibGUgY2xhc3M9InNoYWRv dyBib3JkZXIgcm91bmQiPgorICA8L3RhYmxlPgorPC9ib2R5PgorPC9odG1sPgo=