110192 2013-02-19 01:32:59 -0800 WebAudio API: Change the Platform::createAudioDevice function to take a DeviceId parameter 2013-03-01 13:31:42 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 109494 1 tommyw tommyw abarth crogers dglazkov fishd jamesr jesus tkent+wkapi webkit.review.bot oldest_to_newest 836121 0 tommyw 2013-02-19 01:32:59 -0800 WebAudio API: Change the Platform::createAudioDevice function to take a DeviceId parameter 836123 1 189022 tommyw 2013-02-19 01:33:39 -0800 Created attachment 189022 Patch 836126 2 webkit.review.bot 2013-02-19 01:36:57 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 836563 3 189022 abarth 2013-02-19 11:06:05 -0800 Comment on attachment 189022 Patch ok 836641 4 189022 crogers 2013-02-19 12:10:23 -0800 Comment on attachment 189022 Patch tommyw, thanks for staging the changes like this 836675 5 189022 webkit.review.bot 2013-02-19 12:38:18 -0800 Comment on attachment 189022 Patch Clearing flags on attachment: 189022 Committed r143372: <http://trac.webkit.org/changeset/143372> 836676 6 webkit.review.bot 2013-02-19 12:38:23 -0800 All reviewed patches have been landed. Closing bug. 845437 7 jesus 2013-03-01 13:01:51 -0800 What is this new parameter (deviceID) meant for? 845454 8 crogers 2013-03-01 13:15:52 -0800 This really should have been named "inputDeviceId". It is a string identifier to specify the exact audio input device to use. Many machines have more than one audio input device, so this needs to be specified. This bug provides more background: https://bugs.webkit.org/show_bug.cgi?id=109494 845466 9 jesus 2013-03-01 13:31:42 -0800 (In reply to comment #8) > This really should have been named "inputDeviceId". It is a string identifier to specify the exact audio input device to use. Many machines have more than one audio input device, so this needs to be specified. > > This bug provides more background: > https://bugs.webkit.org/show_bug.cgi?id=109494 Thanks! I get it now. It would be nice if the API was called using a const char* (WebString would need an extra implicit ctor, I guess) instead of a WTF::String directly, but we can workaround this. 189022 2013-02-19 01:33:39 -0800 2013-02-19 12:38:18 -0800 Patch bug-110192-20130219103001.patch text/plain 2186 tommyw U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzMTc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCAyMTQ2ZDIyZTg0NjA2 NjM3ZTYwMWQxODg1Yzc2MTI1NDg3MWNjOTUxLi5kOGZiMzUxZjk2ZWU5OTg5ZjkwMmZjMDNiM2Mw M2Q5ODJlMDJlY2VlIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMy0wMi0xOSAg VG9tbXkgV2lkZW5mbHljaHQgIDx0b21teXdAZ29vZ2xlLmNvbT4KKworICAgICAgICBXZWJBdWRp byBBUEk6IENoYW5nZSB0aGUgUGxhdGZvcm06OmNyZWF0ZUF1ZGlvRGV2aWNlIGZ1bmN0aW9uIHRv IHRha2UgYSBEZXZpY2VJZCBwYXJhbWV0ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTExMDE5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogY2hyb21pdW0vcHVibGljL1BsYXRmb3JtLmg6CisgICAgICAg IChXZWJLaXQ6OlBsYXRmb3JtOjpjcmVhdGVBdWRpb0RldmljZSk6CisgICAgICAgIChQbGF0Zm9y bSk6CisKIDIwMTMtMDItMTQgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwu Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxNDI4NDEuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1BsYXRmb3JtLmggYi9Tb3VyY2Uv UGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1BsYXRmb3JtLmgKaW5kZXggYTdkZTNiYzhjNzMxY2Qw MGQ1MDdjYTk1MDI0ZThlYTNkZTM5MjFiMS4uMzllOWRmMzU0MmRkZDQ0Njc0MDQxOGI5ZTk3Mjc4 YTFmNGU3ODQ1YSAxMDA2NDQKLS0tIGEvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9Q bGF0Zm9ybS5oCisrKyBiL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvUGxhdGZvcm0u aApAQCAtMTE3LDEwICsxMTcsMTEgQEAgcHVibGljOgogCiAgICAgLy8gQ3JlYXRlcyBhIGRldmlj ZSBmb3IgYXVkaW8gSS9PLgogICAgIC8vIFBhc3MgaW4gKG51bWJlck9mSW5wdXRDaGFubmVscyA+ IDApIGlmIGxpdmUvbG9jYWwgYXVkaW8gaW5wdXQgaXMgZGVzaXJlZC4KLSAgICB2aXJ0dWFsIFdl YkF1ZGlvRGV2aWNlKiBjcmVhdGVBdWRpb0RldmljZShzaXplX3QgYnVmZmVyU2l6ZSwgdW5zaWdu ZWQgbnVtYmVyT2ZJbnB1dENoYW5uZWxzLCB1bnNpZ25lZCBudW1iZXJPZkNoYW5uZWxzLCBkb3Vi bGUgc2FtcGxlUmF0ZSwgV2ViQXVkaW9EZXZpY2U6OlJlbmRlckNhbGxiYWNrKikgeyByZXR1cm4g MDsgfQorICAgIHZpcnR1YWwgV2ViQXVkaW9EZXZpY2UqIGNyZWF0ZUF1ZGlvRGV2aWNlKHNpemVf dCBidWZmZXJTaXplLCB1bnNpZ25lZCBudW1iZXJPZklucHV0Q2hhbm5lbHMsIHVuc2lnbmVkIG51 bWJlck9mQ2hhbm5lbHMsIGRvdWJsZSBzYW1wbGVSYXRlLCBXZWJBdWRpb0RldmljZTo6UmVuZGVy Q2FsbGJhY2sqLCBjb25zdCBXZWJTdHJpbmcmIGRldmljZUlkKSB7IHJldHVybiAwOyB9CiAKLSAg ICAvLyBGSVhNRTogcmVtb3ZlIGRlcHJlY2F0ZWQgQVBJIG9uY2UgY2hyb21pdW0gc3dpdGNoZXMg b3ZlciB0byBuZXcgbWV0aG9kLgorICAgIC8vIEZJWE1FOiByZW1vdmUgZGVwcmVjYXRlZCBBUElz IG9uY2UgY2hyb21pdW0gc3dpdGNoZXMgb3ZlciB0byBuZXcgbWV0aG9kLgogICAgIHZpcnR1YWwg V2ViQXVkaW9EZXZpY2UqIGNyZWF0ZUF1ZGlvRGV2aWNlKHNpemVfdCBidWZmZXJTaXplLCB1bnNp Z25lZCBudW1iZXJPZkNoYW5uZWxzLCBkb3VibGUgc2FtcGxlUmF0ZSwgV2ViQXVkaW9EZXZpY2U6 OlJlbmRlckNhbGxiYWNrKikgeyByZXR1cm4gMDsgfQorICAgIHZpcnR1YWwgV2ViQXVkaW9EZXZp Y2UqIGNyZWF0ZUF1ZGlvRGV2aWNlKHNpemVfdCBidWZmZXJTaXplLCB1bnNpZ25lZCBudW1iZXJP ZklucHV0Q2hhbm5lbHMsIHVuc2lnbmVkIG51bWJlck9mQ2hhbm5lbHMsIGRvdWJsZSBzYW1wbGVS YXRlLCBXZWJBdWRpb0RldmljZTo6UmVuZGVyQ2FsbGJhY2sqKSB7IHJldHVybiAwOyB9CiAKIAog ICAgIC8vIEJsb2IgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLQo=