110180 2013-02-18 22:46:40 -0800 Refactoring FixedTableLayout class for readability. 2023-04-02 20:58:32 -0700 1 1 1 Unclassified WebKit Tables 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P3 Normal --- 1 pravind pravind ahmad.saleem792 eric jchaffraix ojan.autocc webkit.review.bot zalan oldest_to_newest 835986 0 pravind 2013-02-18 22:46:40 -0800 Refactoring the code width distribution code in FixedTableLayout::layout() for readability. 836416 1 189093 pravind 2013-02-19 08:25:46 -0800 Created attachment 189093 Patch 836433 2 189096 pravind 2013-02-19 08:42:10 -0800 Created attachment 189096 Patch 836576 3 189096 jchaffraix 2013-02-19 11:15:25 -0800 Comment on attachment 189096 Patch Really not sure how much more clear this is but it's moot from my perspective. As discussed on IRC, I would rather have the algorithm straightened up (like how we shrink looks suspicious (I would argue that shrinking is probably a wrong idea but that could be needed for compatibility)), maybe the different parts split up, unify the extra logical width spreading... This would lead to a much more readable code. 976939 4 189096 kling 2014-02-05 11:11:07 -0800 Comment on attachment 189096 Patch Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag. 1946048 5 ahmad.saleem792 2023-04-02 08:03:20 -0700 @Alan - do we need to track it up, we can apply this patch (I looked into it) but I think Julien mentioned that it is not fixing much or anything. I just trying to close old bugs so if we don't need to do anything, we can close this or if you want me to apply patch, I can try it with local build. https://searchfox.org/wubkat/source/Source/WebCore/rendering/FixedTableLayout.cpp#266 1946115 6 zalan 2023-04-02 20:51:35 -0700 (In reply to Ahmad Saleem from comment #5) > @Alan - do we need to track it up, we can apply this patch (I looked into > it) but I think Julien mentioned that it is not fixing much or anything. > > I just trying to close old bugs so if we don't need to do anything, we can > close this or if you want me to apply patch, I can try it with local build. > > https://searchfox.org/wubkat/source/Source/WebCore/rendering/ > FixedTableLayout.cpp#266 I wouldn't put too much effort into it. 1946116 7 ahmad.saleem792 2023-04-02 20:58:32 -0700 Closing this old bug now based on discussion with Alan. :-) 189093 2013-02-19 08:25:46 -0800 2013-02-19 08:35:05 -0800 Patch bug-110180-20130220032208.patch text/plain 4110 pravind U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzMjk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjEwNmYwM2Y2OWUyYmRk MTE4ODNjNWMwMjZhYTg1ZTI2NzhkZmY2MS4uZWZmNjVjM2FkMzcwMWQ4MzUyYjMwYWMyNWUwYzg5 N2E1NDU5NTU4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAyLTE5ICBQcmF2 aW4gRCAgPHByYXZpbmRAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgUmVmYWN0b3JpbmcgRml4ZWRU YWJsZUxheW91dCBjbGFzcyBmb3IgcmVhZGFiaWxpdHkuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTAxODAKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZWZhY3RvcmluZyB0aGUgY29kZS4gTm8gbmV3IFRl c3RjYXNlIHJlcXVpcmVkLgorCisgICAgICAgICogcmVuZGVyaW5nL0ZpeGVkVGFibGVMYXlvdXQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6Rml4ZWRUYWJsZUxheW91dDo6bGF5b3V0KToKKyAgICAg ICAgIFN3YXBlZCB0aGUgaWYoKSAuLiBlbHNlIGNhc2VzIGZvciBiZXR0ZXIgcmVhZGFiaWxpdHku CisKIDIwMTMtMDItMTggIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgVGhhdCBkaWRuJ3Qgd29yayBlaXRoZXIuIEp1c3QgbWFrZSBpdCBwdWJsaWMuIFRoaXMgaXMg d2h5IEkgaGF0ZSBuZXN0ZWQgY2xhc3Nlcy4gVGhleSBqdXN0IGRvbid0IHdvcmsuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvRml4ZWRUYWJsZUxheW91dC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvRml4ZWRUYWJsZUxheW91dC5jcHAKaW5kZXggMTBkZmJjOGIx OTEwMjExYjcxYThiZjE0ZGIxMjBiY2RlYTMzNzdhMi4uNTYyOTE3YzY4MDgwYmY4OGE0MzQ1YTRi M2Q1YzRkYTk5NjQxM2YxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0Zp eGVkVGFibGVMYXlvdXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9GaXhlZFRh YmxlTGF5b3V0LmNwcApAQCAtMjUzLDMyICsyNTMsNyBAQCB2b2lkIEZpeGVkVGFibGVMYXlvdXQ6 OmxheW91dCgpCiAKICAgICBpbnQgaHNwYWNpbmcgPSBtX3RhYmxlLT5oQm9yZGVyU3BhY2luZygp OwogICAgIGludCB0b3RhbFdpZHRoID0gdG90YWxGaXhlZFdpZHRoICsgdG90YWxQZXJjZW50V2lk dGg7Ci0gICAgaWYgKCFudW1BdXRvIHx8IHRvdGFsV2lkdGggPiB0YWJsZUxvZ2ljYWxXaWR0aCkg ewotICAgICAgICAvLyBJZiB0aGVyZSBhcmUgbm8gYXV0byBjb2x1bW5zLCBvciBpZiB0aGUgdG90 YWwgaXMgdG9vIHdpZGUsIHRha2UKLSAgICAgICAgLy8gd2hhdCB3ZSBoYXZlIGFuZCBzY2FsZSBp dCB0byBmaXQgYXMgbmVjZXNzYXJ5LgotICAgICAgICBpZiAodG90YWxXaWR0aCAhPSB0YWJsZUxv Z2ljYWxXaWR0aCkgewotICAgICAgICAgICAgLy8gRml4ZWQgd2lkdGhzIG9ubHkgc2NhbGUgdXAK LSAgICAgICAgICAgIGlmICh0b3RhbEZpeGVkV2lkdGggJiYgdG90YWxXaWR0aCA8IHRhYmxlTG9n aWNhbFdpZHRoKSB7Ci0gICAgICAgICAgICAgICAgdG90YWxGaXhlZFdpZHRoID0gMDsKLSAgICAg ICAgICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgbkVmZkNvbHM7IGkrKykgewotICAg ICAgICAgICAgICAgICAgICBpZiAobV93aWR0aFtpXS5pc0ZpeGVkKCkpIHsKLSAgICAgICAgICAg ICAgICAgICAgICAgIGNhbGNXaWR0aFtpXSA9IGNhbGNXaWR0aFtpXSAqIHRhYmxlTG9naWNhbFdp ZHRoIC8gdG90YWxXaWR0aDsKLSAgICAgICAgICAgICAgICAgICAgICAgIHRvdGFsRml4ZWRXaWR0 aCArPSBjYWxjV2lkdGhbaV07Ci0gICAgICAgICAgICAgICAgICAgIH0KLSAgICAgICAgICAgICAg ICB9Ci0gICAgICAgICAgICB9Ci0gICAgICAgICAgICBpZiAodG90YWxQZXJjZW50KSB7Ci0gICAg ICAgICAgICAgICAgdG90YWxQZXJjZW50V2lkdGggPSAwOwotICAgICAgICAgICAgICAgIGZvciAo dW5zaWduZWQgaSA9IDA7IGkgPCBuRWZmQ29sczsgaSsrKSB7Ci0gICAgICAgICAgICAgICAgICAg IGlmIChtX3dpZHRoW2ldLmlzUGVyY2VudCgpKSB7Ci0gICAgICAgICAgICAgICAgICAgICAgICBj YWxjV2lkdGhbaV0gPSBtX3dpZHRoW2ldLnBlcmNlbnQoKSAqICh0YWJsZUxvZ2ljYWxXaWR0aCAt IHRvdGFsRml4ZWRXaWR0aCkgLyB0b3RhbFBlcmNlbnQ7Ci0gICAgICAgICAgICAgICAgICAgICAg ICB0b3RhbFBlcmNlbnRXaWR0aCArPSBjYWxjV2lkdGhbaV07Ci0gICAgICAgICAgICAgICAgICAg IH0KLSAgICAgICAgICAgICAgICB9Ci0gICAgICAgICAgICB9Ci0gICAgICAgICAgICB0b3RhbFdp ZHRoID0gdG90YWxGaXhlZFdpZHRoICsgdG90YWxQZXJjZW50V2lkdGg7Ci0gICAgICAgIH0KLSAg ICB9IGVsc2UgeworICAgIGlmIChudW1BdXRvICYmIHRvdGFsV2lkdGggPCB0YWJsZUxvZ2ljYWxX aWR0aCkgewogICAgICAgICAvLyBEaXZpZGUgdGhlIHJlbWFpbmluZyB3aWR0aCBhbW9uZyB0aGUg YXV0byBjb2x1bW5zLgogICAgICAgICBBU1NFUlQoYXV0b1NwYW4gPj0gbnVtQXV0byk7CiAgICAg ICAgIGludCByZW1haW5pbmdXaWR0aCA9IHRhYmxlTG9naWNhbFdpZHRoIC0gdG90YWxGaXhlZFdp ZHRoIC0gdG90YWxQZXJjZW50V2lkdGggLSBoc3BhY2luZyAqIChhdXRvU3BhbiAtIG51bUF1dG8p OwpAQCAtMzAxLDYgKzI3NiwzMCBAQCB2b2lkIEZpeGVkVGFibGVMYXlvdXQ6OmxheW91dCgpCiAg ICAgICAgIGlmIChyZW1haW5pbmdXaWR0aCkKICAgICAgICAgICAgIGNhbGNXaWR0aFtsYXN0QXV0 b10gKz0gcmVtYWluaW5nV2lkdGg7CiAgICAgICAgIHRvdGFsV2lkdGggPSB0YWJsZUxvZ2ljYWxX aWR0aDsKKyAgICB9IGVsc2UgeworICAgICAgICAvLyBJZiB0aGVyZSBhcmUgbm8gYXV0byBjb2x1 bW5zLCBvciBpZiB0aGUgdG90YWwgaXMgdG9vIHdpZGUsIHRha2UKKyAgICAgICAgLy8gd2hhdCB3 ZSBoYXZlIGFuZCBzY2FsZSBpdCB0byBmaXQgYXMgbmVjZXNzYXJ5LgorICAgICAgICAvLyBGaXhl ZCB3aWR0aHMgb25seSBzY2FsZSB1cAorICAgICAgICBpZiAodG90YWxGaXhlZFdpZHRoICYmIHRv dGFsV2lkdGggPCB0YWJsZUxvZ2ljYWxXaWR0aCkgeworICAgICAgICAgICAgdG90YWxGaXhlZFdp ZHRoID0gMDsKKyAgICAgICAgICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBuRWZmQ29sczsg aSsrKSB7CisgICAgICAgICAgICAgICAgaWYgKG1fd2lkdGhbaV0uaXNGaXhlZCgpKSB7CisgICAg ICAgICAgICAgICAgICAgIGNhbGNXaWR0aFtpXSA9IGNhbGNXaWR0aFtpXSAqIHRhYmxlTG9naWNh bFdpZHRoIC8gdG90YWxXaWR0aDsKKyAgICAgICAgICAgICAgICAgICAgdG90YWxGaXhlZFdpZHRo ICs9IGNhbGNXaWR0aFtpXTsKKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICB9CisgICAg ICAgIH0KKyAgICAgICAgLy8gTm93IGFkanVzdCB0aGUgcGVyY2VudCB3aWR0aHMuCisgICAgICAg IGlmICh0b3RhbFBlcmNlbnQgJiYgdG90YWxXaWR0aCAhPSB0YWJsZUxvZ2ljYWxXaWR0aCkgewor ICAgICAgICAgICAgdG90YWxQZXJjZW50V2lkdGggPSAwOworICAgICAgICAgICAgZm9yICh1bnNp Z25lZCBpID0gMDsgaSA8IG5FZmZDb2xzOyBpKyspIHsKKyAgICAgICAgICAgICAgICBpZiAobV93 aWR0aFtpXS5pc1BlcmNlbnQoKSkgeworICAgICAgICAgICAgICAgICAgICBjYWxjV2lkdGhbaV0g PSBtX3dpZHRoW2ldLnBlcmNlbnQoKSAqICh0YWJsZUxvZ2ljYWxXaWR0aCAtIHRvdGFsRml4ZWRX aWR0aCkgLyB0b3RhbFBlcmNlbnQ7CisgICAgICAgICAgICAgICAgICAgIHRvdGFsUGVyY2VudFdp ZHRoICs9IGNhbGNXaWR0aFtpXTsKKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICB9Cisg ICAgICAgIH0KKyAgICAgICAgdG90YWxXaWR0aCA9IHRvdGFsRml4ZWRXaWR0aCArIHRvdGFsUGVy Y2VudFdpZHRoOwogICAgIH0KIAogICAgIGlmICh0b3RhbFdpZHRoIDwgdGFibGVMb2dpY2FsV2lk dGgpIHsK 189096 2013-02-19 08:42:10 -0800 2014-02-05 11:11:02 -0800 Patch bug-110180-20130220033832.patch text/plain 4440 pravind U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzMjk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjEwNmYwM2Y2OWUyYmRk MTE4ODNjNWMwMjZhYTg1ZTI2NzhkZmY2MS4uZWZmNjVjM2FkMzcwMWQ4MzUyYjMwYWMyNWUwYzg5 N2E1NDU5NTU4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAyLTE5ICBQcmF2 aW4gRCAgPHByYXZpbmRAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgUmVmYWN0b3JpbmcgRml4ZWRU YWJsZUxheW91dCBjbGFzcyBmb3IgcmVhZGFiaWxpdHkuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTAxODAKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZWZhY3RvcmluZyB0aGUgY29kZS4gTm8gbmV3IFRl c3RjYXNlIHJlcXVpcmVkLgorCisgICAgICAgICogcmVuZGVyaW5nL0ZpeGVkVGFibGVMYXlvdXQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6Rml4ZWRUYWJsZUxheW91dDo6bGF5b3V0KToKKyAgICAg ICAgIFN3YXBlZCB0aGUgaWYoKSAuLiBlbHNlIGNhc2VzIGZvciBiZXR0ZXIgcmVhZGFiaWxpdHku CisKIDIwMTMtMDItMTggIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgVGhhdCBkaWRuJ3Qgd29yayBlaXRoZXIuIEp1c3QgbWFrZSBpdCBwdWJsaWMuIFRoaXMgaXMg d2h5IEkgaGF0ZSBuZXN0ZWQgY2xhc3Nlcy4gVGhleSBqdXN0IGRvbid0IHdvcmsuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvRml4ZWRUYWJsZUxheW91dC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvRml4ZWRUYWJsZUxheW91dC5jcHAKaW5kZXggMTBkZmJjOGIx OTEwMjExYjcxYThiZjE0ZGIxMjBiY2RlYTMzNzdhMi4uMTIxNDVlOGRmMWVlMzIzMzNjYzg3Y2Zj MjgxOWNiNjg5NjMzZjQ4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0Zp eGVkVGFibGVMYXlvdXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9GaXhlZFRh YmxlTGF5b3V0LmNwcApAQCAtMjUzLDMyICsyNTMsNyBAQCB2b2lkIEZpeGVkVGFibGVMYXlvdXQ6 OmxheW91dCgpCiAKICAgICBpbnQgaHNwYWNpbmcgPSBtX3RhYmxlLT5oQm9yZGVyU3BhY2luZygp OwogICAgIGludCB0b3RhbFdpZHRoID0gdG90YWxGaXhlZFdpZHRoICsgdG90YWxQZXJjZW50V2lk dGg7Ci0gICAgaWYgKCFudW1BdXRvIHx8IHRvdGFsV2lkdGggPiB0YWJsZUxvZ2ljYWxXaWR0aCkg ewotICAgICAgICAvLyBJZiB0aGVyZSBhcmUgbm8gYXV0byBjb2x1bW5zLCBvciBpZiB0aGUgdG90 YWwgaXMgdG9vIHdpZGUsIHRha2UKLSAgICAgICAgLy8gd2hhdCB3ZSBoYXZlIGFuZCBzY2FsZSBp dCB0byBmaXQgYXMgbmVjZXNzYXJ5LgotICAgICAgICBpZiAodG90YWxXaWR0aCAhPSB0YWJsZUxv Z2ljYWxXaWR0aCkgewotICAgICAgICAgICAgLy8gRml4ZWQgd2lkdGhzIG9ubHkgc2NhbGUgdXAK LSAgICAgICAgICAgIGlmICh0b3RhbEZpeGVkV2lkdGggJiYgdG90YWxXaWR0aCA8IHRhYmxlTG9n aWNhbFdpZHRoKSB7Ci0gICAgICAgICAgICAgICAgdG90YWxGaXhlZFdpZHRoID0gMDsKLSAgICAg ICAgICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgbkVmZkNvbHM7IGkrKykgewotICAg ICAgICAgICAgICAgICAgICBpZiAobV93aWR0aFtpXS5pc0ZpeGVkKCkpIHsKLSAgICAgICAgICAg ICAgICAgICAgICAgIGNhbGNXaWR0aFtpXSA9IGNhbGNXaWR0aFtpXSAqIHRhYmxlTG9naWNhbFdp ZHRoIC8gdG90YWxXaWR0aDsKLSAgICAgICAgICAgICAgICAgICAgICAgIHRvdGFsRml4ZWRXaWR0 aCArPSBjYWxjV2lkdGhbaV07Ci0gICAgICAgICAgICAgICAgICAgIH0KLSAgICAgICAgICAgICAg ICB9Ci0gICAgICAgICAgICB9Ci0gICAgICAgICAgICBpZiAodG90YWxQZXJjZW50KSB7Ci0gICAg ICAgICAgICAgICAgdG90YWxQZXJjZW50V2lkdGggPSAwOwotICAgICAgICAgICAgICAgIGZvciAo dW5zaWduZWQgaSA9IDA7IGkgPCBuRWZmQ29sczsgaSsrKSB7Ci0gICAgICAgICAgICAgICAgICAg IGlmIChtX3dpZHRoW2ldLmlzUGVyY2VudCgpKSB7Ci0gICAgICAgICAgICAgICAgICAgICAgICBj YWxjV2lkdGhbaV0gPSBtX3dpZHRoW2ldLnBlcmNlbnQoKSAqICh0YWJsZUxvZ2ljYWxXaWR0aCAt IHRvdGFsRml4ZWRXaWR0aCkgLyB0b3RhbFBlcmNlbnQ7Ci0gICAgICAgICAgICAgICAgICAgICAg ICB0b3RhbFBlcmNlbnRXaWR0aCArPSBjYWxjV2lkdGhbaV07Ci0gICAgICAgICAgICAgICAgICAg IH0KLSAgICAgICAgICAgICAgICB9Ci0gICAgICAgICAgICB9Ci0gICAgICAgICAgICB0b3RhbFdp ZHRoID0gdG90YWxGaXhlZFdpZHRoICsgdG90YWxQZXJjZW50V2lkdGg7Ci0gICAgICAgIH0KLSAg ICB9IGVsc2UgeworICAgIGlmIChudW1BdXRvICYmIHRvdGFsV2lkdGggPCB0YWJsZUxvZ2ljYWxX aWR0aCkgewogICAgICAgICAvLyBEaXZpZGUgdGhlIHJlbWFpbmluZyB3aWR0aCBhbW9uZyB0aGUg YXV0byBjb2x1bW5zLgogICAgICAgICBBU1NFUlQoYXV0b1NwYW4gPj0gbnVtQXV0byk7CiAgICAg ICAgIGludCByZW1haW5pbmdXaWR0aCA9IHRhYmxlTG9naWNhbFdpZHRoIC0gdG90YWxGaXhlZFdp ZHRoIC0gdG90YWxQZXJjZW50V2lkdGggLSBoc3BhY2luZyAqIChhdXRvU3BhbiAtIG51bUF1dG8p OwpAQCAtMzAxLDEwICsyNzYsMzQgQEAgdm9pZCBGaXhlZFRhYmxlTGF5b3V0OjpsYXlvdXQoKQog ICAgICAgICBpZiAocmVtYWluaW5nV2lkdGgpCiAgICAgICAgICAgICBjYWxjV2lkdGhbbGFzdEF1 dG9dICs9IHJlbWFpbmluZ1dpZHRoOwogICAgICAgICB0b3RhbFdpZHRoID0gdGFibGVMb2dpY2Fs V2lkdGg7CisgICAgfSBlbHNlIHsKKyAgICAgICAgLy8gSWYgdGhlcmUgYXJlIG5vIGF1dG8gY29s dW1ucywgb3IgaWYgdGhlIHRvdGFsIGlzIHRvbyB3aWRlLCB0YWtlCisgICAgICAgIC8vIHdoYXQg d2UgaGF2ZSBhbmQgc2NhbGUgaXQgdG8gZml0IGFzIG5lY2Vzc2FyeS4KKyAgICAgICAgLy8gRml4 ZWQgd2lkdGhzIG9ubHkgc2NhbGUgdXAgdG8gYWNjb211ZGF0ZSB0aGUgZXh0cmEgbG9naWNhbCB3 aWR0aC4KKyAgICAgICAgaWYgKHRvdGFsRml4ZWRXaWR0aCAmJiB0b3RhbFdpZHRoIDwgdGFibGVM b2dpY2FsV2lkdGgpIHsKKyAgICAgICAgICAgIHRvdGFsRml4ZWRXaWR0aCA9IDA7CisgICAgICAg ICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgbkVmZkNvbHM7IGkrKykgeworICAgICAgICAg ICAgICAgIGlmIChtX3dpZHRoW2ldLmlzRml4ZWQoKSkgeworICAgICAgICAgICAgICAgICAgICBj YWxjV2lkdGhbaV0gPSBjYWxjV2lkdGhbaV0gKiB0YWJsZUxvZ2ljYWxXaWR0aCAvIHRvdGFsV2lk dGg7CisgICAgICAgICAgICAgICAgICAgIHRvdGFsRml4ZWRXaWR0aCArPSBjYWxjV2lkdGhbaV07 CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgfQorICAgICAgICB9CisgICAgICAgIC8v IE5vdyBhZGp1c3QgdGhlIHBlcmNlbnQgd2lkdGhzIHRvIGZpdCB0aGUgY29sdW1ucyB3aXRoaW4g dGhlIGxvZ2ljYWwgdGFibGUgd2lkdGguCisgICAgICAgIGlmICh0b3RhbFBlcmNlbnQgJiYgdG90 YWxXaWR0aCAhPSB0YWJsZUxvZ2ljYWxXaWR0aCkgeworICAgICAgICAgICAgdG90YWxQZXJjZW50 V2lkdGggPSAwOworICAgICAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IG5FZmZDb2xz OyBpKyspIHsKKyAgICAgICAgICAgICAgICBpZiAobV93aWR0aFtpXS5pc1BlcmNlbnQoKSkgewor ICAgICAgICAgICAgICAgICAgICBjYWxjV2lkdGhbaV0gPSBtX3dpZHRoW2ldLnBlcmNlbnQoKSAq ICh0YWJsZUxvZ2ljYWxXaWR0aCAtIHRvdGFsRml4ZWRXaWR0aCkgLyB0b3RhbFBlcmNlbnQ7Cisg ICAgICAgICAgICAgICAgICAgIHRvdGFsUGVyY2VudFdpZHRoICs9IGNhbGNXaWR0aFtpXTsKKyAg ICAgICAgICAgICAgICB9CisgICAgICAgICAgICB9CisgICAgICAgIH0KKyAgICAgICAgdG90YWxX aWR0aCA9IHRvdGFsRml4ZWRXaWR0aCArIHRvdGFsUGVyY2VudFdpZHRoOwogICAgIH0KIAorICAg IC8vIFNwcmVhZCBleHRyYSBzcGFjZShnb3QgZHVlIHRvIGZyYWN0aW9uYWwgcm91bmRpbmcgb2Zm KSBvdmVyIGNvbHVtbnMuCiAgICAgaWYgKHRvdGFsV2lkdGggPCB0YWJsZUxvZ2ljYWxXaWR0aCkg ewotICAgICAgICAvLyBTcHJlYWQgZXh0cmEgc3BhY2Ugb3ZlciBjb2x1bW5zLgogICAgICAgICBp bnQgcmVtYWluaW5nV2lkdGggPSB0YWJsZUxvZ2ljYWxXaWR0aCAtIHRvdGFsV2lkdGg7CiAgICAg ICAgIGludCB0b3RhbCA9IG5FZmZDb2xzOwogICAgICAgICB3aGlsZSAodG90YWwpIHsK