110177 2013-02-18 22:25:54 -0800 [JS Binding] ScriptObject default constructor should initialize the Script State to 0 2013-02-21 11:22:11 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 vivekg vivekg barraclough fpizlo ggaren msaboff oliver rniwa webkit.review.bot oldest_to_newest 835957 0 vivekg 2013-02-18 22:25:54 -0800 ScriptObject default constructor should initialize the Script State to 0. V8 binding has already done the initialization( http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/v8/ScriptObject.h#L47 ). Adding it for JS binding. Patch follows. 835959 1 188989 vivekg 2013-02-18 22:28:45 -0800 Created attachment 188989 Patch 835994 2 ggaren 2013-02-18 23:01:59 -0800 Is there a regression test for this? 836005 3 vivekg 2013-02-18 23:16:55 -0800 (In reply to comment #2) > Is there a regression test for this? Unfortunately I couldn't find any regression test handy for this at the moment. I am trying to create empty InjectedScript in a case when the JavaScript is disabled across the browser. During this, I found that the ScriptState is not initialized to 0. 838598 4 vivekg 2013-02-21 11:08:31 -0800 @Geoffrey I am not sure how to write a test case for this error scenario as I am finding it as a non-trivial case. Do you have any suggestion about writing the test scenario for it? Thank you. 838599 5 188989 ggaren 2013-02-21 11:09:30 -0800 Comment on attachment 188989 Patch OK. r=me 838605 6 188989 vivekg 2013-02-21 11:11:32 -0800 Comment on attachment 188989 Patch Thank you! 838621 7 188989 webkit.review.bot 2013-02-21 11:22:07 -0800 Comment on attachment 188989 Patch Clearing flags on attachment: 188989 Committed r143631: <http://trac.webkit.org/changeset/143631> 838622 8 webkit.review.bot 2013-02-21 11:22:11 -0800 All reviewed patches have been landed. Closing bug. 188989 2013-02-18 22:28:45 -0800 2013-02-21 11:22:07 -0800 Patch bug-110177-20130219115611.patch text/plain 1488 vivekg U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzMjkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzExYWE2MWQ3MzUwMjI5 M2Q1OWViZmMwOTkyYmVjYzc5MTIxMTM0OC4uYmM3MmUwOTNmZjc2MmYxOTY0MWM1MTA0ODUxMzNl NzYzNThlNzk3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAyLTE4ICBWaXZl ayBHYWxhdGFnZSAgPHZpdmVrLnZnQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtKUyBCaW5kaW5n XSBTY3JpcHRPYmplY3QgZGVmYXVsdCBjb25zdHJ1Y3RvciBzaG91bGQgaW5pdGlhbGl6ZSB0aGUg U2NyaXB0IFN0YXRlIHRvIDAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExMDE3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEFkZGluZyB0aGUgaW5pdGlhbGl6YXRpb24gb2YgU2NyaXB0U3RhdGUgdG8gMC4K KworICAgICAgICAqIGJpbmRpbmdzL2pzL1NjcmlwdE9iamVjdC5oOgorICAgICAgICAoV2ViQ29y ZTo6U2NyaXB0T2JqZWN0OjpTY3JpcHRPYmplY3QpOgorCiAyMDEzLTAyLTE4ICBSeW9zdWtlIE5p d2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFdpbmRvd3MgYnVpbGQgZml4LiBBcHBh cmVudGx5IFZpc3VhbCBTdHVkaW8gc3RpbGwgaGFzIGEgbG90IG9mIGJ1Z3Mgd2l0aCByZXNwZWN0 IHRvIG5lc3RlZCBjbGFzc2VzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv anMvU2NyaXB0T2JqZWN0LmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRPYmpl Y3QuaAppbmRleCAyYzFhZTRkMzMzZDRmNWUzNTNlYTY0NjUwOGY0OWJkNGNlOWNhN2U4Li4wOTEz M2I3MGFiNWY5ZTA4MzI1NzZmZGRiYjViNGIxMGRjOTZkYWVhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRPYmplY3QuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9qcy9TY3JpcHRPYmplY3QuaApAQCAtNDUsNyArNDUsNyBAQCBuYW1lc3BhY2UgV2Vi Q29yZSB7CiAgICAgcHVibGljOgogICAgICAgICBTY3JpcHRPYmplY3QoU2NyaXB0U3RhdGUqLCBK U0M6OkpTT2JqZWN0Kik7CiAgICAgICAgIFNjcmlwdE9iamVjdChTY3JpcHRTdGF0ZSosIGNvbnN0 IFNjcmlwdFZhbHVlJik7Ci0gICAgICAgIFNjcmlwdE9iamVjdCgpIHsgfQorICAgICAgICBTY3Jp cHRPYmplY3QoKSA6IG1fc2NyaXB0U3RhdGUoMCkgeyB9CiAgICAgICAgIEpTQzo6SlNPYmplY3Qq IGpzT2JqZWN0KCkgY29uc3QgeyByZXR1cm4gYXNPYmplY3QoanNWYWx1ZSgpKTsgfQogICAgICAg ICBTY3JpcHRTdGF0ZSogc2NyaXB0U3RhdGUoKSBjb25zdCB7IHJldHVybiBtX3NjcmlwdFN0YXRl OyB9CiAK