110169 2013-02-18 17:24:16 -0800 Encapsulate FloatingObject's constructor inside create 2017-07-18 08:29:26 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified REOPENED P2 Normal --- 1 rniwa rniwa benjamin buildbot dglazkov eric hyatt jchaffraix leviw ojan.autocc philn rego+ews rniwa simon.fraser tony webkit.review.bot xan.lopez oldest_to_newest 835850 0 rniwa 2013-02-18 17:24:16 -0800 Encapsulate FloatingObject's constructor inside create 835852 1 188967 rniwa 2013-02-18 17:25:45 -0800 Created attachment 188967 Cleanup 835900 2 188967 darin 2013-02-18 19:18:49 -0800 Comment on attachment 188967 Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=188967&action=review > Source/WebCore/rendering/RenderBlock.cpp:7714 > +void RenderBlock::ensureFloatingObjects() I’m not such a big fan of the naming here. I understand, though, that we’re using the word “ensure” for this in many places in WebKit now. But I have two thoughts: 1) We should find a better name or short phrase for this that is less like jargon if we can. 2) In other places, I think this is only used when the function has a return value. To me this is just createFloatingObjects. The fact that it's smart enough not to recreate it if it already exists seems like a detail that need not be in its name. > Source/WebCore/rendering/RenderBlock.cpp:7717 > + if (!m_floatingObjects) > + m_floatingObjects = FloatingObjects::create(this, isHorizontalWritingMode()); I like early return when we already have it better than nesting like this, but it's just a matter of taste. > Source/WebCore/rendering/RenderBlock.cpp:7720 > +inline PassOwnPtr<RenderBlock::FloatingObjects> RenderBlock::FloatingObjects::create(const RenderBlock* renderer, bool horizontalWritingMode) With older compilers, the inline needs to before the code that uses it. Thus, I suggest reordering these three things in exactly the reverse order they currently appear. 835905 3 rniwa 2013-02-18 19:40:18 -0800 Committed r143289: <http://trac.webkit.org/changeset/143289> 835955 4 rniwa 2013-02-18 22:17:18 -0800 Apparently this patch doesn't work on Windows :( Build fix landed in http://trac.webkit.org/changeset/143293. 835960 5 rniwa 2013-02-18 22:29:17 -0800 Still doesn't work: 6>C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\include\private\wtf/OwnPtrCommon.h(63) : error C2248: 'WebCore::RenderBlock::FloatingObjects' : cannot access protected class declared in class 'WebCore::RenderBlock' 6> c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\RenderBlock.h(1140) : see declaration of 'WebCore::RenderBlock::FloatingObjects' 6> c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\RenderBlock.h(83) : see declaration of 'WebCore::RenderBlock' 6> C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\include\private\wtf/OwnPtr.h(63) : see reference to function template instantiation 'void WTF::deleteOwnedPtr<WebCore::RenderBlock::FloatingObjects>(T *)' being compiled 6> with 6> [ 6> T=WebCore::RenderBlock::FloatingObjects 6> ] 6> C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\include\private\wtf/OwnPtr.h(63) : while compiling class template member function 'WTF::OwnPtr<T>::~OwnPtr(void)' 6> with 6> [ 6> T=WebCore::RenderBlock::FloatingObjects 6> ] 6> c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\RenderBlock.h(1180) : see reference to class template instantiation 'WTF::OwnPtr<T>' being compiled 6> with 6> [ 6> T=WebCore::RenderBlock::FloatingObjects 6> ] 835963 6 rniwa 2013-02-18 22:30:05 -0800 I made the class public: http://trac.webkit.org/changeset/143294 This is why I hate nested classes. They never work. 835999 7 rniwa 2013-02-18 23:11:54 -0800 Reopening to attach new patch. 836000 8 188998 rniwa 2013-02-18 23:11:57 -0800 Created attachment 188998 Cleanup after build fixes 836006 9 188998 webkit-ews 2013-02-18 23:17:16 -0800 Comment on attachment 188998 Cleanup after build fixes Attachment 188998 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/16627369 836007 10 188998 webkit-ews 2013-02-18 23:18:32 -0800 Comment on attachment 188998 Cleanup after build fixes Attachment 188998 did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/16613540 836015 11 188998 webkit.review.bot 2013-02-18 23:24:41 -0800 Comment on attachment 188998 Cleanup after build fixes Attachment 188998 did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16627371 836017 12 188998 webkit.review.bot 2013-02-18 23:26:08 -0800 Comment on attachment 188998 Cleanup after build fixes Attachment 188998 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16627370 836023 13 188998 eflews.bot 2013-02-18 23:29:23 -0800 Comment on attachment 188998 Cleanup after build fixes Attachment 188998 did not pass efl-ews (efl): Output: http://queues.webkit.org/results/16627382 836039 14 188998 buildbot 2013-02-18 23:44:20 -0800 Comment on attachment 188998 Cleanup after build fixes Attachment 188998 did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16612585 836058 15 189009 rniwa 2013-02-19 00:09:36 -0800 Created attachment 189009 Upload the right file 836065 16 189009 webkit-ews 2013-02-19 00:14:30 -0800 Comment on attachment 189009 Upload the right file Attachment 189009 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/16621547 836066 17 189009 webkit-ews 2013-02-19 00:15:01 -0800 Comment on attachment 189009 Upload the right file Attachment 189009 did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/16628344 836068 18 189009 buildbot 2013-02-19 00:18:21 -0800 Comment on attachment 189009 Upload the right file Attachment 189009 did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16608735 836074 19 189009 webkit.review.bot 2013-02-19 00:22:05 -0800 Comment on attachment 189009 Upload the right file Attachment 189009 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16622002 836079 20 189009 webkit.review.bot 2013-02-19 00:26:00 -0800 Comment on attachment 189009 Upload the right file Attachment 189009 did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16632001 836086 21 189009 eflews.bot 2013-02-19 00:35:12 -0800 Comment on attachment 189009 Upload the right file Attachment 189009 did not pass efl-ews (efl): Output: http://queues.webkit.org/results/16620003 836127 22 189024 rniwa 2013-02-19 01:37:39 -0800 Created attachment 189024 Fixed builds 836132 23 189024 webkit-ews 2013-02-19 01:50:38 -0800 Comment on attachment 189024 Fixed builds Attachment 189024 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/16629325 836133 24 189024 webkit-ews 2013-02-19 01:53:37 -0800 Comment on attachment 189024 Fixed builds Attachment 189024 did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/16610700 836139 25 189024 webkit.review.bot 2013-02-19 01:58:34 -0800 Comment on attachment 189024 Fixed builds Attachment 189024 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16627433 836154 26 189024 webkit.review.bot 2013-02-19 02:18:40 -0800 Comment on attachment 189024 Fixed builds Attachment 189024 did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16614661 836170 27 189024 eflews.bot 2013-02-19 02:57:38 -0800 Comment on attachment 189024 Fixed builds Attachment 189024 did not pass efl-ews (efl): Output: http://queues.webkit.org/results/16610717 837407 28 189024 buildbot 2013-02-20 06:17:48 -0800 Comment on attachment 189024 Fixed builds Attachment 189024 did not pass win-ews (win): Output: http://queues.webkit.org/results/16653297 842409 29 189024 benjamin 2013-02-26 15:01:38 -0800 Comment on attachment 189024 Fixed builds View in context: https://bugs.webkit.org/attachment.cgi?id=189024&action=review > Source/WebCore/rendering/RenderBlock.cpp:7752 > +inline PassOwnPtr<RenderBlock::FloatingObjects> RenderBlock::FloatingObjects::create(const RenderBlock* renderer, bool horizontalWritingMode) > +{ > + return adoptPtr(new FloatingObjects(renderer, horizontalWritingMode)); > +} For better encapsulation, remove horizontalWritingMode and do?: return adoptPtr(new FloatingObjects(renderer, renderer->isHorizontalWritingMode())); > Source/WebCore/rendering/RenderBlock.h:1178 > friend void RenderBlock::createFloatingObjects(); You should remove this. > Source/WebCore/rendering/RenderBlock.h:1181 > + friend OwnPtr<FloatingObjects>; > + friend PassOwnPtr<FloatingObjects>; friend class xxx For which scope was this needed? 188967 2013-02-18 17:25:45 -0800 2013-02-18 23:11:51 -0800 Cleanup bug-110169-20130218172207.patch text/plain 5183 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MzI3NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEzLTAyLTE4ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEVuY2Fwc3VsYXRlIEZsb2F0aW5n T2JqZWN0J3MgY29uc3RydWN0b3IgaW5zaWRlIGNyZWF0ZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwMTY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgRmxvYXRpbmdPYmplY3Q6OmNyZWF0ZSBh bmQgbWFkZSBGbG9hdGluZ09iamVjdCdzIGNvbnN0cnVjdG9yIHByaXZhdGUuCisgICAgICAgIEFs c28gYWRkZWQgUmVuZGVyQmxvY2s6OmVuc3VyZUZsb2F0aW5nT2JqZWN0cyB0byBoZWxwIGxhemls eSBjcmVhdGluZyBGbG9hdGluZ09iamVjdHMuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVy QmxvY2suY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6Omluc2VydEZsb2F0aW5n T2JqZWN0KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjphZGRPdmVyaGFuZ2luZ0Zs b2F0cyk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6YWRkSW50cnVkaW5nRmxvYXRz KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjplbnN1cmVGbG9hdGluZ09iamVjdHMp OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6OkZsb2F0aW5nT2JqZWN0czo6Y3JlYXRl KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjpGbG9hdGluZ09iamVjdHM6OkZsb2F0 aW5nT2JqZWN0cyk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2NrLmg6CisgICAgICAg IChGbG9hdGluZ09iamVjdHMpOgorICAgICAgICAoUmVuZGVyQmxvY2spOgorCiAyMDEzLTAyLTE4 ICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgogCiAgICAgICAgIFtDdXJs XSBUaGUgZnVuY3Rpb24gY29va2llc0ZvckRPTSgpIGRvZXMgbm90IGJlaGF2ZSBjb3JyZWN0bHku CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAJKHJldmlzaW9u IDE0MzI3NCkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTM4NDAsNyArMzg0MCw3IEBAIFJlbmRlckJsb2NrOjpGbG9hdGluZ09i amVjdCogUmVuZGVyQmxvY2sKIAogICAgIC8vIENyZWF0ZSB0aGUgbGlzdCBvZiBzcGVjaWFsIG9i amVjdHMgaWYgd2UgZG9uJ3QgYWxlYWR5IGhhdmUgb25lCiAgICAgaWYgKCFtX2Zsb2F0aW5nT2Jq ZWN0cykKLSAgICAgICAgbV9mbG9hdGluZ09iamVjdHMgPSBhZG9wdFB0cihuZXcgRmxvYXRpbmdP YmplY3RzKHRoaXMsIGlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlKCkpKTsKKyAgICAgICAgZW5zdXJl RmxvYXRpbmdPYmplY3RzKCk7CiAgICAgZWxzZSB7CiAgICAgICAgIC8vIERvbid0IGluc2VydCB0 aGUgb2JqZWN0IGFnYWluIGlmIGl0J3MgYWxyZWFkeSBpbiB0aGUgbGlzdAogICAgICAgICBjb25z dCBGbG9hdGluZ09iamVjdFNldCYgZmxvYXRpbmdPYmplY3RTZXQgPSBtX2Zsb2F0aW5nT2JqZWN0 cy0+c2V0KCk7CkBAIC00NjA3LDggKzQ2MDcsNyBAQCBMYXlvdXRVbml0IFJlbmRlckJsb2NrOjph ZGRPdmVyaGFuZ2luZ0ZsCiAKICAgICAgICAgICAgICAgICAvLyBXZSBjcmVhdGUgdGhlIGZsb2F0 aW5nIG9iamVjdCBsaXN0IGxhemlseS4KICAgICAgICAgICAgICAgICBpZiAoIW1fZmxvYXRpbmdP YmplY3RzKQotICAgICAgICAgICAgICAgICAgICBtX2Zsb2F0aW5nT2JqZWN0cyA9IGFkb3B0UHRy KG5ldyBGbG9hdGluZ09iamVjdHModGhpcywgaXNIb3Jpem9udGFsV3JpdGluZ01vZGUoKSkpOwot CisgICAgICAgICAgICAgICAgICAgIGVuc3VyZUZsb2F0aW5nT2JqZWN0cygpOwogICAgICAgICAg ICAgICAgIG1fZmxvYXRpbmdPYmplY3RzLT5hZGQoZmxvYXRpbmdPYmopOwogICAgICAgICAgICAg fQogICAgICAgICB9IGVsc2UgewpAQCAtNDY4MCw3ICs0Njc5LDcgQEAgdm9pZCBSZW5kZXJCbG9j azo6YWRkSW50cnVkaW5nRmxvYXRzKFJlbgogICAgICAgICAgICAgICAgIAogICAgICAgICAgICAg ICAgIC8vIFdlIGNyZWF0ZSB0aGUgZmxvYXRpbmcgb2JqZWN0IGxpc3QgbGF6aWx5LgogICAgICAg ICAgICAgICAgIGlmICghbV9mbG9hdGluZ09iamVjdHMpCi0gICAgICAgICAgICAgICAgICAgIG1f ZmxvYXRpbmdPYmplY3RzID0gYWRvcHRQdHIobmV3IEZsb2F0aW5nT2JqZWN0cyh0aGlzLCBpc0hv cml6b250YWxXcml0aW5nTW9kZSgpKSk7CisgICAgICAgICAgICAgICAgICAgIGVuc3VyZUZsb2F0 aW5nT2JqZWN0cygpOwogICAgICAgICAgICAgICAgIG1fZmxvYXRpbmdPYmplY3RzLT5hZGQoZmxv YXRpbmdPYmopOwogICAgICAgICAgICAgfQogICAgICAgICB9CkBAIC03NzEyLDYgKzc3MTEsMjYg QEAgY29uc3QgY2hhciogUmVuZGVyQmxvY2s6OnJlbmRlck5hbWUoKSBjbwogICAgIHJldHVybiAi UmVuZGVyQmxvY2siOwogfQogCit2b2lkIFJlbmRlckJsb2NrOjplbnN1cmVGbG9hdGluZ09iamVj dHMoKQoreworICAgIGlmICghbV9mbG9hdGluZ09iamVjdHMpCisgICAgICAgIG1fZmxvYXRpbmdP YmplY3RzID0gRmxvYXRpbmdPYmplY3RzOjpjcmVhdGUodGhpcywgaXNIb3Jpem9udGFsV3JpdGlu Z01vZGUoKSk7Cit9CisKK2lubGluZSBQYXNzT3duUHRyPFJlbmRlckJsb2NrOjpGbG9hdGluZ09i amVjdHM+IFJlbmRlckJsb2NrOjpGbG9hdGluZ09iamVjdHM6OmNyZWF0ZShjb25zdCBSZW5kZXJC bG9jayogcmVuZGVyZXIsIGJvb2wgaG9yaXpvbnRhbFdyaXRpbmdNb2RlKQoreworICAgIHJldHVy biBhZG9wdFB0cihuZXcgRmxvYXRpbmdPYmplY3RzKHJlbmRlcmVyLCBob3Jpem9udGFsV3JpdGlu Z01vZGUpKTsKK30KKworaW5saW5lIFJlbmRlckJsb2NrOjpGbG9hdGluZ09iamVjdHM6OkZsb2F0 aW5nT2JqZWN0cyhjb25zdCBSZW5kZXJCbG9jayogcmVuZGVyZXIsIGJvb2wgaG9yaXpvbnRhbFdy aXRpbmdNb2RlKQorICAgIDogbV9wbGFjZWRGbG9hdHNUcmVlKFVuaW5pdGlhbGl6ZWRUcmVlKQor ICAgICwgbV9sZWZ0T2JqZWN0c0NvdW50KDApCisgICAgLCBtX3JpZ2h0T2JqZWN0c0NvdW50KDAp CisgICAgLCBtX2hvcml6b250YWxXcml0aW5nTW9kZShob3Jpem9udGFsV3JpdGluZ01vZGUpCisg ICAgLCBtX3JlbmRlcmVyKHJlbmRlcmVyKQoreworfQorCiBpbmxpbmUgdm9pZCBSZW5kZXJCbG9j azo6RmxvYXRpbmdPYmplY3RzOjpjbGVhcigpCiB7CiAgICAgbV9zZXQuY2xlYXIoKTsKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5oCShyZXZpc2lvbiAxNDMyNzQpCisr KyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suaAkod29ya2luZyBjb3B5KQpA QCAtMTEzOSwxNiArMTEzOSw5IEBAIHByb3RlY3RlZDoKICAgICB9OwogCiAgICAgY2xhc3MgRmxv YXRpbmdPYmplY3RzIHsKKyAgICAgICAgV1RGX01BS0VfTk9OQ09QWUFCTEUoRmxvYXRpbmdPYmpl Y3RzKTsgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQ7CiAgICAgcHVibGljOgotICAgICAgICBGbG9h dGluZ09iamVjdHMoY29uc3QgUmVuZGVyQmxvY2sqIHJlbmRlcmVyLCBib29sIGhvcml6b250YWxX cml0aW5nTW9kZSkKLSAgICAgICAgICAgIDogbV9wbGFjZWRGbG9hdHNUcmVlKFVuaW5pdGlhbGl6 ZWRUcmVlKQotICAgICAgICAgICAgLCBtX2xlZnRPYmplY3RzQ291bnQoMCkKLSAgICAgICAgICAg ICwgbV9yaWdodE9iamVjdHNDb3VudCgwKQotICAgICAgICAgICAgLCBtX2hvcml6b250YWxXcml0 aW5nTW9kZShob3Jpem9udGFsV3JpdGluZ01vZGUpCi0gICAgICAgICAgICAsIG1fcmVuZGVyZXIo cmVuZGVyZXIpCi0gICAgICAgIHsKLSAgICAgICAgfQotCisgICAgICAgIHN0YXRpYyBQYXNzT3du UHRyPEZsb2F0aW5nT2JqZWN0cz4gY3JlYXRlKGNvbnN0IFJlbmRlckJsb2NrKiwgYm9vbCBob3Jp em9udGFsV3JpdGluZ01vZGUpOwogICAgICAgICB2b2lkIGNsZWFyKCk7CiAgICAgICAgIHZvaWQg YWRkKEZsb2F0aW5nT2JqZWN0Kik7CiAgICAgICAgIHZvaWQgcmVtb3ZlKEZsb2F0aW5nT2JqZWN0 Kik7CkBAIC0xMTY1LDYgKzExNTgsNyBAQCBwcm90ZWN0ZWQ6CiAgICAgICAgICAgICByZXR1cm4g bV9wbGFjZWRGbG9hdHNUcmVlOyAKICAgICAgICAgfQogICAgIHByaXZhdGU6CisgICAgICAgIEZs b2F0aW5nT2JqZWN0cyhjb25zdCBSZW5kZXJCbG9jayosIGJvb2wgaG9yaXpvbnRhbFdyaXRpbmdN b2RlKTsKICAgICAgICAgdm9pZCBjb21wdXRlUGxhY2VkRmxvYXRzVHJlZSgpOwogICAgICAgICBp bmxpbmUgdm9pZCBjb21wdXRlUGxhY2VkRmxvYXRzVHJlZUlmTmVlZGVkKCkKICAgICAgICAgewpA QCAtMTE4Miw4ICsxMTc2LDEyIEBAIHByb3RlY3RlZDoKICAgICAgICAgYm9vbCBtX2hvcml6b250 YWxXcml0aW5nTW9kZTsKICAgICAgICAgY29uc3QgUmVuZGVyQmxvY2sqIG1fcmVuZGVyZXI7CiAg ICAgfTsKKwogICAgIE93blB0cjxGbG9hdGluZ09iamVjdHM+IG1fZmxvYXRpbmdPYmplY3RzOwog CisgICAgdm9pZCBlbnN1cmVGbG9hdGluZ09iamVjdHMoKTsKKworCiAgICAgLy8gQWxsb2NhdGVk IG9ubHkgd2hlbiBzb21lIG9mIHRoZXNlIGZpZWxkcyBoYXZlIG5vbi1kZWZhdWx0IHZhbHVlcwog ICAgIHN0cnVjdCBSZW5kZXJCbG9ja1JhcmVEYXRhIHsKICAgICAgICAgV1RGX01BS0VfTk9OQ09Q WUFCTEUoUmVuZGVyQmxvY2tSYXJlRGF0YSk7IFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwo= 188998 2013-02-18 23:11:57 -0800 2013-02-19 00:09:36 -0800 Cleanup after build fixes bug-110169-20130218230820.patch text/plain 2590 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MzI5NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAyLTE4ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEVuY2Fwc3VsYXRlIEZsb2F0aW5n T2JqZWN0J3MgY29uc3RydWN0b3IgaW5zaWRlIGNyZWF0ZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwMTY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT24gbXkgc2Vjb25kIHRob3VnaHQsIHdlIHNob3Vs ZCBiZSBhYmxlIHRvIHdvcmstYXJvdW5kIHRoZSBWaXN1YWwgU3R1ZGlvJ3MgYmVoYXZpb3IKKyAg ICAgICAgYnkgbWFraW5nIE93blB0ciBhbmQgUGFzc093blB0ciBmcmllbmRzIG9mIFJlbmRlckJs b2NrLiBUcnkgdGhhdCBpbnN0ZWFkLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2Nr LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjpGbG9hdGluZ09iamVjdHM6OkZs b2F0aW5nT2JqZWN0cyk6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlckJsb2NrOjpjcmVhdGVGbG9hdGluZ09iamVjdHMpOgorICAgICAgICAqIHJlbmRlcmluZy9S ZW5kZXJCbG9jay5oOgorICAgICAgICAoUmVuZGVyQmxvY2spOgorICAgICAgICAoRmxvYXRpbmdP YmplY3RzKToKKwogMjAxMy0wMi0xOCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxl LmNvbT4KIAogICAgICAgICBDbGVhbiB1cCB0aGUgYm9vbGVhbiBhcmd1bWVudCB0byB2aXNpYmxl Q29udGVudFJlY3QKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNw cAkocmV2aXNpb24gMTQzMjkzKQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJs b2NrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzc0Niw5ICs3NzQ2LDE0IEBAIGlubGluZSBSZW5k ZXJCbG9jazo6RmxvYXRpbmdPYmplY3RzOjpGbG8KIHsKIH0KIAoraW5saW5lIFBhc3NPd25QdHI8 RmxvYXRpbmdPYmplY3RzPiBSZW5kZXJCbG9jazo6RmxvYXRpbmdPYmplY3RzOjpGbG9hdGluZ09i amVjdHMoY29uc3QgUmVuZGVyQmxvY2sqIHJlbmRlcmVyLCBib29sIGhvcml6b250YWxXcml0aW5n TW9kZSkKK3sKKyAgICByZXR1cm4gYWRvcHRQdHIobmV3IEZsb2F0aW5nT2JqZWN0cyhyZW5kZXJl ciwgaG9yaXpvbnRhbFdyaXRpbmdNb2RlKSk7Cit9CisKIHZvaWQgUmVuZGVyQmxvY2s6OmNyZWF0 ZUZsb2F0aW5nT2JqZWN0cygpCiB7Ci0gICAgbV9mbG9hdGluZ09iamVjdHMgPSBhZG9wdFB0cihu ZXcgRmxvYXRpbmdPYmplY3RzKHRoaXMsIGlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlKCkpKTsKKyAg ICBtX2Zsb2F0aW5nT2JqZWN0cyA9IEZsb2F0aW5nT2JqZWN0czo6Y3JlYXRlKHRoaXMsIGlzSG9y aXpvbnRhbFdyaXRpbmdNb2RlKCkpKTsKIH0KIAogaW5saW5lIHZvaWQgUmVuZGVyQmxvY2s6OkZs b2F0aW5nT2JqZWN0czo6Y2xlYXIoKQpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckJsb2NrLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckJsb2NrLmgJKHJldmlzaW9uIDE0MzI5NCkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJCbG9jay5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMTM3LDExICsxMTM3LDEwIEBAIHByb3Rl Y3RlZDoKIAogICAgIHZvaWQgY3JlYXRlRmxvYXRpbmdPYmplY3RzKCk7CiAKLXB1YmxpYzoKLQog ICAgIGNsYXNzIEZsb2F0aW5nT2JqZWN0cyB7CiAgICAgICAgIFdURl9NQUtFX05PTkNPUFlBQkxF KEZsb2F0aW5nT2JqZWN0cyk7IFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogICAgIHB1YmxpYzoK KyAgICAgICAgc3RhdGljIGNyZWF0ZSgpOwogICAgICAgICB2b2lkIGNsZWFyKCk7CiAgICAgICAg IHZvaWQgYWRkKEZsb2F0aW5nT2JqZWN0Kik7CiAgICAgICAgIHZvaWQgcmVtb3ZlKEZsb2F0aW5n T2JqZWN0Kik7CkBAIC0xMTc4LDggKzExNzcsOCBAQCBwdWJsaWM6CiAKICAgICAgICAgZnJpZW5k IHZvaWQgUmVuZGVyQmxvY2s6OmNyZWF0ZUZsb2F0aW5nT2JqZWN0cygpOwogICAgIH07Ci0KLXBy b3RlY3RlZDoKKyAgICBmcmllbmQgT3duUHRyPEZsb2F0aW5nT2JqZWN0cz47CisgICAgZnJpZW5k IFBhc3NPd25QdHI8RmxvYXRpbmdPYmplY3RzPjsKIAogICAgIE93blB0cjxGbG9hdGluZ09iamVj dHM+IG1fZmxvYXRpbmdPYmplY3RzOwogCg== 189009 2013-02-19 00:09:36 -0800 2013-02-19 01:37:34 -0800 Upload the right file fix110169c text/plain 2653 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MzI5NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAyLTE4ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEVuY2Fwc3VsYXRlIEZsb2F0aW5n T2JqZWN0J3MgY29uc3RydWN0b3IgaW5zaWRlIGNyZWF0ZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwMTY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT24gbXkgc2Vjb25kIHRob3VnaHQsIHdlIHNob3Vs ZCBiZSBhYmxlIHRvIHdvcmstYXJvdW5kIHRoZSBWaXN1YWwgU3R1ZGlvJ3MgYmVoYXZpb3IKKyAg ICAgICAgYnkgbWFraW5nIE93blB0ciBhbmQgUGFzc093blB0ciBmcmllbmRzIG9mIFJlbmRlckJs b2NrLiBUcnkgdGhhdCBpbnN0ZWFkLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2Nr LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjpGbG9hdGluZ09iamVjdHM6OkZs b2F0aW5nT2JqZWN0cyk6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlckJsb2NrOjpjcmVhdGVGbG9hdGluZ09iamVjdHMpOgorICAgICAgICAqIHJlbmRlcmluZy9S ZW5kZXJCbG9jay5oOgorICAgICAgICAoUmVuZGVyQmxvY2spOgorICAgICAgICAoRmxvYXRpbmdP YmplY3RzKToKKwogMjAxMy0wMi0xOCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxl LmNvbT4KIAogICAgICAgICBDbGVhbiB1cCB0aGUgYm9vbGVhbiBhcmd1bWVudCB0byB2aXNpYmxl Q29udGVudFJlY3QKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNw cAkocmV2aXNpb24gMTQzMjkzKQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJs b2NrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzc0Niw5ICs3NzQ2LDE0IEBAIGlubGluZSBSZW5k ZXJCbG9jazo6RmxvYXRpbmdPYmplY3RzOjpGbG8KIHsKIH0KIAoraW5saW5lIFBhc3NPd25QdHI8 RmxvYXRpbmdPYmplY3RzPiBSZW5kZXJCbG9jazo6RmxvYXRpbmdPYmplY3RzOjpjcmVhdGUoY29u c3QgUmVuZGVyQmxvY2sqIHJlbmRlcmVyLCBib29sIGhvcml6b250YWxXcml0aW5nTW9kZSkKK3sK KyAgICByZXR1cm4gYWRvcHRQdHIobmV3IEZsb2F0aW5nT2JqZWN0cyhyZW5kZXJlciwgaG9yaXpv bnRhbFdyaXRpbmdNb2RlKSk7Cit9CisKIHZvaWQgUmVuZGVyQmxvY2s6OmNyZWF0ZUZsb2F0aW5n T2JqZWN0cygpCiB7Ci0gICAgbV9mbG9hdGluZ09iamVjdHMgPSBhZG9wdFB0cihuZXcgRmxvYXRp bmdPYmplY3RzKHRoaXMsIGlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlKCkpKTsKKyAgICBtX2Zsb2F0 aW5nT2JqZWN0cyA9IEZsb2F0aW5nT2JqZWN0czo6Y3JlYXRlKHRoaXMsIGlzSG9yaXpvbnRhbFdy aXRpbmdNb2RlKCkpKTsKIH0KIAogaW5saW5lIHZvaWQgUmVuZGVyQmxvY2s6OkZsb2F0aW5nT2Jq ZWN0czo6Y2xlYXIoKQpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2Nr LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmgJ KHJldmlzaW9uIDE0MzI5NCkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9j ay5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMTM3LDExICsxMTM3LDEwIEBAIHByb3RlY3RlZDoKIAog ICAgIHZvaWQgY3JlYXRlRmxvYXRpbmdPYmplY3RzKCk7CiAKLXB1YmxpYzoKLQogICAgIGNsYXNz IEZsb2F0aW5nT2JqZWN0cyB7CiAgICAgICAgIFdURl9NQUtFX05PTkNPUFlBQkxFKEZsb2F0aW5n T2JqZWN0cyk7IFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogICAgIHB1YmxpYzoKKyAgICAgICAg c3RhdGljIFBhc3NPd25QdHI8RmxvYXRpbmdPYmplY3RzPiBjcmVhdGUoY29uc3QgUmVuZGVyQmxv Y2sqLCBib29sIGhvcml6b250YWxXcml0aW5nTW9kZSk7CiAgICAgICAgIHZvaWQgY2xlYXIoKTsK ICAgICAgICAgdm9pZCBhZGQoRmxvYXRpbmdPYmplY3QqKTsKICAgICAgICAgdm9pZCByZW1vdmUo RmxvYXRpbmdPYmplY3QqKTsKQEAgLTExNzgsOCArMTE3Nyw4IEBAIHB1YmxpYzoKIAogICAgICAg ICBmcmllbmQgdm9pZCBSZW5kZXJCbG9jazo6Y3JlYXRlRmxvYXRpbmdPYmplY3RzKCk7CiAgICAg fTsKLQotcHJvdGVjdGVkOgorICAgIGZyaWVuZCBPd25QdHI8RmxvYXRpbmdPYmplY3RzPjsKKyAg ICBmcmllbmQgUGFzc093blB0cjxGbG9hdGluZ09iamVjdHM+OwogCiAgICAgT3duUHRyPEZsb2F0 aW5nT2JqZWN0cz4gbV9mbG9hdGluZ09iamVjdHM7Cg== 189024 2013-02-19 01:37:39 -0800 2013-02-26 15:01:37 -0800 Fixed builds bug-110169-20130219013401.patch text/plain 2649 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MzMwOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAyLTE5ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEVuY2Fwc3VsYXRlIEZsb2F0aW5n T2JqZWN0J3MgY29uc3RydWN0b3IgaW5zaWRlIGNyZWF0ZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwMTY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT24gbXkgc2Vjb25kIHRob3VnaHQsIHdlIHNob3Vs ZCBiZSBhYmxlIHRvIHdvcmstYXJvdW5kIHRoZSBWaXN1YWwgU3R1ZGlvJ3MgYmVoYXZpb3IKKyAg ICAgICAgYnkgbWFraW5nIE93blB0ciBhbmQgUGFzc093blB0ciBmcmllbmRzIG9mIFJlbmRlckJs b2NrLiBUcnkgdGhhdCBpbnN0ZWFkLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2Nr LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjpGbG9hdGluZ09iamVjdHM6OkZs b2F0aW5nT2JqZWN0cyk6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlckJsb2NrOjpjcmVhdGVGbG9hdGluZ09iamVjdHMpOgorICAgICAgICAqIHJlbmRlcmluZy9S ZW5kZXJCbG9jay5oOgorICAgICAgICAoUmVuZGVyQmxvY2spOgorICAgICAgICAoRmxvYXRpbmdP YmplY3RzKToKKwogMjAxMy0wMi0xOSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4K IAogICAgICAgICBZZXQgYW50aGVyIEpTQyBidWlsZCBmaXggYWZ0ZXIgcjE0MzMwNC4KSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAkocmV2aXNpb24gMTQzMzA0 KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAkod29ya2luZyBj b3B5KQpAQCAtNzc0Niw5ICs3NzQ2LDE0IEBAIGlubGluZSBSZW5kZXJCbG9jazo6RmxvYXRpbmdP YmplY3RzOjpGbG8KIHsKIH0KIAoraW5saW5lIFBhc3NPd25QdHI8UmVuZGVyQmxvY2s6OkZsb2F0 aW5nT2JqZWN0cz4gUmVuZGVyQmxvY2s6OkZsb2F0aW5nT2JqZWN0czo6Y3JlYXRlKGNvbnN0IFJl bmRlckJsb2NrKiByZW5kZXJlciwgYm9vbCBob3Jpem9udGFsV3JpdGluZ01vZGUpCit7CisgICAg cmV0dXJuIGFkb3B0UHRyKG5ldyBGbG9hdGluZ09iamVjdHMocmVuZGVyZXIsIGhvcml6b250YWxX cml0aW5nTW9kZSkpOworfQorCiB2b2lkIFJlbmRlckJsb2NrOjpjcmVhdGVGbG9hdGluZ09iamVj dHMoKQogewotICAgIG1fZmxvYXRpbmdPYmplY3RzID0gYWRvcHRQdHIobmV3IEZsb2F0aW5nT2Jq ZWN0cyh0aGlzLCBpc0hvcml6b250YWxXcml0aW5nTW9kZSgpKSk7CisgICAgbV9mbG9hdGluZ09i amVjdHMgPSBGbG9hdGluZ09iamVjdHM6OmNyZWF0ZSh0aGlzLCBpc0hvcml6b250YWxXcml0aW5n TW9kZSgpKTsKIH0KIAogaW5saW5lIHZvaWQgUmVuZGVyQmxvY2s6OkZsb2F0aW5nT2JqZWN0czo6 Y2xlYXIoKQpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmgJKHJldmlz aW9uIDE0MzMwNCkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5oCSh3 b3JraW5nIGNvcHkpCkBAIC0xMTM3LDExICsxMTM3LDEwIEBAIHByb3RlY3RlZDoKIAogICAgIHZv aWQgY3JlYXRlRmxvYXRpbmdPYmplY3RzKCk7CiAKLXB1YmxpYzoKLQogICAgIGNsYXNzIEZsb2F0 aW5nT2JqZWN0cyB7CiAgICAgICAgIFdURl9NQUtFX05PTkNPUFlBQkxFKEZsb2F0aW5nT2JqZWN0 cyk7IFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogICAgIHB1YmxpYzoKKyAgICAgICAgc3RhdGlj IFBhc3NPd25QdHI8RmxvYXRpbmdPYmplY3RzPiBjcmVhdGUoY29uc3QgUmVuZGVyQmxvY2sqLCBi b29sIGhvcml6b250YWxXcml0aW5nTW9kZSk7CiAgICAgICAgIHZvaWQgY2xlYXIoKTsKICAgICAg ICAgdm9pZCBhZGQoRmxvYXRpbmdPYmplY3QqKTsKICAgICAgICAgdm9pZCByZW1vdmUoRmxvYXRp bmdPYmplY3QqKTsKQEAgLTExNzgsOCArMTE3Nyw4IEBAIHB1YmxpYzoKIAogICAgICAgICBmcmll bmQgdm9pZCBSZW5kZXJCbG9jazo6Y3JlYXRlRmxvYXRpbmdPYmplY3RzKCk7CiAgICAgfTsKLQot cHJvdGVjdGVkOgorICAgIGZyaWVuZCBPd25QdHI8RmxvYXRpbmdPYmplY3RzPjsKKyAgICBmcmll bmQgUGFzc093blB0cjxGbG9hdGluZ09iamVjdHM+OwogCiAgICAgT3duUHRyPEZsb2F0aW5nT2Jq ZWN0cz4gbV9mbG9hdGluZ09iamVjdHM7CiAK