110168 2013-02-18 17:01:56 -0800 Begin stubbing out session storage classes 2013-02-18 17:24:25 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca levin+threading webkit.review.bot oldest_to_newest 835837 0 andersca 2013-02-18 17:01:56 -0800 Begin stubbing out session storage classes 835838 1 188964 andersca 2013-02-18 17:02:56 -0800 Created attachment 188964 Patch 835842 2 188964 kling 2013-02-18 17:11:10 -0800 Comment on attachment 188964 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188964&action=review LGTM > Source/WebKit2/UIProcess/Storage/StorageManager.cpp:72 > + HashMap<RefPtr<SecurityOrigin>, RefPtr<StorageArea>, SecurityOriginHash> m_storageAreaMap; Can we make a global DefaultHash<RefPtr<SecurityOrigin> > that pulls in SecurityOriginHash? That could clean up a number of usage sites. Not necessary for this patch. 835851 3 andersca 2013-02-18 17:24:25 -0800 Committed r143277: <http://trac.webkit.org/changeset/143277> 188964 2013-02-18 17:02:56 -0800 2013-02-18 17:11:10 -0800 Patch bug-110168-20130218165918.patch text/plain 5650 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzMjczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOGZkZGU0ZGFiMTdmNDQz OWIyMmYzNjI5ZDYyMzZiOTEzNTRjZGM2NS4uY2FmNmU1ZDE2MzcxMzE2OTI2ZDE4MjU5N2E2NmEx Mzk5N2M3MTc1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMwIEBACiAyMDEzLTAyLTE4ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgQmVnaW4gc3R1YmJp bmcgb3V0IHNlc3Npb24gc3RvcmFnZSBjbGFzc2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTAxNjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9TdG9yYWdlL1N0b3JhZ2VNYW5hZ2Vy LmNwcDoKKyAgICAgICAgKFN0b3JhZ2VNYW5hZ2VyOjpTdG9yYWdlQXJlYSk6CisgICAgICAgIChX ZWJLaXQpOgorICAgICAgICAoV2ViS2l0OjpTdG9yYWdlTWFuYWdlcjo6U3RvcmFnZUFyZWE6OmNy ZWF0ZSk6CisgICAgICAgIChXZWJLaXQ6OlN0b3JhZ2VNYW5hZ2VyOjpTdG9yYWdlQXJlYTo6U3Rv cmFnZUFyZWEpOgorICAgICAgICAoV2ViS2l0OjpTdG9yYWdlTWFuYWdlcjo6U3RvcmFnZUFyZWE6 On5TdG9yYWdlQXJlYSk6CisgICAgICAgIChTdG9yYWdlTWFuYWdlcjo6U2Vzc2lvblN0b3JhZ2VO YW1lc3BhY2UpOgorICAgICAgICAoV2ViS2l0OjpTdG9yYWdlTWFuYWdlcjo6U2Vzc2lvblN0b3Jh Z2VOYW1lc3BhY2U6OmlzRW1wdHkpOgorICAgICAgICAoV2ViS2l0OjpTdG9yYWdlTWFuYWdlcjo6 U2Vzc2lvblN0b3JhZ2VOYW1lc3BhY2U6OmNyZWF0ZSk6CisgICAgICAgIChXZWJLaXQ6OlN0b3Jh Z2VNYW5hZ2VyOjpTZXNzaW9uU3RvcmFnZU5hbWVzcGFjZTo6U2Vzc2lvblN0b3JhZ2VOYW1lc3Bh Y2UpOgorICAgICAgICAoV2ViS2l0OjpTdG9yYWdlTWFuYWdlcjo6U2Vzc2lvblN0b3JhZ2VOYW1l c3BhY2U6On5TZXNzaW9uU3RvcmFnZU5hbWVzcGFjZSk6CisgICAgICAgIChXZWJLaXQ6OlN0b3Jh Z2VNYW5hZ2VyOjpTZXNzaW9uU3RvcmFnZU5hbWVzcGFjZTo6Y2xvbmVUbyk6CisgICAgICAgIChX ZWJLaXQ6OlN0b3JhZ2VNYW5hZ2VyOjpjcmVhdGVTZXNzaW9uU3RvcmFnZU5hbWVzcGFjZUludGVy bmFsKToKKyAgICAgICAgKFdlYktpdDo6U3RvcmFnZU1hbmFnZXI6OmRlc3Ryb3lTZXNzaW9uU3Rv cmFnZU5hbWVzcGFjZUludGVybmFsKToKKyAgICAgICAgKFdlYktpdDo6U3RvcmFnZU1hbmFnZXI6 OmNsb25lU2Vzc2lvblN0b3JhZ2VOYW1lc3BhY2VJbnRlcm5hbCk6CisgICAgICAgICogVUlQcm9j ZXNzL1N0b3JhZ2UvU3RvcmFnZU1hbmFnZXIuaDoKKyAgICAgICAgKFN0b3JhZ2VNYW5hZ2VyKToK KworMjAxMy0wMi0xOCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCiAg ICAgICAgIEFkZCBTdG9yYWdlTWFuYWdlciBtZW1iZXIgZnVuY3Rpb25zIGZvciBrZWVwaW5nIHRy YWNrIG9mIHNlc3Npb24gc3RvcmFnZSBuYW1lc3BhY2VzCiAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTAxNjMKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL1N0b3JhZ2UvU3RvcmFnZU1hbmFnZXIuY3BwIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL1N0b3JhZ2UvU3RvcmFnZU1hbmFnZXIuY3BwCmluZGV4IDBlNzNmOWYwMDE4 NjdmMmUxYzM3Y2M0YjgzYjAxYTQzMmI2YjYxYmEuLjRiMjE5NWI5MDY5NWExYjZjYjI0MzY4Y2Nh OWE0MDhhM2EwYmJlYjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9TdG9y YWdlL1N0b3JhZ2VNYW5hZ2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvU3Rv cmFnZS9TdG9yYWdlTWFuYWdlci5jcHAKQEAgLTI5LDkgKzI5LDY5IEBACiAjaW5jbHVkZSAiU3Rv cmFnZU1hbmFnZXJNZXNzYWdlcy5oIgogI2luY2x1ZGUgIldlYlByb2Nlc3NQcm94eS5oIgogI2lu Y2x1ZGUgIldvcmtRdWV1ZS5oIgorI2luY2x1ZGUgPFdlYkNvcmUvU2VjdXJpdHlPcmlnaW5IYXNo Lmg+CisKK3VzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAor Y2xhc3MgU3RvcmFnZU1hbmFnZXI6OlN0b3JhZ2VBcmVhIDogcHVibGljIFRocmVhZFNhZmVSZWZD b3VudGVkPFN0b3JhZ2VNYW5hZ2VyOjpTdG9yYWdlQXJlYT4geworcHVibGljOgorICAgIHN0YXRp YyBQYXNzUmVmUHRyPFN0b3JhZ2VBcmVhPiBjcmVhdGUoKTsKKyAgICB+U3RvcmFnZUFyZWEoKTsK KworcHJpdmF0ZToKKyAgICBTdG9yYWdlQXJlYSgpOworfTsKKworUGFzc1JlZlB0cjxTdG9yYWdl TWFuYWdlcjo6U3RvcmFnZUFyZWE+IFN0b3JhZ2VNYW5hZ2VyOjpTdG9yYWdlQXJlYTo6Y3JlYXRl KCkKK3sKKyAgICByZXR1cm4gYWRvcHRSZWYobmV3IFN0b3JhZ2VBcmVhKCkpOworfQorCitTdG9y YWdlTWFuYWdlcjo6U3RvcmFnZUFyZWE6OlN0b3JhZ2VBcmVhKCkKK3sKK30KKworU3RvcmFnZU1h bmFnZXI6OlN0b3JhZ2VBcmVhOjp+U3RvcmFnZUFyZWEoKQoreworfQorCitjbGFzcyBTdG9yYWdl TWFuYWdlcjo6U2Vzc2lvblN0b3JhZ2VOYW1lc3BhY2UgOiBwdWJsaWMgVGhyZWFkU2FmZVJlZkNv dW50ZWQ8U2Vzc2lvblN0b3JhZ2VOYW1lc3BhY2U+IHsKK3B1YmxpYzoKKyAgICBzdGF0aWMgUGFz c1JlZlB0cjxTZXNzaW9uU3RvcmFnZU5hbWVzcGFjZT4gY3JlYXRlKCk7CisgICAgflNlc3Npb25T dG9yYWdlTmFtZXNwYWNlKCk7CisKKyAgICBib29sIGlzRW1wdHkoKSBjb25zdCB7IHJldHVybiBt X3N0b3JhZ2VBcmVhTWFwLmlzRW1wdHkoKTsgfQorCisgICAgdm9pZCBjbG9uZVRvKFNlc3Npb25T dG9yYWdlTmFtZXNwYWNlJiBuZXdTZXNzaW9uU3RvcmFnZU5hbWVzcGFjZSk7CisKK3ByaXZhdGU6 CisgICAgU2Vzc2lvblN0b3JhZ2VOYW1lc3BhY2UoKTsKKworICAgIEhhc2hNYXA8UmVmUHRyPFNl Y3VyaXR5T3JpZ2luPiwgUmVmUHRyPFN0b3JhZ2VBcmVhPiwgU2VjdXJpdHlPcmlnaW5IYXNoPiBt X3N0b3JhZ2VBcmVhTWFwOworfTsKKworUGFzc1JlZlB0cjxTdG9yYWdlTWFuYWdlcjo6U2Vzc2lv blN0b3JhZ2VOYW1lc3BhY2U+IFN0b3JhZ2VNYW5hZ2VyOjpTZXNzaW9uU3RvcmFnZU5hbWVzcGFj ZTo6Y3JlYXRlKCkKK3sKKyAgICByZXR1cm4gYWRvcHRSZWYobmV3IFNlc3Npb25TdG9yYWdlTmFt ZXNwYWNlKCkpOworfQorCitTdG9yYWdlTWFuYWdlcjo6U2Vzc2lvblN0b3JhZ2VOYW1lc3BhY2U6 OlNlc3Npb25TdG9yYWdlTmFtZXNwYWNlKCkKK3sKK30KKworU3RvcmFnZU1hbmFnZXI6OlNlc3Np b25TdG9yYWdlTmFtZXNwYWNlOjp+U2Vzc2lvblN0b3JhZ2VOYW1lc3BhY2UoKQoreworfQorCit2 b2lkIFN0b3JhZ2VNYW5hZ2VyOjpTZXNzaW9uU3RvcmFnZU5hbWVzcGFjZTo6Y2xvbmVUbyhTZXNz aW9uU3RvcmFnZU5hbWVzcGFjZSYgbmV3U2Vzc2lvblN0b3JhZ2VOYW1lc3BhY2UpCit7CisgICAg QVNTRVJUKG5ld1Nlc3Npb25TdG9yYWdlTmFtZXNwYWNlLmlzRW1wdHkoKSk7CisKKyAgICAvLyBG SVhNRTogSW1wbGVtZW50LgorfQorCiBQYXNzUmVmUHRyPFN0b3JhZ2VNYW5hZ2VyPiBTdG9yYWdl TWFuYWdlcjo6Y3JlYXRlKCkKIHsKICAgICByZXR1cm4gYWRvcHRSZWYobmV3IFN0b3JhZ2VNYW5h Z2VyKTsKQEAgLTg4LDE3ICsxNDgsMjcgQEAgdm9pZCBTdG9yYWdlTWFuYWdlcjo6Z2V0VmFsdWVz KENvcmVJUEM6OkNvbm5lY3Rpb24qLCB1aW50NjRfdCwgSGFzaE1hcDxTdHJpbmcsIFMKIAogdm9p ZCBTdG9yYWdlTWFuYWdlcjo6Y3JlYXRlU2Vzc2lvblN0b3JhZ2VOYW1lc3BhY2VJbnRlcm5hbCh1 aW50NjRfdCBzdG9yYWdlTmFtZXNwYWNlSUQpCiB7Ci0gICAgLy8gRklYTUU6IEltcGxlbWVudC4K KyAgICBBU1NFUlQoIW1fc2Vzc2lvblN0b3JhZ2VOYW1lc3BhY2VzLmNvbnRhaW5zKHN0b3JhZ2VO YW1lc3BhY2VJRCkpOworCisgICAgbV9zZXNzaW9uU3RvcmFnZU5hbWVzcGFjZXMuc2V0KHN0b3Jh Z2VOYW1lc3BhY2VJRCwgU2Vzc2lvblN0b3JhZ2VOYW1lc3BhY2U6OmNyZWF0ZSgpKTsKIH0KIAog dm9pZCBTdG9yYWdlTWFuYWdlcjo6ZGVzdHJveVNlc3Npb25TdG9yYWdlTmFtZXNwYWNlSW50ZXJu YWwodWludDY0X3Qgc3RvcmFnZU5hbWVzcGFjZUlEKQogewotICAgIC8vIEZJWE1FOiBJbXBsZW1l bnQuCisgICAgQVNTRVJUKG1fc2Vzc2lvblN0b3JhZ2VOYW1lc3BhY2VzLmNvbnRhaW5zKHN0b3Jh Z2VOYW1lc3BhY2VJRCkpOworCisgICAgbV9zZXNzaW9uU3RvcmFnZU5hbWVzcGFjZXMucmVtb3Zl KHN0b3JhZ2VOYW1lc3BhY2VJRCk7CiB9CiAKIHZvaWQgU3RvcmFnZU1hbmFnZXI6OmNsb25lU2Vz c2lvblN0b3JhZ2VOYW1lc3BhY2VJbnRlcm5hbCh1aW50NjRfdCBzdG9yYWdlTmFtZXNwYWNlSUQs IHVpbnQ2NF90IG5ld1N0b3JhZ2VOYW1lc3BhY2VJRCkKIHsKLSAgICAvLyBGSVhNRTogSW1wbGVt ZW50LgorICAgIFNlc3Npb25TdG9yYWdlTmFtZXNwYWNlKiBzZXNzaW9uU3RvcmFnZU5hbWVzcGFj ZSA9IG1fc2Vzc2lvblN0b3JhZ2VOYW1lc3BhY2VzLmdldChzdG9yYWdlTmFtZXNwYWNlSUQpLmdl dCgpOworICAgIEFTU0VSVChzZXNzaW9uU3RvcmFnZU5hbWVzcGFjZSk7CisKKyAgICBTZXNzaW9u U3RvcmFnZU5hbWVzcGFjZSogbmV3U2Vzc2lvblN0b3JhZ2VOYW1lc3BhY2UgPSBtX3Nlc3Npb25T dG9yYWdlTmFtZXNwYWNlcy5nZXQobmV3U3RvcmFnZU5hbWVzcGFjZUlEKS5nZXQoKTsKKyAgICBB U1NFUlQobmV3U2Vzc2lvblN0b3JhZ2VOYW1lc3BhY2UpOworCisgICAgc2Vzc2lvblN0b3JhZ2VO YW1lc3BhY2UtPmNsb25lVG8oKm5ld1Nlc3Npb25TdG9yYWdlTmFtZXNwYWNlKTsKIH0KIAogfSAv LyBuYW1lc3BhY2UgV2ViS2l0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv U3RvcmFnZS9TdG9yYWdlTWFuYWdlci5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1N0b3Jh Z2UvU3RvcmFnZU1hbmFnZXIuaAppbmRleCBiNDczNzgxNmVmZmM1YzAzZjJkYjZkZWI1ZmU2YTdh MjhiMDcwZGE5Li41NDBlZTgzODhkNTQ1ZGJhYjA3YmNjZWNkODVhODEyZDBjODk1ZGQ5IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvU3RvcmFnZS9TdG9yYWdlTWFuYWdlci5o CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9TdG9yYWdlL1N0b3JhZ2VNYW5hZ2VyLmgK QEAgLTY3LDYgKzY3LDExIEBAIHByaXZhdGU6CiAgICAgdm9pZCBjbG9uZVNlc3Npb25TdG9yYWdl TmFtZXNwYWNlSW50ZXJuYWwodWludDY0X3Qgc3RvcmFnZU5hbWVzcGFjZUlELCB1aW50NjRfdCBu ZXdTdG9yYWdlTmFtZXNwYWNlSUQpOwogCiAgICAgUmVmUHRyPFdvcmtRdWV1ZT4gbV9xdWV1ZTsK KworICAgIGNsYXNzIFNlc3Npb25TdG9yYWdlTmFtZXNwYWNlOworICAgIEhhc2hNYXA8dWludDY0 X3QsIFJlZlB0cjxTZXNzaW9uU3RvcmFnZU5hbWVzcGFjZT4gPiBtX3Nlc3Npb25TdG9yYWdlTmFt ZXNwYWNlczsKKworICAgIGNsYXNzIFN0b3JhZ2VBcmVhOwogfTsKIAogfSAvLyBuYW1lc3BhY2Ug V2ViS2l0Cg==