110162 2013-02-18 15:51:53 -0800 DFG backend Branch handling has duplicate code and dead code 2013-02-18 17:16:58 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 835806 0 fpizlo 2013-02-18 15:51:53 -0800 Patch forthcoming. 835819 1 188959 fpizlo 2013-02-18 16:23:31 -0800 Created attachment 188959 the patch 835823 2 188959 mhahnenberg 2013-02-18 16:27:50 -0800 Comment on attachment 188959 the patch r=me 835847 3 fpizlo 2013-02-18 17:16:58 -0800 Landed in http://trac.webkit.org/changeset/143276 188959 2013-02-18 16:23:31 -0800 2013-02-18 16:27:50 -0800 the patch blah.patch text/plain 4272 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQzMjc0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDEzLTAyLTE4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHIGJhY2tlbmQgQnJhbmNoIGhhbmRsaW5nIGhhcyBkdXBsaWNhdGUgY29kZSBhbmQgZGVhZCBj b2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTAx NjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAg ICAgIFN0cmVhbWxpbmUgdGhlIGNvZGUsIGFuZCBtYWtlIHRoZSA2NCBiYWNrZW5kJ3Mgb3B0aW1p emF0aW9ucyBtYWtlIG1vcmUgc2Vuc2UKKyAgICAgICAgKGkuZS4gbm90IGJlIGRlYWQgY29kZSku CisKKyAgICAgICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHA6CisgICAgICAgIChK U0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGUpOgorICAgICAgICAqIGRmZy9ERkdTcGVj dWxhdGl2ZUpJVDY0LmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpTcGVjdWxhdGl2ZUpJVDo6ZW1p dEJyYW5jaCk6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGUpOgor CiAyMDEzLTAyLTE4ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1Ad2Via2l0Lm9yZz4KIAogICAg ICAgICBbV2luZG93c10gVW5yZXZpZXdlZCBWUzIwMTAgYnVpbGQgY29ycmVjdGlvbiBhZnRlciBy MTQzMjczLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJ VDMyXzY0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1Nw ZWN1bGF0aXZlSklUMzJfNjQuY3BwCShyZXZpc2lvbiAxNDMyNzEpCisrKyBTb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUMzJfNjQuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0zMTYxLDI3ICszMTYxLDYgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZShOb2RlKiBu b2RlKQogICAgIH0KIAogICAgIGNhc2UgQnJhbmNoOgotICAgICAgICBpZiAobm9kZS0+Y2hpbGQx KCktPnNob3VsZFNwZWN1bGF0ZUludGVnZXIoKSkgewotICAgICAgICAgICAgU3BlY3VsYXRlSW50 ZWdlck9wZXJhbmQgb3AodGhpcywgbm9kZS0+Y2hpbGQxKCkpOwotICAgICAgICAgICAgCi0gICAg ICAgICAgICBCbG9ja0luZGV4IHRha2VuID0gbm9kZS0+dGFrZW5CbG9ja0luZGV4KCk7Ci0gICAg ICAgICAgICBCbG9ja0luZGV4IG5vdFRha2VuID0gbm9kZS0+bm90VGFrZW5CbG9ja0luZGV4KCk7 Ci0gICAgICAgICAgICAKLSAgICAgICAgICAgIE1hY3JvQXNzZW1ibGVyOjpSZXN1bHRDb25kaXRp b24gY29uZGl0aW9uID0gTWFjcm9Bc3NlbWJsZXI6Ok5vblplcm87Ci0gICAgICAgICAgICAKLSAg ICAgICAgICAgIGlmICh0YWtlbiA9PSBuZXh0QmxvY2soKSkgewotICAgICAgICAgICAgICAgIGNv bmRpdGlvbiA9IE1hY3JvQXNzZW1ibGVyOjpaZXJvOwotICAgICAgICAgICAgICAgIEJsb2NrSW5k ZXggdG1wID0gdGFrZW47Ci0gICAgICAgICAgICAgICAgdGFrZW4gPSBub3RUYWtlbjsKLSAgICAg ICAgICAgICAgICBub3RUYWtlbiA9IHRtcDsKLSAgICAgICAgICAgIH0KLSAgICAgICAgICAgIAot ICAgICAgICAgICAgYnJhbmNoVGVzdDMyKGNvbmRpdGlvbiwgb3AuZ3ByKCksIHRha2VuKTsKLSAg ICAgICAgICAgIGp1bXAobm90VGFrZW4pOwotICAgICAgICAgICAgCi0gICAgICAgICAgICBub1Jl c3VsdChub2RlKTsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICB9CiAgICAgICAgIGVtaXRC cmFuY2gobm9kZSk7CiAgICAgICAgIGJyZWFrOwogCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv cmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUNjQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQ2NC5jcHAJKHJldmlzaW9uIDE0MzI3MSkK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQ2NC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTE4NjYsMTAgKzE4NjYsMTIgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6 ZW1pdEJyYW5jaChOb2RlKiBubwogICAgICAgICBHUFJUZW1wb3JhcnkgcmVzdWx0KHRoaXMpOwog ICAgICAgICBHUFJSZWcgcmVzdWx0R1BSID0gcmVzdWx0LmdwcigpOwogICAgICAgICAKLSAgICAg ICAgYnJhbmNoNjQoTWFjcm9Bc3NlbWJsZXI6OkVxdWFsLCB2YWx1ZUdQUiwgTWFjcm9Bc3NlbWJs ZXI6OlRydXN0ZWRJbW02NChKU1ZhbHVlOjplbmNvZGUoanNOdW1iZXIoMCkpKSwgbm90VGFrZW4p OwotICAgICAgICBicmFuY2g2NChNYWNyb0Fzc2VtYmxlcjo6QWJvdmVPckVxdWFsLCB2YWx1ZUdQ UiwgR1BSSW5mbzo6dGFnVHlwZU51bWJlclJlZ2lzdGVyLCB0YWtlbik7CisgICAgICAgIGlmIChu b2RlLT5jaGlsZDEoKS0+cHJlZGljdGlvbigpICYgU3BlY0ludDMyKSB7CisgICAgICAgICAgICBi cmFuY2g2NChNYWNyb0Fzc2VtYmxlcjo6RXF1YWwsIHZhbHVlR1BSLCBNYWNyb0Fzc2VtYmxlcjo6 VHJ1c3RlZEltbTY0KEpTVmFsdWU6OmVuY29kZShqc051bWJlcigwKSkpLCBub3RUYWtlbik7Cisg ICAgICAgICAgICBicmFuY2g2NChNYWNyb0Fzc2VtYmxlcjo6QWJvdmVPckVxdWFsLCB2YWx1ZUdQ UiwgR1BSSW5mbzo6dGFnVHlwZU51bWJlclJlZ2lzdGVyLCB0YWtlbik7CisgICAgICAgIH0KICAg ICAKLSAgICAgICAgaWYgKCFwcmVkaWN0Qm9vbGVhbikgeworICAgICAgICBpZiAobm9kZS0+Y2hp bGQxKCktPnByZWRpY3Rpb24oKSAmIFNwZWNCb29sZWFuKSB7CiAgICAgICAgICAgICBicmFuY2g2 NChNYWNyb0Fzc2VtYmxlcjo6RXF1YWwsIHZhbHVlR1BSLCBNYWNyb0Fzc2VtYmxlcjo6VHJ1c3Rl ZEltbTY0KEpTVmFsdWU6OmVuY29kZShqc0Jvb2xlYW4oZmFsc2UpKSksIG5vdFRha2VuKTsKICAg ICAgICAgICAgIGJyYW5jaDY0KE1hY3JvQXNzZW1ibGVyOjpFcXVhbCwgdmFsdWVHUFIsIE1hY3Jv QXNzZW1ibGVyOjpUcnVzdGVkSW1tNjQoSlNWYWx1ZTo6ZW5jb2RlKGpzQm9vbGVhbih0cnVlKSkp LCB0YWtlbik7CiAgICAgICAgIH0KQEAgLTMxMzEsMjcgKzMxMzMsNiBAQCB2b2lkIFNwZWN1bGF0 aXZlSklUOjpjb21waWxlKE5vZGUqIG5vZGUpCiAgICAgfQogCiAgICAgY2FzZSBCcmFuY2g6Ci0g ICAgICAgIGlmIChub2RlLT5jaGlsZDEoKS0+c2hvdWxkU3BlY3VsYXRlSW50ZWdlcigpKSB7Ci0g ICAgICAgICAgICBTcGVjdWxhdGVJbnRlZ2VyT3BlcmFuZCBvcCh0aGlzLCBub2RlLT5jaGlsZDEo KSk7Ci0gICAgICAgICAgICAKLSAgICAgICAgICAgIEJsb2NrSW5kZXggdGFrZW4gPSBub2RlLT50 YWtlbkJsb2NrSW5kZXgoKTsKLSAgICAgICAgICAgIEJsb2NrSW5kZXggbm90VGFrZW4gPSBub2Rl LT5ub3RUYWtlbkJsb2NrSW5kZXgoKTsKLSAgICAgICAgICAgIAotICAgICAgICAgICAgTWFjcm9B c3NlbWJsZXI6OlJlc3VsdENvbmRpdGlvbiBjb25kaXRpb24gPSBNYWNyb0Fzc2VtYmxlcjo6Tm9u WmVybzsKLSAgICAgICAgICAgIAotICAgICAgICAgICAgaWYgKHRha2VuID09IG5leHRCbG9jaygp KSB7Ci0gICAgICAgICAgICAgICAgY29uZGl0aW9uID0gTWFjcm9Bc3NlbWJsZXI6Olplcm87Ci0g ICAgICAgICAgICAgICAgQmxvY2tJbmRleCB0bXAgPSB0YWtlbjsKLSAgICAgICAgICAgICAgICB0 YWtlbiA9IG5vdFRha2VuOwotICAgICAgICAgICAgICAgIG5vdFRha2VuID0gdG1wOwotICAgICAg ICAgICAgfQotICAgICAgICAgICAgCi0gICAgICAgICAgICBicmFuY2hUZXN0MzIoY29uZGl0aW9u LCBvcC5ncHIoKSwgdGFrZW4pOwotICAgICAgICAgICAganVtcChub3RUYWtlbik7Ci0gICAgICAg ICAgICAKLSAgICAgICAgICAgIG5vUmVzdWx0KG5vZGUpOwotICAgICAgICAgICAgYnJlYWs7Ci0g ICAgICAgIH0KICAgICAgICAgZW1pdEJyYW5jaChub2RlKTsKICAgICAgICAgYnJlYWs7CiAK