110152 2013-02-18 13:30:59 -0800 Make HexNumber functions return 8-bit strings 2013-02-18 14:40:38 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap benjamin cmarcelo dglazkov msaboff ojan.autocc webkit.review.bot oldest_to_newest 835724 0 ap 2013-02-18 13:30:59 -0800 I'm seeing them unnecessarily make URLs 16-bit, blob ones in particular. 835725 1 188938 ap 2013-02-18 13:36:59 -0800 Created attachment 188938 proposed patch 835736 2 188938 msaboff 2013-02-18 13:55:16 -0800 Comment on attachment 188938 proposed patch r+ I have a slight concern on platforms where char is signed that the compiler may complain for the cases we are adding an LChar to a char buffer. An example is the call to placeByteAsHex in appendEscapedChar in KURL.cpp 835746 3 188938 webkit.review.bot 2013-02-18 14:18:38 -0800 Comment on attachment 188938 proposed patch Attachment 188938 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16613339 New failing tests: fast/regions/seamless-iframe-flowed-into-regions.html 835758 4 ap 2013-02-18 14:40:38 -0800 Committed <http://trac.webkit.org/r143265>. The failure looks unrelated. 188938 2013-02-18 13:36:59 -0800 2013-02-18 14:18:38 -0800 proposed patch HexNumber.txt text/plain 3615 ap SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNDMyNTcpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAyLTE4ICBBbGV4ZXkgUHJvc2t1cnlha292 ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIE1ha2UgSGV4TnVtYmVyIGZ1bmN0aW9ucyByZXR1 cm4gOC1iaXQgc3RyaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTEwMTUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiB3dGYvSGV4TnVtYmVyLmg6CisgICAgICAgIChJbnRlcm5hbCk6CisgICAgICAg IChXVEY6OkludGVybmFsOjpoZXhEaWdpdHNGb3JNb2RlKToKKyAgICAgICAgKFdURjo6YXBwZW5k Qnl0ZUFzSGV4KToKKyAgICAgICAgKFdURjo6cGxhY2VCeXRlQXNIZXhDb21wcmVzc0lmUG9zc2li bGUpOgorICAgICAgICAoV1RGOjpwbGFjZUJ5dGVBc0hleCk6CisgICAgICAgIChXVEY6OmFwcGVu ZFVuc2lnbmVkQXNIZXgpOgorICAgICAgICAoV1RGOjphcHBlbmRVbnNpZ25lZEFzSGV4Rml4ZWRT aXplKToKKyAgICAgICAgVXNlIExDaGFyIGV2ZXJ5d2hlcmUuCisKIDIwMTMtMDItMTggIEJlbmph bWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIFZlY3Rv cjo6ZGF0YVNsb3QoKSwgaXQgaGFzIG5vIGltcGxlbWVudGF0aW9uCkluZGV4OiBTb3VyY2UvV1RG L3d0Zi9IZXhOdW1iZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9IZXhOdW1iZXIu aAkocmV2aXNpb24gMTQzMjM0KQorKysgU291cmNlL1dURi93dGYvSGV4TnVtYmVyLmgJKHdvcmtp bmcgY29weSkKQEAgLTMxLDkgKzMxLDkgQEAgZW51bSBIZXhDb252ZXJzaW9uTW9kZSB7CiAKIG5h bWVzcGFjZSBJbnRlcm5hbCB7CiAKLWNvbnN0IGNoYXIgbG93ZXJIZXhEaWdpdHNbMTddID0gIjAx MjM0NTY3ODlhYmNkZWYiOwotY29uc3QgY2hhciB1cHBlckhleERpZ2l0c1sxN10gPSAiMDEyMzQ1 Njc4OUFCQ0RFRiI7Ci1pbmxpbmUgY29uc3QgY2hhciogaGV4RGlnaXRzRm9yTW9kZShIZXhDb252 ZXJzaW9uTW9kZSBtb2RlKQorY29uc3QgTENoYXIgbG93ZXJIZXhEaWdpdHNbMTddID0gIjAxMjM0 NTY3ODlhYmNkZWYiOworY29uc3QgTENoYXIgdXBwZXJIZXhEaWdpdHNbMTddID0gIjAxMjM0NTY3 ODlBQkNERUYiOworaW5saW5lIGNvbnN0IExDaGFyKiBoZXhEaWdpdHNGb3JNb2RlKEhleENvbnZl cnNpb25Nb2RlIG1vZGUpCiB7CiAgICAgcmV0dXJuIG1vZGUgPT0gTG93ZXJjYXNlID8gbG93ZXJI ZXhEaWdpdHMgOiB1cHBlckhleERpZ2l0czsKIH0KQEAgLTQzLDcgKzQzLDcgQEAgaW5saW5lIGNv bnN0IGNoYXIqIGhleERpZ2l0c0Zvck1vZGUoSGV4QwogdGVtcGxhdGU8dHlwZW5hbWUgVD4KIGlu bGluZSB2b2lkIGFwcGVuZEJ5dGVBc0hleCh1bnNpZ25lZCBjaGFyIGJ5dGUsIFQmIGRlc3RpbmF0 aW9uLCBIZXhDb252ZXJzaW9uTW9kZSBtb2RlID0gVXBwZXJjYXNlKQogewotICAgIGNvbnN0IGNo YXIqIGhleERpZ2l0cyA9IEludGVybmFsOjpoZXhEaWdpdHNGb3JNb2RlKG1vZGUpOworICAgIGNv bnN0IExDaGFyKiBoZXhEaWdpdHMgPSBJbnRlcm5hbDo6aGV4RGlnaXRzRm9yTW9kZShtb2RlKTsK ICAgICBkZXN0aW5hdGlvbi5hcHBlbmQoaGV4RGlnaXRzW2J5dGUgPj4gNF0pOwogICAgIGRlc3Rp bmF0aW9uLmFwcGVuZChoZXhEaWdpdHNbYnl0ZSAmIDB4Rl0pOwogfQpAQCAtNTEsNyArNTEsNyBA QCBpbmxpbmUgdm9pZCBhcHBlbmRCeXRlQXNIZXgodW5zaWduZWQgY2hhCiB0ZW1wbGF0ZTx0eXBl bmFtZSBUPgogaW5saW5lIHZvaWQgcGxhY2VCeXRlQXNIZXhDb21wcmVzc0lmUG9zc2libGUodW5z aWduZWQgY2hhciBieXRlLCBUJiBkZXN0aW5hdGlvbiwgdW5zaWduZWQmIGluZGV4LCBIZXhDb252 ZXJzaW9uTW9kZSBtb2RlID0gVXBwZXJjYXNlKQogewotICAgIGNvbnN0IGNoYXIqIGhleERpZ2l0 cyA9IEludGVybmFsOjpoZXhEaWdpdHNGb3JNb2RlKG1vZGUpOworICAgIGNvbnN0IExDaGFyKiBo ZXhEaWdpdHMgPSBJbnRlcm5hbDo6aGV4RGlnaXRzRm9yTW9kZShtb2RlKTsKICAgICBpZiAoYnl0 ZSA+PSAweDEwKQogICAgICAgICBkZXN0aW5hdGlvbltpbmRleCsrXSA9IGhleERpZ2l0c1tieXRl ID4+IDRdOwogICAgIGRlc3RpbmF0aW9uW2luZGV4KytdID0gaGV4RGlnaXRzW2J5dGUgJiAweEZd OwpAQCAtNjAsNyArNjAsNyBAQCBpbmxpbmUgdm9pZCBwbGFjZUJ5dGVBc0hleENvbXByZXNzSWZQ b3NzCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPgogaW5saW5lIHZvaWQgcGxhY2VCeXRlQXNIZXgodW5z aWduZWQgY2hhciBieXRlLCBUJiBkZXN0aW5hdGlvbiwgSGV4Q29udmVyc2lvbk1vZGUgbW9kZSA9 IFVwcGVyY2FzZSkKIHsKLSAgICBjb25zdCBjaGFyKiBoZXhEaWdpdHMgPSBJbnRlcm5hbDo6aGV4 RGlnaXRzRm9yTW9kZShtb2RlKTsKKyAgICBjb25zdCBMQ2hhciogaGV4RGlnaXRzID0gSW50ZXJu YWw6OmhleERpZ2l0c0Zvck1vZGUobW9kZSk7CiAgICAgKmRlc3RpbmF0aW9uKysgPSBoZXhEaWdp dHNbYnl0ZSA+PiA0XTsKICAgICAqZGVzdGluYXRpb24rKyA9IGhleERpZ2l0c1tieXRlICYgMHhG XTsKIH0KQEAgLTY4LDggKzY4LDggQEAgaW5saW5lIHZvaWQgcGxhY2VCeXRlQXNIZXgodW5zaWdu ZWQgY2hhcgogdGVtcGxhdGU8dHlwZW5hbWUgVD4KIGlubGluZSB2b2lkIGFwcGVuZFVuc2lnbmVk QXNIZXgodW5zaWduZWQgbnVtYmVyLCBUJiBkZXN0aW5hdGlvbiwgSGV4Q29udmVyc2lvbk1vZGUg bW9kZSA9IFVwcGVyY2FzZSkKIHsKLSAgICBjb25zdCBjaGFyKiBoZXhEaWdpdHMgPSBJbnRlcm5h bDo6aGV4RGlnaXRzRm9yTW9kZShtb2RlKTsKLSAgICBWZWN0b3I8VUNoYXIsIDg+IHJlc3VsdDsK KyAgICBjb25zdCBMQ2hhciogaGV4RGlnaXRzID0gSW50ZXJuYWw6OmhleERpZ2l0c0Zvck1vZGUo bW9kZSk7CisgICAgVmVjdG9yPExDaGFyLCA4PiByZXN1bHQ7CiAgICAgZG8gewogICAgICAgICBy ZXN1bHQucHJlcGVuZChoZXhEaWdpdHNbbnVtYmVyICUgMTZdKTsKICAgICAgICAgbnVtYmVyID4+ PSA0OwpAQCAtODQsOCArODQsOCBAQCBpbmxpbmUgdm9pZCBhcHBlbmRVbnNpZ25lZEFzSGV4Rml4 ZWRTaXplCiB7CiAgICAgQVNTRVJUKGRlc2lyZWREaWdpdHMpOwogCi0gICAgY29uc3QgY2hhciog aGV4RGlnaXRzID0gSW50ZXJuYWw6OmhleERpZ2l0c0Zvck1vZGUobW9kZSk7Ci0gICAgVmVjdG9y PFVDaGFyLCA4PiByZXN1bHQ7CisgICAgY29uc3QgTENoYXIqIGhleERpZ2l0cyA9IEludGVybmFs OjpoZXhEaWdpdHNGb3JNb2RlKG1vZGUpOworICAgIFZlY3RvcjxMQ2hhciwgOD4gcmVzdWx0Owog ICAgIGRvIHsKICAgICAgICAgcmVzdWx0LnByZXBlbmQoaGV4RGlnaXRzW251bWJlciAlIDE2XSk7 CiAgICAgICAgIG51bWJlciA+Pj0gNDsK