110144 2013-02-18 11:50:37 -0800 clear databases before running read-transactions-running-concurrently test 2013-02-18 13:53:45 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jochen jochen thakis webkit.review.bot oldest_to_newest 835664 0 jochen 2013-02-18 11:50:37 -0800 clear databases before running read-transactions-running-concurrently test 835665 1 188926 jochen 2013-02-18 11:51:19 -0800 Created attachment 188926 Patch 835703 2 188926 thakis 2013-02-18 12:59:38 -0800 Comment on attachment 188926 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188926&action=review > LayoutTests/ChangeLog:9 > + of databases from previous tests are hanging around. Shouldn't the test runner do this before running a test? 835705 3 jochen 2013-02-18 13:01:54 -0800 (In reply to comment #2) > (From update of attachment 188926 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=188926&action=review > > > LayoutTests/ChangeLog:9 > > + of databases from previous tests are hanging around. > > Shouldn't the test runner do this before running a test? it's a rather expensive operation, as it hits the filesystem. 835707 4 thakis 2013-02-18 13:05:10 -0800 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 188926 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=188926&action=review > > > > > LayoutTests/ChangeLog:9 > > > + of databases from previous tests are hanging around. > > > > Shouldn't the test runner do this before running a test? > > it's a rather expensive operation, as it hits the filesystem. How often? A single stat is relatively cheap since every test stats at least the html file and often a js and a css file. And I'd guess in most cases there's nothing to clean up. (stating a .d file in ninja takes ~6µs on a medium-warm cache.) 835720 5 jochen 2013-02-18 13:27:42 -0800 (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > (From update of attachment 188926 [details] [details] [details]) > > > View in context: https://bugs.webkit.org/attachment.cgi?id=188926&action=review > > > > > > > LayoutTests/ChangeLog:9 > > > > + of databases from previous tests are hanging around. > > > > > > Shouldn't the test runner do this before running a test? > > > > it's a rather expensive operation, as it hits the filesystem. > > How often? A single stat is relatively cheap since every test stats at least the html file and often a js and a css file. And I'd guess in most cases there's nothing to clean up. > > (stating a .d file in ninja takes ~6µs on a medium-warm cache.) dunno, is that also true on e.g. android (or content shell, where we have to do this in another process)? Anyway, this seems to be the common pattern, e.g. cookies tests also clean up after themselves, instead of DRT resetting the cookie store after every test (although you could argue that this would make sense as well) 835721 6 188926 thakis 2013-02-18 13:28:59 -0800 Comment on attachment 188926 Patch ok ok 835733 7 188926 webkit.review.bot 2013-02-18 13:53:42 -0800 Comment on attachment 188926 Patch Clearing flags on attachment: 188926 Committed r143261: <http://trac.webkit.org/changeset/143261> 835734 8 webkit.review.bot 2013-02-18 13:53:45 -0800 All reviewed patches have been landed. Closing bug. 188926 2013-02-18 11:51:19 -0800 2013-02-18 13:53:42 -0800 Patch bug-110144-20130218204741.patch text/plain 1454 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzMjQ4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNDM2YzhiM2I3YjdiZWE0NzNmZjU0 MmJjNmE4OWJiYzA2ZTQ2MjRhZS4uMTg1Yzc3NmM2M2ZiMTdkMTVmODU2MzI3ZTQ0ZjNiMjI3NzI2 ZWY1ZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAyLTE4ICBKb2NoZW4gRWlzaW5nZXIg IDxqb2NoZW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIGNsZWFyIGRhdGFiYXNlcyBiZWZvcmUg cnVubmluZyByZWFkLXRyYW5zYWN0aW9ucy1ydW5uaW5nLWNvbmN1cnJlbnRseSB0ZXN0CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTAxNDQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPdGhlcndpc2UsIHdl IG1pZ2h0IG5vdCBoYXZlIGVub3VnaCBxdW90YSB3aGVuIHJ1bm5pbmcgdGhpcyB0ZXN0cyBhbmQg bG90cworICAgICAgICBvZiBkYXRhYmFzZXMgZnJvbSBwcmV2aW91cyB0ZXN0cyBhcmUgaGFuZ2lu ZyBhcm91bmQuCisKKyAgICAgICAgKiBzdG9yYWdlL3dlYnNxbC9yZWFkLXRyYW5zYWN0aW9ucy1y dW5uaW5nLWNvbmN1cnJlbnRseS5odG1sOgorCiAyMDEzLTAyLTE3ICBGaWxpcCBQaXpsbyAgPGZw aXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgR2V0IHJpZCBvZiBERkc6OkRvdWJsZU9wZXJhbmQg YW5kIHNpbXBsaWZ5IFZhbHVlVG9JbnQzMgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3RvcmFn ZS93ZWJzcWwvcmVhZC10cmFuc2FjdGlvbnMtcnVubmluZy1jb25jdXJyZW50bHkuaHRtbCBiL0xh eW91dFRlc3RzL3N0b3JhZ2Uvd2Vic3FsL3JlYWQtdHJhbnNhY3Rpb25zLXJ1bm5pbmctY29uY3Vy cmVudGx5Lmh0bWwKaW5kZXggYWQ4MDFjZmNlYTc2MTFlNDg3OTRkNmJiOTU3ODU2NmU2ZDM5MGM1 Ni4uNjljZmY4MzIwZjU3YzNjMDJhMTJiZWIxNzA3NTEwNTBmMWNjYjcyZCAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvc3RvcmFnZS93ZWJzcWwvcmVhZC10cmFuc2FjdGlvbnMtcnVubmluZy1jb25j dXJyZW50bHkuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9zdG9yYWdlL3dlYnNxbC9yZWFkLXRyYW5z YWN0aW9ucy1ydW5uaW5nLWNvbmN1cnJlbnRseS5odG1sCkBAIC00MSw2ICs0MSw3IEBAIGZ1bmN0 aW9uIHJ1blJlYWRUcmFuc2FjdGlvbihkYikKIAogZnVuY3Rpb24gcnVuVGVzdCgpIHsKICAgICBp ZiAod2luZG93LnRlc3RSdW5uZXIpIHsKKyAgICAgICAgdGVzdFJ1bm5lci5jbGVhckFsbERhdGFi YXNlcygpOwogICAgICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKICAgICAgICAgdGVzdFJ1 bm5lci53YWl0VW50aWxEb25lKCk7CiAgICAgfQo=