110131 2013-02-18 09:16:13 -0800 Add event dispatch class for the new calendar picker 2013-02-21 02:18:20 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 109439 110132 1 keishi keishi tkent webkit.review.bot oldest_to_newest 835547 0 keishi 2013-02-18 09:16:13 -0800 We need to add an event dispatch class that will be used in the new calendar picker 835554 1 188904 keishi 2013-02-18 09:26:44 -0800 Created attachment 188904 Patch 836879 2 188904 buildbot 2013-02-19 15:42:22 -0800 Comment on attachment 188904 Patch Attachment 188904 did not pass win-ews (win): Output: http://queues.webkit.org/results/16637067 837211 3 188904 tkent 2013-02-19 23:25:06 -0800 Comment on attachment 188904 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188904&action=review > Source/WebCore/Resources/pagepopups/calendarPicker.js:690 > + if (!this._callbacks) > + return; > + var callbacksForType = this._callbacks[type]; > + if (!callbacksForType) > + return; The function does nothing in a case that 'callback' is not registered. Should we warn in such case, or should we accept such call sites? > Source/WebCore/Resources/pagepopups/calendarPicker.js:691 > + callbacksForType.splice(callbacksForType.indexOf(callback), 1); What should happen if 'callback' is not a member of 'callbacksForType'? 837235 4 keishi 2013-02-20 00:16:19 -0800 (In reply to comment #3) > (From update of attachment 188904 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=188904&action=review > > > Source/WebCore/Resources/pagepopups/calendarPicker.js:690 > > + if (!this._callbacks) > > + return; > > + var callbacksForType = this._callbacks[type]; > > + if (!callbacksForType) > > + return; > > The function does nothing in a case that 'callback' is not registered. Should we warn in such case, or should we accept such call sites? > > > Source/WebCore/Resources/pagepopups/calendarPicker.js:691 > > + callbacksForType.splice(callbacksForType.indexOf(callback), 1); > > What should happen if 'callback' is not a member of 'callbacksForType'? Like Element.removeEventListener, if the callback is not registered there will be no effect. I kind of feel that this is better because of its simplicity. We usually don't care if the callback exists or not and we just want it gone. For example when calling CalendarPicker.cleanup() you don't know which callbacks have been set (it might be in the middle of an animation) but you know you want to remove them. 837317 5 188904 tkent 2013-02-20 03:51:38 -0800 Comment on attachment 188904 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188904&action=review > Source/WebCore/ChangeLog:8 > + > + No new tests. Code is not yet used. Please mention that this patch is a part of Bug 109439. 838226 6 189477 keishi 2013-02-21 01:54:57 -0800 Created attachment 189477 Patch 838245 7 189477 webkit.review.bot 2013-02-21 02:18:16 -0800 Comment on attachment 189477 Patch Clearing flags on attachment: 189477 Committed r143576: <http://trac.webkit.org/changeset/143576> 838246 8 webkit.review.bot 2013-02-21 02:18:20 -0800 All reviewed patches have been landed. Closing bug. 188904 2013-02-18 09:26:44 -0800 2013-02-21 01:54:53 -0800 Patch bug-110131-20130219022306.patch text/plain 3114 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzMjEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGM5MjY3ZDFmZWUxNDEx N2Y4ZTM2NWM2M2I0ZmFjZDUzYTFkMzJmZS4uOTZhYjM4NGJkYzZjZjdhMTE3MDdmM2E5MzA3N2E4 OWMzNTk1ZTIxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAyLTE4ICBLZWlz aGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgorCisgICAgICAgIEFkZCBldmVudCBkaXNw YXRjaCBjbGFzcyBmb3IgdGhlIG5ldyBjYWxlbmRhciBwaWNrZXIKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDEzMQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gQ29kZSBpcyBub3Qg eWV0IHVzZWQuCisKKyAgICAgICAgKiBSZXNvdXJjZXMvcGFnZXBvcHVwcy9jYWxlbmRhclBpY2tl ci5qczoKKyAgICAgICAgKEV2ZW50RW1pdHRlcik6CisgICAgICAgIChFdmVudEVtaXR0ZXIucHJv dG90eXBlLm9uKTogQWRkcyBhIGNhbGxiYWNrIGZvciBhbiBldmVudC4KKyAgICAgICAgKEV2ZW50 RW1pdHRlci5wcm90b3R5cGUuaGFzTGlzdGVuZXIpOiBSZXR1cm5zIHRydWUgaWYgbW9yZSB0aGFu IG9uZSBsaXN0ZW5lcnMgZXhpc3QgZm9yIGFuIGV2ZW50IHR5cGUuCisgICAgICAgIChFdmVudEVt aXR0ZXIucHJvdG90eXBlLnJlbW92ZUxpc3RlbmVyKTogUmVtb3ZlcyBhbiBldmVudCBsaXN0ZW5l ci4KKyAgICAgICAgKEV2ZW50RW1pdHRlci5wcm90b3R5cGUuZGlzcGF0Y2hFdmVudCk6IERpc3Bh dGNoZXMgYW4gZXZlbnQgdG8gYWxsIGNhbGxiYWNrcy4gVGFrZXMgdmFyaWFibGUgbnVtYmVyIG9m IGFyZ3VtZW50cy4KKwogMjAxMy0wMi0xOCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lh QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gRm9yY2Ugc2luZ2xlIGhlYWRlciBpbmNsdWRl cyBpbiBHT2JqZWN0IERPTSBiaW5kaW5ncwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvUmVz b3VyY2VzL3BhZ2Vwb3B1cHMvY2FsZW5kYXJQaWNrZXIuanMgYi9Tb3VyY2UvV2ViQ29yZS9SZXNv dXJjZXMvcGFnZXBvcHVwcy9jYWxlbmRhclBpY2tlci5qcwppbmRleCA3ZmZhYWMxNmIxZWQ2ZGFl ODE3ODEwYmFmMjUzYWY1YjhjZjUxNmYzLi4wMWViNzNiOTU0YTU4NGRjMWU3OTJhZjAyZGJlMDRi OTVlMzRkNTFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9SZXNvdXJjZXMvcGFnZXBvcHVw cy9jYWxlbmRhclBpY2tlci5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9SZXNvdXJjZXMvcGFnZXBv cHVwcy9jYWxlbmRhclBpY2tlci5qcwpAQCAtNjUyLDYgKzY1Miw2NCBAQCBmdW5jdGlvbiBvcGVu Q2FsZW5kYXJQaWNrZXIoKSB7CiAKIC8qKgogICogQGNvbnN0cnVjdG9yCisgKi8KK2Z1bmN0aW9u IEV2ZW50RW1pdHRlcigpIHsKK307CisKKy8qKgorICogQHBhcmFtIHshc3RyaW5nfSB0eXBlCisg KiBAcGFyYW0geyFmdW5jdGlvbih7Li4uKn0pfSBjYWxsYmFjaworICovCitFdmVudEVtaXR0ZXIu cHJvdG90eXBlLm9uID0gZnVuY3Rpb24odHlwZSwgY2FsbGJhY2spIHsKKyAgICBjb25zb2xlLmFz c2VydChjYWxsYmFjayBpbnN0YW5jZW9mIEZ1bmN0aW9uKTsKKyAgICBpZiAoIXRoaXMuX2NhbGxi YWNrcykKKyAgICAgICAgdGhpcy5fY2FsbGJhY2tzID0ge307CisgICAgaWYgKCF0aGlzLl9jYWxs YmFja3NbdHlwZV0pCisgICAgICAgIHRoaXMuX2NhbGxiYWNrc1t0eXBlXSA9IFtdOworICAgIHRo aXMuX2NhbGxiYWNrc1t0eXBlXS5wdXNoKGNhbGxiYWNrKTsKK307CisKK0V2ZW50RW1pdHRlci5w cm90b3R5cGUuaGFzTGlzdGVuZXIgPSBmdW5jdGlvbih0eXBlKSB7CisgICAgaWYgKCF0aGlzLl9j YWxsYmFja3MpCisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB2YXIgY2FsbGJhY2tzRm9yVHlw ZSA9IHRoaXMuX2NhbGxiYWNrc1t0eXBlXTsKKyAgICBpZiAoIWNhbGxiYWNrc0ZvclR5cGUpCisg ICAgICAgIHJldHVybiBmYWxzZTsKKyAgICByZXR1cm4gY2FsbGJhY2tzRm9yVHlwZS5sZW5ndGgg PiAwOworfTsKKworLyoqCisgKiBAcGFyYW0geyFzdHJpbmd9IHR5cGUKKyAqIEBwYXJhbSB7IWZ1 bmN0aW9uKE9iamVjdCl9IGNhbGxiYWNrCisgKi8KK0V2ZW50RW1pdHRlci5wcm90b3R5cGUucmVt b3ZlTGlzdGVuZXIgPSBmdW5jdGlvbih0eXBlLCBjYWxsYmFjaykgeworICAgIGlmICghdGhpcy5f Y2FsbGJhY2tzKQorICAgICAgICByZXR1cm47CisgICAgdmFyIGNhbGxiYWNrc0ZvclR5cGUgPSB0 aGlzLl9jYWxsYmFja3NbdHlwZV07CisgICAgaWYgKCFjYWxsYmFja3NGb3JUeXBlKQorICAgICAg ICByZXR1cm47CisgICAgY2FsbGJhY2tzRm9yVHlwZS5zcGxpY2UoY2FsbGJhY2tzRm9yVHlwZS5p bmRleE9mKGNhbGxiYWNrKSwgMSk7CisgICAgaWYgKGNhbGxiYWNrc0ZvclR5cGUubGVuZ3RoID09 PSAwKQorICAgICAgICBkZWxldGUgdGhpcy5fY2FsbGJhY2tzW3R5cGVdOworfTsKKworLyoqCisg KiBAcGFyYW0geyFzdHJpbmd9IHR5cGUKKyAqIEBwYXJhbSB7Li4uKn0gdmFyX2FyZ3MKKyAqLwor RXZlbnRFbWl0dGVyLnByb3RvdHlwZS5kaXNwYXRjaEV2ZW50ID0gZnVuY3Rpb24odHlwZSkgewor ICAgIGlmICghdGhpcy5fY2FsbGJhY2tzKQorICAgICAgICByZXR1cm47CisgICAgdmFyIGNhbGxi YWNrc0ZvclR5cGUgPSB0aGlzLl9jYWxsYmFja3NbdHlwZV07CisgICAgaWYgKCFjYWxsYmFja3NG b3JUeXBlKQorICAgICAgICByZXR1cm47CisgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBjYWxsYmFj a3NGb3JUeXBlLmxlbmd0aDsgKytpKSB7CisgICAgICAgIGNhbGxiYWNrc0ZvclR5cGVbaV0uYXBw bHkodGhpcywgQXJyYXkucHJvdG90eXBlLnNsaWNlLmNhbGwoYXJndW1lbnRzLCAxKSk7CisgICAg fQorfTsKKworLyoqCisgKiBAY29uc3RydWN0b3IKICAqIEBwYXJhbSB7IUVsZW1lbnR9IGVsZW1l bnQKICAqIEBwYXJhbSB7IU9iamVjdH0gY29uZmlnCiAgKi8K 189477 2013-02-21 01:54:57 -0800 2013-02-21 02:18:16 -0800 Patch bug-110131-20130221185117.patch text/plain 3209 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzNTc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODg5OTRlZDAyMmNjMGMx ZTQyYThkMGQyMTg1YjZkYmNkOGY4ZTQyYS4uMzBiYzA4ODM5Yjk0YTQ2YTVkM2FmNjJlNDQ4MjA5 YjkyMGVkMmI1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAyLTIxICBLZWlz aGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgorCisgICAgICAgIEFkZCBldmVudCBkaXNw YXRjaCBjbGFzcyBmb3IgdGhlIG5ldyBjYWxlbmRhciBwaWNrZXIKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDEzMQorCisgICAgICAgIFJldmlld2Vk IGJ5IEtlbnQgVGFtdXJhLgorCisgICAgICAgIEFkZGluZyBldmVudCBkaXNwYXRjaGVyIGNsYXNz IGFzIHBhcnQgb2YgdGhlIG5ldyBjYWxlbmRhciBwaWNrZXIgcGF0Y2ggYXQgQnVnIDEwOTQzOS4K KworICAgICAgICBObyBuZXcgdGVzdHMuIENvZGUgaXMgbm90IHlldCB1c2VkLgorCisgICAgICAg ICogUmVzb3VyY2VzL3BhZ2Vwb3B1cHMvY2FsZW5kYXJQaWNrZXIuanM6CisgICAgICAgIChFdmVu dEVtaXR0ZXIpOgorICAgICAgICAoRXZlbnRFbWl0dGVyLnByb3RvdHlwZS5vbik6IEFkZHMgYSBj YWxsYmFjayBmb3IgYW4gZXZlbnQuCisgICAgICAgIChFdmVudEVtaXR0ZXIucHJvdG90eXBlLmhh c0xpc3RlbmVyKTogUmV0dXJucyB0cnVlIGlmIG1vcmUgdGhhbiBvbmUgbGlzdGVuZXJzIGV4aXN0 IGZvciBhbiBldmVudCB0eXBlLgorICAgICAgICAoRXZlbnRFbWl0dGVyLnByb3RvdHlwZS5yZW1v dmVMaXN0ZW5lcik6IFJlbW92ZXMgYW4gZXZlbnQgbGlzdGVuZXIuCisgICAgICAgIChFdmVudEVt aXR0ZXIucHJvdG90eXBlLmRpc3BhdGNoRXZlbnQpOiBEaXNwYXRjaGVzIGFuIGV2ZW50IHRvIGFs bCBjYWxsYmFja3MuIFRha2VzIHZhcmlhYmxlIG51bWJlciBvZiBhcmd1bWVudHMuCisKIDIwMTMt MDItMjEgIEtlbiBLYW5pYSAgPGtrYW5pYUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIElu c3BlY3RvcjogQWRkIGNvbW1hbmQgZm9yIHNlbGVjdGluZyBmaWxlcyBmb3IgZmlsZSBpbnB1dCBl bGVtZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9SZXNvdXJjZXMvcGFnZXBvcHVwcy9j YWxlbmRhclBpY2tlci5qcyBiL1NvdXJjZS9XZWJDb3JlL1Jlc291cmNlcy9wYWdlcG9wdXBzL2Nh bGVuZGFyUGlja2VyLmpzCmluZGV4IDdmZmFhYzE2YjFlZDZkYWU4MTc4MTBiYWYyNTNhZjViOGNm NTE2ZjMuLjAxZWI3M2I5NTRhNTg0ZGMxZTc5MmFmMDJkYmUwNGI5NWUzNGQ1MWUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL1Jlc291cmNlcy9wYWdlcG9wdXBzL2NhbGVuZGFyUGlja2VyLmpz CisrKyBiL1NvdXJjZS9XZWJDb3JlL1Jlc291cmNlcy9wYWdlcG9wdXBzL2NhbGVuZGFyUGlja2Vy LmpzCkBAIC02NTIsNiArNjUyLDY0IEBAIGZ1bmN0aW9uIG9wZW5DYWxlbmRhclBpY2tlcigpIHsK IAogLyoqCiAgKiBAY29uc3RydWN0b3IKKyAqLworZnVuY3Rpb24gRXZlbnRFbWl0dGVyKCkgewor fTsKKworLyoqCisgKiBAcGFyYW0geyFzdHJpbmd9IHR5cGUKKyAqIEBwYXJhbSB7IWZ1bmN0aW9u KHsuLi4qfSl9IGNhbGxiYWNrCisgKi8KK0V2ZW50RW1pdHRlci5wcm90b3R5cGUub24gPSBmdW5j dGlvbih0eXBlLCBjYWxsYmFjaykgeworICAgIGNvbnNvbGUuYXNzZXJ0KGNhbGxiYWNrIGluc3Rh bmNlb2YgRnVuY3Rpb24pOworICAgIGlmICghdGhpcy5fY2FsbGJhY2tzKQorICAgICAgICB0aGlz Ll9jYWxsYmFja3MgPSB7fTsKKyAgICBpZiAoIXRoaXMuX2NhbGxiYWNrc1t0eXBlXSkKKyAgICAg ICAgdGhpcy5fY2FsbGJhY2tzW3R5cGVdID0gW107CisgICAgdGhpcy5fY2FsbGJhY2tzW3R5cGVd LnB1c2goY2FsbGJhY2spOworfTsKKworRXZlbnRFbWl0dGVyLnByb3RvdHlwZS5oYXNMaXN0ZW5l ciA9IGZ1bmN0aW9uKHR5cGUpIHsKKyAgICBpZiAoIXRoaXMuX2NhbGxiYWNrcykKKyAgICAgICAg cmV0dXJuIGZhbHNlOworICAgIHZhciBjYWxsYmFja3NGb3JUeXBlID0gdGhpcy5fY2FsbGJhY2tz W3R5cGVdOworICAgIGlmICghY2FsbGJhY2tzRm9yVHlwZSkKKyAgICAgICAgcmV0dXJuIGZhbHNl OworICAgIHJldHVybiBjYWxsYmFja3NGb3JUeXBlLmxlbmd0aCA+IDA7Cit9OworCisvKioKKyAq IEBwYXJhbSB7IXN0cmluZ30gdHlwZQorICogQHBhcmFtIHshZnVuY3Rpb24oT2JqZWN0KX0gY2Fs bGJhY2sKKyAqLworRXZlbnRFbWl0dGVyLnByb3RvdHlwZS5yZW1vdmVMaXN0ZW5lciA9IGZ1bmN0 aW9uKHR5cGUsIGNhbGxiYWNrKSB7CisgICAgaWYgKCF0aGlzLl9jYWxsYmFja3MpCisgICAgICAg IHJldHVybjsKKyAgICB2YXIgY2FsbGJhY2tzRm9yVHlwZSA9IHRoaXMuX2NhbGxiYWNrc1t0eXBl XTsKKyAgICBpZiAoIWNhbGxiYWNrc0ZvclR5cGUpCisgICAgICAgIHJldHVybjsKKyAgICBjYWxs YmFja3NGb3JUeXBlLnNwbGljZShjYWxsYmFja3NGb3JUeXBlLmluZGV4T2YoY2FsbGJhY2spLCAx KTsKKyAgICBpZiAoY2FsbGJhY2tzRm9yVHlwZS5sZW5ndGggPT09IDApCisgICAgICAgIGRlbGV0 ZSB0aGlzLl9jYWxsYmFja3NbdHlwZV07Cit9OworCisvKioKKyAqIEBwYXJhbSB7IXN0cmluZ30g dHlwZQorICogQHBhcmFtIHsuLi4qfSB2YXJfYXJncworICovCitFdmVudEVtaXR0ZXIucHJvdG90 eXBlLmRpc3BhdGNoRXZlbnQgPSBmdW5jdGlvbih0eXBlKSB7CisgICAgaWYgKCF0aGlzLl9jYWxs YmFja3MpCisgICAgICAgIHJldHVybjsKKyAgICB2YXIgY2FsbGJhY2tzRm9yVHlwZSA9IHRoaXMu X2NhbGxiYWNrc1t0eXBlXTsKKyAgICBpZiAoIWNhbGxiYWNrc0ZvclR5cGUpCisgICAgICAgIHJl dHVybjsKKyAgICBmb3IgKHZhciBpID0gMDsgaSA8IGNhbGxiYWNrc0ZvclR5cGUubGVuZ3RoOyAr K2kpIHsKKyAgICAgICAgY2FsbGJhY2tzRm9yVHlwZVtpXS5hcHBseSh0aGlzLCBBcnJheS5wcm90 b3R5cGUuc2xpY2UuY2FsbChhcmd1bWVudHMsIDEpKTsKKyAgICB9Cit9OworCisvKioKKyAqIEBj b25zdHJ1Y3RvcgogICogQHBhcmFtIHshRWxlbWVudH0gZWxlbWVudAogICogQHBhcmFtIHshT2Jq ZWN0fSBjb25maWcKICAqLwo=