110124 2013-02-18 08:43:13 -0800 Web Inspector: Native Memory Instrumentation: show user provided name property of the heap snapshot node 2013-02-19 04:23:09 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 loislo loislo apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs yurys oldest_to_newest 835513 0 loislo 2013-02-18 08:43:13 -0800 Some nodes have nonzero name property that was assigned via MemoryObjectInfo::setName method This name may give the user a clue which particular object takes so much memory. As example in case of WebCore::CachedImage the instrumentation provides url as the name of the object. 835519 1 188895 loislo 2013-02-18 08:45:37 -0800 Created attachment 188895 Patch 836216 2 188895 yurys 2013-02-19 04:12:05 -0800 Comment on attachment 188895 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188895&action=review > Source/WebCore/inspector/front-end/HeapSnapshotProxy.js:186 > + this._worker = /*typeof InspectorTest === "undefined" ? new WebInspector.HeapSnapshotRealWorker() :*/ new WebInspector.HeapSnapshotFakeWorker(); Please revert this. > Source/WebCore/inspector/front-end/NativeHeapSnapshot.js:112 > + userProvidedName: this.name(), displayName ? 836222 3 loislo 2013-02-19 04:23:09 -0800 Committed r143317: <http://trac.webkit.org/changeset/143317> 188895 2013-02-18 08:45:37 -0800 2013-02-19 04:12:05 -0800 Patch bug-110124-20130218204159.patch text/plain 5299 loislo U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzMjE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNThlYmY5NjAwYWM3Yjdi YTBkMGQ3MTcxODlhNGRmNWE5NGUxZGRjYS4uMjY2OTlkNzQ1NGFlNzdlYmQyYjJmZDI1NDhmZjE3 NTJkMTY3MmZjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDEzLTAyLTE4ICBJbHlh IFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KIAorICAgICAgICBXZWIgSW5zcGVj dG9yOiBOYXRpdmUgTWVtb3J5IEluc3RydW1lbnRhdGlvbjogc2hvdyB1c2VyIHByb3ZpZGVkIG5h bWUgcHJvcGVydHkgb2YgdGhlIGhlYXAgc25hcHNob3Qgbm9kZS4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDEyNAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFB1Ymxpc2ggdXNlclByb3ZpZGVkTmFtZSBp bnRvIGdyaWQgbm9kZS4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvSGVhcFNuYXBz aG90R3JpZE5vZGVzLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdEdlbmVy aWNPYmplY3ROb2RlKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3RHZW5lcmlj T2JqZWN0Tm9kZS5wcm90b3R5cGUuX2NyZWF0ZU9iamVjdENlbGwpOgorICAgICAgICAoV2ViSW5z cGVjdG9yLkhlYXBTbmFwc2hvdEdlbmVyaWNPYmplY3ROb2RlLnByb3RvdHlwZS5nZXQgZGF0YSk6 CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3RQcm94eS5qczoKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3RXb3JrZXIpOgorICAgICAgICAqIGluc3Bl Y3Rvci9mcm9udC1lbmQvTmF0aXZlSGVhcFNuYXBzaG90LmpzOgorICAgICAgICAoV2ViSW5zcGVj dG9yLk5hdGl2ZUhlYXBTbmFwc2hvdE5vZGUucHJvdG90eXBlLnNlcmlhbGl6ZSk6CisKKzIwMTMt MDItMTggIElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgorCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IE5hdGl2ZSBNZW1vcnkgSW5zdHJ1bWVudGF0aW9uOiBHZW5lcmF0ZSBt ZXRhIGluZm9ybWF0aW9uIGZvciBIZWFwU25hcHNob3QgcGFyc2VyLgogICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwMTA0CiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSGVhcFNuYXBzaG90R3JpZE5vZGVzLmpz IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3RHcmlkTm9k ZXMuanMKaW5kZXggYzllNDAwYjhlZThmOGM0OTQ3ZDdmMGE3YmNjZmI4NjczMjI2NmI0MS4uODNm MDhjODdiNmM1ZDY1MTNkZWI3ZjM0MTQ2MjhiNGNjYjM2NDA3MCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3RHcmlkTm9kZXMuanMKKysr IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3RHcmlkTm9k ZXMuanMKQEAgLTM1MCw2ICszNTAsNyBAQCBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90R2VuZXJp Y09iamVjdE5vZGUgPSBmdW5jdGlvbih0cmVlLCBub2RlKQogICAgIGlmICghbm9kZSkKICAgICAg ICAgcmV0dXJuOwogICAgIHRoaXMuX25hbWUgPSBub2RlLm5hbWU7CisgICAgdGhpcy5fdXNlclBy b3ZpZGVkTmFtZSA9IG5vZGUudXNlclByb3ZpZGVkTmFtZTsKICAgICB0aGlzLl90eXBlID0gbm9k ZS50eXBlOwogICAgIHRoaXMuX2Rpc3RhbmNlID0gbm9kZS5kaXN0YW5jZTsKICAgICB0aGlzLl9z aGFsbG93U2l6ZSA9IG5vZGUuc2VsZlNpemU7CkBAIC0zODMsMTkgKzM4NCwzMSBAQCBXZWJJbnNw ZWN0b3IuSGVhcFNuYXBzaG90R2VuZXJpY09iamVjdE5vZGUucHJvdG90eXBlID0gewogICAgICAg ICB2YXIgZGl2ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CiAgICAgICAgIGRpdi5j bGFzc05hbWUgPSAic291cmNlLWNvZGUgZXZlbnQtcHJvcGVydGllcyI7CiAgICAgICAgIGRpdi5z dHlsZS5vdmVyZmxvdyA9ICJ2aXNpYmxlIjsKKwogICAgICAgICB2YXIgZGF0YSA9IHRoaXMuZGF0 YVsib2JqZWN0Il07CiAgICAgICAgIGlmICh0aGlzLl9wcmVmaXhPYmplY3RDZWxsKQogICAgICAg ICAgICAgdGhpcy5fcHJlZml4T2JqZWN0Q2VsbChkaXYsIGRhdGEpOworCiAgICAgICAgIHZhciB2 YWx1ZVNwYW4gPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJzcGFuIik7CiAgICAgICAgIHZhbHVl U3Bhbi5jbGFzc05hbWUgPSAidmFsdWUgY29uc29sZS1mb3JtYXR0ZWQtIiArIGRhdGEudmFsdWVT dHlsZTsKICAgICAgICAgdmFsdWVTcGFuLnRleHRDb250ZW50ID0gZGF0YS52YWx1ZTsKICAgICAg ICAgZGl2LmFwcGVuZENoaWxkKHZhbHVlU3Bhbik7CisKKyAgICAgICAgaWYgKHRoaXMuZGF0YS51 c2VyUHJvdmlkZWROYW1lKSB7CisgICAgICAgICAgICB2YXIgbmFtZVNwYW4gPSBkb2N1bWVudC5j cmVhdGVFbGVtZW50KCJzcGFuIik7CisgICAgICAgICAgICBuYW1lU3Bhbi5jbGFzc05hbWUgPSAi bmFtZSBjb25zb2xlLWZvcm1hdHRlZC1uYW1lIjsKKyAgICAgICAgICAgIG5hbWVTcGFuLnRleHRD b250ZW50ID0gIiAiICsgdGhpcy5kYXRhLnVzZXJQcm92aWRlZE5hbWU7CisgICAgICAgICAgICBk aXYuYXBwZW5kQ2hpbGQobmFtZVNwYW4pOworICAgICAgICB9CisKICAgICAgICAgdmFyIGlkU3Bh biA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInNwYW4iKTsKICAgICAgICAgaWRTcGFuLmNsYXNz TmFtZSA9ICJjb25zb2xlLWZvcm1hdHRlZC1pZCI7CiAgICAgICAgIGlkU3Bhbi50ZXh0Q29udGVu dCA9ICIgQCIgKyBkYXRhWyJub2RlSWQiXTsKICAgICAgICAgZGl2LmFwcGVuZENoaWxkKGlkU3Bh bik7CisKICAgICAgICAgaWYgKHRoaXMuX3Bvc3RmaXhPYmplY3RDZWxsKQogICAgICAgICAgICAg dGhpcy5fcG9zdGZpeE9iamVjdENlbGwoZGl2LCBkYXRhKTsKKwogICAgICAgICBjZWxsLmFwcGVu ZENoaWxkKGRpdik7CiAgICAgICAgIGNlbGwuYWRkU3R5bGVDbGFzcygiZGlzY2xvc3VyZSIpOwog ICAgICAgICBpZiAodGhpcy5kZXB0aCkKQEAgLTQ0NCw2ICs0NTcsNyBAQCBXZWJJbnNwZWN0b3Iu SGVhcFNuYXBzaG90R2VuZXJpY09iamVjdE5vZGUucHJvdG90eXBlID0gewogICAgICAgICAgICAg dmFsdWVTdHlsZSArPSAiIGRldGFjaGVkLWRvbS10cmVlLW5vZGUiOwogICAgICAgICBkYXRhWyJv YmplY3QiXSA9IHsgdmFsdWVTdHlsZTogdmFsdWVTdHlsZSwgdmFsdWU6IHZhbHVlLCBub2RlSWQ6 IHRoaXMuc25hcHNob3ROb2RlSWQgfTsKIAorICAgICAgICBkYXRhWyJ1c2VyUHJvdmlkZWROYW1l Il0gPSB0aGlzLl91c2VyUHJvdmlkZWROYW1lOwogICAgICAgICBkYXRhWyJkaXN0YW5jZSJdID0g IHRoaXMuX2Rpc3RhbmNlOwogICAgICAgICBkYXRhWyJzaGFsbG93U2l6ZSJdID0gTnVtYmVyLndp dGhUaG91c2FuZHNTZXBhcmF0b3IodGhpcy5fc2hhbGxvd1NpemUpOwogICAgICAgICBkYXRhWyJy ZXRhaW5lZFNpemUiXSA9IE51bWJlci53aXRoVGhvdXNhbmRzU2VwYXJhdG9yKHRoaXMuX3JldGFp bmVkU2l6ZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L0hlYXBTbmFwc2hvdFByb3h5LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9IZWFwU25hcHNob3RQcm94eS5qcwppbmRleCAxNDE0Y2MzMGQ0YmVjYTg2NmQyNjk5MzFjZGRi MDEyYzdhNjM3ODFhLi5kNWI0ODhmMWFmYTY1Nzg1ODFjY2NiYmJkNzc0ZTZhMGExMmFlODlkIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hv dFByb3h5LmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSGVhcFNu YXBzaG90UHJveHkuanMKQEAgLTE4Myw3ICsxODMsNyBAQCBXZWJJbnNwZWN0b3IuSGVhcFNuYXBz aG90V29ya2VyID0gZnVuY3Rpb24oKQogICAgIHRoaXMuX2NhbGxiYWNrcyA9IFtdOwogICAgIHRo aXMuX3ByZXZpb3VzQ2FsbGJhY2tzID0gW107CiAgICAgLy8gVGhlcmUgaXMgbm8gc3VwcG9ydCBm b3Igd29ya2VycyBpbiBDaHJvbWl1bSBEUlQuCi0gICAgdGhpcy5fd29ya2VyID0gdHlwZW9mIElu c3BlY3RvclRlc3QgPT09ICJ1bmRlZmluZWQiID8gbmV3IFdlYkluc3BlY3Rvci5IZWFwU25hcHNo b3RSZWFsV29ya2VyKCkgOiBuZXcgV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdEZha2VXb3JrZXIo KTsKKyAgICB0aGlzLl93b3JrZXIgPSAvKnR5cGVvZiBJbnNwZWN0b3JUZXN0ID09PSAidW5kZWZp bmVkIiA/IG5ldyBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90UmVhbFdvcmtlcigpIDoqLyBuZXcg V2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdEZha2VXb3JrZXIoKTsKICAgICB0aGlzLl93b3JrZXIu YWRkRXZlbnRMaXN0ZW5lcigibWVzc2FnZSIsIHRoaXMuX21lc3NhZ2VSZWNlaXZlZCwgdGhpcyk7 CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvTmF0 aXZlSGVhcFNuYXBzaG90LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9O YXRpdmVIZWFwU25hcHNob3QuanMKaW5kZXggNjk2NTkzMDYyY2FmNTA3NTVhZDc3Yjk5NmJkZTk3 MTMxZTQ5MWNjNy4uNzFhN2VhNTJiNzYyZjZjNzE5OTRjYmY2Y2EzY2RjYTM2MjQ5ZjBkYyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OYXRpdmVIZWFwU25h cHNob3QuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OYXRpdmVI ZWFwU25hcHNob3QuanMKQEAgLTEwOSw2ICsxMDksNyBAQCBXZWJJbnNwZWN0b3IuTmF0aXZlSGVh cFNuYXBzaG90Tm9kZS5wcm90b3R5cGUgPSB7CiAgICAgICAgIHJldHVybiB7CiAgICAgICAgICAg ICBpZDogdGhpcy5pZCgpLAogICAgICAgICAgICAgbmFtZTogdGhpcy5jbGFzc05hbWUoKSwKKyAg ICAgICAgICAgIHVzZXJQcm92aWRlZE5hbWU6IHRoaXMubmFtZSgpLAogICAgICAgICAgICAgZGlz dGFuY2U6IHRoaXMuZGlzdGFuY2UoKSwKICAgICAgICAgICAgIG5vZGVJbmRleDogdGhpcy5ub2Rl SW5kZXgsCiAgICAgICAgICAgICByZXRhaW5lZFNpemU6IHRoaXMucmV0YWluZWRTaXplKCksCg==