110107 2013-02-18 05:47:52 -0800 [Soup] Superfluous HashMap check in SocketStreamHandleSoup::getHandleFromId() 2013-02-18 09:21:16 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez cgarcia danw gustavo laszlo.gombos mrobinson rakuco webkit.review.bot yutak oldest_to_newest 835396 0 cdumez 2013-02-18 05:47:52 -0800 SocketStreamHandleSoup::getHandleFromId() currently does the following: static HashMap<void*, SocketStreamHandle*> gActiveHandles; static SocketStreamHandle* getHandleFromId(void* id) { if (!gActiveHandles.contains(id)) return 0; return gActiveHandles.get(id); } The gActiveHandles.contains() checks is superfluous as gActiveHandles.get() will already return 0 if the key cannot be found. 835401 1 188864 cdumez 2013-02-18 05:52:00 -0800 Created attachment 188864 Patch 835551 2 188864 webkit.review.bot 2013-02-18 09:21:12 -0800 Comment on attachment 188864 Patch Clearing flags on attachment: 188864 Committed r143233: <http://trac.webkit.org/changeset/143233> 835552 3 webkit.review.bot 2013-02-18 09:21:16 -0800 All reviewed patches have been landed. Closing bug. 188864 2013-02-18 05:52:00 -0800 2013-02-18 09:21:12 -0800 Patch 110107_getHandleFromId.patch text/plain 1718 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiYjJkYTM0Li5kMDcyZWI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTMtMDItMTggIENocmlzdG9waGUgRHVtZXogIDxjaC5kdW1lekBzaXNhLnNhbXN1bmcu Y29tPgorCisgICAgICAgIFtTb3VwXSBTdXBlcmZsdW91cyBIYXNoTWFwIGNoZWNrIGluIFNvY2tl dFN0cmVhbUhhbmRsZVNvdXA6OmdldEhhbmRsZUZyb21JZCgpCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTAxMDcKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgU3VwZXJmbHVvdXMgSGFzaE1hcDo6 Y29udGFpbnMoKSBjYWxsIGluIFNvY2tldFN0cmVhbUhhbmRsZVNvdXA6OmdldEhhbmRsZUZyb21J ZCgpCisgICAgICAgIGFzIEhhc2hNYXA6OmdldCgpIHdpbGwgYWxyZWFkeSByZXR1cm4gMCBpbiB0 aGlzIGNhc2UgYW55d2F5LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hh bmdlLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9zb3VwL1NvY2tldFN0cmVhbUhhbmRs ZVNvdXAuY3BwOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpnZXRIYW5k bGVGcm9tSWQpOgorCiAyMDEzLTAyLTE4ICBIdWFuZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBh bnkxMDAubmV0PgogCiAgICAgICAgIFtFRkxdW1dLMl0gY29tcG9zaXRpbmcvbGF5ZXItY3JlYXRp b24vZml4ZWQtcG9zaXRpb24tb3V0LW9mLXZpZXctc2NhbGVkLmh0bWwgaXMgZmxha3kKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9Tb2NrZXRTdHJlYW1I YW5kbGVTb3VwLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9Tb2Nr ZXRTdHJlYW1IYW5kbGVTb3VwLmNwcAppbmRleCA2YzRlZWZmLi4yNDA0NWM1IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvU29ja2V0U3RyZWFtSGFuZGxl U291cC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1NvY2tl dFN0cmVhbUhhbmRsZVNvdXAuY3BwCkBAIC02MCwxMCArNjAsMTAgQEAgc3RhdGljIGdib29sZWFu IHdyaXRlUmVhZHlDYWxsYmFjayhHUG9sbGFibGVPdXRwdXRTdHJlYW0qLCB2b2lkKik7CiAvLyB3 ZSBqdXN0IGlnbm9yZSBpdCBpbiB0aGUgY2FsbGJhY2suIFdlIGF2b2lkIGEgbG90IG9mIGV4dHJh IGNoZWNrcyBhbmQgdHJpY2t5CiAvLyBzaXR1YXRpb25zIHRoaXMgd2F5Lgogc3RhdGljIEhhc2hN YXA8dm9pZCosIFNvY2tldFN0cmVhbUhhbmRsZSo+IGdBY3RpdmVIYW5kbGVzOworQ09NUElMRV9B U1NFUlQoSGFzaFRyYWl0czxTb2NrZXRTdHJlYW1IYW5kbGUqPjo6ZW1wdHlWYWx1ZUlzWmVybywg ZW1wdHlNYXBWYWx1ZV9pc18wKTsKKwogc3RhdGljIFNvY2tldFN0cmVhbUhhbmRsZSogZ2V0SGFu ZGxlRnJvbUlkKHZvaWQqIGlkKQogewotICAgIGlmICghZ0FjdGl2ZUhhbmRsZXMuY29udGFpbnMo aWQpKQotICAgICAgICByZXR1cm4gMDsKICAgICByZXR1cm4gZ0FjdGl2ZUhhbmRsZXMuZ2V0KGlk KTsKIH0KIAo=