110106 2013-02-18 05:41:17 -0800 Web Inspector: Disable hiding the debugger when it is below the source code 2013-02-18 08:56:03 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kaznacheev kaznacheev apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs yurys oldest_to_newest 835392 0 kaznacheev 2013-02-18 05:41:17 -0800 The recently added option to split the sources panel horizontally does not play well with the button that shows/hides the sidebar. The proposed solution: 1. Hide this button when the "Split horizontally" option is checked. 2. Force-show the sidebar if the sidebar is hidden and "Split horizontally" is clicked. 835393 1 188861 kaznacheev 2013-02-18 05:46:23 -0800 Created attachment 188861 Patch 835406 2 188867 kaznacheev 2013-02-18 05:58:59 -0800 Created attachment 188867 Patch 835530 3 pfeldman 2013-02-18 08:56:03 -0800 Committed r143227: <http://trac.webkit.org/changeset/143227> 188861 2013-02-18 05:46:23 -0800 2013-02-18 05:58:54 -0800 Patch bug-110106-20130218174246.patch text/plain 3413 kaznacheev U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzMTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmIyZGEzNDQxZTY1YzZl MGZmMGJkNzgxMzRiNGJmMTJkMDUxNDVkNS4uN2Y0NDNmMzZkNzY2MThhYTVjYjJiZTI0MGI3YzY1 MjhhY2IyMzI0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAyLTE4ICBWbGFk aXNsYXYgS2F6bmFjaGVldiAgPGthem5hY2hlZXZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdl YiBJbnNwZWN0b3I6IERpc2FibGUgaGlkaW5nIHRoZSBkZWJ1Z2dlciB3aGVuIGl0IGlzIGJlbG93 IHRoZSBzb3VyY2UgY29kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTEwMTA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgV2hlbiB0aGUgIlNwbGl0IGhvcml6b250YWxseSIgb3B0aW9uIGlzIGNoZWNrZWQg aW4gdGhlIFNvdXJjZXMgcGFuZWwgdGhlIGJ1dHRvbiByZXNwb25zaWJsZSBmb3IgdGhlIHNpZGVi YXIKKyAgICAgICAgdmlzaWJpbGl0eSBpcyBoaWRkZW4gYW5kIHRoZSBzaWRlYmFyIGlzIGZvcmNl LXNob3duLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIGluc3BlY3Rvci9m cm9udC1lbmQvU2NyaXB0c1BhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNjcmlwdHNQ YW5lbCk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9zY3JpcHRzUGFuZWwuY3NzOgor ICAgICAgICAoLnNwbGl0LXZpZXctaG9yaXpvbnRhbCAjc2NyaXB0cy1kZWJ1Zy1zaWRlYmFyLXJl c2l6ZXItd2lkZ2V0KToKKwogMjAxMy0wMi0xOCAgSHVhbmcgRG9uZ3N1bmcgIDxsdXh0ZWxsYUBj b21wYW55MTAwLm5ldD4KIAogICAgICAgICBbRUZMXVtXSzJdIGNvbXBvc2l0aW5nL2xheWVyLWNy ZWF0aW9uL2ZpeGVkLXBvc2l0aW9uLW91dC1vZi12aWV3LXNjYWxlZC5odG1sIGlzIGZsYWt5CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNQYW5l bC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpz CmluZGV4IGYxNWM1NWZiOTEzNWZlNmM2MDZlYWU0NjRhYzk2N2NkYzc5MjliNmEuLmRiNGZkNDY4 ZDNkNTFlZmFmODFjZDVkN2Y4MWRiYTM5ZmM1MmRmMjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpzCkBAIC0xMzEsOCArMTMxLDYg QEAgV2ViSW5zcGVjdG9yLlNjcmlwdHNQYW5lbCA9IGZ1bmN0aW9uKHdvcmtzcGFjZUZvclRlc3Qp CiAgICAgdGhpcy5fc3BsaXRTaWRlYmFyU2V0dGluZyA9IFdlYkluc3BlY3Rvci5zZXR0aW5ncy5j cmVhdGVTZXR0aW5nKHRoaXMubmFtZSArICJQYW5lbFNwbGl0U2lkZWJhciIsIGZhbHNlKTsKICAg ICB0aGlzLl9zcGxpdFNpZGViYXJTZXR0aW5nLmFkZENoYW5nZUxpc3RlbmVyKHRoaXMuX2FycmFu Z2VTaWRlYmFyUGFuZXMuYmluZCh0aGlzKSk7CiAKLSAgICB0aGlzLl9hcnJhbmdlU2lkZWJhclBh bmVzKCk7Ci0KICAgICB0aGlzLnNpZGViYXJQYW5lcy5jYWxsc3RhY2sucmVnaXN0ZXJTaG9ydGN1 dHModGhpcy5yZWdpc3RlclNob3J0Y3V0cy5iaW5kKHRoaXMpKTsKICAgICB0aGlzLnJlZ2lzdGVy U2hvcnRjdXRzKFdlYkluc3BlY3Rvci5TY3JpcHRzUGFuZWxEZXNjcmlwdG9yLlNob3J0Y3V0S2V5 cy5FdmFsdWF0ZVNlbGVjdGlvbkluQ29uc29sZSwgdGhpcy5fZXZhbHVhdGVTZWxlY3Rpb25JbkNv bnNvbGUuYmluZCh0aGlzKSk7CiAgICAgdGhpcy5yZWdpc3RlclNob3J0Y3V0cyhXZWJJbnNwZWN0 b3IuU2NyaXB0c1BhbmVsRGVzY3JpcHRvci5TaG9ydGN1dEtleXMuR29Ub01lbWJlciwgdGhpcy5f c2hvd091dGxpbmVEaWFsb2cuYmluZCh0aGlzKSk7CkBAIC0xNjEsNiArMTU5LDcgQEAgV2ViSW5z cGVjdG9yLlNjcmlwdHNQYW5lbCA9IGZ1bmN0aW9uKHdvcmtzcGFjZUZvclRlc3QpCiAgICAgdGhp cy5fc2NyaXB0Vmlld1N0YXR1c0Jhckl0ZW1zQ29udGFpbmVyLnN0eWxlLmRpc3BsYXkgPSAiaW5s aW5lLWJsb2NrIjsKIAogICAgIHRoaXMuX2luc3RhbGxEZWJ1Z2dlclNpZGViYXJDb250cm9sbGVy KCk7CisgICAgdGhpcy5fYXJyYW5nZVNpZGViYXJQYW5lcygpOwogCiAgICAgdGhpcy5fc291cmNl RnJhbWVzQnlVSVNvdXJjZUNvZGUgPSBuZXcgTWFwKCk7CiAgICAgdGhpcy5fdXBkYXRlRGVidWdn ZXJCdXR0b25zKCk7CkBAIC0xMjMyLDYgKzEyMzEsOSBAQCBXZWJJbnNwZWN0b3IuU2NyaXB0c1Bh bmVsLnByb3RvdHlwZSA9IHsKIAogICAgICAgICBpZiAoV2ViSW5zcGVjdG9yLnNldHRpbmdzLndh dGNoRXhwcmVzc2lvbnMuZ2V0KCkubGVuZ3RoID4gMCkKICAgICAgICAgICAgIHRoaXMuc2lkZWJh clBhbmVzLndhdGNoRXhwcmVzc2lvbnMuZXhwYW5kKCk7CisKKyAgICAgICAgaWYgKCF2ZXJ0aWNh bCkKKyAgICAgICAgICAgIHRoaXMuX3Nob3dEZWJ1Z2dlclNpZGViYXIoKTsKICAgICB9LAogCiAg ICAgX19wcm90b19fOiBXZWJJbnNwZWN0b3IuUGFuZWwucHJvdG90eXBlCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL3NjcmlwdHNQYW5lbC5jc3MgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL3NjcmlwdHNQYW5lbC5jc3MKaW5kZXggY2Y0 NWFiZmU1NTJhZGNiOTE0OTUzZjhmZjJiM2U0NmFmYzU4NWMzYS4uMDQ3MzNkOTZjMWM0YWNjOTNh NzNiOTE5MjJlN2I1ZGY4ZjU2ZTZmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9zY3JpcHRzUGFuZWwuY3NzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvc2NyaXB0c1BhbmVsLmNzcwpAQCAtMjczLDYgKzI3MywxMSBAQCBidXR0 b24uc3RhdHVzLWJhci1pdGVtLnNjcmlwdHMtZGVidWdnZXItc2hvdy1oaWRlLWJ1dHRvbiB7CiAg ICAgYm9yZGVyOiBub25lOwogfQogCisuc3BsaXQtdmlldy1ob3Jpem9udGFsIGJ1dHRvbi5zdGF0 dXMtYmFyLWl0ZW0uc2NyaXB0cy1kZWJ1Z2dlci1zaG93LWhpZGUtYnV0dG9uLAorLnNwbGl0LXZp ZXctaG9yaXpvbnRhbCAjc2NyaXB0cy1kZWJ1Zy1zaWRlYmFyLXJlc2l6ZXItd2lkZ2V0IHsKKyAg ICBkaXNwbGF5OiBub25lOworfQorCiBidXR0b24uc3RhdHVzLWJhci1pdGVtLnNjcmlwdHMtZGVi dWdnZXItc2hvdy1oaWRlLWJ1dHRvbjphY3RpdmUgewogICAgIHRvcDogMXB4OwogfQo= 188867 2013-02-18 05:58:59 -0800 2013-02-18 06:08:33 -0800 Patch bug-110106-20130218175522.patch text/plain 3785 kaznacheev U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzMTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmIyZGEzNDQxZTY1YzZl MGZmMGJkNzgxMzRiNGJmMTJkMDUxNDVkNS4uODI3OWQ1OGI5ZDRlNDdiMzQ4OWY0YmYxOTBjNWQ1 M2RmMjI1NWU4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAyLTE4ICBWbGFk aXNsYXYgS2F6bmFjaGVldiAgPGthem5hY2hlZXZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdl YiBJbnNwZWN0b3I6IERpc2FibGUgaGlkaW5nIHRoZSBkZWJ1Z2dlciB3aGVuIGl0IGlzIGJlbG93 IHRoZSBzb3VyY2UgY29kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTEwMTA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgV2hlbiB0aGUgIlNwbGl0IGhvcml6b250YWxseSIgb3B0aW9uIGlzIGNoZWNrZWQg aW4gdGhlIFNvdXJjZXMgcGFuZWwgdGhlIGJ1dHRvbiByZXNwb25zaWJsZSBmb3IgdGhlIHNpZGVi YXIKKyAgICAgICAgdmlzaWJpbGl0eSBpcyBoaWRkZW4gYW5kIHRoZSBzaWRlYmFyIGlzIGZvcmNl LXNob3duLiBBbHNvIHNldCB0aGUgIlNwbGl0IHNpZGViYXIiIG9wdGlvbiBkZWZhdWx0IHRvIHRy dWUuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250 LWVuZC9TY3JpcHRzUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU2NyaXB0c1BhbmVs KToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL3NjcmlwdHNQYW5lbC5jc3M6CisgICAg ICAgICguc3BsaXQtdmlldy1ob3Jpem9udGFsICNzY3JpcHRzLWRlYnVnLXNpZGViYXItcmVzaXpl ci13aWRnZXQpOgorCiAyMDEzLTAyLTE4ICBIdWFuZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBh bnkxMDAubmV0PgogCiAgICAgICAgIFtFRkxdW1dLMl0gY29tcG9zaXRpbmcvbGF5ZXItY3JlYXRp b24vZml4ZWQtcG9zaXRpb24tb3V0LW9mLXZpZXctc2NhbGVkLmh0bWwgaXMgZmxha3kKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpz IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFuZWwuanMKaW5k ZXggZjE1YzU1ZmI5MTM1ZmU2YzYwNmVhZTQ2NGFjOTY3Y2RjNzkyOWI2YS4uYzNiNmZhYzIzNjY0 ZTI5NmUxYmQ0MGQ4OWIzMWExMmZhOTc0MGZmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFuZWwuanMKQEAgLTEyOCwxMSArMTI4LDkgQEAg V2ViSW5zcGVjdG9yLlNjcmlwdHNQYW5lbCA9IGZ1bmN0aW9uKHdvcmtzcGFjZUZvclRlc3QpCiAg ICAgdGhpcy5fc3BsaXREaXJlY3Rpb25TZXR0aW5nID0gV2ViSW5zcGVjdG9yLnNldHRpbmdzLmNy ZWF0ZVNldHRpbmcodGhpcy5uYW1lICsgIlBhbmVsU3BsaXRIb3Jpem9udGFsbHkiLCBmYWxzZSk7 CiAgICAgdGhpcy5fc3BsaXREaXJlY3Rpb25TZXR0aW5nLmFkZENoYW5nZUxpc3RlbmVyKHRoaXMu X2FycmFuZ2VTaWRlYmFyUGFuZXMuYmluZCh0aGlzKSk7CiAKLSAgICB0aGlzLl9zcGxpdFNpZGVi YXJTZXR0aW5nID0gV2ViSW5zcGVjdG9yLnNldHRpbmdzLmNyZWF0ZVNldHRpbmcodGhpcy5uYW1l ICsgIlBhbmVsU3BsaXRTaWRlYmFyIiwgZmFsc2UpOworICAgIHRoaXMuX3NwbGl0U2lkZWJhclNl dHRpbmcgPSBXZWJJbnNwZWN0b3Iuc2V0dGluZ3MuY3JlYXRlU2V0dGluZyh0aGlzLm5hbWUgKyAi UGFuZWxTcGxpdFNpZGViYXIiLCB0cnVlKTsKICAgICB0aGlzLl9zcGxpdFNpZGViYXJTZXR0aW5n LmFkZENoYW5nZUxpc3RlbmVyKHRoaXMuX2FycmFuZ2VTaWRlYmFyUGFuZXMuYmluZCh0aGlzKSk7 CiAKLSAgICB0aGlzLl9hcnJhbmdlU2lkZWJhclBhbmVzKCk7Ci0KICAgICB0aGlzLnNpZGViYXJQ YW5lcy5jYWxsc3RhY2sucmVnaXN0ZXJTaG9ydGN1dHModGhpcy5yZWdpc3RlclNob3J0Y3V0cy5i aW5kKHRoaXMpKTsKICAgICB0aGlzLnJlZ2lzdGVyU2hvcnRjdXRzKFdlYkluc3BlY3Rvci5TY3Jp cHRzUGFuZWxEZXNjcmlwdG9yLlNob3J0Y3V0S2V5cy5FdmFsdWF0ZVNlbGVjdGlvbkluQ29uc29s ZSwgdGhpcy5fZXZhbHVhdGVTZWxlY3Rpb25JbkNvbnNvbGUuYmluZCh0aGlzKSk7CiAgICAgdGhp cy5yZWdpc3RlclNob3J0Y3V0cyhXZWJJbnNwZWN0b3IuU2NyaXB0c1BhbmVsRGVzY3JpcHRvci5T aG9ydGN1dEtleXMuR29Ub01lbWJlciwgdGhpcy5fc2hvd091dGxpbmVEaWFsb2cuYmluZCh0aGlz KSk7CkBAIC0xNjEsNiArMTU5LDcgQEAgV2ViSW5zcGVjdG9yLlNjcmlwdHNQYW5lbCA9IGZ1bmN0 aW9uKHdvcmtzcGFjZUZvclRlc3QpCiAgICAgdGhpcy5fc2NyaXB0Vmlld1N0YXR1c0Jhckl0ZW1z Q29udGFpbmVyLnN0eWxlLmRpc3BsYXkgPSAiaW5saW5lLWJsb2NrIjsKIAogICAgIHRoaXMuX2lu c3RhbGxEZWJ1Z2dlclNpZGViYXJDb250cm9sbGVyKCk7CisgICAgdGhpcy5fYXJyYW5nZVNpZGVi YXJQYW5lcygpOwogCiAgICAgdGhpcy5fc291cmNlRnJhbWVzQnlVSVNvdXJjZUNvZGUgPSBuZXcg TWFwKCk7CiAgICAgdGhpcy5fdXBkYXRlRGVidWdnZXJCdXR0b25zKCk7CkBAIC0xMjMyLDYgKzEy MzEsOSBAQCBXZWJJbnNwZWN0b3IuU2NyaXB0c1BhbmVsLnByb3RvdHlwZSA9IHsKIAogICAgICAg ICBpZiAoV2ViSW5zcGVjdG9yLnNldHRpbmdzLndhdGNoRXhwcmVzc2lvbnMuZ2V0KCkubGVuZ3Ro ID4gMCkKICAgICAgICAgICAgIHRoaXMuc2lkZWJhclBhbmVzLndhdGNoRXhwcmVzc2lvbnMuZXhw YW5kKCk7CisKKyAgICAgICAgaWYgKCF2ZXJ0aWNhbCkKKyAgICAgICAgICAgIHRoaXMuX3Nob3dE ZWJ1Z2dlclNpZGViYXIoKTsKICAgICB9LAogCiAgICAgX19wcm90b19fOiBXZWJJbnNwZWN0b3Iu UGFuZWwucHJvdG90eXBlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL3NjcmlwdHNQYW5lbC5jc3MgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL3NjcmlwdHNQYW5lbC5jc3MKaW5kZXggY2Y0NWFiZmU1NTJhZGNiOTE0OTUzZjhmZjJiM2U0 NmFmYzU4NWMzYS4uMDQ3MzNkOTZjMWM0YWNjOTNhNzNiOTE5MjJlN2I1ZGY4ZjU2ZTZmOSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9zY3JpcHRzUGFuZWwu Y3NzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvc2NyaXB0c1BhbmVs LmNzcwpAQCAtMjczLDYgKzI3MywxMSBAQCBidXR0b24uc3RhdHVzLWJhci1pdGVtLnNjcmlwdHMt ZGVidWdnZXItc2hvdy1oaWRlLWJ1dHRvbiB7CiAgICAgYm9yZGVyOiBub25lOwogfQogCisuc3Bs aXQtdmlldy1ob3Jpem9udGFsIGJ1dHRvbi5zdGF0dXMtYmFyLWl0ZW0uc2NyaXB0cy1kZWJ1Z2dl ci1zaG93LWhpZGUtYnV0dG9uLAorLnNwbGl0LXZpZXctaG9yaXpvbnRhbCAjc2NyaXB0cy1kZWJ1 Zy1zaWRlYmFyLXJlc2l6ZXItd2lkZ2V0IHsKKyAgICBkaXNwbGF5OiBub25lOworfQorCiBidXR0 b24uc3RhdHVzLWJhci1pdGVtLnNjcmlwdHMtZGVidWdnZXItc2hvdy1oaWRlLWJ1dHRvbjphY3Rp dmUgewogICAgIHRvcDogMXB4OwogfQo=