110100 2013-02-18 04:07:50 -0800 [Soup] CookieJarSoup::deleteCookie() should stop looking for the cookie after it is removed 2013-02-18 05:31:20 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez cgarcia danw gustavo laszlo.gombos mrobinson rakuco webkit.review.bot oldest_to_newest 835317 0 cdumez 2013-02-18 04:07:50 -0800 CookieJarSoup::deleteCookie() currently retrieves the list of cookies that apply to a given URL, then iterates through the cookies to find the one with the right name and delete it. However, the current implementation does not break when the cookie is removed and it keeps iterating through the whole list for no reason. 835330 1 cdumez 2013-02-18 04:20:53 -0800 Actually, we need to keep iterating so that the cookies get freed. However, we can introduce a boolean to stop comparing cookie names after the cookie was removed. 835337 2 188847 cdumez 2013-02-18 04:28:26 -0800 Created attachment 188847 Patch 835358 3 cdumez 2013-02-18 04:59:50 -0800 Could someone from GTK port please take a look before landing this? 835370 4 cgarcia 2013-02-18 05:15:32 -0800 LGTM 835388 5 188847 webkit.review.bot 2013-02-18 05:31:16 -0800 Comment on attachment 188847 Patch Clearing flags on attachment: 188847 Committed r143204: <http://trac.webkit.org/changeset/143204> 835389 6 webkit.review.bot 2013-02-18 05:31:20 -0800 All reviewed patches have been landed. Closing bug. 188847 2013-02-18 04:28:26 -0800 2013-02-18 05:31:16 -0800 Patch 110100_deleteCookie.patch text/plain 2080 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4ZDAzODk2Li5jNTFlMWY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTMtMDItMTggIENocmlzdG9waGUgRHVtZXogIDxjaC5kdW1lekBzaXNhLnNhbXN1bmcu Y29tPgorCisgICAgICAgIFtTb3VwXSBDb29raWVKYXJTb3VwOjpkZWxldGVDb29raWUoKSBzaG91 bGQgc3RvcCBsb29raW5nIGZvciB0aGUgY29va2llIGFmdGVyIGl0IGlzIHJlbW92ZWQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDEwMAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvb2tpZUphclNvdXA6 OmRlbGV0ZUNvb2tpZSgpIHJldHJpZXZlcyB0aGUgbGlzdCBvZiBjb29raWVzIHRoYXQgYXBwbHkg dG8gYSBnaXZlbiBVUkwsIHRoZW4KKyAgICAgICAgaXRlcmF0ZXMgdGhyb3VnaCB0aGUgY29va2ll cyB0byBmaW5kIHRoZSBvbmUgd2l0aCB0aGUgcmlnaHQgbmFtZSBhbmQgZGVsZXRlIGl0LiBIb3dl dmVyLCB0aGUKKyAgICAgICAgY3VycmVudCBpbXBsZW1lbnRhdGlvbiBrZWVwcyBvbiBjb21wYXJp bmcgY29va2llIG5hbWVzIGFmdGVyIHRoZSBjb29raWUgd2FzIHJlbW92ZWQuIFRoaXMKKyAgICAg ICAgcGF0Y2ggaW50cm9kdWNlcyBhICJ3YXNEZWxldGVkIiBib29sZWFuIHRvIHN0b3AgY29tcGFy aW5nIGNvb2tpZSBuYW1lcyBhZnRlciB0aGUgY29va2llIHdhcworICAgICAgICBkZWxldGVkLiBO b3RlIHRoYXQgd2UgY2Fubm90IGJyZWFrIGFzIHNvb24gYXMgdGhlIGNvb2tpZSBpcyBmb3VuZCBh cyB3ZSBuZWVkIHRvIGtlZXAgaXRlcmF0aW5nCisgICAgICAgIHNvIHRoYXQgdGhlIGNvb2tpZXMg Z2V0IGZyZWVkIGJ5IEdPd25QdHIuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlv ciBjaGFuZ2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQ29va2llSmFyU291 cC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpkZWxldGVDb29raWUpOgorCiAyMDEzLTAyLTE4ICBH cnplZ29yeiBDemFqa293c2tpICA8Zy5jemFqa293c2tpQHNhbXN1bmcuY29tPgogCiAgICAgICAg IFtXSzJdW0VGTF0gVW5pZmllZCB0ZXh0IGNoZWNrZXIgaW1wbGVtZW50YXRpb24KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9Db29raWVKYXJTb3VwLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9Db29raWVKYXJTb3VwLmNw cAppbmRleCBhZTU0YmMwLi5iZDI3M2MwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9uZXR3b3JrL3NvdXAvQ29va2llSmFyU291cC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9zb3VwL0Nvb2tpZUphclNvdXAuY3BwCkBAIC0xNjksMTAgKzE2OSwx MyBAQCB2b2lkIGRlbGV0ZUNvb2tpZShjb25zdCBOZXR3b3JrU3RvcmFnZVNlc3Npb24mIHNlc3Np b24sIGNvbnN0IEtVUkwmIHVybCwgY29uc3QgUwogICAgICAgICByZXR1cm47CiAKICAgICBDU3Ry aW5nIGNvb2tpZU5hbWUgPSBuYW1lLnV0ZjgoKTsKKyAgICBib29sIHdhc0RlbGV0ZWQgPSBmYWxz ZTsKICAgICBmb3IgKEdTTGlzdCogaXRlciA9IGNvb2tpZXMuZ2V0KCk7IGl0ZXI7IGl0ZXIgPSBn X3NsaXN0X25leHQoaXRlcikpIHsKICAgICAgICAgR093blB0cjxTb3VwQ29va2llPiBjb29raWUo c3RhdGljX2Nhc3Q8U291cENvb2tpZSo+KGl0ZXItPmRhdGEpKTsKLSAgICAgICAgaWYgKGNvb2tp ZU5hbWUgPT0gY29va2llLT5uYW1lKQorICAgICAgICBpZiAoIXdhc0RlbGV0ZWQgJiYgY29va2ll TmFtZSA9PSBjb29raWUtPm5hbWUpIHsKICAgICAgICAgICAgIHNvdXBfY29va2llX2phcl9kZWxl dGVfY29va2llKGphciwgY29va2llLmdldCgpKTsKKyAgICAgICAgICAgIHdhc0RlbGV0ZWQgPSB0 cnVlOworICAgICAgICB9CiAgICAgfQogfQogCg==