<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>110087</bug_id>
          
          <creation_ts>2013-02-18 01:15:01 -0800</creation_ts>
          <short_desc>WKR (new-commit-bot) is too slow</short_desc>
          <delta_ts>2013-04-08 23:43:22 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ryosuke Niwa">rniwa</reporter>
          <assigned_to name="Ryosuke Niwa">rniwa</assigned_to>
          <cc>abarth</cc>
    
    <cc>dpranke</cc>
    
    <cc>eric</cc>
    
    <cc>kling</cc>
    
    <cc>koivisto</cc>
    
    <cc>morrita</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>835206</commentid>
    <comment_count>0</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2013-02-18 01:15:01 -0800</bug_when>
    <thetext>Apparently running &quot;svn up&quot; or &quot;git svn fetch&quot; on my 5 years old MBP is way too slow and takes multiple minutes to complete. I&apos;ve found a solution that dramatically reduces this time that only works on a svn checkout.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>835211</commentid>
    <comment_count>1</comment_count>
      <attachid>188816</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2013-02-18 01:17:42 -0800</bug_when>
    <thetext>Created attachment 188816
Use svn log -r without updating checkout</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>835214</commentid>
    <comment_count>2</comment_count>
      <attachid>188817</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2013-02-18 01:21:21 -0800</bug_when>
    <thetext>Created attachment 188817
Merged ToT</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>835226</commentid>
    <comment_count>3</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2013-02-18 01:35:39 -0800</bug_when>
    <thetext>I&apos;m using the new implementation now. It&apos;s MUCH faster :D</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>835266</commentid>
    <comment_count>4</comment_count>
      <attachid>188834</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2013-02-18 02:32:01 -0800</bug_when>
    <thetext>Created attachment 188834
Also use utf-8 encoding</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>836526</commentid>
    <comment_count>5</comment_count>
      <attachid>188834</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2013-02-19 10:33:00 -0800</bug_when>
    <thetext>Comment on attachment 188834
Also use utf-8 encoding

View in context: https://bugs.webkit.org/attachment.cgi?id=188834&amp;action=review

&gt; Tools/Scripts/webkitpy/tool/commands/newcommitbot.py:79
&gt; +        for revision in range(self._last_svn_revision + 1, self._last_svn_revision + 10):

10?

&gt; Tools/Scripts/webkitpy/tool/commands/newcommitbot.py:85
&gt; +            if re.match(r&apos;^\-+$&apos;, commit_log):
&gt; +                continue

What is this looking for?

&gt; Tools/Scripts/webkitpy/tool/commands/newcommitbot.py:89
&gt; +            revision += 1

Doesn&apos;t the for-in-range handle incrementing the revision?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>836527</commentid>
    <comment_count>6</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2013-02-19 10:33:19 -0800</bug_when>
    <thetext>Does it update it&apos;s working copy periodically?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>836528</commentid>
    <comment_count>7</comment_count>
      <attachid>188834</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2013-02-19 10:36:36 -0800</bug_when>
    <thetext>Comment on attachment 188834
Also use utf-8 encoding

View in context: https://bugs.webkit.org/attachment.cgi?id=188834&amp;action=review

&gt;&gt; Tools/Scripts/webkitpy/tool/commands/newcommitbot.py:79
&gt;&gt; +        for revision in range(self._last_svn_revision + 1, self._last_svn_revision + 10):
&gt; 
&gt; 10?

This is so that when there are many commits at once or something goes wrong, we don&apos;t end up spamming IRC with hundreds of messages.

&gt;&gt; Tools/Scripts/webkitpy/tool/commands/newcommitbot.py:85
&gt;&gt; +                continue
&gt; 
&gt; What is this looking for?

It&apos;s looking for empty entries that&apos;s filled with -------...
You get this when someone commits into branches.

&gt;&gt; Tools/Scripts/webkitpy/tool/commands/newcommitbot.py:89
&gt;&gt; +            revision += 1
&gt; 
&gt; Doesn&apos;t the for-in-range handle incrementing the revision?

Oops, yeah, we can get rid of this now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>836529</commentid>
    <comment_count>8</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2013-02-19 10:37:31 -0800</bug_when>
    <thetext>(In reply to comment #6)
&gt; Does it update it&apos;s working copy periodically?

No. My plan is to have restart command do it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>836654</commentid>
    <comment_count>9</comment_count>
      <attachid>188834</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2013-02-19 12:15:59 -0800</bug_when>
    <thetext>Comment on attachment 188834
Also use utf-8 encoding

View in context: https://bugs.webkit.org/attachment.cgi?id=188834&amp;action=review

&gt;&gt;&gt; Tools/Scripts/webkitpy/tool/commands/newcommitbot.py:79
&gt;&gt;&gt; +        for revision in range(self._last_svn_revision + 1, self._last_svn_revision + 10):
&gt;&gt; 
&gt;&gt; 10?
&gt; 
&gt; This is so that when there are many commits at once or something goes wrong, we don&apos;t end up spamming IRC with hundreds of messages.

OK.  Can you use a named constant and explain the &quot;why&quot; with a comment?

&gt;&gt;&gt; Tools/Scripts/webkitpy/tool/commands/newcommitbot.py:85
&gt;&gt;&gt; +                continue
&gt;&gt; 
&gt;&gt; What is this looking for?
&gt; 
&gt; It&apos;s looking for empty entries that&apos;s filled with -------...
&gt; You get this when someone commits into branches.

Can you add a helper function with a descriptive name so that folks reading this code know what its supposed to do?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>836759</commentid>
    <comment_count>10</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2013-02-19 14:03:31 -0800</bug_when>
    <thetext>(In reply to comment #9)
&gt; (From update of attachment 188834 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=188834&amp;action=review
&gt; 
&gt; &gt;&gt;&gt; Tools/Scripts/webkitpy/tool/commands/newcommitbot.py:79
&gt; &gt;&gt;&gt; +        for revision in range(self._last_svn_revision + 1, self._last_svn_revision + 10):
&gt; &gt;&gt; 
&gt; &gt;&gt; 10?
&gt; &gt; 
&gt; &gt; This is so that when there are many commits at once or something goes wrong, we don&apos;t end up spamming IRC with hundreds of messages.
&gt; 
&gt; OK.  Can you use a named constant and explain the &quot;why&quot; with a comment?

I&apos;ll add a named variable like _maximum_number_of_revisions_to_avoid_spamming_irc to avoid adding a comment.

&gt; &gt;&gt;&gt; Tools/Scripts/webkitpy/tool/commands/newcommitbot.py:85
&gt; &gt;&gt;&gt; +                continue
&gt; &gt;&gt; 
&gt; &gt;&gt; What is this looking for?
&gt; &gt; 
&gt; &gt; It&apos;s looking for empty entries that&apos;s filled with -------...
&gt; &gt; You get this when someone commits into branches.
&gt; 
&gt; Can you add a helper function with a descriptive name so that folks reading this code know what its supposed to do?

Sure. _is_empty_log?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>836765</commentid>
    <comment_count>11</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2013-02-19 14:08:03 -0800</bug_when>
    <thetext>Sure.  Those names sound fine.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>871479</commentid>
    <comment_count>12</comment_count>
      <attachid>197004</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2013-04-08 23:39:37 -0700</bug_when>
    <thetext>Created attachment 197004
Fixed per comments</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>871480</commentid>
    <comment_count>13</comment_count>
      <attachid>197004</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2013-04-08 23:41:27 -0700</bug_when>
    <thetext>Comment on attachment 197004
Fixed per comments

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>871482</commentid>
    <comment_count>14</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2013-04-08 23:43:22 -0700</bug_when>
    <thetext>Committed r147984: &lt;http://trac.webkit.org/changeset/147984&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>188816</attachid>
            <date>2013-02-18 01:17:42 -0800</date>
            <delta_ts>2013-02-18 01:21:19 -0800</delta_ts>
            <desc>Use svn log -r without updating checkout</desc>
            <filename>bug-110087-20130218011405.patch</filename>
            <type>text/plain</type>
            <size>3760</size>
            <attacher name="Ryosuke Niwa">rniwa</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDE0MzE2NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE5IEBACisyMDEzLTAyLTE4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor
CisgICAgICAgIFdLUiAobmV3LWNvbW1pdC1ib3QpIGlzIHRvbyBzbG93CisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTAwODcKKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSdW5uaW5nICJzdm4gdXAiIG9yICJn
aXQgc3ZuIGZldGNoIiBpcyB3YXkgdG9vIHNsb3cgKHRha2VzIDItMyBtaW51dGVzKSBvbiB0aGUg
bWFjaGluZSBJJ20gcnVubmluZyB0aGUgYm90LgorICAgICAgICBKdXN0IHJ1biAic3ZuIGxvZyAt
ciA8cmV2aXNpb24+IiBpbnN0ZWFkIHRvIGN1dCBkb3duIHRoZSBkZWxheS4KKworICAgICAgICBV
bmZvcnR1bmF0ZWx5LCB0aGlzIHdvcmsgYXJvdW5kIGRvZXNuJ3Qgd29yayBpbiBhIGdpdCBjaGVj
a291dCBidXQgd2hvIGNhcmVzIGdpdmVuIEknbSB0aGUgb25lIHJ1bm5pbmcgdGhlIGJvdC4KKwor
ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9uZXdjb21taXRib3QucHk6
CisgICAgICAgIChOZXdDb21taXRCb3QubmV4dF93b3JrX2l0ZW0pOgorICAgICAgICAoTmV3Q29t
bWl0Qm90Ll91cGRhdGVfY2hlY2tvdXQpOgorCiAyMDEzLTAyLTE4ICBSeW9zdWtlIE5pd2EgIDxy
bml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFdLUiBidWlsZCBmaXguIEFsd2F5cyB1c2UgYXNj
aWkgc2luY2UgaXJjbGliL2lyY2JvdCBkb2Vzbid0IHN1cHBvcnQgdW5pY29kZS4KSW5kZXg6IFRv
b2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9uZXdjb21taXRib3QucHkKPT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL25ld2NvbW1pdGJv
dC5weQkocmV2aXNpb24gMTQzMTUzKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2Nv
bW1hbmRzL25ld2NvbW1pdGJvdC5weQkod29ya2luZyBjb3B5KQpAQCAtMzEsNiArMzEsNyBAQCBp
bXBvcnQgbG9nZ2luZwogaW1wb3J0IHJlCiAKIGZyb20gd2Via2l0cHkuY29tbW9uLmNvbmZpZy5j
b21taXR0ZXJzIGltcG9ydCBDb21taXR0ZXJMaXN0Citmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0
ZW0uZXhlY3V0aXZlIGltcG9ydCBTY3JpcHRFcnJvcgogZnJvbSB3ZWJraXRweS50b29sLmJvdC5p
cmNfY29tbWFuZCBpbXBvcnQgSVJDQ29tbWFuZAogZnJvbSB3ZWJraXRweS50b29sLmJvdC5pcmNf
Y29tbWFuZCBpbXBvcnQgSGVscAogZnJvbSB3ZWJraXRweS50b29sLmJvdC5pcmNfY29tbWFuZCBp
bXBvcnQgSGkKQEAgLTcyLDE2ICs3MywyMCBAQCBjbGFzcyBOZXdDb21taXRCb3QoQWJzdHJhY3RR
dWV1ZSwgU3RlcFNlCiAKICAgICAgICAgX2xvZy5pbmZvKCdMYXN0IFNWTiByZXZpc2lvbjogJWQn
ICUgc2VsZi5fbGFzdF9zdm5fcmV2aXNpb24pCiAKLSAgICAgICAgX2xvZy5pbmZvKCdVcGRhdGlu
ZyBjaGVja291dCcpCi0gICAgICAgIHNlbGYuX3VwZGF0ZV9jaGVja291dCgpCisgICAgICAgIGlm
IHNlbGYuX3Rvb2wuc2NtKCkuZXhlY3V0YWJsZV9uYW1lICE9ICdzdm4nOgorICAgICAgICAgICAg
X2xvZy5lcnJvcignVGhpcyBib3Qgb25seSB3b3JrcyBpbnNpZGUgYSBTVk4gY2hlY2tvdXQnKQog
Ci0gICAgICAgIF9sb2cuaW5mbygnT2J0YWluaW5nIG5ldyBTVk4gcmV2aXNpb25zJykKLSAgICAg
ICAgcmV2aXNpb25zID0gc2VsZi5fbmV3X3N2bl9yZXZpc2lvbnMoKQotCi0gICAgICAgIF9sb2cu
aW5mbygnT2J0YWluaW5nIGNvbW1pdCBsb2dzIGZvciAlZCByZXZpc2lvbnMnICUgbGVuKHJldmlz
aW9ucykpCi0gICAgICAgIGZvciByZXZpc2lvbiBpbiByZXZpc2lvbnM6Ci0gICAgICAgICAgICBj
b21taXRfbG9nID0gc2VsZi5fdG9vbC5zY20oKS5zdm5fY29tbWl0X2xvZyhyZXZpc2lvbikKLSAg
ICAgICAgICAgIHNlbGYuX3Rvb2wuaXJjKCkucG9zdChzZWxmLl9zdW1tYXJpemVfY29tbWl0X2xv
Zyhjb21taXRfbG9nKSkKKyAgICAgICAgZm9yIHJldmlzaW9uIGluIHJhbmdlKHNlbGYuX2xhc3Rf
c3ZuX3JldmlzaW9uICsgMSwgc2VsZi5fbGFzdF9zdm5fcmV2aXNpb24gKyAxMCk6CisgICAgICAg
ICAgICB0cnk6CisgICAgICAgICAgICAgICAgY29tbWl0X2xvZyA9IHNlbGYuX3Rvb2wuc2NtKCku
c3ZuX2NvbW1pdF9sb2cocmV2aXNpb24pCisgICAgICAgICAgICBleGNlcHQgU2NyaXB0RXJyb3I6
CisgICAgICAgICAgICAgICAgYnJlYWsKKyAgICAgICAgICAgIGlmIHJlLm1hdGNoKHInXlwtKyQn
LCBjb21taXRfbG9nKToKKyAgICAgICAgICAgICAgICBjb250aW51ZQorICAgICAgICAgICAgX2xv
Zy5pbmZvKCdGb3VuZCByZXZpc2lvbiAlZCcgJSByZXZpc2lvbikKKyAgICAgICAgICAgIHNlbGYu
X2xhc3Rfc3ZuX3JldmlzaW9uID0gcmV2aXNpb24KKyAgICAgICAgICAgIHNlbGYuX3Rvb2wuaXJj
KCkucG9zdChzZWxmLl9zdW1tYXJpemVfY29tbWl0X2xvZyhjb21taXRfbG9nKS5lbmNvZGUoJ2Fz
Y2lpJywgJ2lnbm9yZScpKQorICAgICAgICAgICAgcmV2aXNpb24gKz0gMQogCiAgICAgICAgIHJl
dHVybgogCkBAIC05MiwxMyArOTcsNiBAQCBjbGFzcyBOZXdDb21taXRCb3QoQWJzdHJhY3RRdWV1
ZSwgU3RlcFNlCiAgICAgICAgIHRvb2wgPSBzZWxmLl90b29sCiAgICAgICAgIHRvb2wuZXhlY3V0
aXZlLnJ1bl9hbmRfdGhyb3dfaWZfZmFpbCh0b29sLmRlcHJlY2F0ZWRfcG9ydCgpLnVwZGF0ZV93
ZWJraXRfY29tbWFuZCgpLCBxdWlldD1UcnVlLCBjd2Q9dG9vbC5zY20oKS5jaGVja291dF9yb290
KQogCi0gICAgZGVmIF9uZXdfc3ZuX3JldmlzaW9ucyhzZWxmKToKLSAgICAgICAgc2NtID0gc2Vs
Zi5fdG9vbC5zY20oKQotICAgICAgICBjdXJyZW50X2hlYWQgPSBpbnQoc2NtLmhlYWRfc3ZuX3Jl
dmlzaW9uKCkpCi0gICAgICAgIGZpcnN0X25ld19yZXZpc2lvbiA9IHNlbGYuX2xhc3Rfc3ZuX3Jl
dmlzaW9uICsgMQotICAgICAgICBzZWxmLl9sYXN0X3N2bl9yZXZpc2lvbiA9IGN1cnJlbnRfaGVh
ZAotICAgICAgICByZXR1cm4gcmFuZ2UobWF4KGZpcnN0X25ld19yZXZpc2lvbiwgY3VycmVudF9o
ZWFkIC0gMjApLCBjdXJyZW50X2hlYWQgKyAxKQotCiAgICAgX3BhdGNoX2J5X3JlZ2V4ID0gcmUu
Y29tcGlsZShyJ15QYXRjaFxzK2J5XHMrKD9QPGF1dGhvcj4uKz8pXHMrb24oXHMrXGR7NH0tXGR7
Mn0tXGR7Mn0pP1xuPycsIHJlLk1VTFRJTElORSB8IHJlLklHTk9SRUNBU0UpCiAgICAgX3JvbGxv
dXRfcmVnZXggPSByZS5jb21waWxlKHInKHJvbGxpbmcgb3V0fHJldmVydGluZykgKD9QPHJldmlz
aW9ucz5yP1xkKygoLFxzKnwsP1xzKmFuZFxzKyk/cj9cZCspKilcLj9ccyonLCByZS5NVUxUSUxJ
TkUgfCByZS5JR05PUkVDQVNFKQogICAgIF9yZXF1ZXN0ZWRfYnlfcmVnZXggPSByZS5jb21waWxl
KHInXlwiPyg/UDxyZWFzb24+Lis/KVwiPyBcKFJlcXVlc3RlZFxzK2J5XHMrKD9QPGF1dGhvcj4u
Kz8pXHMrb25ccysjd2Via2l0XClcLicsIHJlLk1VTFRJTElORSB8IHJlLklHTk9SRUNBU0UpCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>188817</attachid>
            <date>2013-02-18 01:21:21 -0800</date>
            <delta_ts>2013-02-18 02:31:58 -0800</delta_ts>
            <desc>Merged ToT</desc>
            <filename>bug-110087-20130218011745.patch</filename>
            <type>text/plain</type>
            <size>3685</size>
            <attacher name="Ryosuke Niwa">rniwa</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDE0MzE2NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE5IEBACisyMDEzLTAyLTE4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor
CisgICAgICAgIFdLUiAobmV3LWNvbW1pdC1ib3QpIGlzIHRvbyBzbG93CisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTAwODcKKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSdW5uaW5nICJzdm4gdXAiIG9yICJn
aXQgc3ZuIGZldGNoIiBpcyB3YXkgdG9vIHNsb3cgKHRha2VzIDItMyBtaW51dGVzKSBvbiB0aGUg
bWFjaGluZSBJJ20gcnVubmluZyB0aGUgYm90LgorICAgICAgICBKdXN0IHJ1biAic3ZuIGxvZyAt
ciA8cmV2aXNpb24+IiBpbnN0ZWFkIHRvIGN1dCBkb3duIHRoZSBkZWxheS4KKworICAgICAgICBV
bmZvcnR1bmF0ZWx5LCB0aGlzIHdvcmsgYXJvdW5kIGRvZXNuJ3Qgd29yayBpbiBhIGdpdCBjaGVj
a291dCBidXQgd2hvIGNhcmVzIGdpdmVuIEknbSB0aGUgb25lIHJ1bm5pbmcgdGhlIGJvdC4KKwor
ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9uZXdjb21taXRib3QucHk6
CisgICAgICAgIChOZXdDb21taXRCb3QubmV4dF93b3JrX2l0ZW0pOgorICAgICAgICAoTmV3Q29t
bWl0Qm90Ll91cGRhdGVfY2hlY2tvdXQpOgorCiAyMDEzLTAyLTE4ICBSeW9zdWtlIE5pd2EgIDxy
bml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFdLUiBidWlsZCBmaXguIEFsd2F5cyB1c2UgYXNj
aWkgc2luY2UgaXJjbGliL2lyY2JvdCBkb2Vzbid0IHN1cHBvcnQgdW5pY29kZS4KSW5kZXg6IFRv
b2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9uZXdjb21taXRib3QucHkKPT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL25ld2NvbW1pdGJv
dC5weQkocmV2aXNpb24gMTQzMTY5KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2Nv
bW1hbmRzL25ld2NvbW1pdGJvdC5weQkod29ya2luZyBjb3B5KQpAQCAtMzEsNiArMzEsNyBAQCBp
bXBvcnQgbG9nZ2luZwogaW1wb3J0IHJlCiAKIGZyb20gd2Via2l0cHkuY29tbW9uLmNvbmZpZy5j
b21taXR0ZXJzIGltcG9ydCBDb21taXR0ZXJMaXN0Citmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0
ZW0uZXhlY3V0aXZlIGltcG9ydCBTY3JpcHRFcnJvcgogZnJvbSB3ZWJraXRweS50b29sLmJvdC5p
cmNfY29tbWFuZCBpbXBvcnQgSVJDQ29tbWFuZAogZnJvbSB3ZWJraXRweS50b29sLmJvdC5pcmNf
Y29tbWFuZCBpbXBvcnQgSGVscAogZnJvbSB3ZWJraXRweS50b29sLmJvdC5pcmNfY29tbWFuZCBp
bXBvcnQgSGkKQEAgLTcyLDE2ICs3MywyMCBAQCBjbGFzcyBOZXdDb21taXRCb3QoQWJzdHJhY3RR
dWV1ZSwgU3RlcFNlCiAKICAgICAgICAgX2xvZy5pbmZvKCdMYXN0IFNWTiByZXZpc2lvbjogJWQn
ICUgc2VsZi5fbGFzdF9zdm5fcmV2aXNpb24pCiAKLSAgICAgICAgX2xvZy5pbmZvKCdVcGRhdGlu
ZyBjaGVja291dCcpCi0gICAgICAgIHNlbGYuX3VwZGF0ZV9jaGVja291dCgpCisgICAgICAgIGlm
IHNlbGYuX3Rvb2wuc2NtKCkuZXhlY3V0YWJsZV9uYW1lICE9ICdzdm4nOgorICAgICAgICAgICAg
X2xvZy5lcnJvcignVGhpcyBib3Qgb25seSB3b3JrcyBpbnNpZGUgYSBTVk4gY2hlY2tvdXQnKQog
Ci0gICAgICAgIF9sb2cuaW5mbygnT2J0YWluaW5nIG5ldyBTVk4gcmV2aXNpb25zJykKLSAgICAg
ICAgcmV2aXNpb25zID0gc2VsZi5fbmV3X3N2bl9yZXZpc2lvbnMoKQotCi0gICAgICAgIF9sb2cu
aW5mbygnT2J0YWluaW5nIGNvbW1pdCBsb2dzIGZvciAlZCByZXZpc2lvbnMnICUgbGVuKHJldmlz
aW9ucykpCi0gICAgICAgIGZvciByZXZpc2lvbiBpbiByZXZpc2lvbnM6Ci0gICAgICAgICAgICBj
b21taXRfbG9nID0gc2VsZi5fdG9vbC5zY20oKS5zdm5fY29tbWl0X2xvZyhyZXZpc2lvbikKKyAg
ICAgICAgZm9yIHJldmlzaW9uIGluIHJhbmdlKHNlbGYuX2xhc3Rfc3ZuX3JldmlzaW9uICsgMSwg
c2VsZi5fbGFzdF9zdm5fcmV2aXNpb24gKyAxMCk6CisgICAgICAgICAgICB0cnk6CisgICAgICAg
ICAgICAgICAgY29tbWl0X2xvZyA9IHNlbGYuX3Rvb2wuc2NtKCkuc3ZuX2NvbW1pdF9sb2cocmV2
aXNpb24pCisgICAgICAgICAgICBleGNlcHQgU2NyaXB0RXJyb3I6CisgICAgICAgICAgICAgICAg
YnJlYWsKKyAgICAgICAgICAgIGlmIHJlLm1hdGNoKHInXlwtKyQnLCBjb21taXRfbG9nKToKKyAg
ICAgICAgICAgICAgICBjb250aW51ZQorICAgICAgICAgICAgX2xvZy5pbmZvKCdGb3VuZCByZXZp
c2lvbiAlZCcgJSByZXZpc2lvbikKKyAgICAgICAgICAgIHNlbGYuX2xhc3Rfc3ZuX3JldmlzaW9u
ID0gcmV2aXNpb24KICAgICAgICAgICAgIHNlbGYuX3Rvb2wuaXJjKCkucG9zdChzZWxmLl9zdW1t
YXJpemVfY29tbWl0X2xvZyhjb21taXRfbG9nKS5lbmNvZGUoJ2FzY2lpJywgJ2lnbm9yZScpKQor
ICAgICAgICAgICAgcmV2aXNpb24gKz0gMQogCiAgICAgICAgIHJldHVybgogCkBAIC05MiwxMyAr
OTcsNiBAQCBjbGFzcyBOZXdDb21taXRCb3QoQWJzdHJhY3RRdWV1ZSwgU3RlcFNlCiAgICAgICAg
IHRvb2wgPSBzZWxmLl90b29sCiAgICAgICAgIHRvb2wuZXhlY3V0aXZlLnJ1bl9hbmRfdGhyb3df
aWZfZmFpbCh0b29sLmRlcHJlY2F0ZWRfcG9ydCgpLnVwZGF0ZV93ZWJraXRfY29tbWFuZCgpLCBx
dWlldD1UcnVlLCBjd2Q9dG9vbC5zY20oKS5jaGVja291dF9yb290KQogCi0gICAgZGVmIF9uZXdf
c3ZuX3JldmlzaW9ucyhzZWxmKToKLSAgICAgICAgc2NtID0gc2VsZi5fdG9vbC5zY20oKQotICAg
ICAgICBjdXJyZW50X2hlYWQgPSBpbnQoc2NtLmhlYWRfc3ZuX3JldmlzaW9uKCkpCi0gICAgICAg
IGZpcnN0X25ld19yZXZpc2lvbiA9IHNlbGYuX2xhc3Rfc3ZuX3JldmlzaW9uICsgMQotICAgICAg
ICBzZWxmLl9sYXN0X3N2bl9yZXZpc2lvbiA9IGN1cnJlbnRfaGVhZAotICAgICAgICByZXR1cm4g
cmFuZ2UobWF4KGZpcnN0X25ld19yZXZpc2lvbiwgY3VycmVudF9oZWFkIC0gMjApLCBjdXJyZW50
X2hlYWQgKyAxKQotCiAgICAgX3BhdGNoX2J5X3JlZ2V4ID0gcmUuY29tcGlsZShyJ15QYXRjaFxz
K2J5XHMrKD9QPGF1dGhvcj4uKz8pXHMrb24oXHMrXGR7NH0tXGR7Mn0tXGR7Mn0pP1xuPycsIHJl
Lk1VTFRJTElORSB8IHJlLklHTk9SRUNBU0UpCiAgICAgX3JvbGxvdXRfcmVnZXggPSByZS5jb21w
aWxlKHInKHJvbGxpbmcgb3V0fHJldmVydGluZykgKD9QPHJldmlzaW9ucz5yP1xkKygoLFxzKnws
P1xzKmFuZFxzKyk/cj9cZCspKilcLj9ccyonLCByZS5NVUxUSUxJTkUgfCByZS5JR05PUkVDQVNF
KQogICAgIF9yZXF1ZXN0ZWRfYnlfcmVnZXggPSByZS5jb21waWxlKHInXlwiPyg/UDxyZWFzb24+
Lis/KVwiPyBcKFJlcXVlc3RlZFxzK2J5XHMrKD9QPGF1dGhvcj4uKz8pXHMrb25ccysjd2Via2l0
XClcLicsIHJlLk1VTFRJTElORSB8IHJlLklHTk9SRUNBU0UpCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>188834</attachid>
            <date>2013-02-18 02:32:01 -0800</date>
            <delta_ts>2013-04-08 23:39:33 -0700</delta_ts>
            <desc>Also use utf-8 encoding</desc>
            <filename>bug-110087-20130218022824.patch</filename>
            <type>text/plain</type>
            <size>3744</size>
            <attacher name="Ryosuke Niwa">rniwa</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDE0MzE3OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE5IEBACisyMDEzLTAyLTE4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor
CisgICAgICAgIFdLUiAobmV3LWNvbW1pdC1ib3QpIGlzIHRvbyBzbG93CisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTAwODcKKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSdW5uaW5nICJzdm4gdXAiIG9yICJn
aXQgc3ZuIGZldGNoIiBpcyB3YXkgdG9vIHNsb3cgKHRha2VzIDItMyBtaW51dGVzKSBvbiB0aGUg
bWFjaGluZSBJJ20gcnVubmluZyB0aGUgYm90LgorICAgICAgICBKdXN0IHJ1biAic3ZuIGxvZyAt
ciA8cmV2aXNpb24+IiBpbnN0ZWFkIHRvIGN1dCBkb3duIHRoZSBkZWxheS4KKworICAgICAgICBV
bmZvcnR1bmF0ZWx5LCB0aGlzIHdvcmsgYXJvdW5kIGRvZXNuJ3Qgd29yayBpbiBhIGdpdCBjaGVj
a291dCBidXQgd2hvIGNhcmVzIGdpdmVuIEknbSB0aGUgb25lIHJ1bm5pbmcgdGhlIGJvdC4KKwor
ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9uZXdjb21taXRib3QucHk6
CisgICAgICAgIChOZXdDb21taXRCb3QubmV4dF93b3JrX2l0ZW0pOgorICAgICAgICAoTmV3Q29t
bWl0Qm90Ll91cGRhdGVfY2hlY2tvdXQpOgorCiAyMDEzLTAyLTE4ICBab2x0YW4gQXJ2YWkgIDx6
YXJ2YWlAaW5mLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIFVucmV2aWV3ZWQuIEFkZCBteXNlbGYg
YXMgYSBjb21taXR0ZXIuCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFu
ZHMvbmV3Y29tbWl0Ym90LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv
dG9vbC9jb21tYW5kcy9uZXdjb21taXRib3QucHkJKHJldmlzaW9uIDE0MzE3OSkKKysrIFRvb2xz
L1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9uZXdjb21taXRib3QucHkJKHdvcmtpbmcg
Y29weSkKQEAgLTMxLDYgKzMxLDcgQEAgaW1wb3J0IGxvZ2dpbmcKIGltcG9ydCByZQogCiBmcm9t
IHdlYmtpdHB5LmNvbW1vbi5jb25maWcuY29tbWl0dGVycyBpbXBvcnQgQ29tbWl0dGVyTGlzdAor
ZnJvbSB3ZWJraXRweS5jb21tb24uc3lzdGVtLmV4ZWN1dGl2ZSBpbXBvcnQgU2NyaXB0RXJyb3IK
IGZyb20gd2Via2l0cHkudG9vbC5ib3QuaXJjX2NvbW1hbmQgaW1wb3J0IElSQ0NvbW1hbmQKIGZy
b20gd2Via2l0cHkudG9vbC5ib3QuaXJjX2NvbW1hbmQgaW1wb3J0IEhlbHAKIGZyb20gd2Via2l0
cHkudG9vbC5ib3QuaXJjX2NvbW1hbmQgaW1wb3J0IEhpCkBAIC03MiwxNiArNzMsMjAgQEAgY2xh
c3MgTmV3Q29tbWl0Qm90KEFic3RyYWN0UXVldWUsIFN0ZXBTZQogCiAgICAgICAgIF9sb2cuaW5m
bygnTGFzdCBTVk4gcmV2aXNpb246ICVkJyAlIHNlbGYuX2xhc3Rfc3ZuX3JldmlzaW9uKQogCi0g
ICAgICAgIF9sb2cuaW5mbygnVXBkYXRpbmcgY2hlY2tvdXQnKQotICAgICAgICBzZWxmLl91cGRh
dGVfY2hlY2tvdXQoKQorICAgICAgICBpZiBzZWxmLl90b29sLnNjbSgpLmV4ZWN1dGFibGVfbmFt
ZSAhPSAnc3ZuJzoKKyAgICAgICAgICAgIF9sb2cuZXJyb3IoJ1RoaXMgYm90IG9ubHkgd29ya3Mg
aW5zaWRlIGEgU1ZOIGNoZWNrb3V0JykKIAotICAgICAgICBfbG9nLmluZm8oJ09idGFpbmluZyBu
ZXcgU1ZOIHJldmlzaW9ucycpCi0gICAgICAgIHJldmlzaW9ucyA9IHNlbGYuX25ld19zdm5fcmV2
aXNpb25zKCkKLQotICAgICAgICBfbG9nLmluZm8oJ09idGFpbmluZyBjb21taXQgbG9ncyBmb3Ig
JWQgcmV2aXNpb25zJyAlIGxlbihyZXZpc2lvbnMpKQotICAgICAgICBmb3IgcmV2aXNpb24gaW4g
cmV2aXNpb25zOgotICAgICAgICAgICAgY29tbWl0X2xvZyA9IHNlbGYuX3Rvb2wuc2NtKCkuc3Zu
X2NvbW1pdF9sb2cocmV2aXNpb24pCi0gICAgICAgICAgICBzZWxmLl90b29sLmlyYygpLnBvc3Qo
c2VsZi5fc3VtbWFyaXplX2NvbW1pdF9sb2coY29tbWl0X2xvZykuZW5jb2RlKCdhc2NpaScsICdp
Z25vcmUnKSkKKyAgICAgICAgZm9yIHJldmlzaW9uIGluIHJhbmdlKHNlbGYuX2xhc3Rfc3ZuX3Jl
dmlzaW9uICsgMSwgc2VsZi5fbGFzdF9zdm5fcmV2aXNpb24gKyAxMCk6CisgICAgICAgICAgICB0
cnk6CisgICAgICAgICAgICAgICAgY29tbWl0X2xvZyA9IHNlbGYuX3Rvb2wuc2NtKCkuc3ZuX2Nv
bW1pdF9sb2cocmV2aXNpb24pCisgICAgICAgICAgICBleGNlcHQgU2NyaXB0RXJyb3I6CisgICAg
ICAgICAgICAgICAgYnJlYWsKKyAgICAgICAgICAgIGlmIHJlLm1hdGNoKHInXlwtKyQnLCBjb21t
aXRfbG9nKToKKyAgICAgICAgICAgICAgICBjb250aW51ZQorICAgICAgICAgICAgX2xvZy5pbmZv
KCdGb3VuZCByZXZpc2lvbiAlZCcgJSByZXZpc2lvbikKKyAgICAgICAgICAgIHNlbGYuX2xhc3Rf
c3ZuX3JldmlzaW9uID0gcmV2aXNpb24KKyAgICAgICAgICAgIHNlbGYuX3Rvb2wuaXJjKCkucG9z
dChzZWxmLl9zdW1tYXJpemVfY29tbWl0X2xvZyhjb21taXRfbG9nKS5lbmNvZGUoJ3V0Zi04Jykp
CisgICAgICAgICAgICByZXZpc2lvbiArPSAxCiAKICAgICAgICAgcmV0dXJuCiAKQEAgLTkyLDEz
ICs5Nyw2IEBAIGNsYXNzIE5ld0NvbW1pdEJvdChBYnN0cmFjdFF1ZXVlLCBTdGVwU2UKICAgICAg
ICAgdG9vbCA9IHNlbGYuX3Rvb2wKICAgICAgICAgdG9vbC5leGVjdXRpdmUucnVuX2FuZF90aHJv
d19pZl9mYWlsKHRvb2wuZGVwcmVjYXRlZF9wb3J0KCkudXBkYXRlX3dlYmtpdF9jb21tYW5kKCks
IHF1aWV0PVRydWUsIGN3ZD10b29sLnNjbSgpLmNoZWNrb3V0X3Jvb3QpCiAKLSAgICBkZWYgX25l
d19zdm5fcmV2aXNpb25zKHNlbGYpOgotICAgICAgICBzY20gPSBzZWxmLl90b29sLnNjbSgpCi0g
ICAgICAgIGN1cnJlbnRfaGVhZCA9IGludChzY20uaGVhZF9zdm5fcmV2aXNpb24oKSkKLSAgICAg
ICAgZmlyc3RfbmV3X3JldmlzaW9uID0gc2VsZi5fbGFzdF9zdm5fcmV2aXNpb24gKyAxCi0gICAg
ICAgIHNlbGYuX2xhc3Rfc3ZuX3JldmlzaW9uID0gY3VycmVudF9oZWFkCi0gICAgICAgIHJldHVy
biByYW5nZShtYXgoZmlyc3RfbmV3X3JldmlzaW9uLCBjdXJyZW50X2hlYWQgLSAyMCksIGN1cnJl
bnRfaGVhZCArIDEpCi0KICAgICBfcGF0Y2hfYnlfcmVnZXggPSByZS5jb21waWxlKHInXlBhdGNo
XHMrYnlccysoP1A8YXV0aG9yPi4rPylccytvbihccytcZHs0fS1cZHsyfS1cZHsyfSk/XG4/Jywg
cmUuTVVMVElMSU5FIHwgcmUuSUdOT1JFQ0FTRSkKICAgICBfcm9sbG91dF9yZWdleCA9IHJlLmNv
bXBpbGUocicocm9sbGluZyBvdXR8cmV2ZXJ0aW5nKSAoP1A8cmV2aXNpb25zPnI/XGQrKCgsXHMq
fCw/XHMqYW5kXHMrKT9yP1xkKykqKVwuP1xzKicsIHJlLk1VTFRJTElORSB8IHJlLklHTk9SRUNB
U0UpCiAgICAgX3JlcXVlc3RlZF9ieV9yZWdleCA9IHJlLmNvbXBpbGUocideXCI/KD9QPHJlYXNv
bj4uKz8pXCI/IFwoUmVxdWVzdGVkXHMrYnlccysoP1A8YXV0aG9yPi4rPylccytvblxzKyN3ZWJr
aXRcKVwuJywgcmUuTVVMVElMSU5FIHwgcmUuSUdOT1JFQ0FTRSkK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>197004</attachid>
            <date>2013-04-08 23:39:37 -0700</date>
            <delta_ts>2013-04-08 23:41:27 -0700</delta_ts>
            <desc>Fixed per comments</desc>
            <filename>bug-110087-20130408233923.patch</filename>
            <type>text/plain</type>
            <size>4218</size>
            <attacher name="Ryosuke Niwa">rniwa</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDE0Nzk4MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDIxIEBACisyMDEzLTA0LTA4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor
CisgICAgICAgIFdLUiAobmV3LWNvbW1pdC1ib3QpIGlzIHRvbyBzbG93CisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTAwODcKKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSdW5uaW5nICJzdm4gdXAiIG9yICJn
aXQgc3ZuIGZldGNoIiBpcyB3YXkgdG9vIHNsb3cgKHRha2VzIDItMyBtaW51dGVzKSBvbiB0aGUg
bWFjaGluZSBJJ20gcnVubmluZyB0aGUgYm90LgorICAgICAgICBKdXN0IHJ1biAic3ZuIGxvZyAt
ciA8cmV2aXNpb24+IiBpbnN0ZWFkIHRvIGN1dCBkb3duIHRoZSBkZWxheS4KKworICAgICAgICBV
bmZvcnR1bmF0ZWx5LCB0aGlzIHdvcmsgYXJvdW5kIGRvZXNuJ3Qgd29yayBpbiBhIGdpdCBjaGVj
a291dCBidXQgd2hvIGNhcmVzIGdpdmVuIEknbSB0aGUgb25lIHJ1bm5pbmcgdGhlIGJvdC4KKwor
ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9uZXdjb21taXRib3QucHk6
CisgICAgICAgIChOZXdDb21taXRCb3QpOgorICAgICAgICAoTmV3Q29tbWl0Qm90Lm5leHRfd29y
a19pdGVtKToKKyAgICAgICAgKE5ld0NvbW1pdEJvdC5faXNfZW1wdHlfbG9nKToKKyAgICAgICAg
KE5ld0NvbW1pdEJvdC5fdXBkYXRlX2NoZWNrb3V0KToKKwogMjAxMy0wNC0wOCAgUnlvc3VrZSBO
aXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBCdWlsZCBmaXguIENhbid0IHJlbW92
ZSBhcHBlbmRDdXN0b21CdWlsZEZsYWdzLgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS90
b29sL2NvbW1hbmRzL25ld2NvbW1pdGJvdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRz
L3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvbmV3Y29tbWl0Ym90LnB5CShyZXZpc2lvbiAxNDc5ODMp
CisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvbmV3Y29tbWl0Ym90LnB5
CSh3b3JraW5nIGNvcHkpCkBAIC0zMSw2ICszMSw3IEBAIGltcG9ydCBsb2dnaW5nCiBpbXBvcnQg
cmUKIAogZnJvbSB3ZWJraXRweS5jb21tb24uY29uZmlnLmNvbW1pdHRlcnMgaW1wb3J0IENvbW1p
dHRlckxpc3QKK2Zyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS5leGVjdXRpdmUgaW1wb3J0IFNj
cmlwdEVycm9yCiBmcm9tIHdlYmtpdHB5LnRvb2wuYm90LmlyY19jb21tYW5kIGltcG9ydCBJUkND
b21tYW5kCiBmcm9tIHdlYmtpdHB5LnRvb2wuYm90LmlyY19jb21tYW5kIGltcG9ydCBIZWxwCiBm
cm9tIHdlYmtpdHB5LnRvb2wuYm90LmlyY19jb21tYW5kIGltcG9ydCBIaQpAQCAtNTYsNiArNTcs
OCBAQCBjbGFzcyBOZXdDb21taXRCb3QoQWJzdHJhY3RRdWV1ZSwgU3RlcFNlCiAgICAgICAgICJy
ZXN0YXJ0IjogUmVzdGFydCwKICAgICB9CiAKKyAgICBfbWF4aW11bV9udW1iZXJfb2ZfcmV2aXNp
b25zX3RvX2F2b2lkX3NwYW1taW5nX2lyYyA9IDEwCisKICAgICAjIEFic3RyYWN0UXVldWUgbWV0
aG9kcwogCiAgICAgZGVmIGJlZ2luX3dvcmtfcXVldWUoc2VsZik6CkBAIC03MiwxOCArNzUsMjIg
QEAgY2xhc3MgTmV3Q29tbWl0Qm90KEFic3RyYWN0UXVldWUsIFN0ZXBTZQogCiAgICAgICAgIF9s
b2cuaW5mbygnTGFzdCBTVk4gcmV2aXNpb246ICVkJyAlIHNlbGYuX2xhc3Rfc3ZuX3JldmlzaW9u
KQogCi0gICAgICAgIF9sb2cuaW5mbygnVXBkYXRpbmcgY2hlY2tvdXQnKQotICAgICAgICBzZWxm
Ll91cGRhdGVfY2hlY2tvdXQoKQotCi0gICAgICAgIF9sb2cuaW5mbygnT2J0YWluaW5nIG5ldyBT
Vk4gcmV2aXNpb25zJykKLSAgICAgICAgcmV2aXNpb25zID0gc2VsZi5fbmV3X3N2bl9yZXZpc2lv
bnMoKQorICAgICAgICBpZiBzZWxmLl90b29sLnNjbSgpLmV4ZWN1dGFibGVfbmFtZSAhPSAnc3Zu
JzoKKyAgICAgICAgICAgIF9sb2cuZXJyb3IoJ1RoaXMgYm90IG9ubHkgd29ya3MgaW5zaWRlIGEg
U1ZOIGNoZWNrb3V0JykKIAotICAgICAgICBfbG9nLmluZm8oJ09idGFpbmluZyBjb21taXQgbG9n
cyBmb3IgJWQgcmV2aXNpb25zJyAlIGxlbihyZXZpc2lvbnMpKQotICAgICAgICBmb3IgcmV2aXNp
b24gaW4gcmV2aXNpb25zOgotICAgICAgICAgICAgY29tbWl0X2xvZyA9IHNlbGYuX3Rvb2wuc2Nt
KCkuc3ZuX2NvbW1pdF9sb2cocmV2aXNpb24pCi0gICAgICAgICAgICBzZWxmLl90b29sLmlyYygp
LnBvc3Qoc2VsZi5fc3VtbWFyaXplX2NvbW1pdF9sb2coY29tbWl0X2xvZykuZW5jb2RlKCdhc2Np
aScsICdpZ25vcmUnKSkKKyAgICAgICAgZm9yIHJldmlzaW9uIGluIHJhbmdlKHNlbGYuX2xhc3Rf
c3ZuX3JldmlzaW9uICsgMSwgc2VsZi5fbGFzdF9zdm5fcmV2aXNpb24gKyBzZWxmLl9tYXhpbXVt
X251bWJlcl9vZl9yZXZpc2lvbnNfdG9fYXZvaWRfc3BhbW1pbmdfaXJjKToKKyAgICAgICAgICAg
IHRyeToKKyAgICAgICAgICAgICAgICBjb21taXRfbG9nID0gc2VsZi5fdG9vbC5zY20oKS5zdm5f
Y29tbWl0X2xvZyhyZXZpc2lvbikKKyAgICAgICAgICAgIGV4Y2VwdCBTY3JpcHRFcnJvcjoKKyAg
ICAgICAgICAgICAgICBicmVhaworICAgICAgICAgICAgaWYgc2VsZi5faXNfZW1wdHlfbG9nKGNv
bW1pdF9sb2cpOgorICAgICAgICAgICAgICAgIGNvbnRpbnVlCisgICAgICAgICAgICBfbG9nLmlu
Zm8oJ0ZvdW5kIHJldmlzaW9uICVkJyAlIHJldmlzaW9uKQorICAgICAgICAgICAgc2VsZi5fbGFz
dF9zdm5fcmV2aXNpb24gPSByZXZpc2lvbgorICAgICAgICAgICAgc2VsZi5fdG9vbC5pcmMoKS5w
b3N0KHNlbGYuX3N1bW1hcml6ZV9jb21taXRfbG9nKGNvbW1pdF9sb2cpLmVuY29kZSgndXRmLTgn
KSkKIAotICAgICAgICByZXR1cm4KKyAgICBkZWYgX2lzX2VtcHR5X2xvZyhzZWxmLCBjb21taXRf
bG9nKToKKyAgICAgICAgcmV0dXJuIHJlLm1hdGNoKHInXlwtKyQnLCBjb21taXRfbG9nKQogCiAg
ICAgZGVmIHByb2Nlc3Nfd29ya19pdGVtKHNlbGYsIGZhaWx1cmVfbWFwKToKICAgICAgICAgcmV0
dXJuIFRydWUKQEAgLTkyLDEzICs5OSw2IEBAIGNsYXNzIE5ld0NvbW1pdEJvdChBYnN0cmFjdFF1
ZXVlLCBTdGVwU2UKICAgICAgICAgdG9vbCA9IHNlbGYuX3Rvb2wKICAgICAgICAgdG9vbC5leGVj
dXRpdmUucnVuX2FuZF90aHJvd19pZl9mYWlsKHRvb2wuZGVwcmVjYXRlZF9wb3J0KCkudXBkYXRl
X3dlYmtpdF9jb21tYW5kKCksIHF1aWV0PVRydWUsIGN3ZD10b29sLnNjbSgpLmNoZWNrb3V0X3Jv
b3QpCiAKLSAgICBkZWYgX25ld19zdm5fcmV2aXNpb25zKHNlbGYpOgotICAgICAgICBzY20gPSBz
ZWxmLl90b29sLnNjbSgpCi0gICAgICAgIGN1cnJlbnRfaGVhZCA9IGludChzY20uaGVhZF9zdm5f
cmV2aXNpb24oKSkKLSAgICAgICAgZmlyc3RfbmV3X3JldmlzaW9uID0gc2VsZi5fbGFzdF9zdm5f
cmV2aXNpb24gKyAxCi0gICAgICAgIHNlbGYuX2xhc3Rfc3ZuX3JldmlzaW9uID0gY3VycmVudF9o
ZWFkCi0gICAgICAgIHJldHVybiByYW5nZShtYXgoZmlyc3RfbmV3X3JldmlzaW9uLCBjdXJyZW50
X2hlYWQgLSAyMCksIGN1cnJlbnRfaGVhZCArIDEpCi0KICAgICBfcGF0Y2hfYnlfcmVnZXggPSBy
ZS5jb21waWxlKHInXlBhdGNoXHMrYnlccysoP1A8YXV0aG9yPi4rPylccytvbihccytcZHs0fS1c
ZHsyfS1cZHsyfSk/XG4/JywgcmUuTVVMVElMSU5FIHwgcmUuSUdOT1JFQ0FTRSkKICAgICBfcm9s
bG91dF9yZWdleCA9IHJlLmNvbXBpbGUocicocm9sbGluZyBvdXR8cmV2ZXJ0aW5nKSAoP1A8cmV2
aXNpb25zPnI/XGQrKCgsXHMqfCw/XHMqYW5kXHMrKT9yP1xkKykqKVwuP1xzKicsIHJlLk1VTFRJ
TElORSB8IHJlLklHTk9SRUNBU0UpCiAgICAgX3JlcXVlc3RlZF9ieV9yZWdleCA9IHJlLmNvbXBp
bGUocideXCI/KD9QPHJlYXNvbj4uKz8pXCI/IFwoUmVxdWVzdGVkXHMrYnlccysoP1A8YXV0aG9y
Pi4rPylccytvblxzKyN3ZWJraXRcKVwuJywgcmUuTVVMVElMSU5FIHwgcmUuSUdOT1JFQ0FTRSkK
</data>
<flag name="review"
          id="219152"
          type_id="1"
          status="+"
          setter="ggaren"
    />
          </attachment>
      

    </bug>

</bugzilla>