110059 2013-02-17 12:03:53 -0800 [EFL][WK2] compositing/layer-creation/fixed-position-out-of-view-scaled.html is flaky 2013-02-18 04:13:44 -0800 1 1 1 Unclassified WebKit WebKit BREWMP 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez dongseong.hwang cmarcelo dongseong.hwang kenneth luiz mikhail.pozdnyakov noam webkit.review.bot oldest_to_newest 835019 0 cdumez 2013-02-17 12:03:53 -0800 compositing/layer-creation/fixed-position-out-of-view-scaled.html sometimes crashes on the bots: crash log for WebKitTestRunner (pid 26034): STDOUT: <empty> STDERR: ASSERTION FAILED: m_fixedToViewport STDERR: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp(606) : void WebCore::TextureMapperLayer::setScrollPositionDeltaIfNeeded(const WebCore::FloatSize&) STDERR: 1 0x7fa8631ef93e WebCore::TextureMapperLayer::setScrollPositionDeltaIfNeeded(WebCore::FloatSize const&) STDERR: 2 0x7fa8631d4f0a WebCore::CoordinatedGraphicsScene::adjustPositionForFixedLayers() STDERR: 3 0x7fa8631d45c0 WebCore::CoordinatedGraphicsScene::paintToCurrentGLContext(WebCore::TransformationMatrix const&, float, WebCore::FloatRect const&, unsigned int) STDERR: 4 0x7fa85f8f130c EwkView::paintToCurrentGLContext() STDERR: 5 0x7fa85f8f1650 EwkView::displayTimerFired(WebCore::Timer<EwkView>*) STDERR: 6 0x7fa85f8f774c WebCore::Timer<EwkView>::fired() STDERR: 7 0x7fa86311d521 WebCore::ThreadTimers::sharedTimerFiredInternal() STDERR: 8 0x7fa86311d435 WebCore::ThreadTimers::sharedTimerFired() STDERR: 9 0x7fa863c9eba1 STDERR: 10 0x7fa85ea923de _ecore_timer_expired_call STDERR: 11 0x7fa85ea925ab _ecore_timer_expired_timers_call STDERR: 12 0x7fa85ea8f4b1 STDERR: 13 0x7fa85ea8fb47 ecore_main_loop_begin STDERR: 14 0x4363cb WTR::TestController::platformRunUntil(bool&, double) STDERR: 15 0x420214 WTR::TestController::runUntil(bool&, WTR::TestController::TimeoutDuration) STDERR: 16 0x427a09 WTR::TestInvocation::invoke() STDERR: 17 0x41ff34 WTR::TestController::runTest(char const*) STDERR: 18 0x42006d WTR::TestController::runTestingServerLoop() STDERR: 19 0x420107 WTR::TestController::run() STDERR: 20 0x41d7a5 WTR::TestController::TestController(int, char const**) STDERR: 21 0x436565 main STDERR: 22 0x7fa85d5ee76d __libc_start_main STDERR: 23 0x41c089 STDERR: ERROR: Thread name "com.apple.WebKit.ChildProcess.WatchDogQueue" is longer than 31 characters and will be truncated by Visual Studio STDERR: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WTF/wtf/Threading.cpp(78) : WTF::ThreadIdentifier WTF::createThread(WTF::ThreadFunction, void*, const char*) 835055 1 dongseong.hwang 2013-02-17 15:40:13 -0800 oops, thank you for reporting. 835056 2 188779 dongseong.hwang 2013-02-17 15:47:15 -0800 Created attachment 188779 Patch 835227 3 188779 kenneth 2013-02-18 01:35:56 -0800 Comment on attachment 188779 Patch You are not explaining why it is right to call the below code? Should the assert instead be moved into the if sentence? 835241 4 dongseong.hwang 2013-02-18 01:57:29 -0800 (In reply to comment #3) > (From update of attachment 188779 [details]) > You are not explaining why it is right to call the below code? Should the assert instead be moved into the if sentence? Only one client calls TextureMapperLayer::setScrollPositionDeltaIfNeeded(). void CoordinatedGraphicsScene::adjustPositionForFixedLayers() { ... LayerRawPtrMap::iterator end = m_fixedLayers.end(); for (LayerRawPtrMap::iterator it = m_fixedLayers.begin(); it != end; ++it) toTextureMapperLayer(it->value)->setScrollPositionDeltaIfNeeded(delta); } It means CoordinatedGraphicsScene calls setScrollPositionDeltaIfNeeded() if TextureMapperLayer is a fixed layer. So the assertion is correct except for a small moment between updating GraphicsLayer and synchronizing TextureMapperLayer. After Bug 108294, the assertion will be always correct because updating GraphicsLayer and synchronizing TextureMapperLayer will be performed together. Could I explain 'why it is right to call the below code' in changelog? 835248 5 cdumez 2013-02-18 02:03:12 -0800 Please unskip the test as well. 835268 6 188835 dongseong.hwang 2013-02-18 02:36:51 -0800 Created attachment 188835 Patch 835270 7 dongseong.hwang 2013-02-18 02:42:00 -0800 (In reply to comment #5) > Please unskip the test as well. yes. Assertion cannot go into if statement. 'if statement' does not check if this layer is fixed layer. 'if statement' checks if this layer is nested fixed layer. The assertion was created because we wanted to verify setScrollPositionDeltaIfNeeded() must be called when the layer is a fixed position layer. But the time gap between update and flush makes the assumption not always true. 835284 8 cdumez 2013-02-18 02:58:44 -0800 I had to skip compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html as well due to the same assertion. 835288 9 dongseong.hwang 2013-02-18 03:00:20 -0800 (In reply to comment #8) > I had to skip compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html as well due to the same assertion. Ah, thank you :) 835296 10 188841 dongseong.hwang 2013-02-18 03:05:56 -0800 Created attachment 188841 Patch 835319 11 188841 webkit.review.bot 2013-02-18 04:13:39 -0800 Comment on attachment 188841 Patch Clearing flags on attachment: 188841 Committed r143194: <http://trac.webkit.org/changeset/143194> 835320 12 webkit.review.bot 2013-02-18 04:13:44 -0800 All reviewed patches have been landed. Closing bug. 188779 2013-02-17 15:47:15 -0800 2013-02-18 02:36:47 -0800 Patch bug-110059-20130218084243.patch text/plain 2026 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyOTY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDkzZTVlNWE2MTdhN2U0 M2MyZGM2YTViNDBiMGE3ZWZmNDY5MGIyNy4uOWRlYjY4NGUxY2FkNWQ0ZTA0YWJmMWFlMWI4MzM5 NDFkM2I2ZDVmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAyLTE3ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIFtFRkxdW1dL Ml0gY29tcG9zaXRpbmcvbGF5ZXItY3JlYXRpb24vZml4ZWQtcG9zaXRpb24tb3V0LW9mLXZpZXct c2NhbGVkLmh0bWwgaXMgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExMDA1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFJlbW92ZSB0aGUgQVNTRVJUIGNoZWNrIGluIFRleHR1cmVNYXBwZXJMYXll ci4gV2hlbgorICAgICAgICBDb29yZGluYXRlZEdyYXBoaWNzU2NlbmU6OmFkanVzdFBvc2l0aW9u Rm9yRml4ZWRMYXllcnMoKSBjYWxscworICAgICAgICBUZXh0dXJlTWFwcGVyTGF5ZXI6OnNldFNj cm9sbFBvc2l0aW9uRGVsdGFJZk5lZWRlZCgpLCBUZXh0dXJlTWFwcGVyTGF5ZXIgY2FuIGJlCisg ICAgICAgIGEgbm9uLWZpeGVkIGVsZW1lbnQgbGF5ZXIsIGJlY2F1c2UgR3JhcGhpY3NMYXllclRl eHR1cmVNYXBwZXIgdXBkYXRlcworICAgICAgICBUZXh0dXJlTWFwcGVyTGF5ZXIgZHVyaW5nIGZs dXNoaW5nLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBw ZXJMYXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUZXh0dXJlTWFwcGVyTGF5ZXI6OnNldFNj cm9sbFBvc2l0aW9uRGVsdGFJZk5lZWRlZCk6CisKIDIwMTMtMDItMTQgIFl1cnkgU2VtaWtoYXRz a3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogYWx3YXlz IHNob3cgbWVtb3J5IHNpemUgaW4gTWIgb24gdGhlIG5hdGl2ZSBtZW1vcnkgZ3JhcGgKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFw cGVyTGF5ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1Rl eHR1cmVNYXBwZXJMYXllci5jcHAKaW5kZXggNjNhYzllZDU1MTMzNTJmY2QzOGE5OTkyMzBmYzU3 ZmFmM2VhYWM3My4uODhlYjNjZDFmZDk3ZjBmY2ZjMTExNzVkYWY4NjdhNTI1OGI5MThkMyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVN YXBwZXJMYXllci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4 bWFwL1RleHR1cmVNYXBwZXJMYXllci5jcHAKQEAgLTYwMyw3ICs2MDMsNiBAQCB2b2lkIFRleHR1 cmVNYXBwZXJMYXllcjo6c2V0U2Nyb2xsUG9zaXRpb25EZWx0YUlmTmVlZGVkKGNvbnN0IEZsb2F0 U2l6ZSYgZGVsdGEpCiAgICAgLy8gaW4gdGhlIHdlYiBwcm9jZXNzLiBXZSBhZGQgdGhpcyBkZWx0 YSB0byB0aGUgcG9zaXRpb24gb2YgZml4ZWQgbGF5ZXJzLCB0byBtYWtlCiAgICAgLy8gc3VyZSB0 aGF0IHRoZXkgZG8gbm90IG1vdmUgd2hpbGUgc2Nyb2xsaW5nLiBXZSBuZWVkIHRvIHJlc2V0IHRo aXMgZGVsdGEgdG8gZml4ZWQgbGF5ZXJzCiAgICAgLy8gdGhhdCBoYXZlIGFuIGFuY2VzdG9yIHdo aWNoIGlzIGFsc28gYSBmaXhlZCBsYXllciwgYmVjYXVzZSB0aGUgZGVsdGEgd2lsbCBiZSBhZGRl ZCB0byB0aGUgYW5jZXN0b3IuCi0gICAgQVNTRVJUKG1fZml4ZWRUb1ZpZXdwb3J0KTsKICAgICBp ZiAoaXNBbmNlc3RvckZpeGVkVG9WaWV3cG9ydCgpKQogICAgICAgICBtX3Njcm9sbFBvc2l0aW9u RGVsdGEgPSBGbG9hdFNpemUoKTsKICAgICBlbHNlCg== 188835 2013-02-18 02:36:51 -0800 2013-02-18 03:05:51 -0800 Patch bug-110059-20130218193218.patch text/plain 2312 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzMTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGQ1MTMyYzEyM2ZlMjE4 NTk3MGZjNTM3ZTY5NWM3NmE4OGUyMjU3Yy4uMzczNjU2ZjE4OThmNTk2MjI5MTA2ODhmYTFlYmY5 OTgwOGVjYjU3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEzLTAyLTE4ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIFtFRkxdW1dL Ml0gY29tcG9zaXRpbmcvbGF5ZXItY3JlYXRpb24vZml4ZWQtcG9zaXRpb24tb3V0LW9mLXZpZXct c2NhbGVkLmh0bWwgaXMgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExMDA1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFJlbW92ZSB0aGUgQVNTRVJUIGNoZWNrIGluIFRleHR1cmVNYXBwZXJMYXll ci4gVGhpcyBhc3NlcnRpb24gc2VlbXMKKyAgICAgICAgdmFsaWQgYmVjYXVzZSBDb29yZGluYXRl ZEdyYXBoaWNzU2NlbmU6OmFkanVzdFBvc2l0aW9uRm9yRml4ZWRMYXllcnMoKSBjYWxscworICAg ICAgICBUZXh0dXJlTWFwcGVyTGF5ZXI6OnNldFNjcm9sbFBvc2l0aW9uRGVsdGFJZk5lZWRlZCgp IHdoZW4gdGhlIGdyYXBoaWNzCisgICAgICAgIGxheWVyIGlzIGEgZml4ZWQgcG9zaXRpb24gbGF5 ZXIuIEhvd2V2ZXIsIHRoZSBhc3NlcnRpb24gY2FuIGJlIGZhaWxlZAorICAgICAgICBiZWNhdXNl IGl0IGlzIHBvc3NpYmxlIHRoYXQgVGV4dHVyZU1hcHBlckxheWVyIGlzIGEgbm9uLWZpeGVkIHBv c2l0aW9uCisgICAgICAgIGxheWVyIHdoZW4gdGhlIGdyYXBoaWNzIGxheWVyIHRoYXQgaG9sZHMg dGhlIFRleHR1cmVNYXBwZXJMYXllciBpcyBhCisgICAgICAgIGZpeGVkIHBvc2l0aW9uIGxheWVy LiBXaGVuIENvb3JkaW5hdGVkR3JhcGhpY3NTY2VuZSBmbHVzaGVzLAorICAgICAgICBUZXh0dXJl TWFwcGVyTGF5ZXIgYmVjb21lcyBhIGZpeGVkIHBvc2l0aW9uIGxheWVyLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXllci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpUZXh0dXJlTWFwcGVyTGF5ZXI6OnNldFNjcm9sbFBvc2l0aW9uRGVsdGFJZk5lZWRlZCk6CisK IDIwMTMtMDItMTggIElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFVucmV2aWV3ZWQgc3BlY3VsYXRpdmUgZml4IGZvciBDaHJvbWl1bSBNYWMuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1h cHBlckxheWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9U ZXh0dXJlTWFwcGVyTGF5ZXIuY3BwCmluZGV4IDYzYWM5ZWQ1NTEzMzUyZmNkMzhhOTk5MjMwZmM1 N2ZhZjNlYWFjNzMuLjg4ZWIzY2QxZmQ5N2YwZmNmYzExMTc1ZGFmODY3YTUyNThiOTE4ZDMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJl TWFwcGVyTGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3Rl eG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuY3BwCkBAIC02MDMsNyArNjAzLDYgQEAgdm9pZCBUZXh0 dXJlTWFwcGVyTGF5ZXI6OnNldFNjcm9sbFBvc2l0aW9uRGVsdGFJZk5lZWRlZChjb25zdCBGbG9h dFNpemUmIGRlbHRhKQogICAgIC8vIGluIHRoZSB3ZWIgcHJvY2Vzcy4gV2UgYWRkIHRoaXMgZGVs dGEgdG8gdGhlIHBvc2l0aW9uIG9mIGZpeGVkIGxheWVycywgdG8gbWFrZQogICAgIC8vIHN1cmUg dGhhdCB0aGV5IGRvIG5vdCBtb3ZlIHdoaWxlIHNjcm9sbGluZy4gV2UgbmVlZCB0byByZXNldCB0 aGlzIGRlbHRhIHRvIGZpeGVkIGxheWVycwogICAgIC8vIHRoYXQgaGF2ZSBhbiBhbmNlc3RvciB3 aGljaCBpcyBhbHNvIGEgZml4ZWQgbGF5ZXIsIGJlY2F1c2UgdGhlIGRlbHRhIHdpbGwgYmUgYWRk ZWQgdG8gdGhlIGFuY2VzdG9yLgotICAgIEFTU0VSVChtX2ZpeGVkVG9WaWV3cG9ydCk7CiAgICAg aWYgKGlzQW5jZXN0b3JGaXhlZFRvVmlld3BvcnQoKSkKICAgICAgICAgbV9zY3JvbGxQb3NpdGlv bkRlbHRhID0gRmxvYXRTaXplKCk7CiAgICAgZWxzZQo= 188841 2013-02-18 03:05:56 -0800 2013-02-18 04:13:39 -0800 Patch bug-110059-20130218200123.patch text/plain 4206 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzMTg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmViMGE0MDhiZjcxZTM3 NGI0OWM0NmY3ZjQwOTY1ZGQxYzQzMzZkNy4uNmJhZmUzMDIxNDhlMWJmNjRlMjkwNDkxMjRjMzll MTY3N2NiODBmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEzLTAyLTE4ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIFtFRkxdW1dL Ml0gY29tcG9zaXRpbmcvbGF5ZXItY3JlYXRpb24vZml4ZWQtcG9zaXRpb24tb3V0LW9mLXZpZXct c2NhbGVkLmh0bWwgaXMgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExMDA1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFJlbW92ZSB0aGUgQVNTRVJUIGNoZWNrIGluIFRleHR1cmVNYXBwZXJMYXll ci4gVGhpcyBhc3NlcnRpb24gc2VlbXMKKyAgICAgICAgdmFsaWQgYmVjYXVzZSBDb29yZGluYXRl ZEdyYXBoaWNzU2NlbmU6OmFkanVzdFBvc2l0aW9uRm9yRml4ZWRMYXllcnMoKSBjYWxscworICAg ICAgICBUZXh0dXJlTWFwcGVyTGF5ZXI6OnNldFNjcm9sbFBvc2l0aW9uRGVsdGFJZk5lZWRlZCgp IHdoZW4gdGhlIGdyYXBoaWNzCisgICAgICAgIGxheWVyIGlzIGEgZml4ZWQgcG9zaXRpb24gbGF5 ZXIuIEhvd2V2ZXIsIHRoZSBhc3NlcnRpb24gY2FuIGJlIGZhaWxlZAorICAgICAgICBiZWNhdXNl IGl0IGlzIHBvc3NpYmxlIHRoYXQgVGV4dHVyZU1hcHBlckxheWVyIGlzIGEgbm9uLWZpeGVkIHBv c2l0aW9uCisgICAgICAgIGxheWVyIHdoZW4gdGhlIGdyYXBoaWNzIGxheWVyIHRoYXQgaG9sZHMg dGhlIFRleHR1cmVNYXBwZXJMYXllciBpcyBhCisgICAgICAgIGZpeGVkIHBvc2l0aW9uIGxheWVy LiBXaGVuIENvb3JkaW5hdGVkR3JhcGhpY3NTY2VuZSBmbHVzaGVzLAorICAgICAgICBUZXh0dXJl TWFwcGVyTGF5ZXIgYmVjb21lcyBhIGZpeGVkIHBvc2l0aW9uIGxheWVyLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXllci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpUZXh0dXJlTWFwcGVyTGF5ZXI6OnNldFNjcm9sbFBvc2l0aW9uRGVsdGFJZk5lZWRlZCk6CisK IDIwMTMtMDItMTggIE5pY28gV2ViZXIgIDx0aGFraXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFtjaHJvbWl1bS9jbGFuZ10gUmVtb3ZlIC1Xbm8tcmV0dXJuLXR5cGUtYy1saW5rYWdlCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1h cHBlckxheWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9U ZXh0dXJlTWFwcGVyTGF5ZXIuY3BwCmluZGV4IDYzYWM5ZWQ1NTEzMzUyZmNkMzhhOTk5MjMwZmM1 N2ZhZjNlYWFjNzMuLjg4ZWIzY2QxZmQ5N2YwZmNmYzExMTc1ZGFmODY3YTUyNThiOTE4ZDMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJl TWFwcGVyTGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3Rl eG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuY3BwCkBAIC02MDMsNyArNjAzLDYgQEAgdm9pZCBUZXh0 dXJlTWFwcGVyTGF5ZXI6OnNldFNjcm9sbFBvc2l0aW9uRGVsdGFJZk5lZWRlZChjb25zdCBGbG9h dFNpemUmIGRlbHRhKQogICAgIC8vIGluIHRoZSB3ZWIgcHJvY2Vzcy4gV2UgYWRkIHRoaXMgZGVs dGEgdG8gdGhlIHBvc2l0aW9uIG9mIGZpeGVkIGxheWVycywgdG8gbWFrZQogICAgIC8vIHN1cmUg dGhhdCB0aGV5IGRvIG5vdCBtb3ZlIHdoaWxlIHNjcm9sbGluZy4gV2UgbmVlZCB0byByZXNldCB0 aGlzIGRlbHRhIHRvIGZpeGVkIGxheWVycwogICAgIC8vIHRoYXQgaGF2ZSBhbiBhbmNlc3RvciB3 aGljaCBpcyBhbHNvIGEgZml4ZWQgbGF5ZXIsIGJlY2F1c2UgdGhlIGRlbHRhIHdpbGwgYmUgYWRk ZWQgdG8gdGhlIGFuY2VzdG9yLgotICAgIEFTU0VSVChtX2ZpeGVkVG9WaWV3cG9ydCk7CiAgICAg aWYgKGlzQW5jZXN0b3JGaXhlZFRvVmlld3BvcnQoKSkKICAgICAgICAgbV9zY3JvbGxQb3NpdGlv bkRlbHRhID0gRmxvYXRTaXplKCk7CiAgICAgZWxzZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDJiODIzZDFkOWFmNTI0YzIz ZDJiNWI5MGVlNzhkNzFhNDU5ZWM4OGEuLjkxYTcyNjJlMTYwOThmNzBlMzMwODc2OWJmZTEyNTE3 OTgwMTRlYmUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMy0wMi0xOCAgSHVhbmcgRG9uZ3N1 bmcgIDxsdXh0ZWxsYUBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBbRUZMXVtXSzJdIGNvbXBv c2l0aW5nL2xheWVyLWNyZWF0aW9uL2ZpeGVkLXBvc2l0aW9uLW91dC1vZi12aWV3LXNjYWxlZC5o dG1sIGlzIGZsYWt5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTAwNTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBVbnNraXAgdHdvIHRlc3RzIG9uIEVGTCBwb3J0LiBOb3cgdGhvc2UgcGFzcy4KKyAgICAg ICAgY29tcG9zaXRpbmcvbGF5ZXItY3JlYXRpb24vZml4ZWQtcG9zaXRpb24tb3V0LW9mLXZpZXct c2NhbGVkLmh0bWwKKyAgICAgICAgY29tcG9zaXRpbmcvbGF5ZXItY3JlYXRpb24vZml4ZWQtcG9z aXRpb24tb3V0LW9mLXZpZXctc2NhbGVkLXNjcm9sbC5odG1sCisKKyAgICAgICAgKiBwbGF0Zm9y bS9lZmwtd2syL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTMtMDItMTggIENocmlzdG9waGUgRHVt ZXogIDxjaC5kdW1lekBzaXNhLnNhbXN1bmcuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgRUZM IGdhcmRlbmluZy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC13azIvVGVz dEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC13azIvVGVzdEV4cGVjdGF0 aW9ucwppbmRleCBjMTEyZTNjNWE0NDNmZTczYmY5NTg0OTRiNzE0YjY5Y2E2NjE5NjA1Li5jMTFh ZWNiMDE5MWUwNmI2NDIyNWE1MTcxNmRhNmE1OTcwYmExM2Y5IDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9lZmwtd2syL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMv cGxhdGZvcm0vZWZsLXdrMi9UZXN0RXhwZWN0YXRpb25zCkBAIC03OCwxMCArNzgsNiBAQCB3ZWJr aXQub3JnL2IvMTA5OTQ1IHdlYmdsL2NvbmZvcm1hbmNlL3VuaWZvcm1zL2dsLXVuaWZvcm0tYXJy YXlzLmh0bWwgWyBDcmFzaCBGYQogd2Via2l0Lm9yZy9iLzEwOTk0NSB3ZWJnbC9jb25mb3JtYW5j ZS91bmlmb3Jtcy91bmlmb3JtLWRlZmF1bHQtdmFsdWVzLmh0bWwgWyBDcmFzaCBdCiB3ZWJraXQu b3JnL2IvMTA5OTQ1IHdlYmdsL2NvbmZvcm1hbmNlL29nbGVzL0dML3N3aXp6bGVycy9zd2l6emxl cnNfMDgxX3RvXzA4OC5odG1sIFsgQ3Jhc2ggXQogCi0jIEFTU0VSVElPTiBGQUlMRUQ6IG1fZml4 ZWRUb1ZpZXdwb3J0Lgotd2Via2l0Lm9yZy9iLzExMDA1OSBbIERlYnVnIF0gY29tcG9zaXRpbmcv bGF5ZXItY3JlYXRpb24vZml4ZWQtcG9zaXRpb24tb3V0LW9mLXZpZXctc2NhbGVkLmh0bWwgWyBD cmFzaCBQYXNzIF0KLXdlYmtpdC5vcmcvYi8xMTAwNTkgWyBEZWJ1ZyBdIGNvbXBvc2l0aW5nL2xh eWVyLWNyZWF0aW9uL2ZpeGVkLXBvc2l0aW9uLW91dC1vZi12aWV3LXNjYWxlZC1zY3JvbGwuaHRt bCBbIENyYXNoIFBhc3MgXQotCiAjLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLwogIyBG TEFLWSBURVNUUwogIy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8K