110045 2013-02-16 20:25:08 -0800 [WebGL] Fix oes-element-index-uint.html test. 2013-02-20 10:00:35 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 kalyan.kondapally kalyan.kondapally gman gyuyoung.kim kbr rakuco webkit.review.bot oldest_to_newest 834915 0 kalyan.kondapally 2013-02-16 20:25:08 -0800 Test seems to use some old functions and misses shaders for runResizedBufferTests. 834920 1 188752 kalyan.kondapally 2013-02-16 21:09:40 -0800 Created attachment 188752 patch 836664 2 188752 kbr 2013-02-19 12:30:40 -0800 Comment on attachment 188752 patch View in context: https://bugs.webkit.org/attachment.cgi?id=188752&action=review It looks like this test is currently broken so yes, let's fix it. However, the better long-term fix is Gregg's incorporation of the WebGL conformance tests as layout tests, which has been recently completed. Would be good if you could devote effort to getting those tests turned on on various ports. r=me > LayoutTests/fast/canvas/webgl/oes-element-index-uint.html:99 > + var program = wtu.setupSimpleTextureProgram(gl); It looks like the only reason for this change is that resources/webgl-test-utils is out of date. Is that correct? > LayoutTests/fast/canvas/webgl/oes-element-index-uint.html:285 > + gl.disableVertexAttribArray(vertexLoc); It looks like a recent upstream fix to webgl-test-utils removes the need for this. Can you test with https://www.khronos.org/registry/webgl/sdk/tests/conformance/extensions/oes-element-index-uint.html and confirm? 836686 3 188752 webkit.review.bot 2013-02-19 12:45:30 -0800 Comment on attachment 188752 patch Clearing flags on attachment: 188752 Committed r143373: <http://trac.webkit.org/changeset/143373> 836687 4 webkit.review.bot 2013-02-19 12:45:34 -0800 All reviewed patches have been landed. Closing bug. 837120 5 188752 kalyan.kondapally 2013-02-19 21:41:30 -0800 Comment on attachment 188752 patch View in context: https://bugs.webkit.org/attachment.cgi?id=188752&action=review > LayoutTests/fast/canvas/webgl/oes-element-index-uint.html:100 > When I proposed the change, my assumption was that the test is out of date. I should have cross checked webgl-test-utils with the version in Khronous conformance tests. Yes, that was the only reason. Should we try to sync both versions of webgl-test-utils or any time frame when this is planned?? 837352 6 188752 kalyan.kondapally 2013-02-20 04:51:24 -0800 Comment on attachment 188752 patch View in context: https://bugs.webkit.org/attachment.cgi?id=188752&action=review >> LayoutTests/fast/canvas/webgl/oes-element-index-uint.html:285 >> + gl.disableVertexAttribArray(vertexLoc); > > It looks like a recent upstream fix to webgl-test-utils removes the need for this. Can you test with https://www.khronos.org/registry/webgl/sdk/tests/conformance/extensions/oes-element-index-uint.html and confirm? Yes, it seems unnecessary with latest changes in khronous version of webgl-test-utils 837531 7 kbr 2013-02-20 10:00:35 -0800 (In reply to comment #6) > (From update of attachment 188752 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=188752&action=review > > >> LayoutTests/fast/canvas/webgl/oes-element-index-uint.html:285 > >> + gl.disableVertexAttribArray(vertexLoc); > > > > It looks like a recent upstream fix to webgl-test-utils removes the need for this. Can you test with https://www.khronos.org/registry/webgl/sdk/tests/conformance/extensions/oes-element-index-uint.html and confirm? > > Yes, it seems unnecessary with latest changes in khronous version of webgl-test-utils There are no concrete plans to update the copy of webgl-test-utils under fast/canvas/webgl/ . Gregg Tavares just incorporated the entire WebGL conformance suite verbatim under LayoutTests/webgl/ and that's the version that should be focused on going forward. On the other hand, if you want to update the fast/canvas/webgl/ copy in a separate bug for the interim period, that would be fine. 188752 2013-02-16 21:09:40 -0800 2013-02-20 04:51:24 -0800 patch webgltext.patch text/plain 4882 kalyan.kondapally ZGlmZiAtLWdpdCBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmlu ZGV4IGQyODY0YjcuLmVmMDA2ZmUgMTAwNjQ0Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysr IExheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAyLTE2ICBLb25k YXBhbGx5IEthbHlhbiAgPGthbHlhbi5rb25kYXBhbGx5QGludGVsLmNvbT4KKworICAgICAgICBb V2ViR0xdIEZpeCBvZXMtZWxlbWVudC1pbmRleC11aW50Lmh0bWwgdGVzdC4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDA0NQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggZml4ZXMgdGhl IHRlc3QgY2FzZSB0byB1c2UgdXBkYXRlZCBXZWJHTFRlc3RVdGlscyBmdW5jdGlvbnMKKyAgICAg ICAgYW5kIGFkZHMgc2hhZGVycyB1c2VkIGR1cmluZyByZXNpemVkIGJ1ZmZlciB0ZXN0cy4gVGhp cyBwYXRjaAorICAgICAgICBhbHNvIGVuYWJsZXMgdGhlIHRlc3QgZm9yIEVGTCBwb3J0LgorCisg ICAgICAgICogZmFzdC9jYW52YXMvd2ViZ2wvb2VzLWVsZW1lbnQtaW5kZXgtdWludC1leHBlY3Rl ZC50eHQ6CisgICAgICAgICogZmFzdC9jYW52YXMvd2ViZ2wvb2VzLWVsZW1lbnQtaW5kZXgtdWlu dC5odG1sOgorICAgICAgICAqIHBsYXRmb3JtL2VmbC9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDEz LTAyLTE1ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUGFkZGlu ZyBhbmQgYm9yZGVyIGNoYW5nZXMgZG9lc24ndCB0cmlnZ2VyIHJlbGF5b3V0IG9mIGNoaWxkcmVu CmRpZmYgLS1naXQgTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvb2VzLWVsZW1lbnQtaW5k ZXgtdWludC1leHBlY3RlZC50eHQgTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvb2VzLWVs ZW1lbnQtaW5kZXgtdWludC1leHBlY3RlZC50eHQKaW5kZXggYzI1M2I5OC4uMjExYzA5MCAxMDA2 NDQKLS0tIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL29lcy1lbGVtZW50LWluZGV4LXVp bnQtZXhwZWN0ZWQudHh0CisrKyBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9vZXMtZWxl bWVudC1pbmRleC11aW50LWV4cGVjdGVkLnR4dApAQCAtNjAsMyArNjAsNCBAQCBQQVNTIGdldEVy cm9yIHdhcyBleHBlY3RlZCB2YWx1ZTogTk9fRVJST1IgOiB0aGVyZSBzaG91bGQgYmUgbm8gZXJy b3JzCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKIFRFU1QgQ09NUExFVEUKXCBO byBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCisKZGlmZiAtLWdpdCBMYXlvdXRUZXN0cy9mYXN0L2Nh bnZhcy93ZWJnbC9vZXMtZWxlbWVudC1pbmRleC11aW50Lmh0bWwgTGF5b3V0VGVzdHMvZmFzdC9j YW52YXMvd2ViZ2wvb2VzLWVsZW1lbnQtaW5kZXgtdWludC5odG1sCmluZGV4IDdjOTI4NDQuLjMz NmE5NWEgMTAwNjQ0Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9vZXMtZWxlbWVu dC1pbmRleC11aW50Lmh0bWwKKysrIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL29lcy1l bGVtZW50LWluZGV4LXVpbnQuaHRtbApAQCAtMTIsMTEgKzEyLDMyIEBACiA8ZGl2IGlkPSJkZXNj cmlwdGlvbiI+PC9kaXY+CiA8Y2FudmFzIGlkPSJjYW52YXMiIHN0eWxlPSJ3aWR0aDogNTBweDsg aGVpZ2h0OiA1MHB4OyI+IDwvY2FudmFzPgogPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Cis8c2Ny aXB0IGlkPSJ2cyIgdHlwZT0ieC1zaGFkZXIveC12ZXJ0ZXgiPgorYXR0cmlidXRlIHZlYzQgdlBv c2l0aW9uOworYXR0cmlidXRlIHZlYzQgdkNvbG9yOwordmFyeWluZyB2ZWM0IGNvbG9yOwordm9p ZCBtYWluKCkgeworICAgIGdsX1Bvc2l0aW9uID0gdlBvc2l0aW9uOworICAgIGNvbG9yID0gdkNv bG9yOworfQorPC9zY3JpcHQ+Cis8c2NyaXB0IGlkPSJmcyIgdHlwZT0ieC1zaGFkZXIveC1mcmFn bWVudCI+CisjaWYgZGVmaW5lZChHTF9FUykKK3ByZWNpc2lvbiBtZWRpdW1wIGZsb2F0OworI2Vu ZGlmCit2YXJ5aW5nIHZlYzQgY29sb3I7Cit2b2lkIG1haW4oKSB7CisgIGdsX0ZyYWdDb2xvciA9 IGNvbG9yOworfQorPC9zY3JpcHQ+CiA8c2NyaXB0PgogZGVzY3JpcHRpb24oIlRoaXMgdGVzdCB2 ZXJpZmllcyB0aGUgZnVuY3Rpb25hbGl0eSBvZiB0aGUgT0VTX2VsZW1lbnRfaW5kZXhfdWludCBl eHRlbnNpb24sIGlmIGl0IGlzIGF2YWlsYWJsZS4iKTsKIAogZGVidWcoIiIpOwogCitpZiAod2lu ZG93LmludGVybmFscykKKyAgICB3aW5kb3cuaW50ZXJuYWxzLnNldHRpbmdzLnNldFdlYkdMRXJy b3JzVG9Db25zb2xlRW5hYmxlZChmYWxzZSk7CisKIHZhciB3dHUgPSBXZWJHTFRlc3RVdGlsczsK IHZhciBjYW52YXMgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY2FudmFzIik7CiB2YXIgZ2wg PSBjcmVhdGUzRENvbnRleHQoY2FudmFzKTsKQEAgLTc1LDcgKzk2LDcgQEAgZnVuY3Rpb24gcnVu RHJhd1Rlc3RzKCkgewogICAgIGNhbnZhcy53aWR0aCA9IDUwOyBjYW52YXMuaGVpZ2h0ID0gNTA7 CiAgICAgZ2wudmlld3BvcnQoMCwgMCwgY2FudmFzLndpZHRoLCBjYW52YXMuaGVpZ2h0KTsKICAg ICAKLSAgICB2YXIgcHJvZ3JhbSA9IHd0dS5zZXR1cE5vVGV4Q29vcmRUZXh0dXJlUHJvZ3JhbShn bCk7CisgICAgdmFyIHByb2dyYW0gPSB3dHUuc2V0dXBTaW1wbGVUZXh0dXJlUHJvZ3JhbShnbCk7 CiAKICAgICBmdW5jdGlvbiBzZXR1cERyYXcocykgewogICAgICAgICAvLyBDcmVhdGUgYSB2ZXJ0 ZXggYnVmZmVyIHRoYXQgY2Fubm90IGJlIGZ1bGx5IGluZGV4ZWQgdmlhIHNob3J0cwpAQCAtMjYx LDYgKzI4Miw3IEBAIGZ1bmN0aW9uIHJ1bkluZGV4VmFsaWRhdGlvblRlc3RzKCkgewogICAgIGds LnZlcnRleEF0dHJpYlBvaW50ZXIobm9ybWFsTG9jLCAzLCBnbC5GTE9BVCwgZmFsc2UsIDcgKiBz aXplSW5CeXRlcyhnbC5GTE9BVCksIC0yMDAwMDAwMDAwICogc2l6ZUluQnl0ZXMoZ2wuRkxPQVQp KTsKICAgICBnbEVycm9yU2hvdWxkQmUoZ2wsIGdsLklOVkFMSURfVkFMVUUpOwogICAgIHNob3Vs ZEJlVW5kZWZpbmVkKCdnbC5kcmF3RWxlbWVudHMoZ2wuVFJJQU5HTEVTLCAzLCBnbC5VTlNJR05F RF9JTlQsIDApJyk7CisgICAgZ2wuZGlzYWJsZVZlcnRleEF0dHJpYkFycmF5KHZlcnRleExvYyk7 CiB9CiAKIGZ1bmN0aW9uIHJ1bkNvcGllc0luZGljZXNUZXN0cygpIHsKQEAgLTI5NCw3ICszMTYs NyBAQCBmdW5jdGlvbiBydW5Db3BpZXNJbmRpY2VzVGVzdHMoKSB7CiBmdW5jdGlvbiBydW5SZXNp emVkQnVmZmVyVGVzdHMoKSB7CiAgICAgZGVidWcoIlRlc3QgdGhhdCB1cGRhdGluZyB0aGUgc2l6 ZSBvZiBhIHZlcnRleCBidWZmZXIgaXMgcHJvcGVybHkgbm90aWNlZCBieSB0aGUgV2ViR0wgaW1w bGVtZW50YXRpb24uIik7CiAKLSAgICB2YXIgcHJvZ3JhbSA9IHNldHVwUHJvZ3JhbShnbCwgInZz IiwgImZzIiwgWyJ2UG9zaXRpb24iLCAidkNvbG9yIl0pOworICAgIHZhciBwcm9ncmFtID0gd3R1 LnNldHVwUHJvZ3JhbShnbCwgWyJ2cyIsICJmcyJdLCBbInZQb3NpdGlvbiIsICJ2Q29sb3IiXSk7 CiAgICAgZ2xFcnJvclNob3VsZEJlKGdsLCBnbC5OT19FUlJPUiwgImFmdGVyIGluaXRpYWxpemF0 aW9uIik7CiAKICAgICB2YXIgdmVydGV4T2JqZWN0ID0gZ2wuY3JlYXRlQnVmZmVyKCk7CkBAIC0z ODksOCArNDExLDExIEBAIGZ1bmN0aW9uIHJ1bkNyYXNoV2l0aEJ1ZmZlclN1YkRhdGFUZXN0cygp IHsKICAgICBnbEVycm9yU2hvdWxkQmUoZ2wsIGdsLklOVkFMSURfVkFMVUUsICJhZnRlciBhdHRl bXB0aW5nIHRvIHVwZGF0ZSBhIGJ1ZmZlciBvdXRzaWRlIG9mIHRoZSBhbGxvY2F0ZWQgYm91bmRz Iik7CiAgICAgdGVzdFBhc3NlZCgiYnVmZmVyU3ViRGF0YSwgd2hlbiBidWZmZXIgb2JqZWN0IHdh cyBpbml0aWFsaXplZCB3aXRoIG51bGwsIGRpZCBub3QgY3Jhc2giKTsKIH0KLTwvc2NyaXB0Pgot PHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0Pgog CitkZWJ1ZygiIik7CitzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOworaXNTdWNjZXNzZnVsbHlQ YXJzZWQoKTsKKworPC9zY3JpcHQ+CiA8L2JvZHk+CiA8L2h0bWw+CmRpZmYgLS1naXQgTGF5b3V0 VGVzdHMvcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnMgTGF5b3V0VGVzdHMvcGxhdGZvcm0v ZWZsL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggNjE5ODc0ZS4uMmU4M2VhOCAxMDA2NDQKLS0tIExh eW91dFRlc3RzL3BsYXRmb3JtL2VmbC9UZXN0RXhwZWN0YXRpb25zCisrKyBMYXlvdXRUZXN0cy9w bGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMzQ1LDkgKzM0NSw2IEBAIGZhc3QvY3Nz L2RyYWdnYWJsZS1yZWdpb24tcGFyc2VyLmh0bWwKIAogd2Via2l0Lm9yZy9iLzk5MDk2IGZhc3Qv Y2FudmFzL3dlYmdsL2FycmF5YnVmZmVyLXRyYW5zZmVyLW9mLWNvbnRyb2wuaHRtbCBbIEZhaWx1 cmUgUGFzcyBdCiAKLSMgRXhwZWN0ZWQgdG8gZmFpbCB1bnRpbCBPRVNfZWxlbWVudF9pbmRleF91 aW50IGV4dGVuc2lvbiBpcyBpbXBsZW1lbnRlZAotd2Via2l0Lm9yZy9iLzk4MjU3IGZhc3QvY2Fu dmFzL3dlYmdsL29lcy1lbGVtZW50LWluZGV4LXVpbnQuaHRtbCBbIEZhaWx1cmUgUGFzcyBdCi0K ICMvLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vCiAjIFRFU1RTIEVYUEVDVEVEIFRPIEZB SUwKICMvLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vCg==