110041 2013-02-16 16:36:30 -0800 Stop passing around SelectorChecker in ContentSelectorQuery. 2013-02-17 22:38:54 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 89879 1 dglazkov dglazkov eric koivisto ojan.autocc webkit.review.bot oldest_to_newest 834885 0 dglazkov 2013-02-16 16:36:30 -0800 Stop passing around SelectorChecker in ContentSelectorQuery. 834890 1 188742 dglazkov 2013-02-16 16:40:35 -0800 Created attachment 188742 Patch 835141 2 188742 webkit.review.bot 2013-02-17 22:38:51 -0800 Comment on attachment 188742 Patch Clearing flags on attachment: 188742 Committed r143150: <http://trac.webkit.org/changeset/143150> 835143 3 webkit.review.bot 2013-02-17 22:38:54 -0800 All reviewed patches have been landed. Closing bug. 188742 2013-02-16 16:40:35 -0800 2013-02-17 22:38:51 -0800 Patch bug-110041-20130216163700.patch text/plain 5950 dglazkov U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzMTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2QyMDRiYTU3MWNiYzY4 OTNjMmUxMDc1MTlkMWY4YjQ3ZDUyNTcxYS4uZTg2YzU2N2YzNzY5N2EwNGY1ODM0ODgyZjg1NDJh YzU5YzYxN2MzZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEzLTAyLTE2ICBEaW1p dHJpIEdsYXprb3YgIDxkZ2xhemtvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgU3RvcCBwYXNz aW5nIGFyb3VuZCBTZWxlY3RvckNoZWNrZXIgaW4gQ29udGVudFNlbGVjdG9yUXVlcnkuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTAwNDEKKworICAg ICAgICBOb3cgdGhhdCBTZWxlY3RvckNoZWNrZXIgaGFzIG5vIGludGVyZXN0aW5nIHN0YXRlLCB3 ZSBjYW4gc2ltcGxpZnkgQ29udGVudFNlbGVjdG9yUXVlcnkgYW5kIGdldCByaWQgb2YgYSBjbGFz cy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBm dW5jdGlvbmFsIGNoYW5nZXMsIGNvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAg KiBodG1sL3NoYWRvdy9Db250ZW50U2VsZWN0b3JRdWVyeS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpDb250ZW50U2VsZWN0b3JEYXRhTGlzdDo6Y2hlY2tDb250ZW50U2VsZWN0b3IpOiBaYXBwZWQg Q29udGVudFNlbGVjdG9yQ2hlY2tlciBhbmQgbW92ZWQgaXRzIG9ubHkgcmVtYWluaW5nIG1ldGhv ZCBoZXJlLgorICAgICAgICAoV2ViQ29yZTo6Q29udGVudFNlbGVjdG9yRGF0YUxpc3Q6Om1hdGNo ZXMpOiBSZW1vdmVkIFNlbGVjdG9yQ2hlY2tlciBhcmd1bWVudC4KKyAgICAgICAgKFdlYkNvcmU6 OkNvbnRlbnRTZWxlY3RvclF1ZXJ5OjpDb250ZW50U2VsZWN0b3JRdWVyeSk6IFJlbW92ZWQgYW4g dW5uZWNlc3NhcnkgbWVtYmVyLgorICAgICAgICAoV2ViQ29yZTo6Q29udGVudFNlbGVjdG9yUXVl cnk6Om1hdGNoZXMpOiBSZW1vdmVkIHVubmVjZXNzYXJ5IGFyZ3VtZW50LgorICAgICAgICAqIGh0 bWwvc2hhZG93L0NvbnRlbnRTZWxlY3RvclF1ZXJ5Lmg6CisgICAgICAgIChXZWJDb3JlKTogQ2xl YW5lZCB1cCB0aGUgZmlsZS4KKyAgICAgICAgKENvbnRlbnRTZWxlY3RvckRhdGFMaXN0KTogVXBk YXRlZCBkZWNscy4KKyAgICAgICAgKENvbnRlbnRTZWxlY3RvclF1ZXJ5KTogRGl0dG8uCisKIDIw MTMtMDItMTYgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgogCiAgICAgICAgIHBl cmNlbnRhZ2UgdG9wIHZhbHVlIG9mIHBvc2l0aW9uOnJlbGF0aXZlIGVsZW1lbnQgbm90IGNhbGN1 bGF0ZWQgdXNpbmcgcGFyZW50J3MgbWluLWhlaWdodCB1bmxlc3MgaGVpZ2h0IHNldApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvQ29udGVudFNlbGVjdG9yUXVlcnkuY3Bw IGIvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvQ29udGVudFNlbGVjdG9yUXVlcnkuY3BwCmlu ZGV4IDljZjE5NTYyNzU0NDNlNzk2YzIzNzM2NDZiZjRjNDBjOWMwYzkyYjQuLjJiNzFiMDkwODEw OWNhMWZkMjM2YTg3MzJlYzUzNzViMDQ5YTcwZjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvc2hhZG93L0NvbnRlbnRTZWxlY3RvclF1ZXJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL3NoYWRvdy9Db250ZW50U2VsZWN0b3JRdWVyeS5jcHAKQEAgLTM1LDE3ICszNSwxNCBA QAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLUNvbnRlbnRTZWxlY3RvckNoZWNrZXI6OkNvbnRl bnRTZWxlY3RvckNoZWNrZXIoRG9jdW1lbnQqIGRvY3VtZW50KQotICAgIDogbV9zZWxlY3RvckNo ZWNrZXIoZG9jdW1lbnQsIFNlbGVjdG9yQ2hlY2tlcjo6Q29sbGVjdGluZ1J1bGVzKQorYm9vbCBD b250ZW50U2VsZWN0b3JEYXRhTGlzdDo6Y2hlY2tDb250ZW50U2VsZWN0b3IoY29uc3QgQ1NTU2Vs ZWN0b3IqIHNlbGVjdG9yLCBjb25zdCBWZWN0b3I8UmVmUHRyPE5vZGU+ID4mIHNpYmxpbmdzLCBp bnQgbnRoKQogewotfQotCi1ib29sIENvbnRlbnRTZWxlY3RvckNoZWNrZXI6OmNoZWNrQ29udGVu dFNlbGVjdG9yKGNvbnN0IENTU1NlbGVjdG9yKiBzZWxlY3RvciwgY29uc3QgVmVjdG9yPFJlZlB0 cjxOb2RlPiA+JiBzaWJsaW5ncywgaW50IG50aCkgY29uc3QKLXsKLSAgICBTZWxlY3RvckNoZWNr ZXI6OlNlbGVjdG9yQ2hlY2tpbmdDb250ZXh0IGNvbnRleHQoc2VsZWN0b3IsIHRvRWxlbWVudChz aWJsaW5nc1tudGhdLmdldCgpKSwgU2VsZWN0b3JDaGVja2VyOjpWaXNpdGVkTWF0Y2hFbmFibGVk KTsKKyAgICBFbGVtZW50KiBlbGVtZW50ID0gdG9FbGVtZW50KHNpYmxpbmdzW250aF0uZ2V0KCkp OworICAgIFNlbGVjdG9yQ2hlY2tlciBzZWxlY3RvckNoZWNrZXIoZWxlbWVudC0+ZG9jdW1lbnQo KSwgU2VsZWN0b3JDaGVja2VyOjpDb2xsZWN0aW5nUnVsZXMpOworICAgIFNlbGVjdG9yQ2hlY2tl cjo6U2VsZWN0b3JDaGVja2luZ0NvbnRleHQgY29udGV4dChzZWxlY3RvciwgZWxlbWVudCwgU2Vs ZWN0b3JDaGVja2VyOjpWaXNpdGVkTWF0Y2hFbmFibGVkKTsKICAgICBTaGFkb3dET01TaWJsaW5n VHJhdmVyc2FsU3RyYXRlZ3kgc3RyYXRlZ3koc2libGluZ3MsIG50aCk7CiAgICAgUHNldWRvSWQg aWdub3JlRHluYW1pY1BzZXVkbyA9IE5PUFNFVURPOwotICAgIHJldHVybiBtX3NlbGVjdG9yQ2hl Y2tlci5tYXRjaChjb250ZXh0LCBpZ25vcmVEeW5hbWljUHNldWRvLCBzdHJhdGVneSkgPT0gU2Vs ZWN0b3JDaGVja2VyOjpTZWxlY3Rvck1hdGNoZXM7CisgICAgcmV0dXJuIHNlbGVjdG9yQ2hlY2tl ci5tYXRjaChjb250ZXh0LCBpZ25vcmVEeW5hbWljUHNldWRvLCBzdHJhdGVneSkgPT0gU2VsZWN0 b3JDaGVja2VyOjpTZWxlY3Rvck1hdGNoZXM7CiB9CiAKIHZvaWQgQ29udGVudFNlbGVjdG9yRGF0 YUxpc3Q6OmluaXRpYWxpemUoY29uc3QgQ1NTU2VsZWN0b3JMaXN0JiBzZWxlY3RvcnMpCkBAIC01 NCwxMSArNTEsMTEgQEAgdm9pZCBDb250ZW50U2VsZWN0b3JEYXRhTGlzdDo6aW5pdGlhbGl6ZShj b25zdCBDU1NTZWxlY3Rvckxpc3QmIHNlbGVjdG9ycykKICAgICAgICAgbV9zZWxlY3RvcnMuYXBw ZW5kKHNlbGVjdG9yKTsKIH0KIAotYm9vbCBDb250ZW50U2VsZWN0b3JEYXRhTGlzdDo6bWF0Y2hl cyhjb25zdCBDb250ZW50U2VsZWN0b3JDaGVja2VyJiBzZWxlY3RvckNoZWNrZXIsIGNvbnN0IFZl Y3RvcjxSZWZQdHI8Tm9kZT4gPiYgc2libGluZ3MsIGludCBudGgpIGNvbnN0Citib29sIENvbnRl bnRTZWxlY3RvckRhdGFMaXN0OjptYXRjaGVzKGNvbnN0IFZlY3RvcjxSZWZQdHI8Tm9kZT4gPiYg c2libGluZ3MsIGludCBudGgpIGNvbnN0CiB7CiAgICAgdW5zaWduZWQgc2VsZWN0b3JDb3VudCA9 IG1fc2VsZWN0b3JzLnNpemUoKTsKICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgc2VsZWN0 b3JDb3VudDsgKytpKSB7Ci0gICAgICAgIGlmIChzZWxlY3RvckNoZWNrZXIuY2hlY2tDb250ZW50 U2VsZWN0b3IobV9zZWxlY3RvcnNbaV0sIHNpYmxpbmdzLCBudGgpKQorICAgICAgICBpZiAoY2hl Y2tDb250ZW50U2VsZWN0b3IobV9zZWxlY3RvcnNbaV0sIHNpYmxpbmdzLCBudGgpKQogICAgICAg ICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQogICAgIHJldHVybiBmYWxzZTsKQEAgLTY2LDcgKzYz LDYgQEAgYm9vbCBDb250ZW50U2VsZWN0b3JEYXRhTGlzdDo6bWF0Y2hlcyhjb25zdCBDb250ZW50 U2VsZWN0b3JDaGVja2VyJiBzZWxlY3RvckNoZWMKIAogQ29udGVudFNlbGVjdG9yUXVlcnk6OkNv bnRlbnRTZWxlY3RvclF1ZXJ5KEluc2VydGlvblBvaW50KiBpbnNlcnRpb25Qb2ludCkKICAgICA6 IG1faW5zZXJ0aW9uUG9pbnQoaW5zZXJ0aW9uUG9pbnQpCi0gICAgLCBtX3NlbGVjdG9yQ2hlY2tl cihpbnNlcnRpb25Qb2ludC0+ZG9jdW1lbnQoKSkKIHsKICAgICBtX3NlbGVjdG9ycy5pbml0aWFs aXplKGluc2VydGlvblBvaW50LT5zZWxlY3Rvckxpc3QoKSk7CiB9CkBAIC04Miw3ICs3OCw3IEBA IGJvb2wgQ29udGVudFNlbGVjdG9yUXVlcnk6Om1hdGNoZXMoY29uc3QgVmVjdG9yPFJlZlB0cjxO b2RlPiA+JiBzaWJsaW5ncywgaW50IG50CiAgICAgY2FzZSBJbnNlcnRpb25Qb2ludDo6TmV2ZXJN YXRjaGVzOgogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgY2FzZSBJbnNlcnRpb25Qb2ludDo6 SGFzVG9NYXRjaFNlbGVjdG9yOgotICAgICAgICByZXR1cm4gbm9kZS0+aXNFbGVtZW50Tm9kZSgp ICYmIG1fc2VsZWN0b3JzLm1hdGNoZXMobV9zZWxlY3RvckNoZWNrZXIsIHNpYmxpbmdzLCBudGgp OworICAgICAgICByZXR1cm4gbm9kZS0+aXNFbGVtZW50Tm9kZSgpICYmIG1fc2VsZWN0b3JzLm1h dGNoZXMoc2libGluZ3MsIG50aCk7CiAgICAgZGVmYXVsdDoKICAgICAgICAgQVNTRVJUX05PVF9S RUFDSEVEKCk7CiAgICAgICAgIHJldHVybiBmYWxzZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvc2hhZG93L0NvbnRlbnRTZWxlY3RvclF1ZXJ5LmggYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL3NoYWRvdy9Db250ZW50U2VsZWN0b3JRdWVyeS5oCmluZGV4IDRkMzhlZGQxYTVjODYxMGY3 NzI5MzEzMjRhNmE2ZWVkY2QzN2E3MTYuLmJjZWU5YmRkMTVmZjdhZmFhOGU0NTU2YzQ1NzgyMTM1 Y2Y1YTc5MmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L0NvbnRlbnRT ZWxlY3RvclF1ZXJ5LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvQ29udGVudFNl bGVjdG9yUXVlcnkuaApAQCAtNDMsMjEgKzQzLDE0IEBAIGNsYXNzIERvY3VtZW50OwogY2xhc3Mg Tm9kZTsKIGNsYXNzIEluc2VydGlvblBvaW50OwogCi1jbGFzcyBDb250ZW50U2VsZWN0b3JDaGVj a2VyIHsKLXB1YmxpYzoKLSAgICBDb250ZW50U2VsZWN0b3JDaGVja2VyKERvY3VtZW50Kik7Ci0K LSAgICBib29sIGNoZWNrQ29udGVudFNlbGVjdG9yKGNvbnN0IENTU1NlbGVjdG9yKiwgY29uc3Qg VmVjdG9yPFJlZlB0cjxOb2RlPiA+JiBzaWJsaW5ncywgaW50IG50aE5vZGUpIGNvbnN0OwotcHJp dmF0ZToKLSAgICBTZWxlY3RvckNoZWNrZXIgbV9zZWxlY3RvckNoZWNrZXI7Ci19OwotCiBjbGFz cyBDb250ZW50U2VsZWN0b3JEYXRhTGlzdCB7CiBwdWJsaWM6CiAgICAgdm9pZCBpbml0aWFsaXpl KGNvbnN0IENTU1NlbGVjdG9yTGlzdCYpOwotICAgIGJvb2wgbWF0Y2hlcyhjb25zdCBDb250ZW50 U2VsZWN0b3JDaGVja2VyJiwgY29uc3QgVmVjdG9yPFJlZlB0cjxOb2RlPiA+JiBzaWJsaW5ncywg aW50IG50aE5vZGUpIGNvbnN0OworICAgIGJvb2wgbWF0Y2hlcyhjb25zdCBWZWN0b3I8UmVmUHRy PE5vZGU+ID4mIHNpYmxpbmdzLCBpbnQgbnRoTm9kZSkgY29uc3Q7CiAKIHByaXZhdGU6CisgICAg c3RhdGljIGJvb2wgY2hlY2tDb250ZW50U2VsZWN0b3IoY29uc3QgQ1NTU2VsZWN0b3IqLCBjb25z dCBWZWN0b3I8UmVmUHRyPE5vZGU+ID4mIHNpYmxpbmdzLCBpbnQgbnRoTm9kZSk7CisKICAgICBW ZWN0b3I8Y29uc3QgQ1NTU2VsZWN0b3IqPiBtX3NlbGVjdG9yczsKIH07CiAKQEAgLTY3LDExICs2 MCwxMCBAQCBwdWJsaWM6CiAgICAgZXhwbGljaXQgQ29udGVudFNlbGVjdG9yUXVlcnkoSW5zZXJ0 aW9uUG9pbnQqKTsKIAogICAgIGJvb2wgbWF0Y2hlcyhjb25zdCBWZWN0b3I8UmVmUHRyPE5vZGU+ ID4mIHNpYmxpbmdzLCBpbnQgbnRoTm9kZSkgY29uc3Q7Ci1wcml2YXRlOgogCitwcml2YXRlOgog ICAgIEluc2VydGlvblBvaW50KiBtX2luc2VydGlvblBvaW50OwogICAgIENvbnRlbnRTZWxlY3Rv ckRhdGFMaXN0IG1fc2VsZWN0b3JzOwotICAgIENvbnRlbnRTZWxlY3RvckNoZWNrZXIgbV9zZWxl Y3RvckNoZWNrZXI7CiB9OwogCiB9Cg==