110036 2013-02-16 15:43:10 -0800 Remove redundant use of inline keyword in StringHasher.h 2013-02-16 15:54:21 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 darin darin webkit-ews oldest_to_newest 834856 0 darin 2013-02-16 15:43:10 -0800 Remove redundant use of inline keyword in StringHasher.h 834859 1 188735 darin 2013-02-16 15:46:26 -0800 Created attachment 188735 Patch 834863 2 188735 ggaren 2013-02-16 15:49:30 -0800 Comment on attachment 188735 Patch r=me 834865 3 188735 darin 2013-02-16 15:50:28 -0800 Comment on attachment 188735 Patch Needs a small fix. 834867 4 188735 webkit-ews 2013-02-16 15:53:47 -0800 Comment on attachment 188735 Patch Attachment 188735 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/16539056 834868 5 darin 2013-02-16 15:54:04 -0800 http://trac.webkit.org/changeset/143116 834869 6 darin 2013-02-16 15:54:21 -0800 The patch I landed fixed the failures the EWS is seeing. 188735 2013-02-16 15:46:26 -0800 2013-02-16 15:53:46 -0800 Patch bug-110036-20130216154251.patch text/plain 6327 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzMTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDNkMDEzODFjNzAxZmRjNTkwZjEwNjFl MGFjZGM2ZmJlYjlhYTM0ZjkuLjczYjkwZTEyNjYwNzJhNGVhZGRlYjZkMGJiOWUwODQ1NTg4NzA5 NjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMDItMTYgIERhcmluIEFkbGVyICA8ZGFyaW5A YXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSByZWR1bmRhbnQgdXNlIG9mIGlubGluZSBrZXl3 b3JkIGluIFN0cmluZ0hhc2hlci5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMTAwMzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBJIGhhdmUgc29tZSBvdGhlciBpbXByb3ZlbWVudHMgZm9yIFN0cmluZ0hh c2hlci5oLCBidXQgd2FudGVkIHRvIGdldCB0aGUgc2ltcGxlc3Qgb25lcworICAgICAgICBvdXQg b2YgdGhlIHdheSBmaXJzdC4KKworICAgICAgICAqIHd0Zi9TdHJpbmdIYXNoZXIuaDogUmVtb3Zl IGlubGluZSBrZXl3b3JkIG9uIGZ1bmN0aW9ucyBpbnNpZGUgdGhlIGNsYXNzIGRlZmluaXRpb24s CisgICAgICAgIHNpbmNlIGZ1bmN0aW9ucyBkZWZpbmVkIGluc2lkZSB0aGUgY2xhc3MgYXJlIGF1 dG9tYXRpY2FsbHkgaW5saW5lLgorCiAyMDEzLTAyLTE1ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9i aW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBTcHJlYWQgdGhlIGd5cCBidWlsZCBm aWxlcyB0aHJvdWdob3V0IHRoZSB0cmVlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9TdHJp bmdIYXNoZXIuaCBiL1NvdXJjZS9XVEYvd3RmL1N0cmluZ0hhc2hlci5oCmluZGV4IGU4OGM1MDc2 YmE3ZmRkOWYxYzM5YTFlOWIwYjY1MjgzYjkwODEzZGYuLjJjMjcyZmZmYmZmNDQ0ZDA5MjEzOTE1 NzkwOGU3NTllNmUwZjJlMTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1N0cmluZ0hhc2hl ci5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1N0cmluZ0hhc2hlci5oCkBAIC0zOCwyMCArMzgsMjAg QEAgY2xhc3MgU3RyaW5nSGFzaGVyIHsKIHB1YmxpYzoKICAgICBzdGF0aWMgY29uc3QgdW5zaWdu ZWQgZmxhZ0NvdW50ID0gODsgLy8gU2F2ZSA4IGJpdHMgZm9yIFN0cmluZ0ltcGwgdG8gdXNlIGFz IGZsYWdzLgogCi0gICAgaW5saW5lIFN0cmluZ0hhc2hlcigpCisgICAgU3RyaW5nSGFzaGVyKCkK ICAgICAgICAgOiBtX2hhc2goc3RyaW5nSGFzaGluZ1N0YXJ0VmFsdWUpCiAgICAgICAgICwgbV9o YXNQZW5kaW5nQ2hhcmFjdGVyKGZhbHNlKQogICAgICAgICAsIG1fcGVuZGluZ0NoYXJhY3Rlcigw KQogICAgIHsKICAgICB9CiAKLSAgICBpbmxpbmUgdm9pZCBhZGRDaGFyYWN0ZXJzKFVDaGFyIGEs IFVDaGFyIGIpCisgICAgdm9pZCBhZGRBbGlnbmVkQ2hhcmFjdGVycyhVQ2hhciBhLCBVQ2hhciBi KQogICAgIHsKICAgICAgICAgQVNTRVJUKCFtX2hhc1BlbmRpbmdDaGFyYWN0ZXIpOwogICAgICAg ICBhZGRDaGFyYWN0ZXJzVG9IYXNoKGEsIGIpOwogICAgIH0KIAotICAgIGlubGluZSB2b2lkIGFk ZENoYXJhY3RlcihVQ2hhciBjaCkKKyAgICB2b2lkIGFkZENoYXJhY3RlcihVQ2hhciBjaCkKICAg ICB7CiAgICAgICAgIGlmIChtX2hhc1BlbmRpbmdDaGFyYWN0ZXIpIHsKICAgICAgICAgICAgIGFk ZENoYXJhY3RlcnNUb0hhc2gobV9wZW5kaW5nQ2hhcmFjdGVyLCBjaCk7CkBAIC02Myw3ICs2Myw3 IEBAIHB1YmxpYzoKICAgICAgICAgbV9oYXNQZW5kaW5nQ2hhcmFjdGVyID0gdHJ1ZTsKICAgICB9 CiAKLSAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBULCBVQ2hhciBDb252ZXJ0ZXIoVCk+IGlubGluZSB2 b2lkIGFkZENoYXJhY3RlcnMoY29uc3QgVCogZGF0YSwgdW5zaWduZWQgbGVuZ3RoKQorICAgIHRl bXBsYXRlPHR5cGVuYW1lIFQsIFVDaGFyIENvbnZlcnRlcihUKT4gdm9pZCBhZGRDaGFyYWN0ZXJz KGNvbnN0IFQqIGRhdGEsIHVuc2lnbmVkIGxlbmd0aCkKICAgICB7CiAgICAgICAgIGlmICghbGVu Z3RoKQogICAgICAgICAgICAgcmV0dXJuOwpAQCAtODYsNyArODYsNyBAQCBwdWJsaWM6CiAgICAg ICAgICAgICBhZGRDaGFyYWN0ZXIoQ29udmVydGVyKCpkYXRhKSk7CiAgICAgfQogCi0gICAgaW5s aW5lIHVuc2lnbmVkIGhhc2hXaXRoVG9wOEJpdHNNYXNrZWQoKSBjb25zdAorICAgIHVuc2lnbmVk IGhhc2hXaXRoVG9wOEJpdHNNYXNrZWQoKSBjb25zdAogICAgIHsKICAgICAgICAgdW5zaWduZWQg cmVzdWx0ID0gYXZhbGFuY2hlQml0cygpOwogCkBAIC0xMDQsNyArMTA0LDcgQEAgcHVibGljOgog ICAgICAgICByZXR1cm4gcmVzdWx0OwogICAgIH0KIAotICAgIGlubGluZSB1bnNpZ25lZCBoYXNo KCkgY29uc3QKKyAgICB1bnNpZ25lZCBoYXNoKCkgY29uc3QKICAgICB7CiAgICAgICAgIHVuc2ln bmVkIHJlc3VsdCA9IGF2YWxhbmNoZUJpdHMoKTsKIApAQCAtMTE4LDcgKzExOCw3IEBAIHB1Ymxp YzoKICAgICAgICAgcmV0dXJuIHJlc3VsdDsKICAgICB9CiAKLSAgICB0ZW1wbGF0ZTx0eXBlbmFt ZSBULCBVQ2hhciBDb252ZXJ0ZXIoVCk+IHN0YXRpYyBpbmxpbmUgdW5zaWduZWQgY29tcHV0ZUhh c2hBbmRNYXNrVG9wOEJpdHMoY29uc3QgVCogZGF0YSwgdW5zaWduZWQgbGVuZ3RoKQorICAgIHRl bXBsYXRlPHR5cGVuYW1lIFQsIFVDaGFyIENvbnZlcnRlcihUKT4gc3RhdGljIHVuc2lnbmVkIGNv bXB1dGVIYXNoQW5kTWFza1RvcDhCaXRzKGNvbnN0IFQqIGRhdGEsIHVuc2lnbmVkIGxlbmd0aCkK ICAgICB7CiAgICAgICAgIFN0cmluZ0hhc2hlciBoYXNoZXI7CiAgICAgICAgIGJvb2wgcmVtID0g bGVuZ3RoICYgMTsKQEAgLTEzNSw3ICsxMzUsNyBAQCBwdWJsaWM6CiAgICAgICAgIHJldHVybiBo YXNoZXIuaGFzaFdpdGhUb3A4Qml0c01hc2tlZCgpOwogICAgIH0KIAotICAgIHRlbXBsYXRlPHR5 cGVuYW1lIFQsIFVDaGFyIENvbnZlcnRlcihUKT4gc3RhdGljIGlubGluZSB1bnNpZ25lZCBjb21w dXRlSGFzaEFuZE1hc2tUb3A4Qml0cyhjb25zdCBUKiBkYXRhKQorICAgIHRlbXBsYXRlPHR5cGVu YW1lIFQsIFVDaGFyIENvbnZlcnRlcihUKT4gc3RhdGljIHVuc2lnbmVkIGNvbXB1dGVIYXNoQW5k TWFza1RvcDhCaXRzKGNvbnN0IFQqIGRhdGEpCiAgICAgewogICAgICAgICBTdHJpbmdIYXNoZXIg aGFzaGVyOwogCkBAIC0xNTUsMjQgKzE1NSwyNCBAQCBwdWJsaWM6CiAgICAgICAgIHJldHVybiBo YXNoZXIuaGFzaFdpdGhUb3A4Qml0c01hc2tlZCgpOwogICAgIH0KIAotICAgIHRlbXBsYXRlPHR5 cGVuYW1lIFQ+IHN0YXRpYyBpbmxpbmUgdW5zaWduZWQgY29tcHV0ZUhhc2hBbmRNYXNrVG9wOEJp dHMoY29uc3QgVCogZGF0YSwgdW5zaWduZWQgbGVuZ3RoKQorICAgIHRlbXBsYXRlPHR5cGVuYW1l IFQ+IHN0YXRpYyB1bnNpZ25lZCBjb21wdXRlSGFzaEFuZE1hc2tUb3A4Qml0cyhjb25zdCBUKiBk YXRhLCB1bnNpZ25lZCBsZW5ndGgpCiAgICAgewogICAgICAgICByZXR1cm4gY29tcHV0ZUhhc2hB bmRNYXNrVG9wOEJpdHM8VCwgZGVmYXVsdENvbnZlcnRlcj4oZGF0YSwgbGVuZ3RoKTsKICAgICB9 CiAKLSAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBzdGF0aWMgaW5saW5lIHVuc2lnbmVkIGNvbXB1 dGVIYXNoQW5kTWFza1RvcDhCaXRzKGNvbnN0IFQqIGRhdGEpCisgICAgdGVtcGxhdGU8dHlwZW5h bWUgVD4gc3RhdGljIHVuc2lnbmVkIGNvbXB1dGVIYXNoQW5kTWFza1RvcDhCaXRzKGNvbnN0IFQq IGRhdGEpCiAgICAgewogICAgICAgICByZXR1cm4gY29tcHV0ZUhhc2hBbmRNYXNrVG9wOEJpdHM8 VCwgZGVmYXVsdENvbnZlcnRlcj4oZGF0YSk7CiAgICAgfQogCi0gICAgdGVtcGxhdGU8dHlwZW5h bWUgVCwgVUNoYXIgQ29udmVydGVyKFQpPiBzdGF0aWMgaW5saW5lIHVuc2lnbmVkIGNvbXB1dGVI YXNoKGNvbnN0IFQqIGRhdGEsIHVuc2lnbmVkIGxlbmd0aCkKKyAgICB0ZW1wbGF0ZTx0eXBlbmFt ZSBULCBVQ2hhciBDb252ZXJ0ZXIoVCk+IHN0YXRpYyB1bnNpZ25lZCBjb21wdXRlSGFzaChjb25z dCBUKiBkYXRhLCB1bnNpZ25lZCBsZW5ndGgpCiAgICAgewogICAgICAgICBTdHJpbmdIYXNoZXIg aGFzaGVyOwogICAgICAgICBoYXNoZXIuYWRkQ2hhcmFjdGVyczxULCBDb252ZXJ0ZXI+KGRhdGEs IGxlbmd0aCk7CiAgICAgICAgIHJldHVybiBoYXNoZXIuaGFzaCgpOwogICAgIH0KIAotICAgIHRl bXBsYXRlPHR5cGVuYW1lIFQsIFVDaGFyIENvbnZlcnRlcihUKT4gc3RhdGljIGlubGluZSB1bnNp Z25lZCBjb21wdXRlSGFzaChjb25zdCBUKiBkYXRhKQorICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQs IFVDaGFyIENvbnZlcnRlcihUKT4gc3RhdGljIHVuc2lnbmVkIGNvbXB1dGVIYXNoKGNvbnN0IFQq IGRhdGEpCiAgICAgewogICAgICAgICBTdHJpbmdIYXNoZXIgaGFzaGVyOwogCkBAIC0xOTIsNDAg KzE5Miw0MCBAQCBwdWJsaWM6CiAgICAgICAgIHJldHVybiBoYXNoZXIuaGFzaCgpOwogICAgIH0K IAotICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IHN0YXRpYyBpbmxpbmUgdW5zaWduZWQgY29tcHV0 ZUhhc2goY29uc3QgVCogZGF0YSwgdW5zaWduZWQgbGVuZ3RoKQorICAgIHRlbXBsYXRlPHR5cGVu YW1lIFQ+IHN0YXRpYyB1bnNpZ25lZCBjb21wdXRlSGFzaChjb25zdCBUKiBkYXRhLCB1bnNpZ25l ZCBsZW5ndGgpCiAgICAgewogICAgICAgICByZXR1cm4gY29tcHV0ZUhhc2g8VCwgZGVmYXVsdENv bnZlcnRlcj4oZGF0YSwgbGVuZ3RoKTsKICAgICB9CiAKLSAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBU PiBzdGF0aWMgaW5saW5lIHVuc2lnbmVkIGNvbXB1dGVIYXNoKGNvbnN0IFQqIGRhdGEpCisgICAg dGVtcGxhdGU8dHlwZW5hbWUgVD4gc3RhdGljIHVuc2lnbmVkIGNvbXB1dGVIYXNoKGNvbnN0IFQq IGRhdGEpCiAgICAgewogICAgICAgICByZXR1cm4gY29tcHV0ZUhhc2g8VCwgZGVmYXVsdENvbnZl cnRlcj4oZGF0YSk7CiAgICAgfQogCi0gICAgdGVtcGxhdGU8c2l6ZV90IGxlbmd0aD4gc3RhdGlj IGlubGluZSB1bnNpZ25lZCBoYXNoTWVtb3J5KGNvbnN0IHZvaWQqIGRhdGEpCisgICAgdGVtcGxh dGU8c2l6ZV90IGxlbmd0aD4gc3RhdGljIHVuc2lnbmVkIGhhc2hNZW1vcnkoY29uc3Qgdm9pZCog ZGF0YSkKICAgICB7CiAgICAgICAgIENPTVBJTEVfQVNTRVJUKCEobGVuZ3RoICUgNCksIGxlbmd0 aF9tdXN0X2JlX2FfbXVsdGlibGVfb2ZfZm91cik7CiAgICAgICAgIHJldHVybiBjb21wdXRlSGFz aEFuZE1hc2tUb3A4Qml0czxVQ2hhcj4oc3RhdGljX2Nhc3Q8Y29uc3QgVUNoYXIqPihkYXRhKSwg bGVuZ3RoIC8gc2l6ZW9mKFVDaGFyKSk7CiAgICAgfQogCi0gICAgc3RhdGljIGlubGluZSB1bnNp Z25lZCBoYXNoTWVtb3J5KGNvbnN0IHZvaWQqIGRhdGEsIHVuc2lnbmVkIHNpemUpCisgICAgc3Rh dGljIHVuc2lnbmVkIGhhc2hNZW1vcnkoY29uc3Qgdm9pZCogZGF0YSwgdW5zaWduZWQgc2l6ZSkK ICAgICB7CiAgICAgICAgIEFTU0VSVCghKHNpemUgJSAyKSk7CiAgICAgICAgIHJldHVybiBjb21w dXRlSGFzaEFuZE1hc2tUb3A4Qml0czxVQ2hhcj4oc3RhdGljX2Nhc3Q8Y29uc3QgVUNoYXIqPihk YXRhKSwgc2l6ZSAvIHNpemVvZihVQ2hhcikpOwogICAgIH0KIAogcHJpdmF0ZToKLSAgICBzdGF0 aWMgaW5saW5lIFVDaGFyIGRlZmF1bHRDb252ZXJ0ZXIoVUNoYXIgY2gpCisgICAgc3RhdGljIFVD aGFyIGRlZmF1bHRDb252ZXJ0ZXIoVUNoYXIgY2gpCiAgICAgewogICAgICAgICByZXR1cm4gY2g7 CiAgICAgfQogCi0gICAgc3RhdGljIGlubGluZSBVQ2hhciBkZWZhdWx0Q29udmVydGVyKExDaGFy IGNoKQorICAgIHN0YXRpYyBVQ2hhciBkZWZhdWx0Q29udmVydGVyKExDaGFyIGNoKQogICAgIHsK ICAgICAgICAgcmV0dXJuIGNoOwogICAgIH0KIAotICAgIGlubGluZSB2b2lkIGFkZENoYXJhY3Rl cnNUb0hhc2goVUNoYXIgYSwgVUNoYXIgYikKKyAgICB2b2lkIGFkZENoYXJhY3RlcnNUb0hhc2go VUNoYXIgYSwgVUNoYXIgYikKICAgICB7CiAgICAgICAgIG1faGFzaCArPSBhOwogICAgICAgICB1 bnNpZ25lZCB0bXAgPSAoYiA8PCAxMSkgXiBtX2hhc2g7CkBAIC0yMzMsNyArMjMzLDcgQEAgcHJp dmF0ZToKICAgICAgICAgbV9oYXNoICs9IG1faGFzaCA+PiAxMTsKICAgICB9CiAKLSAgICBpbmxp bmUgdW5zaWduZWQgYXZhbGFuY2hlQml0cygpIGNvbnN0CisgICAgdW5zaWduZWQgYXZhbGFuY2hl Qml0cygpIGNvbnN0CiAgICAgewogICAgICAgICB1bnNpZ25lZCByZXN1bHQgPSBtX2hhc2g7CiAK