109996 2013-02-15 18:06:42 -0800 [Mac] remove wkCaptionAppearance from WebKitSystemInterface 2013-02-15 21:23:58 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 110000 1 eric.carlson eric.carlson benjamin webkit.review.bot oldest_to_newest 834571 0 eric.carlson 2013-02-15 18:06:42 -0800 The wkCaptionAppearance* functions are no longer needed. 834578 1 188680 eric.carlson 2013-02-15 18:18:20 -0800 Created attachment 188680 Proposed patch 834582 2 eric.carlson 2013-02-15 18:35:45 -0800 http://trac.webkit.org/r143088 834616 3 webkit.review.bot 2013-02-15 20:25:57 -0800 Re-opened since this is blocked by bug 110000 834628 4 benjamin 2013-02-15 21:23:09 -0800 Committed r143096: <http://trac.webkit.org/changeset/143096> 834629 5 benjamin 2013-02-15 21:23:58 -0800 I had the fix locally, I just landed again. 188680 2013-02-15 18:18:20 -0800 2013-02-15 18:35:55 -0800 Proposed patch open_source_patch_2.txt text/plain 7134 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MzA4MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDExIEBACisyMDEzLTAyLTE1ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIHJlbW92ZSB3 a0NhcHRpb25BcHBlYXJhbmNlIGZyb20gV2ViS2l0U3lzdGVtSW50ZXJmYWNlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDk5OTYKKworICAgICAgICAq IHBsYXRmb3JtL21hYy9XZWJDb3JlU3lzdGVtSW50ZXJmYWNlLmg6CisgICAgICAgICogcGxhdGZv cm0vbWFjL1dlYkNvcmVTeXN0ZW1JbnRlcmZhY2UubW06CisKIDIwMTMtMDItMTUgIEFuZHJlYXMg S2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIENhbGxpbmcgRE9NIEVsZW1lbnQu YXR0cmlidXRlcyBzaG91bGRuJ3QgZm9yY2UgY3JlYXRpb24gb2YgRWxlbWVudERhdGEuCkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2ViQ29yZVN5c3RlbUludGVyZmFjZS5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJDb3JlU3lzdGVtSW50 ZXJmYWNlLmgJKHJldmlzaW9uIDE0MzAyMikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21h Yy9XZWJDb3JlU3lzdGVtSW50ZXJmYWNlLmgJKHdvcmtpbmcgY29weSkKQEAgLTM1MSw0MCArMzUx LDYgQEAgZXh0ZXJuIENHRmxvYXQgKCp3a05TRWxhc3RpY0RlbHRhRm9yUmVibwogZXh0ZXJuIENH RmxvYXQgKCp3a05TUmVib3VuZERlbHRhRm9yRWxhc3RpY0RlbHRhKShDR0Zsb2F0IGRlbHRhKTsK ICNlbmRpZgogCi10eXBlZGVmIGVudW0gewotICAgIHdrQ2FwdGlvbkZvbnRTdHlsZURlZmF1bHQg PSAwLAotICAgIHdrQ2FwdGlvbkZvbnRTdHlsZU1vbm9zcGFjZWRXaXRoU2VyaWYsCi0gICAgd2tD YXB0aW9uRm9udFN0eWxlUHJvcG9ydGlvbmFsV2l0aFNlcmlmLAotICAgIHdrQ2FwdGlvbkZvbnRT dHlsZU1vbm9zcGFjZWRXaXRob3V0U2VyaWYsCi0gICAgd2tDYXB0aW9uRm9udFN0eWxlUHJvcG9y dGlvbmFsV2l0aG91dFNlcmlmLAotICAgIHdrQ2FwdGlvbkZvbnRTdHlsZUNhc3VhbCwKLSAgICB3 a0NhcHRpb25Gb250U3R5bGVDdXJzaXZlLAotICAgIHdrQ2FwdGlvbkZvbnRTdHlsZVNtYWxsQ2Fw aXRhbCwKLSAgICB3a0NhcHRpb25Gb250U3R5bGVNYXgKLX0gd2tDYXB0aW9uRm9udFN0eWxlOwot Ci10eXBlZGVmIGVudW0gewotICAgIHdrQ2FwdGlvblRleHRFZGdlU3R5bGVVbmRlZmluZWQgPSAw LAotICAgIHdrQ2FwdGlvblRleHRFZGdlU3R5bGVOb25lLAotICAgIHdrQ2FwdGlvblRleHRFZGdl U3R5bGVSYWlzZWQsCi0gICAgd2tDYXB0aW9uVGV4dEVkZ2VTdHlsZURlcHJlc3NlZCwKLSAgICB3 a0NhcHRpb25UZXh0RWRnZVN0eWxlVW5pZm9ybSwKLSAgICB3a0NhcHRpb25UZXh0RWRnZVN0eWxl RHJvcFNoYWRvdywKLSAgICB3a0NhcHRpb25UZXh0RWRnZVN0eWxlTWF4Ci19IHdrQ2FwdGlvblRl eHRFZGdlU3R5bGU7Ci0KLWV4dGVybiBib29sICgqd2tDYXB0aW9uQXBwZWFyYW5jZUhhc1VzZXJQ cmVmZXJlbmNlcykodm9pZCk7Ci1leHRlcm4gYm9vbCAoKndrQ2FwdGlvbkFwcGVhcmFuY2VTaG93 Q2FwdGlvbnNXaGVuQXZhaWxhYmxlKSh2b2lkKTsKLWV4dGVybiBDR0NvbG9yUmVmKCp3a0NhcHRp b25BcHBlYXJhbmNlQ29weUZvcmVncm91bmRDb2xvcikodm9pZCk7Ci1leHRlcm4gQ0dDb2xvclJl Zigqd2tDYXB0aW9uQXBwZWFyYW5jZUNvcHlCYWNrZ3JvdW5kQ29sb3IpKHZvaWQpOwotZXh0ZXJu IENHQ29sb3JSZWYoKndrQ2FwdGlvbkFwcGVhcmFuY2VDb3B5V2luZG93Q29sb3IpKHZvaWQpOwot ZXh0ZXJuIGJvb2woKndrQ2FwdGlvbkFwcGVhcmFuY2VHZXRGb3JlZ3JvdW5kT3BhY2l0eSkoQ0dG bG9hdCopOwotZXh0ZXJuIGJvb2woKndrQ2FwdGlvbkFwcGVhcmFuY2VHZXRCYWNrZ3JvdW5kT3Bh Y2l0eSkoQ0dGbG9hdCopOwotZXh0ZXJuIGJvb2woKndrQ2FwdGlvbkFwcGVhcmFuY2VHZXRXaW5k b3dPcGFjaXR5KShDR0Zsb2F0Kik7Ci1leHRlcm4gQ0dGb250UmVmKCp3a0NhcHRpb25BcHBlYXJh bmNlQ29weUZvbnRGb3JTdHlsZSkoaW50KTsKLWV4dGVybiBib29sKCp3a0NhcHRpb25BcHBlYXJh bmNlR2V0UmVsYXRpdmVDaGFyYWN0ZXJTaXplKShDR0Zsb2F0Kik7Ci1leHRlcm4gaW50KCp3a0Nh cHRpb25BcHBlYXJhbmNlR2V0VGV4dEVkZ2VTdHlsZSkodm9pZCk7Ci1leHRlcm4gQ0ZTdHJpbmdS ZWYoKndrQ2FwdGlvbkFwcGVhcmFuY2VHZXRTZXR0aW5nc0NoYW5nZWROb3RpZmljYXRpb24pKHZv aWQpOwogfQogCiAjZW5kaWYKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJD b3JlU3lzdGVtSW50ZXJmYWNlLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL21hYy9XZWJDb3JlU3lzdGVtSW50ZXJmYWNlLm1tCShyZXZpc2lvbiAxNDMwMjIpCisrKyBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2ViQ29yZVN5c3RlbUludGVyZmFjZS5tbQkod29y a2luZyBjb3B5KQpAQCAtMjIyLDE2ICsyMjIsMyBAQCBDR0Zsb2F0ICgqd2tOU0VsYXN0aWNEZWx0 YUZvclRpbWVEZWx0YSkoCiBDR0Zsb2F0ICgqd2tOU0VsYXN0aWNEZWx0YUZvclJlYm91bmREZWx0 YSkoQ0dGbG9hdCBkZWx0YSk7CiBDR0Zsb2F0ICgqd2tOU1JlYm91bmREZWx0YUZvckVsYXN0aWNE ZWx0YSkoQ0dGbG9hdCBkZWx0YSk7CiAjZW5kaWYKLQotYm9vbCAoKndrQ2FwdGlvbkFwcGVhcmFu Y2VIYXNVc2VyUHJlZmVyZW5jZXMpKHZvaWQpOwotYm9vbCAoKndrQ2FwdGlvbkFwcGVhcmFuY2VT aG93Q2FwdGlvbnNXaGVuQXZhaWxhYmxlKSh2b2lkKTsKLUNHQ29sb3JSZWYoKndrQ2FwdGlvbkFw cGVhcmFuY2VDb3B5Rm9yZWdyb3VuZENvbG9yKSh2b2lkKTsKLUNHQ29sb3JSZWYoKndrQ2FwdGlv bkFwcGVhcmFuY2VDb3B5QmFja2dyb3VuZENvbG9yKSh2b2lkKTsKLUNHQ29sb3JSZWYoKndrQ2Fw dGlvbkFwcGVhcmFuY2VDb3B5V2luZG93Q29sb3IpKHZvaWQpOwotYm9vbCgqd2tDYXB0aW9uQXBw ZWFyYW5jZUdldEZvcmVncm91bmRPcGFjaXR5KShDR0Zsb2F0Kik7Ci1ib29sKCp3a0NhcHRpb25B cHBlYXJhbmNlR2V0QmFja2dyb3VuZE9wYWNpdHkpKENHRmxvYXQqKTsKLWJvb2woKndrQ2FwdGlv bkFwcGVhcmFuY2VHZXRXaW5kb3dPcGFjaXR5KShDR0Zsb2F0Kik7Ci1DR0ZvbnRSZWYoKndrQ2Fw dGlvbkFwcGVhcmFuY2VDb3B5Rm9udEZvclN0eWxlKShpbnQpOwotYm9vbCgqd2tDYXB0aW9uQXBw ZWFyYW5jZUdldFJlbGF0aXZlQ2hhcmFjdGVyU2l6ZSkoQ0dGbG9hdCopOwotaW50KCp3a0NhcHRp b25BcHBlYXJhbmNlR2V0VGV4dEVkZ2VTdHlsZSkodm9pZCk7Ci1DRlN0cmluZ1JlZigqd2tDYXB0 aW9uQXBwZWFyYW5jZUdldFNldHRpbmdzQ2hhbmdlZE5vdGlmaWNhdGlvbikodm9pZCk7CkluZGV4 OiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIv Q2hhbmdlTG9nCShyZXZpc2lvbiAxNDMwODIpCisrKyBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cJ KHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMy0wMi0xNSAgRXJpYyBDYXJsc29u ICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KKworICAgICAgICBbTWFjXSByZW1vdmUgd2tDYXB0 aW9uQXBwZWFyYW5jZSBmcm9tIFdlYktpdFN5c3RlbUludGVyZmFjZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5OTk2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYkNvcmVTdXBw b3J0L21hYy9XZWJTeXN0ZW1JbnRlcmZhY2UubW06CisgICAgICAgIChJbml0V2ViQ29yZVN5c3Rl bUludGVyZmFjZSk6CisKIDIwMTMtMDItMTUgIEFkZW5pbHNvbiBDYXZhbGNhbnRpICA8Y2F2YWxj YW50aWlAZ21haWwuY29tPgogCiAgICAgICAgIFtRdF1bV0syXSBDcmFzaCBvbiB3aW5kb3cgcmVz aXplIGlmIFdlYlByb2Nlc3MgaXMgY2xvc2VkL2NyYXNoZWQKSW5kZXg6IFNvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvbWFjL1dlYlN5c3RlbUludGVyZmFjZS5tbQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L21hYy9X ZWJTeXN0ZW1JbnRlcmZhY2UubW0JKHJldmlzaW9uIDE0MzAyMikKKysrIFNvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvbWFjL1dlYlN5c3RlbUludGVyZmFjZS5tbQkod29y a2luZyBjb3B5KQpAQCAtMTgzLDE3ICsxODMsNSBAQCB2b2lkIEluaXRXZWJDb3JlU3lzdGVtSW50 ZXJmYWNlKHZvaWQpCiAgICAgICAgIElOSVQoTlNSZWJvdW5kRGVsdGFGb3JFbGFzdGljRGVsdGEp OwogI2VuZGlmCiAKLSAgICAgICAgSU5JVChDYXB0aW9uQXBwZWFyYW5jZUhhc1VzZXJQcmVmZXJl bmNlcyk7Ci0gICAgICAgIElOSVQoQ2FwdGlvbkFwcGVhcmFuY2VTaG93Q2FwdGlvbnNXaGVuQXZh aWxhYmxlKTsKLSAgICAgICAgSU5JVChDYXB0aW9uQXBwZWFyYW5jZUNvcHlGb3JlZ3JvdW5kQ29s b3IpOwotICAgICAgICBJTklUKENhcHRpb25BcHBlYXJhbmNlQ29weUJhY2tncm91bmRDb2xvcik7 Ci0gICAgICAgIElOSVQoQ2FwdGlvbkFwcGVhcmFuY2VDb3B5V2luZG93Q29sb3IpOwotICAgICAg ICBJTklUKENhcHRpb25BcHBlYXJhbmNlR2V0Rm9yZWdyb3VuZE9wYWNpdHkpOwotICAgICAgICBJ TklUKENhcHRpb25BcHBlYXJhbmNlR2V0QmFja2dyb3VuZE9wYWNpdHkpOwotICAgICAgICBJTklU KENhcHRpb25BcHBlYXJhbmNlR2V0V2luZG93T3BhY2l0eSk7Ci0gICAgICAgIElOSVQoQ2FwdGlv bkFwcGVhcmFuY2VDb3B5Rm9udEZvclN0eWxlKTsKLSAgICAgICAgSU5JVChDYXB0aW9uQXBwZWFy YW5jZUdldFJlbGF0aXZlQ2hhcmFjdGVyU2l6ZSk7Ci0gICAgICAgIElOSVQoQ2FwdGlvbkFwcGVh cmFuY2VHZXRUZXh0RWRnZVN0eWxlKTsKLSAgICAgICAgSU5JVChDYXB0aW9uQXBwZWFyYW5jZUdl dFNldHRpbmdzQ2hhbmdlZE5vdGlmaWNhdGlvbik7CiAgICAgfSk7CiB9CkluZGV4OiBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9tYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNDMwODIpCisrKyBTb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cJ KHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMy0wMi0xNSAgRXJpYyBDYXJsc29u ICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KKworICAgICAgICBbTWFjXSByZW1vdmUgd2tDYXB0 aW9uQXBwZWFyYW5jZSBmcm9tIFdlYktpdFN5c3RlbUludGVyZmFjZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5OTk2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9XZWJTeXN0 ZW1JbnRlcmZhY2UubW06CisgICAgICAgIChJbml0V2ViQ29yZVN5c3RlbUludGVyZmFjZSk6CisK IDIwMTMtMDItMTUgIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBkaWdpYS5j b20+CiAKICAgICAgICAgU2ltcGxpZnkgaGl0VGVzdFJlc3VsdEF0UG9pbnQgYW5kIG5vZGVzRnJv bVJlY3QgQVBJcwpJbmRleDogU291cmNlL1dlYktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViU3lz dGVtSW50ZXJmYWNlLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVT dXBwb3J0L1dlYlN5c3RlbUludGVyZmFjZS5tbQkocmV2aXNpb24gMTQzMDIyKQorKysgU291cmNl L1dlYktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViU3lzdGVtSW50ZXJmYWNlLm1tCSh3b3JraW5n IGNvcHkpCkBAIC0yMjAsMTkgKzIyMCw2IEBAIHZvaWQgSW5pdFdlYkNvcmVTeXN0ZW1JbnRlcmZh Y2Uodm9pZCkKICAgICBJTklUKE5TUmVib3VuZERlbHRhRm9yRWxhc3RpY0RlbHRhKTsKICNlbmRp ZgogCi0gICAgSU5JVChDYXB0aW9uQXBwZWFyYW5jZUhhc1VzZXJQcmVmZXJlbmNlcyk7Ci0gICAg SU5JVChDYXB0aW9uQXBwZWFyYW5jZVNob3dDYXB0aW9uc1doZW5BdmFpbGFibGUpOwotICAgIElO SVQoQ2FwdGlvbkFwcGVhcmFuY2VDb3B5Rm9yZWdyb3VuZENvbG9yKTsKLSAgICBJTklUKENhcHRp b25BcHBlYXJhbmNlQ29weUJhY2tncm91bmRDb2xvcik7Ci0gICAgSU5JVChDYXB0aW9uQXBwZWFy YW5jZUNvcHlXaW5kb3dDb2xvcik7Ci0gICAgSU5JVChDYXB0aW9uQXBwZWFyYW5jZUdldEZvcmVn cm91bmRPcGFjaXR5KTsKLSAgICBJTklUKENhcHRpb25BcHBlYXJhbmNlR2V0QmFja2dyb3VuZE9w YWNpdHkpOwotICAgIElOSVQoQ2FwdGlvbkFwcGVhcmFuY2VHZXRXaW5kb3dPcGFjaXR5KTsKLSAg ICBJTklUKENhcHRpb25BcHBlYXJhbmNlQ29weUZvbnRGb3JTdHlsZSk7Ci0gICAgSU5JVChDYXB0 aW9uQXBwZWFyYW5jZUdldFJlbGF0aXZlQ2hhcmFjdGVyU2l6ZSk7Ci0gICAgSU5JVChDYXB0aW9u QXBwZWFyYW5jZUdldFRleHRFZGdlU3R5bGUpOwotICAgIElOSVQoQ2FwdGlvbkFwcGVhcmFuY2VH ZXRTZXR0aW5nc0NoYW5nZWROb3RpZmljYXRpb24pOwotCiAjZW5kaWYKICAgICBkaWRJbml0ID0g dHJ1ZTsKIH0K