109987 2013-02-15 16:45:07 -0800 [JSC]: ASSERT in KURL(ParsedURLStringTag) under sourceMapURLForScript 2013-02-18 10:34:50 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck apavlov joepeck keishi loislo pfeldman pmuellr simon.fraser timothy vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 834496 0 joepeck 2013-02-15 16:45:07 -0800 * STEPS TO REPRODUCE 1. Load a page with <script src="foo.js"></script> and the script has "//@ sourceURL=/one/two" 2. Open the inspector for the page 3. Reload the page => ASSERT ASSERTION FAILED: url.isEmpty() || isSchemeFirstChar(url[0]) /Volumes/SSData/Development/OSX/webkit/OpenSource/Source/WebCore/platform/KURL.cpp(317) : void WebCore::checkEncodedString(const WTF::String &) 1 0x1040b4825 WebCore::checkEncodedString(WTF::String const&) 2 0x1040af60a WebCore::KURL::parse(WTF::String const&) 3 0x1040af580 WebCore::KURL::KURL(WebCore::ParsedURLStringTag, WTF::String const&) 4 0x1040af543 WebCore::KURL::KURL(WebCore::ParsedURLStringTag, WTF::String const&) 5 0x103a30e16 WebCore::InspectorDebuggerAgent::sourceMapURLForScript(WebCore::ScriptDebugListener::Script const&) 6 0x103a30f3e WebCore::InspectorDebuggerAgent::didParseSource(WTF::String const&, WebCore::ScriptDebugListener::Script const&) 7 0x103a31627 non-virtual thunk to WebCore::InspectorDebuggerAgent::didParseSource(WTF::String const&, WebCore::ScriptDebugListener::Script const&) 8 0x1045abd36 WebCore::ScriptDebugServer::dispatchDidParseSource(WTF::HashSet<WebCore::ScriptDebugListener*, WTF::PtrHash<WebCore::ScriptDebugListener*>, WTF::HashTraits<WebCore::ScriptDebugListener*> > const&, JSC::SourceProvider*, bool) 9 0x1045ac078 WebCore::ScriptDebugServer::sourceParsed(JSC::ExecState*, JSC::SourceProvider*, int, WTF::String const&) 10 0x102212835 (anonymous namespace)::Recompiler::~Recompiler() 11 0x102212265 (anonymous namespace)::Recompiler::~Recompiler() 12 0x102212131 JSC::Debugger::recompileAllJSFunctions(JSC::JSGlobalData*) 13 0x1042038c9 WebCore::PageScriptDebugServer::recompileAllJSFunctions(WebCore::Timer<WebCore::ScriptDebugServer>*) 14 0x1045b4ad3 WebCore::Timer<WebCore::ScriptDebugServer>::fired() 834498 1 joepeck 2013-02-15 16:46:34 -0800 Looks like there was duplicate sourceURL parsing on the JSC side. This caused use to override the real Script.url with the sourceURL before its expected. So in sourceMapURLForScript, JSC was working with the sourceURL url, instead of the real script url. 834500 2 joepeck 2013-02-15 16:46:47 -0800 <rdar://problem/12499647> 834504 3 joepeck 2013-02-15 16:50:58 -0800 I'll try to write a test for this to see if this hits the v8 side as well. 834508 4 joepeck 2013-02-15 16:54:06 -0800 Easier way to test this. Just eval the following in the console: js> //@ sourceURL=/one/two 834520 5 188670 joepeck 2013-02-15 17:11:56 -0800 Created attachment 188670 [PATCH] Proposed fix and test 835607 6 188670 webkit.review.bot 2013-02-18 10:34:45 -0800 Comment on attachment 188670 [PATCH] Proposed fix and test Clearing flags on attachment: 188670 Committed r143240: <http://trac.webkit.org/changeset/143240> 835608 7 webkit.review.bot 2013-02-18 10:34:50 -0800 All reviewed patches have been landed. Closing bug. 188670 2013-02-15 17:11:56 -0800 2013-02-18 10:34:45 -0800 [PATCH] Proposed fix and test sourceurl-1.patch text/plain 4641 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjMWFlODAyLi4zNmFkNDg1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDIt MTUgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBbSlND XTogQVNTRVJUIGluIEtVUkwoUGFyc2VkVVJMU3RyaW5nVGFnKSB1bmRlciBzb3VyY2VNYXBVUkxG b3JTY3JpcHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEwOTk4NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogaW5zcGVjdG9yL2RlYnVnZ2VyL3NvdXJjZS11cmwtY29tbWVudC1leHBlY3RlZC50eHQ6Cisg ICAgICAgICogaW5zcGVjdG9yL2RlYnVnZ2VyL3NvdXJjZS11cmwtY29tbWVudC5odG1sOgorICAg ICAgICBBZGQgYSB0ZXN0IGZvciBhIHNvdXJjZVVSTCB3aXRoIGEgbm9uLXJlbGF0aXZlIHBhdGgu IFRoaXMgd2FzIGNhdXNpbmcKKyAgICAgICAgYW4gQVNTRVJULCByaWdodGZ1bGx5IHNvLCBpbiBK U0MgYnVpbGRzLgorCiAyMDEzLTAyLTE0ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgUGFkZGluZyBhbmQgYm9yZGVyIGNoYW5nZXMgZG9lc24ndCB0cmlnZ2VyIHJl bGF5b3V0IG9mIGNoaWxkcmVuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZGVi dWdnZXIvc291cmNlLXVybC1jb21tZW50LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2luc3Bl Y3Rvci9kZWJ1Z2dlci9zb3VyY2UtdXJsLWNvbW1lbnQtZXhwZWN0ZWQudHh0CmluZGV4IDVlZTlm YjguLjdmODNhN2YgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9kZWJ1Z2dlci9z b3VyY2UtdXJsLWNvbW1lbnQtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rv ci9kZWJ1Z2dlci9zb3VyY2UtdXJsLWNvbW1lbnQtZXhwZWN0ZWQudHh0CkBAIC0xMSw1ICsxMSw5 IEBAIGZ1bmN0aW9uIGtlZXBBbGl2ZSgpIHt9CiBSdW5uaW5nOiB0ZXN0U291cmNlVVJMQ29tbWVu dEluRHluYW1pY1NjcmlwdAogZnVuY3Rpb24ga2VlcEFsaXZlSW5EeW5hbWljU2NyaXB0KCkge30K IC8vQCBzb3VyY2VVUkw9ZHluYW1pY1NjcmlwdFVSTC5qcworCitSdW5uaW5nOiB0ZXN0Tm9uUmVs YXRpdmVVUkwKK2Z1bmN0aW9uIHJlbGF0aXZlVVJMU2NyaXB0KCkge30KKy8vQCBzb3VyY2VVUkw9 L2pzL25vblJlbGF0aXZlVVJMLmpzCiBEZWJ1Z2dlciB3YXMgZGlzYWJsZWQuCiAKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9kZWJ1Z2dlci9zb3VyY2UtdXJsLWNvbW1lbnQuaHRt bCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9kZWJ1Z2dlci9zb3VyY2UtdXJsLWNvbW1lbnQuaHRt bAppbmRleCA3MzllZGYzLi5iMGU2Y2Q5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0 b3IvZGVidWdnZXIvc291cmNlLXVybC1jb21tZW50Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvaW5z cGVjdG9yL2RlYnVnZ2VyL3NvdXJjZS11cmwtY29tbWVudC5odG1sCkBAIC0xMyw2ICsxMywxMSBA QCBmdW5jdGlvbiBkb0V2YWwoKQogICAgIGV2YWwoImZ1bmN0aW9uIGtlZXBBbGl2ZSgpIHt9XG4v L0Agc291cmNlVVJMPWV2YWxVUkwuanMiKTsKIH0KIAorZnVuY3Rpb24gZG9FdmFsV2l0aE5vblJl bGF0aXZlVVJMKCkKK3sKKyAgICBldmFsKCJmdW5jdGlvbiByZWxhdGl2ZVVSTFNjcmlwdCgpIHt9 XG4vL0Agc291cmNlVVJMPS9qcy9ub25SZWxhdGl2ZVVSTC5qcyIpOworfQorCiBmdW5jdGlvbiBk b0R5bmFtaWNTY3JpcHQoKQogewogICAgIHZhciBzY3JpcHRFbGVtZW50ID0gZG9jdW1lbnQuY3Jl YXRlRWxlbWVudCgic2NyaXB0Iik7CkBAIC04Nyw2ICs5MiwyNCBAQCBmdW5jdGlvbiB0ZXN0KCkK ICAgICAgICAgICAgICAgICBmb3JFYWNoU2NyaXB0TWF0Y2hpbmdVUkwoImR5bmFtaWNTY3JpcHRV UkwuanMiLCBjaGVja1NjcmlwdEhhc1NvdXJjZVVSTCk7CiAgICAgICAgICAgICAgICAgbmV4dCgp OwogICAgICAgICAgICAgfQorICAgICAgICB9LAorCisgICAgICAgIGZ1bmN0aW9uIHRlc3ROb25S ZWxhdGl2ZVVSTChuZXh0KQorICAgICAgICB7CisgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LnNo b3dTY3JpcHRTb3VyY2UoIm5vblJlbGF0aXZlVVJMLmpzIiwgZGlkU2hvd1NjcmlwdFNvdXJjZSk7 CisgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmV2YWx1YXRlSW5QYWdlKCJzZXRUaW1lb3V0KGRv RXZhbFdpdGhOb25SZWxhdGl2ZVVSTCwgMCkiKTsKKworICAgICAgICAgICAgZnVuY3Rpb24gZGlk U2hvd1NjcmlwdFNvdXJjZShzb3VyY2VGcmFtZSkKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAg ICAgICBmdW5jdGlvbiBjaGVja1NjcmlwdEhhc1NvdXJjZVVSTChzY3JpcHQpCisgICAgICAgICAg ICAgICAgeworICAgICAgICAgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmFzc2VydFRydWUoc2Ny aXB0Lmhhc1NvdXJjZVVSTCwgImhhc1NvdXJjZVVSTCBmbGFnIGlzIG5vdCBzZXQgZm9yIGV2YWwg d2l0aCBhIG5vbi1yZWxhdGl2ZSBVUkwgaW4gYSBzb3VyY2VVUkwgY29tbWVudCIpOworICAgICAg ICAgICAgICAgIH0KKworICAgICAgICAgICAgICAgIEluc3BlY3RvclRlc3QuYWRkUmVzdWx0KHNv dXJjZUZyYW1lLnRleHRFZGl0b3IudGV4dCgpKTsKKyAgICAgICAgICAgICAgICBmb3JFYWNoU2Ny aXB0TWF0Y2hpbmdVUkwoIm5vblJlbGF0aXZlVVJMLmpzIiwgY2hlY2tTY3JpcHRIYXNTb3VyY2VV UkwpOworICAgICAgICAgICAgICAgIG5leHQoKTsKKyAgICAgICAgICAgIH0KICAgICAgICAgfQog ICAgIF0pOwogfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmYzEyZWU1Li5jZTg0MmE2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTMtMDItMTUgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFw cGxlLmNvbT4KKworICAgICAgICBbSlNDXTogQVNTRVJUIGluIEtVUkwoUGFyc2VkVVJMU3RyaW5n VGFnKSB1bmRlciBzb3VyY2VNYXBVUkxGb3JTY3JpcHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTk4NworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEltcHJvdmVkIGFuIGV4aXN0aW5nIHRlc3QgdG8gY292 ZXIgdGhpcy4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL1NjcmlwdERlYnVnU2VydmVyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdERlYnVnU2VydmVyOjpkaXNwYXRjaERpZFBhcnNlU291 cmNlKToKKyAgICAgICAgUmVtb3ZlIHRoZSBzb3VyY2VVUkwgcGFyc2luZyBhbmQgc2NyaXB0LnVy bCByZXBsYWNlbWVudCBmcm9tIHRoZSBKU0MKKyAgICAgICAgaW1wbGVtZW50YXRpb24gb2YgU2Ny aXB0RGVidWdTZXJ2ZXIuIFRoZSBXZWJDb3JlIGluc3BlY3RvciBjb2RlIHRoYXQKKyAgICAgICAg dGhpcyB3YXMgYWRkZWQgZm9yIGFscmVhZHkgZG9lcyB0aGlzLCBhdCBhIG1vcmUgYXBwcm9wcmlh dGUgdGltZS4KKwogMjAxMy0wMi0xMCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgogCiAgICAgICAgIFtpT1NdIEVuYWJsZSBQQUdFX1ZJU0lCSUxJVFlfQVBJCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHREZWJ1Z1NlcnZlci5jcHAgYi9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHREZWJ1Z1NlcnZlci5jcHAKaW5kZXggOTkx MWQ0ZC4uMWM2MzY0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2Ny aXB0RGVidWdTZXJ2ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1Njcmlw dERlYnVnU2VydmVyLmNwcApAQCAtMjkyLDE0ICsyOTIsNiBAQCB2b2lkIFNjcmlwdERlYnVnU2Vy dmVyOjpkaXNwYXRjaERpZFBhcnNlU291cmNlKGNvbnN0IExpc3RlbmVyU2V0JiBsaXN0ZW5lcnMs IFNvdQogICAgIHNjcmlwdC5zdGFydENvbHVtbiA9IHNvdXJjZVByb3ZpZGVyLT5zdGFydFBvc2l0 aW9uKCkubV9jb2x1bW4uemVyb0Jhc2VkSW50KCk7CiAgICAgc2NyaXB0LmlzQ29udGVudFNjcmlw dCA9IGlzQ29udGVudFNjcmlwdDsKIAotI2lmIEVOQUJMRShJTlNQRUNUT1IpCi0gICAgaWYgKCFz Y3JpcHQuc3RhcnRMaW5lICYmICFzY3JpcHQuc3RhcnRDb2x1bW4pIHsKLSAgICAgICAgU3RyaW5n IHNvdXJjZVVSTCA9IENvbnRlbnRTZWFyY2hVdGlsczo6ZmluZFNvdXJjZVVSTChzY3JpcHQuc291 cmNlKTsKLSAgICAgICAgaWYgKCFzb3VyY2VVUkwuaXNFbXB0eSgpKQotICAgICAgICAgICAgc2Ny aXB0LnVybCA9IHNvdXJjZVVSTDsKLSAgICB9Ci0jZW5kaWYKLQogICAgIGludCBzb3VyY2VMZW5n dGggPSBzY3JpcHQuc291cmNlLmxlbmd0aCgpOwogICAgIGludCBsaW5lQ291bnQgPSAxOwogICAg IGludCBsYXN0TGluZVN0YXJ0ID0gMDsK