109930 2013-02-15 05:41:04 -0800 Web Inspector: highlight record revealed in Timeline 2013-02-15 07:49:10 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys yurys apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs yurys oldest_to_newest 833929 0 yurys 2013-02-15 05:41:04 -0800 If user clicks on the memory graph, corresponding record is revealed in the viewport above but it is hard to tell which record exactly was revealed. Highlighting it would make the record more prominent. 833931 1 188547 yurys 2013-02-15 05:42:33 -0800 Created attachment 188547 Patch 833938 2 188547 loislo 2013-02-15 06:04:57 -0800 Comment on attachment 188547 Patch lgtm 833942 3 188547 pfeldman 2013-02-15 06:07:58 -0800 Comment on attachment 188547 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188547&action=review > Source/WebCore/inspector/front-end/TimelinePanel.js:940 > + this._highlightedListRowElement = null; delete this._highlightedListRowElement 834024 4 yurys 2013-02-15 07:49:10 -0800 Committed r142999: <http://trac.webkit.org/changeset/142999> 188547 2013-02-15 05:42:33 -0800 2013-02-15 06:07:58 -0800 Patch bug-109930-20130215173859.patch text/plain 4493 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyOTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjI2MzUwMTk0NmZkOGVk OTdkODkzYzczMTc4NDM5M2FiM2NiYjFjMy4uZTA3MjhiMDY0ZWVmMWNkOTM3ZTVmZjIwOTdhOGE5 MTFmZGI1MjVkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAyLTE1ICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGhpZ2hsaWdodCByZWNvcmQgcmV2ZWFsZWQgaW4gVGltZWxpbmUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTkzMAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJldmVhbGVkIHRpbWVsaW5lIHJlY29y ZCBpcyBub3cgaGlnaGxpZ2h0ZWQgd2l0aCB5ZWxsb3cgYmFja2dyb3VuZAorICAgICAgICB0aGF0 IGZhZGVzIG91dCBpbiAyIHNlY29uZHMuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5k L1RpbWVsaW5lUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVQYW5lbC5w cm90b3R5cGUuX3JldmVhbFJlY29yZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVQ YW5lbC5wcm90b3R5cGUuX3JlZnJlc2hSZWNvcmRzKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5U aW1lbGluZVBhbmVsLnByb3RvdHlwZS5fY2xlYXJSZWNvcmRIaWdobGlnaHQpOgorICAgICAgICAq IGluc3BlY3Rvci9mcm9udC1lbmQvdGltZWxpbmVQYW5lbC5jc3M6CisgICAgICAgICguaGlnaGxp Z2h0ZWQtdGltZWxpbmUtcmVjb3JkKToKKyAgICAgICAgKEAtd2Via2l0LWtleWZyYW1lcyB0aW1l bGluZV9yZWNvcmRfaGlnaGxpZ2h0KToKKyAgICAgICAgKHRvKToKKwogMjAxMy0wMi0xNCAgQW5k cmV5IEFkYWlraW4gIDxhYW5kcmV5QGNocm9taXVtLm9yZz4KIAogICAgICAgICBVc2UgR0wgdHlw ZWRlZnMgaW4gV2ViR0xSZW5kZXJpbmdDb250ZXh0LmlkbApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZVBhbmVsLmpzIGIvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZVBhbmVsLmpzCmluZGV4IGM1YTYyYjBjZmJh ODM3OWFkMWM2ODBiYmIwNWRhMWZlMzU1N2ZkY2MuLmMwM2RhOWIxYTVhNTk1Y2FhMDRhODc1NGI2 NDZhZTk2OTg2NDMyZjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvVGltZWxpbmVQYW5lbC5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL1RpbWVsaW5lUGFuZWwuanMKQEAgLTgxNyw2ICs4MTcsNyBAQCBXZWJJbnNwZWN0b3Iu VGltZWxpbmVQYW5lbC5wcm90b3R5cGUgPSB7CiAgICAgX3JldmVhbFJlY29yZDogZnVuY3Rpb24o cmVjb3JkVG9SZXZlYWwpCiAgICAgewogICAgICAgICAvLyBFeHBhbmQgYWxsIGFuY2VzdG9ycy4K KyAgICAgICAgdGhpcy5fcmVjb3JkVG9IaWdobGlnaHQgPSByZWNvcmRUb1JldmVhbDsKICAgICAg ICAgdmFyIHRyZWVVcGRhdGVkID0gZmFsc2U7CiAgICAgICAgIGZvciAodmFyIHBhcmVudCA9IHJl Y29yZFRvUmV2ZWFsLnBhcmVudDsgcGFyZW50ICE9PSB0aGlzLl9yb290UmVjb3JkKCk7IHBhcmVu dCA9IHBhcmVudC5wYXJlbnQpIHsKICAgICAgICAgICAgIHRyZWVVcGRhdGVkID0gdHJlZVVwZGF0 ZWQgfHwgcGFyZW50LmNvbGxhcHNlZDsKQEAgLTg2OCw2ICs4NjksMTAgQEAgV2ViSW5zcGVjdG9y LlRpbWVsaW5lUGFuZWwucHJvdG90eXBlID0gewogICAgICAgICB0aGlzLl9pdGVtc0dyYXBoc0Vs ZW1lbnQucmVtb3ZlQ2hpbGQodGhpcy5fZXhwYW5kRWxlbWVudHMpOwogICAgICAgICB0aGlzLl9l eHBhbmRFbGVtZW50cy5yZW1vdmVDaGlsZHJlbigpOwogCisgICAgICAgIHRoaXMuX2NsZWFyUmVj b3JkSGlnaGxpZ2h0KCk7CisgICAgICAgIHZhciBoaWdobGlnaHRlZFJlY29yZCA9IHRoaXMuX3Jl Y29yZFRvSGlnaGxpZ2h0OworICAgICAgICB0aGlzLl9yZWNvcmRUb0hpZ2hsaWdodCA9IG51bGw7 CisKICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBlbmRJbmRleDsgKytpKSB7CiAgICAgICAg ICAgICB2YXIgcmVjb3JkID0gcmVjb3Jkc0luV2luZG93W2ldOwogICAgICAgICAgICAgdmFyIGlz RXZlbiA9ICEoaSAlIDIpOwpAQCAtODg5LDYgKzg5NCwxMSBAQCBXZWJJbnNwZWN0b3IuVGltZWxp bmVQYW5lbC5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICAgICAgICAgIHRoaXMuX2dyYXBoUm93 c0VsZW1lbnQuYXBwZW5kQ2hpbGQoZ3JhcGhSb3dFbGVtZW50KTsKICAgICAgICAgICAgICAgICB9 CiAKKyAgICAgICAgICAgICAgICBpZiAoaGlnaGxpZ2h0ZWRSZWNvcmQgPT09IHJlY29yZCkgewor ICAgICAgICAgICAgICAgICAgICB0aGlzLl9oaWdobGlnaHRlZExpc3RSb3dFbGVtZW50ID0gbGlz dFJvd0VsZW1lbnQ7CisgICAgICAgICAgICAgICAgICAgIHRoaXMuX2hpZ2hsaWdodGVkR3JhcGhS b3dFbGVtZW50ID0gZ3JhcGhSb3dFbGVtZW50OworICAgICAgICAgICAgICAgIH0KKwogICAgICAg ICAgICAgICAgIGxpc3RSb3dFbGVtZW50LnJvdy51cGRhdGUocmVjb3JkLCBpc0V2ZW4sIHZpc2li bGVUb3ApOwogICAgICAgICAgICAgICAgIGdyYXBoUm93RWxlbWVudC5yb3cudXBkYXRlKHJlY29y ZCwgaXNFdmVuLCB0aGlzLl9jYWxjdWxhdG9yLCB0aGlzLl9leHBhbmRPZmZzZXQsIGkpOwogCkBA IC05MTQsOSArOTI0LDI0IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZVBhbmVsLnByb3RvdHlwZSA9 IHsKICAgICAgICAgdGhpcy5fYWRqdXN0U2Nyb2xsUG9zaXRpb24oKHJlY29yZHNJbldpbmRvdy5s ZW5ndGggKyB0aGlzLl9oZWFkZXJMaW5lQ291bnQpICogcm93SGVpZ2h0KTsKICAgICAgICAgdGhp cy5fdXBkYXRlU2VhcmNoSGlnaGxpZ2h0KGZhbHNlKTsKIAorICAgICAgICBpZiAodGhpcy5faGln aGxpZ2h0ZWRMaXN0Um93RWxlbWVudCkgeworICAgICAgICAgICAgdGhpcy5faGlnaGxpZ2h0ZWRM aXN0Um93RWxlbWVudC5hZGRTdHlsZUNsYXNzKCJoaWdobGlnaHRlZC10aW1lbGluZS1yZWNvcmQi KTsKKyAgICAgICAgICAgIHRoaXMuX2hpZ2hsaWdodGVkR3JhcGhSb3dFbGVtZW50LmFkZFN0eWxl Q2xhc3MoImhpZ2hsaWdodGVkLXRpbWVsaW5lLXJlY29yZCIpOworICAgICAgICB9CisKICAgICAg ICAgcmV0dXJuIHJlY29yZHNJbldpbmRvdy5sZW5ndGg7CiAgICAgfSwKIAorICAgIF9jbGVhclJl Y29yZEhpZ2hsaWdodDogZnVuY3Rpb24oKQorICAgIHsKKyAgICAgICAgaWYgKCF0aGlzLl9oaWdo bGlnaHRlZExpc3RSb3dFbGVtZW50KQorICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB0aGlz Ll9oaWdobGlnaHRlZExpc3RSb3dFbGVtZW50LnJlbW92ZVN0eWxlQ2xhc3MoImhpZ2hsaWdodGVk LXRpbWVsaW5lLXJlY29yZCIpOworICAgICAgICB0aGlzLl9oaWdobGlnaHRlZExpc3RSb3dFbGVt ZW50ID0gbnVsbDsKKyAgICAgICAgdGhpcy5faGlnaGxpZ2h0ZWRHcmFwaFJvd0VsZW1lbnQucmVt b3ZlU3R5bGVDbGFzcygiaGlnaGxpZ2h0ZWQtdGltZWxpbmUtcmVjb3JkIik7CisgICAgICAgIHRo aXMuX2hpZ2hsaWdodGVkR3JhcGhSb3dFbGVtZW50ID0gbnVsbDsKKyAgICB9LAorCiAgICAgX3Jl ZnJlc2hNYWluVGhyZWFkQmFyczogZnVuY3Rpb24oKQogICAgIHsKICAgICAgICAgY29uc3QgYmFy T2Zmc2V0ID0gMzsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvdGltZWxpbmVQYW5lbC5jc3MgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L3RpbWVsaW5lUGFuZWwuY3NzCmluZGV4IGQ2ZTI4ODk2ZWNjZmFhYzI2MGZjMWZlZTU1MTY1NjY5 MmU0ZGZkOGEuLjA4ZDAyODcyMTU3MGJiNDcyMzE3MmM1MTQ2YmI1NDYwMjNmNTViNDcgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvdGltZWxpbmVQYW5lbC5j c3MKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC90aW1lbGluZVBhbmVs LmNzcwpAQCAtNjg4LDMgKzY4OCwxMiBAQAogLm1lbW9yeS1jYXRlZ29yeS12YWx1ZSB7CiAgICAg ZmxvYXQ6IHJpZ2h0OwogfQorCisuaGlnaGxpZ2h0ZWQtdGltZWxpbmUtcmVjb3JkIHsKKyAgICAt d2Via2l0LWFuaW1hdGlvbjogInRpbWVsaW5lX3JlY29yZF9oaWdobGlnaHQiIDJzIDBzOworfQor CitALXdlYmtpdC1rZXlmcmFtZXMgdGltZWxpbmVfcmVjb3JkX2hpZ2hsaWdodCB7CisgICAgZnJv bSB7YmFja2dyb3VuZC1jb2xvcjogcmdiYSgyNTUsIDI1NSwgMTIwLCAxKTsgfQorICAgIHRvIHsg YmFja2dyb3VuZC1jb2xvcjogcmdiYSgyNTUsIDI1NSwgMTIwLCAwKTsgfQorfQo=