109929 2013-02-15 05:22:30 -0800 Fix build warnings after r139853 2013-02-16 13:02:21 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 seokju webkit-unassigned webkit.review.bot oldest_to_newest 833920 0 seokju 2013-02-15 05:22:30 -0800 Use UNUSED_PARAM macro to fix build warning -Wunused-parameter. 833922 1 188546 seokju 2013-02-15 05:25:55 -0800 Created attachment 188546 Patch 834194 2 188546 webkit.review.bot 2013-02-15 11:13:31 -0800 Comment on attachment 188546 Patch Rejecting attachment 188546 from review queue. ap@webkit.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. 834196 3 188546 webkit.review.bot 2013-02-15 11:14:09 -0800 Comment on attachment 188546 Patch Rejecting attachment 188546 from commit-queue. ap@webkit.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 834586 4 188682 seokju 2013-02-15 18:43:06 -0800 Created attachment 188682 Patch 834785 5 188682 webkit.review.bot 2013-02-16 13:02:17 -0800 Comment on attachment 188682 Patch Clearing flags on attachment: 188682 Committed r143108: <http://trac.webkit.org/changeset/143108> 834786 6 webkit.review.bot 2013-02-16 13:02:21 -0800 All reviewed patches have been landed. Closing bug. 188546 2013-02-15 05:25:55 -0800 2013-02-15 18:42:59 -0800 Patch bug-109929-20130215222221.patch text/plain 2708 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyOTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmEyYWJiNDc4NDFlN2Nj Y2E2ZWM3ZTMyOWI0OTQ3YmY4ZDYzMzk0Yi4uN2JlNmM5N2U3NWJkODZjYzgxYTc1MDJkYTNlYmEz NDcyYjUwNmI5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAyLTE1ICBTZW9r anUgS3dvbiAgPHNlb2tqdS5rd29uQGdtYWlsLmNvbT4KKworICAgICAgICBbV0syXSBGaXggYnVp bGQgd2FybmluZ3MgYWZ0ZXIgcjEzOTg1MworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTA5OTI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVXNlIFVOVVNFRF9QQVJBTSBtYWNybyB0byBmaXggYnVpbGQgd2Fy bmluZyAtV3VudXNlZC1wYXJhbWV0ZXIKKyAgICAgICAgd2hlbiBJTlNQRUNUT1IgaXMgZGlzYWJs ZWQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAg ICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uLmg6CisgICAgICAgIChXZWJD b3JlOjpJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246OmZyYW1lU3RhcnRlZExvYWRpbmcpOgorICAg ICAgICAoV2ViQ29yZTo6SW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uOjpmcmFtZVN0b3BwZWRMb2Fk aW5nKToKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3Rvckluc3RydW1lbnRhdGlvbjo6ZnJhbWVT Y2hlZHVsZWROYXZpZ2F0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3Rvckluc3RydW1l bnRhdGlvbjo6ZnJhbWVDbGVhcmVkU2NoZWR1bGVkTmF2aWdhdGlvbik6CisKIDIwMTMtMDItMTUg IFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVu cmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxNDI4NzYuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uLmggYi9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uLmgKaW5kZXggNTNhZmU2ODI1ZDA0NDVj MzEzNWVjNTVlMjliNmVhYWFjMzhiZTQzMC4uZTZjNzEyOGNlNTliN2JhM2Q0ZmYzN2YzYTM2NWQw MGRhYmYzNTQ3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rv ckluc3RydW1lbnRhdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0 b3JJbnN0cnVtZW50YXRpb24uaApAQCAtMTY3MSw2ICsxNjcxLDggQEAgaW5saW5lIHZvaWQgSW5z cGVjdG9ySW5zdHJ1bWVudGF0aW9uOjpmcmFtZVN0YXJ0ZWRMb2FkaW5nKEZyYW1lKiBmcmFtZSkK ICNpZiBFTkFCTEUoSU5TUEVDVE9SKQogICAgIGlmIChJbnN0cnVtZW50aW5nQWdlbnRzKiBpbnN0 cnVtZW50aW5nQWdlbnRzID0gaW5zdHJ1bWVudGluZ0FnZW50c0ZvckZyYW1lKGZyYW1lKSkKICAg ICAgICAgZnJhbWVTdGFydGVkTG9hZGluZ0ltcGwoaW5zdHJ1bWVudGluZ0FnZW50cywgZnJhbWUp OworI2Vsc2UKKyAgICBVTlVTRURfUEFSQU0oZnJhbWUpOwogI2VuZGlmCiB9CiAKQEAgLTE2Nzks NiArMTY4MSw4IEBAIGlubGluZSB2b2lkIEluc3BlY3Rvckluc3RydW1lbnRhdGlvbjo6ZnJhbWVT dG9wcGVkTG9hZGluZyhGcmFtZSogZnJhbWUpCiAjaWYgRU5BQkxFKElOU1BFQ1RPUikKICAgICBp ZiAoSW5zdHJ1bWVudGluZ0FnZW50cyogaW5zdHJ1bWVudGluZ0FnZW50cyA9IGluc3RydW1lbnRp bmdBZ2VudHNGb3JGcmFtZShmcmFtZSkpCiAgICAgICAgIGZyYW1lU3RvcHBlZExvYWRpbmdJbXBs KGluc3RydW1lbnRpbmdBZ2VudHMsIGZyYW1lKTsKKyNlbHNlCisgICAgVU5VU0VEX1BBUkFNKGZy YW1lKTsKICNlbmRpZgogfQogCkBAIC0xNjg3LDYgKzE2OTEsOSBAQCBpbmxpbmUgdm9pZCBJbnNw ZWN0b3JJbnN0cnVtZW50YXRpb246OmZyYW1lU2NoZWR1bGVkTmF2aWdhdGlvbihGcmFtZSogZnJh bWUsIGRvdQogI2lmIEVOQUJMRShJTlNQRUNUT1IpCiAgICAgaWYgKEluc3RydW1lbnRpbmdBZ2Vu dHMqIGluc3RydW1lbnRpbmdBZ2VudHMgPSBpbnN0cnVtZW50aW5nQWdlbnRzRm9yRnJhbWUoZnJh bWUpKQogICAgICAgICBmcmFtZVNjaGVkdWxlZE5hdmlnYXRpb25JbXBsKGluc3RydW1lbnRpbmdB Z2VudHMsIGZyYW1lLCBkZWxheSk7CisjZWxzZQorICAgIFVOVVNFRF9QQVJBTShmcmFtZSk7Cisg ICAgVU5VU0VEX1BBUkFNKGRlbGF5KTsKICNlbmRpZgogfQogCkBAIC0xNjk1LDYgKzE3MDIsOCBA QCBpbmxpbmUgdm9pZCBJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246OmZyYW1lQ2xlYXJlZFNjaGVk dWxlZE5hdmlnYXRpb24oRnJhbWUqIGZyYQogI2lmIEVOQUJMRShJTlNQRUNUT1IpCiAgICAgaWYg KEluc3RydW1lbnRpbmdBZ2VudHMqIGluc3RydW1lbnRpbmdBZ2VudHMgPSBpbnN0cnVtZW50aW5n QWdlbnRzRm9yRnJhbWUoZnJhbWUpKQogICAgICAgICBmcmFtZUNsZWFyZWRTY2hlZHVsZWROYXZp Z2F0aW9uSW1wbChpbnN0cnVtZW50aW5nQWdlbnRzLCBmcmFtZSk7CisjZWxzZQorICAgIFVOVVNF RF9QQVJBTShmcmFtZSk7CiAjZW5kaWYKIH0KIAo= 188682 2013-02-15 18:43:06 -0800 2013-02-16 13:02:16 -0800 Patch bug-109929-20130216113931.patch text/plain 2751 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzMDc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTM1NmFmZWU0M2ZiYzJj OWY5MDAwNDE2M2UxZjRhZGU0OWFjNGQzOC4uMTRmZDc4MGZlMGU5ZDg3NDk2YzY1NzAzODY5ZThj N2Y2ZGRmNTA2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAyLTE1ICBTZW9r anUgS3dvbiAgPHNlb2tqdS5rd29uQGdtYWlsLmNvbT4KKworICAgICAgICBGaXggYnVpbGQgd2Fy bmluZ3MgYWZ0ZXIgcjEzOTg1MworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTA5OTI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWxleGV5IFByb3NrdXJ5 YWtvdi4KKworICAgICAgICBVc2UgVU5VU0VEX1BBUkFNIG1hY3JvIHRvIGZpeCBidWlsZCB3YXJu aW5nIC1XdW51c2VkLXBhcmFtZXRlcgorICAgICAgICB3aGVuIElOU1BFQ1RPUiBpcyBkaXNhYmxl ZC4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAg ICAqIGluc3BlY3Rvci9JbnNwZWN0b3JJbnN0cnVtZW50YXRpb24uaDoKKyAgICAgICAgKFdlYkNv cmU6Okluc3BlY3Rvckluc3RydW1lbnRhdGlvbjo6ZnJhbWVTdGFydGVkTG9hZGluZyk6CisgICAg ICAgIChXZWJDb3JlOjpJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246OmZyYW1lU3RvcHBlZExvYWRp bmcpOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uOjpmcmFtZVNj aGVkdWxlZE5hdmlnYXRpb24pOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9ySW5zdHJ1bWVu dGF0aW9uOjpmcmFtZUNsZWFyZWRTY2hlZHVsZWROYXZpZ2F0aW9uKToKKwogMjAxMy0wMi0xNSAg S2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1Y4XSBBbiAi RXZlblRhcmdldCIgdHlwZSBpbiBJREwgc2hvdWxkIGJlIGNvbnZlcnRlZCB0byBFdmVudFRhcmdl dCosIG5vdCB0byBOb2RlKgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0lu c3BlY3Rvckluc3RydW1lbnRhdGlvbi5oIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3Bl Y3Rvckluc3RydW1lbnRhdGlvbi5oCmluZGV4IDUzYWZlNjgyNWQwNDQ1YzMxMzVlYzU1ZTI5YjZl YWFhYzM4YmU0MzAuLmU2YzcxMjhjZTU5YjdiYTNkNGZmMzdmM2EzNjVkMDBkYWJmMzU0NzYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JJbnN0cnVtZW50YXRp b24uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9ySW5zdHJ1bWVudGF0 aW9uLmgKQEAgLTE2NzEsNiArMTY3MSw4IEBAIGlubGluZSB2b2lkIEluc3BlY3Rvckluc3RydW1l bnRhdGlvbjo6ZnJhbWVTdGFydGVkTG9hZGluZyhGcmFtZSogZnJhbWUpCiAjaWYgRU5BQkxFKElO U1BFQ1RPUikKICAgICBpZiAoSW5zdHJ1bWVudGluZ0FnZW50cyogaW5zdHJ1bWVudGluZ0FnZW50 cyA9IGluc3RydW1lbnRpbmdBZ2VudHNGb3JGcmFtZShmcmFtZSkpCiAgICAgICAgIGZyYW1lU3Rh cnRlZExvYWRpbmdJbXBsKGluc3RydW1lbnRpbmdBZ2VudHMsIGZyYW1lKTsKKyNlbHNlCisgICAg VU5VU0VEX1BBUkFNKGZyYW1lKTsKICNlbmRpZgogfQogCkBAIC0xNjc5LDYgKzE2ODEsOCBAQCBp bmxpbmUgdm9pZCBJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246OmZyYW1lU3RvcHBlZExvYWRpbmco RnJhbWUqIGZyYW1lKQogI2lmIEVOQUJMRShJTlNQRUNUT1IpCiAgICAgaWYgKEluc3RydW1lbnRp bmdBZ2VudHMqIGluc3RydW1lbnRpbmdBZ2VudHMgPSBpbnN0cnVtZW50aW5nQWdlbnRzRm9yRnJh bWUoZnJhbWUpKQogICAgICAgICBmcmFtZVN0b3BwZWRMb2FkaW5nSW1wbChpbnN0cnVtZW50aW5n QWdlbnRzLCBmcmFtZSk7CisjZWxzZQorICAgIFVOVVNFRF9QQVJBTShmcmFtZSk7CiAjZW5kaWYK IH0KIApAQCAtMTY4Nyw2ICsxNjkxLDkgQEAgaW5saW5lIHZvaWQgSW5zcGVjdG9ySW5zdHJ1bWVu dGF0aW9uOjpmcmFtZVNjaGVkdWxlZE5hdmlnYXRpb24oRnJhbWUqIGZyYW1lLCBkb3UKICNpZiBF TkFCTEUoSU5TUEVDVE9SKQogICAgIGlmIChJbnN0cnVtZW50aW5nQWdlbnRzKiBpbnN0cnVtZW50 aW5nQWdlbnRzID0gaW5zdHJ1bWVudGluZ0FnZW50c0ZvckZyYW1lKGZyYW1lKSkKICAgICAgICAg ZnJhbWVTY2hlZHVsZWROYXZpZ2F0aW9uSW1wbChpbnN0cnVtZW50aW5nQWdlbnRzLCBmcmFtZSwg ZGVsYXkpOworI2Vsc2UKKyAgICBVTlVTRURfUEFSQU0oZnJhbWUpOworICAgIFVOVVNFRF9QQVJB TShkZWxheSk7CiAjZW5kaWYKIH0KIApAQCAtMTY5NSw2ICsxNzAyLDggQEAgaW5saW5lIHZvaWQg SW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uOjpmcmFtZUNsZWFyZWRTY2hlZHVsZWROYXZpZ2F0aW9u KEZyYW1lKiBmcmEKICNpZiBFTkFCTEUoSU5TUEVDVE9SKQogICAgIGlmIChJbnN0cnVtZW50aW5n QWdlbnRzKiBpbnN0cnVtZW50aW5nQWdlbnRzID0gaW5zdHJ1bWVudGluZ0FnZW50c0ZvckZyYW1l KGZyYW1lKSkKICAgICAgICAgZnJhbWVDbGVhcmVkU2NoZWR1bGVkTmF2aWdhdGlvbkltcGwoaW5z dHJ1bWVudGluZ0FnZW50cywgZnJhbWUpOworI2Vsc2UKKyAgICBVTlVTRURfUEFSQU0oZnJhbWUp OwogI2VuZGlmCiB9CiAK