109925 2013-02-15 04:44:09 -0800 [WK2] Refactoring : Fix indentation and braces in WebInspectorClient.h|cpp 2013-02-28 20:41:51 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 seokju webkit-unassigned ap benjamin buildbot rniwa webkit.review.bot oldest_to_newest 833892 0 seokju 2013-02-15 04:44:09 -0800 The contents of an outermost namespace block should not be indented. And One-line control clauses should not use braces. (http://www.webkit.org/coding/coding-style.html) 833893 1 188537 seokju 2013-02-15 04:46:41 -0800 Created attachment 188537 Patch 834133 2 188537 buildbot 2013-02-15 10:10:14 -0800 Comment on attachment 188537 Patch Attachment 188537 did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16598130 New failing tests: http/tests/inspector/resource-tree/resource-request-content-while-loading.html 834560 3 188678 seokju 2013-02-15 17:50:22 -0800 Created attachment 188678 Patch 844742 4 190872 seokju 2013-02-28 19:59:59 -0800 Created attachment 190872 Patch 844743 5 190872 seokju 2013-02-28 20:00:24 -0800 Comment on attachment 190872 Patch rebased 844744 6 seokju 2013-02-28 20:04:16 -0800 @benjamin Could you take a loot at it? It's a simple thing. 844746 7 190872 benjamin 2013-02-28 20:04:44 -0800 Comment on attachment 190872 Patch Why not. 844762 8 190872 webkit.review.bot 2013-02-28 20:41:48 -0800 Comment on attachment 190872 Patch Clearing flags on attachment: 190872 Committed r144411: <http://trac.webkit.org/changeset/144411> 844763 9 webkit.review.bot 2013-02-28 20:41:51 -0800 All reviewed patches have been landed. Closing bug. 188537 2013-02-15 04:46:41 -0800 2013-02-15 17:50:15 -0800 Patch bug-109925-20130215214306.patch text/plain 2299 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyOTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNWRhMjFmNDVlNTg2MjRi NzI4NTZjMjJiN2Y5NWVkN2RjYTNjOTBkOC4uZDIzZDMxNzkxNWU1NjgwZWE4NDMzZWFiN2RkMjc1 NzI2ZDljY2E1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAyLTE1ICBTZW9r anUgS3dvbiAgPHNlb2tqdS5rd29uQGdtYWlsLmNvbT4KKworICAgICAgICBbV0syXSBSZWZhY3Rv cmluZyA6IEZpeCBpbmRlbnRhdGlvbiBhbmQgYnJhY2VzIGluIFdlYkluc3BlY3RvckNsaWVudC5o fGNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5 OTI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhl IGNvbnRlbnRzIG9mIGFuIG91dGVybW9zdCBuYW1lc3BhY2UgYmxvY2sgc2hvdWxkIG5vdCBiZSBp bmRlbnRlZC4KKyAgICAgICAgQW5kIE9uZS1saW5lIGNvbnRyb2wgY2xhdXNlcyBzaG91bGQgbm90 IHVzZSBicmFjZXMuCisgICAgICAgIGh0dHA6Ly93d3cud2Via2l0Lm9yZy9jb2RpbmcvY29kaW5n LXN0eWxlLmh0bWwKKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViSW5z cGVjdG9yQ2xpZW50LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViSW5zcGVjdG9yQ2xpZW50Ojpj bG9zZUluc3BlY3RvckZyb250ZW5kKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYkNvcmVTdXBw b3J0L1dlYkluc3BlY3RvckNsaWVudC5oOgorICAgICAgICAoV2ViQ29yZSk6CisKIDIwMTMtMDIt MTUgIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBkaWdpYS5jb20+CiAKICAg ICAgICAgU2ltcGxpZnkgaGl0VGVzdFJlc3VsdEF0UG9pbnQgYW5kIG5vZGVzRnJvbVJlY3QgQVBJ cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9X ZWJJbnNwZWN0b3JDbGllbnQuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3Jl U3VwcG9ydC9XZWJJbnNwZWN0b3JDbGllbnQuY3BwCmluZGV4IDY5MDc1ZmEwZmNiZjJmM2I1MTc5 MzAwY2JmZWQzMzk3MjJiOWZiYzguLjk5NzhmOWVhZjRiZWE0ZTM0NmJjYWU1MDhiNDFhMWI1MDVi NTYwYTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBv cnQvV2ViSW5zcGVjdG9yQ2xpZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYkNvcmVTdXBwb3J0L1dlYkluc3BlY3RvckNsaWVudC5jcHAKQEAgLTUyLDkgKzUyLDggQEAg V2ViQ29yZTo6SW5zcGVjdG9yRnJvbnRlbmRDaGFubmVsKiBXZWJJbnNwZWN0b3JDbGllbnQ6Om9w ZW5JbnNwZWN0b3JGcm9udGVuZChJbnMKIAogdm9pZCBXZWJJbnNwZWN0b3JDbGllbnQ6OmNsb3Nl SW5zcGVjdG9yRnJvbnRlbmQoKQogewotICAgIGlmIChtX3BhZ2UtPmluc3BlY3RvcigpKSB7Cisg ICAgaWYgKG1fcGFnZS0+aW5zcGVjdG9yKCkpCiAgICAgICAgIG1fcGFnZS0+aW5zcGVjdG9yKCkt PmRpZENsb3NlKCk7Ci0gICAgfQogfQogCiB2b2lkIFdlYkluc3BlY3RvckNsaWVudDo6YnJpbmdG cm9udGVuZFRvRnJvbnQoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0b3JDbGllbnQuaCBiL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViSW5zcGVjdG9yQ2xpZW50LmgKaW5kZXggODUwMDQxYWYx YjllMzFkNGY0OTAzMDY3ZTY0MjgwODczNGE0NDgyOS4uMjkyN2E4YWJiMzc3NTQyNzE3OTUzYjk4 MmViNDg4NWRlMTA2NmU1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0b3JDbGllbnQuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkluc3BlY3RvckNsaWVudC5oCkBAIC0zNCw4ICsz NCw4IEBACiAjaW5jbHVkZSA8V2ViQ29yZS9JbnNwZWN0b3JGcm9udGVuZENoYW5uZWwuaD4KIAog bmFtZXNwYWNlIFdlYkNvcmUgewotICAgIGNsYXNzIEdyYXBoaWNzQ29udGV4dDsKLSAgICBjbGFz cyBJbnRSZWN0OworY2xhc3MgR3JhcGhpY3NDb250ZXh0OworY2xhc3MgSW50UmVjdDsKIH0KIAog bmFtZXNwYWNlIFdlYktpdCB7Cg== 188678 2013-02-15 17:50:22 -0800 2013-02-28 19:59:52 -0800 Patch bug-109925-20130216104647.patch text/plain 2286 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzMDc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZmI2MDE0YWRkNzFhYTI2 Njg0ZGYwMDRhMGQwZGUyMTQ1YjUyYjU5Yi4uMTZjMjU3MDZlZjNlZTdmZmJjNzYwZGEyZTc0MmYx NWVlNGQ3YTVkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAyLTE1ICBTZW9r anUgS3dvbiAgPHNlb2tqdS5rd29uQGdtYWlsLmNvbT4KKworICAgICAgICBbV0syXSBSZWZhY3Rv cmluZyA6IEZpeCBpbmRlbnRhdGlvbiBhbmQgYnJhY2VzIGluIFdlYkluc3BlY3RvckNsaWVudC5o fGNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5 OTI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhl IGNvbnRlbnRzIG9mIGFuIG91dGVybW9zdCBuYW1lc3BhY2UgYmxvY2sgc2hvdWxkIG5vdCBiZSBp bmRlbnRlZC4KKyAgICAgICAgQW5kIE9uZS1saW5lIGNvbnRyb2wgY2xhdXNlcyBzaG91bGQgbm90 IHVzZSBicmFjZXMuCisgICAgICAgIGh0dHA6Ly93d3cud2Via2l0Lm9yZy9jb2RpbmcvY29kaW5n LXN0eWxlLmh0bWwKKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViSW5z cGVjdG9yQ2xpZW50LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViSW5zcGVjdG9yQ2xpZW50Ojpj bG9zZUluc3BlY3RvckZyb250ZW5kKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYkNvcmVTdXBw b3J0L1dlYkluc3BlY3RvckNsaWVudC5oOgorICAgICAgICAoV2ViQ29yZSk6CisKIDIwMTMtMDIt MTUgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQg SGFzaE1hcDo6aXNWYWxpZEtleSBhbmQgSGFzaFNldDo6aXNWYWxpZFZhbHVlCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkluc3BlY3RvckNs aWVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYklu c3BlY3RvckNsaWVudC5jcHAKaW5kZXggNjkwNzVmYTBmY2JmMmYzYjUxNzkzMDBjYmZlZDMzOTcy MmI5ZmJjOC4uOTk3OGY5ZWFmNGJlYTRlMzQ2YmNhZTUwOGI0MWExYjUwNWI1NjBhMCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0 b3JDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBv cnQvV2ViSW5zcGVjdG9yQ2xpZW50LmNwcApAQCAtNTIsOSArNTIsOCBAQCBXZWJDb3JlOjpJbnNw ZWN0b3JGcm9udGVuZENoYW5uZWwqIFdlYkluc3BlY3RvckNsaWVudDo6b3Blbkluc3BlY3RvckZy b250ZW5kKElucwogCiB2b2lkIFdlYkluc3BlY3RvckNsaWVudDo6Y2xvc2VJbnNwZWN0b3JGcm9u dGVuZCgpCiB7Ci0gICAgaWYgKG1fcGFnZS0+aW5zcGVjdG9yKCkpIHsKKyAgICBpZiAobV9wYWdl LT5pbnNwZWN0b3IoKSkKICAgICAgICAgbV9wYWdlLT5pbnNwZWN0b3IoKS0+ZGlkQ2xvc2UoKTsK LSAgICB9CiB9CiAKIHZvaWQgV2ViSW5zcGVjdG9yQ2xpZW50OjpicmluZ0Zyb250ZW5kVG9Gcm9u dCgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0 L1dlYkluc3BlY3RvckNsaWVudC5oIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3Jl U3VwcG9ydC9XZWJJbnNwZWN0b3JDbGllbnQuaAppbmRleCA4NTAwNDFhZjFiOWUzMWQ0ZjQ5MDMw NjdlNjQyODA4NzM0YTQ0ODI5Li4yOTI3YThhYmIzNzc1NDI3MTc5NTNiOTgyZWI0ODg1ZGUxMDY2 ZTU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0 L1dlYkluc3BlY3RvckNsaWVudC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi Q29yZVN1cHBvcnQvV2ViSW5zcGVjdG9yQ2xpZW50LmgKQEAgLTM0LDggKzM0LDggQEAKICNpbmNs dWRlIDxXZWJDb3JlL0luc3BlY3RvckZyb250ZW5kQ2hhbm5lbC5oPgogCiBuYW1lc3BhY2UgV2Vi Q29yZSB7Ci0gICAgY2xhc3MgR3JhcGhpY3NDb250ZXh0OwotICAgIGNsYXNzIEludFJlY3Q7Citj bGFzcyBHcmFwaGljc0NvbnRleHQ7CitjbGFzcyBJbnRSZWN0OwogfQogCiBuYW1lc3BhY2UgV2Vi S2l0IHsK 190872 2013-02-28 19:59:59 -0800 2013-02-28 20:41:48 -0800 Patch bug-109925-20130301125610.patch text/plain 2223 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NDA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjc4NzM5NjI4N2ZhNTQ1 MTkyMDgyMWRhZWJlZmI5MWFkNThhZTQ3ZC4uOWUxNTUzMDg2NGRjOWNkOTgzZGQ0Zjg5YWQwZTQ0 OWY0ZTU5ZTVmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAyLTI4ICBTZW9r anUgS3dvbiAgPHNlb2tqdS5rd29uQGdtYWlsLmNvbT4KKworICAgICAgICBbV0syXSBSZWZhY3Rv cmluZyA6IEZpeCBpbmRlbnRhdGlvbiBhbmQgYnJhY2VzIGluIFdlYkluc3BlY3RvckNsaWVudC5o fGNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5 OTI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhl IGNvbnRlbnRzIG9mIGFuIG91dGVybW9zdCBuYW1lc3BhY2UgYmxvY2sgc2hvdWxkIG5vdCBiZSBp bmRlbnRlZC4KKyAgICAgICAgQW5kIE9uZS1saW5lIGNvbnRyb2wgY2xhdXNlcyBzaG91bGQgbm90 IHVzZSBicmFjZXMuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYklu c3BlY3RvckNsaWVudC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkluc3BlY3RvckNsaWVudDo6 Y2xvc2VJbnNwZWN0b3JGcm9udGVuZCk6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJDb3JlU3Vw cG9ydC9XZWJJbnNwZWN0b3JDbGllbnQuaDoKKyAgICAgICAgKFdlYkNvcmUpOgorCiAyMDEzLTAy LTI4ICBDb25yYWQgU2h1bHR6ICA8Y29ucmFkX3NodWx0ekBhcHBsZS5jb20+CiAKICAgICAgICAg TmVlZCBBUEkgdG8gY29udHJvbCBwYWdlIHVuZGVybGF5IGNvbG9yCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkluc3BlY3RvckNsaWVudC5j cHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkluc3BlY3Rv ckNsaWVudC5jcHAKaW5kZXggNjkwNzVmYTBmY2JmMmYzYjUxNzkzMDBjYmZlZDMzOTcyMmI5ZmJj OC4uOTk3OGY5ZWFmNGJlYTRlMzQ2YmNhZTUwOGI0MWExYjUwNWI1NjBhMCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0b3JDbGll bnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2Vi SW5zcGVjdG9yQ2xpZW50LmNwcApAQCAtNTIsOSArNTIsOCBAQCBXZWJDb3JlOjpJbnNwZWN0b3JG cm9udGVuZENoYW5uZWwqIFdlYkluc3BlY3RvckNsaWVudDo6b3Blbkluc3BlY3RvckZyb250ZW5k KElucwogCiB2b2lkIFdlYkluc3BlY3RvckNsaWVudDo6Y2xvc2VJbnNwZWN0b3JGcm9udGVuZCgp CiB7Ci0gICAgaWYgKG1fcGFnZS0+aW5zcGVjdG9yKCkpIHsKKyAgICBpZiAobV9wYWdlLT5pbnNw ZWN0b3IoKSkKICAgICAgICAgbV9wYWdlLT5pbnNwZWN0b3IoKS0+ZGlkQ2xvc2UoKTsKLSAgICB9 CiB9CiAKIHZvaWQgV2ViSW5zcGVjdG9yQ2xpZW50OjpicmluZ0Zyb250ZW5kVG9Gcm9udCgpCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYklu c3BlY3RvckNsaWVudC5oIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9y dC9XZWJJbnNwZWN0b3JDbGllbnQuaAppbmRleCA4NTAwNDFhZjFiOWUzMWQ0ZjQ5MDMwNjdlNjQy ODA4NzM0YTQ0ODI5Li4yOTI3YThhYmIzNzc1NDI3MTc5NTNiOTgyZWI0ODg1ZGUxMDY2ZTU3IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYklu c3BlY3RvckNsaWVudC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1 cHBvcnQvV2ViSW5zcGVjdG9yQ2xpZW50LmgKQEAgLTM0LDggKzM0LDggQEAKICNpbmNsdWRlIDxX ZWJDb3JlL0luc3BlY3RvckZyb250ZW5kQ2hhbm5lbC5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7 Ci0gICAgY2xhc3MgR3JhcGhpY3NDb250ZXh0OwotICAgIGNsYXNzIEludFJlY3Q7CitjbGFzcyBH cmFwaGljc0NvbnRleHQ7CitjbGFzcyBJbnRSZWN0OwogfQogCiBuYW1lc3BhY2UgV2ViS2l0IHsK