109924 2013-02-15 04:36:48 -0800 [EFL] Fix build when CONTEXT_MENUS flag is turned off 2013-02-18 05:22:22 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 mpakulavelrutka mpakulavelrutka buildbot gyuyoung.kim lucas.de.marchi rakuco rniwa webkit.review.bot oldest_to_newest 833890 0 mpakulavelrutka 2013-02-15 04:36:48 -0800 Currently WebKit1 does not build when CONTEXT_MENUS flag is turned off, this patch fixes it. 833910 1 188542 mpakulavelrutka 2013-02-15 05:08:41 -0800 Created attachment 188542 patch 833981 2 188542 buildbot 2013-02-15 06:49:53 -0800 Comment on attachment 188542 patch Attachment 188542 did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16588145 New failing tests: media/video-controls-captions-trackmenu.html 835329 3 mpakulavelrutka 2013-02-18 04:20:27 -0800 This patch introduces change only in WebKit/EFL code, so it cannot make MAC test fail. 835334 4 188542 gyuyoung.kim 2013-02-18 04:23:48 -0800 Comment on attachment 188542 patch r=me 835378 5 188542 webkit.review.bot 2013-02-18 05:22:18 -0800 Comment on attachment 188542 patch Clearing flags on attachment: 188542 Committed r143200: <http://trac.webkit.org/changeset/143200> 835379 6 webkit.review.bot 2013-02-18 05:22:22 -0800 All reviewed patches have been landed. Closing bug. 188542 2013-02-15 05:08:41 -0800 2013-02-18 05:22:18 -0800 patch context-menu-wk1.diff text/plain 3996 mpakulavelrutka ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBiNDZmOGYxLi5iNDMxZDBjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTMtMDItMTUgIE1pY2hhxYIgUGFrdcWCYSB2ZWwgUnV0a2EgIDxt LnBha3VsYUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBGaXggYnVpbGQgd2hlbiBDT05U RVhUX01FTlVTIGZsYWcgaXMgdHVybmVkIG9mZgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5OTI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9Db250ZXh0TWVudUNsaWVudEVm bC5jcHA6CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvQ29udGV4dE1lbnVDbGllbnRFZmwuaDoK KyAgICAgICAgKiBld2svZXdrX3ZpZXcuY3BwOgorICAgICAgICAoX0V3a19WaWV3X1ByaXZhdGVf RGF0YSk6CisgICAgICAgIChfZXdrX3ZpZXdfcHJpdl9uZXcpOgorICAgICAgICAoX2V3a192aWV3 X3ByaXZfZGVsKToKKyAgICAgICAgKGV3a192aWV3X2NvbnRleHRfbWVudV9nZXQpOgorCiAyMDEz LTAyLTE1ICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgog CiAgICAgICAgIFNpbXBsaWZ5IGhpdFRlc3RSZXN1bHRBdFBvaW50IGFuZCBub2Rlc0Zyb21SZWN0 IEFQSXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0NvbnRl eHRNZW51Q2xpZW50RWZsLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0Nv bnRleHRNZW51Q2xpZW50RWZsLmNwcAppbmRleCA1ZjU2ZTMxLi45NzhiZDIxIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9Db250ZXh0TWVudUNsaWVudEVmbC5j cHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQ29udGV4dE1lbnVDbGll bnRFZmwuY3BwCkBAIC0yOSw2ICsyOSw4IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVk ZSAiQ29udGV4dE1lbnVDbGllbnRFZmwuaCIKIAorI2lmIEVOQUJMRShDT05URVhUX01FTlVTKQor CiAjaW5jbHVkZSAiQ29udGV4dE1lbnUuaCIKICNpbmNsdWRlICJIaXRUZXN0UmVzdWx0LmgiCiAj aW5jbHVkZSAiS1VSTC5oIgpAQCAtODUsMyArODcsNSBAQCB2b2lkIENvbnRleHRNZW51Q2xpZW50 RWZsOjpzZWFyY2hXaXRoR29vZ2xlKGNvbnN0IEZyYW1lKikKIH0KIAogfQorCisjZW5kaWYgLy8g RU5BQkxFKENPTlRFWFRfTUVOVVMpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJD b3JlU3VwcG9ydC9Db250ZXh0TWVudUNsaWVudEVmbC5oIGIvU291cmNlL1dlYktpdC9lZmwvV2Vi Q29yZVN1cHBvcnQvQ29udGV4dE1lbnVDbGllbnRFZmwuaAppbmRleCAzOWE4ODFkLi5jMTM3MWU0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9Db250ZXh0TWVu dUNsaWVudEVmbC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0NvbnRl eHRNZW51Q2xpZW50RWZsLmgKQEAgLTI5LDYgKzI5LDggQEAKICNpZm5kZWYgQ29udGV4dE1lbnVD bGllbnRFZmxfaAogI2RlZmluZSBDb250ZXh0TWVudUNsaWVudEVmbF9oCiAKKyNpZiBFTkFCTEUo Q09OVEVYVF9NRU5VUykKKwogI2luY2x1ZGUgIkNvbnRleHRNZW51Q2xpZW50LmgiCiAKICNpbmNs dWRlIDx3dGYvUmVmQ291bnRlZC5oPgpAQCAtNTIsNCArNTQsNSBAQCBwdWJsaWM6CiB9OwogfQog CisjZW5kaWYgLy8gRU5BQkxFKENPTlRFWFRfTUVOVVMpCiAjZW5kaWYKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2sv ZXdrX3ZpZXcuY3BwCmluZGV4IDU1NmJlNTcuLjViNmNhNzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a192aWV3LmNwcApAQCAtMzc5LDcgKzM3OSw5IEBAIHN0cnVjdCBfRXdrX1ZpZXdfUHJpdmF0ZV9E YXRhIHsKICNpZmRlZiBIQVZFX0VDT1JFX1gKICAgICBib29sIGlzVXNpbmdFY29yZVg7CiAjZW5k aWYKKyNpZiBFTkFCTEUoQ09OVEVYVF9NRU5VUykKICAgICBFd2tfQ29udGV4dF9NZW51KiBjb250 ZXh0TWVudTsKKyNlbmRpZgogfTsKIAogI2lmbmRlZiBFV0tfVFlQRV9DSEVDSwpAQCAtNzYxLDcg Kzc2Myw5IEBAIHN0YXRpYyBFd2tfVmlld19Qcml2YXRlX0RhdGEqIF9ld2tfdmlld19wcml2X25l dyhFd2tfVmlld19TbWFydF9EYXRhKiBzbWFydERhdGEpCiAKICAgICBXZWJDb3JlOjpQYWdlOjpQ YWdlQ2xpZW50cyBwYWdlQ2xpZW50czsKICAgICBwYWdlQ2xpZW50cy5jaHJvbWVDbGllbnQgPSBu ZXcgV2ViQ29yZTo6Q2hyb21lQ2xpZW50RWZsKHNtYXJ0RGF0YS0+c2VsZik7CisjaWYgRU5BQkxF KENPTlRFWFRfTUVOVVMpCiAgICAgcGFnZUNsaWVudHMuY29udGV4dE1lbnVDbGllbnQgPSBuZXcg V2ViQ29yZTo6Q29udGV4dE1lbnVDbGllbnRFZmw7CisjZW5kaWYKICAgICBwYWdlQ2xpZW50cy5l ZGl0b3JDbGllbnQgPSBuZXcgV2ViQ29yZTo6RWRpdG9yQ2xpZW50RWZsKHNtYXJ0RGF0YS0+c2Vs Zik7CiAgICAgcGFnZUNsaWVudHMuZHJhZ0NsaWVudCA9IG5ldyBXZWJDb3JlOjpEcmFnQ2xpZW50 RWZsOwogI2lmIEVOQUJMRShJTlNQRUNUT1IpCkBAIC05MzUsNyArOTM5LDkgQEAgc3RhdGljIEV3 a19WaWV3X1ByaXZhdGVfRGF0YSogX2V3a192aWV3X3ByaXZfbmV3KEV3a19WaWV3X1NtYXJ0X0Rh dGEqIHNtYXJ0RGF0YSkKICAgICBwcml2LT5pc1VzaW5nRWNvcmVYID0gV2ViQ29yZTo6aXNVc2lu Z0Vjb3JlWChzbWFydERhdGEtPmJhc2UuZXZhcyk7CiAjZW5kaWYKIAorI2lmIEVOQUJMRShDT05U RVhUX01FTlVTKQogICAgIHByaXYtPmNvbnRleHRNZW51ID0gMDsKKyNlbmRpZgogCiAjaWYgVVNF KEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQogICAgIHByaXYtPmlzQ29tcG9zaXRpbmdBY3RpdmUg PSBmYWxzZTsKQEAgLTk3NCw4ICs5ODAsMTAgQEAgc3RhdGljIHZvaWQgX2V3a192aWV3X3ByaXZf ZGVsKEV3a19WaWV3X1ByaXZhdGVfRGF0YSogcHJpdikKICAgICBpZiAocHJpdi0+Y3Vyc29yT2Jq ZWN0KQogICAgICAgICBldmFzX29iamVjdF9kZWwocHJpdi0+Y3Vyc29yT2JqZWN0KTsKIAorI2lm IEVOQUJMRShDT05URVhUX01FTlVTKQogICAgIGlmIChwcml2LT5jb250ZXh0TWVudSkKICAgICAg ICAgZXdrX2NvbnRleHRfbWVudV9mcmVlKHByaXYtPmNvbnRleHRNZW51KTsKKyNlbmRpZgogCiAj aWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQogICAgIHByaXYtPmFjY2VsZXJhdGVkQ29t cG9zaXRpbmdDb250ZXh0ID0gbnVsbHB0cjsKQEAgLTQ3ODEsMTAgKzQ3ODksMTUgQEAgdm9pZCBl d2tfdmlld19mdWxsc2NyZWVuX2V4aXQoY29uc3QgRXZhc19PYmplY3QqIGV3a1ZpZXcpCiAKIEV3 a19Db250ZXh0X01lbnUqIGV3a192aWV3X2NvbnRleHRfbWVudV9nZXQoY29uc3QgRXZhc19PYmpl Y3QqIGV3a1ZpZXcpCiB7CisjaWYgRU5BQkxFKENPTlRFWFRfTUVOVVMpCiAgICAgRVdLX1ZJRVdf U0RfR0VUX09SX1JFVFVSTihld2tWaWV3LCBzbWFydERhdGEsIDApOwogICAgIEVXS19WSUVXX1BS SVZfR0VUX09SX1JFVFVSTihzbWFydERhdGEsIHByaXYsIDApOwogCiAgICAgcmV0dXJuIHByaXYt PmNvbnRleHRNZW51OworI2Vsc2UKKyAgICBVTlVTRURfUEFSQU0oZXdrVmlldyk7CisgICAgcmV0 dXJuIDA7CisjZW5kaWYKIH0KIAogRWluYV9Cb29sIGV3a192aWV3X3NldHRpbmdfdGlsZWRfYmFj a2luZ19zdG9yZV9lbmFibGVkX3NldChFdmFzX09iamVjdCogZXdrVmlldywgRWluYV9Cb29sIGVu YWJsZSkK