109917 2013-02-15 02:17:10 -0800 [WK2][EFL] WebPageProxy::setThemePath() should check that the page is valid 2013-03-05 11:52:07 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mikhail.pozdnyakov mikhail.pozdnyakov andersca ap benjamin gyuyoung.kim kenneth lucas.de.marchi rakuco ryuan.choi webkit.review.bot oldest_to_newest 833818 0 mikhail.pozdnyakov 2013-02-15 02:17:10 -0800 WebPageProxy::setThemePath() should check that the page is valid before sending IPC message. 833820 1 188519 mikhail.pozdnyakov 2013-02-15 02:20:21 -0800 Created attachment 188519 patch 833823 2 188519 cdumez 2013-02-15 02:23:46 -0800 Comment on attachment 188519 patch LGTM. 833885 3 188519 kenneth 2013-02-15 04:28:37 -0800 Comment on attachment 188519 patch LGTM 834156 4 188519 ap 2013-02-15 10:32:31 -0800 Comment on attachment 188519 patch Why? This breaks calling this method while the process is launching. 834167 5 andersca 2013-02-15 10:48:51 -0800 (In reply to comment #4) > (From update of attachment 188519 [details]) > Why? This breaks calling this method while the process is launching. I don’t think this is true. isValid() will only return false if the page has been closed using WebPageProxy::closed(), or if the process has crashed and the page hasn’t been reattached to the new process yet. 836439 6 mikhail.pozdnyakov 2013-02-19 08:48:04 -0800 (In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 188519 [details] [details]) > > Why? This breaks calling this method while the process is launching. > > I don’t think this is true. isValid() will only return false if the page has been closed using WebPageProxy::closed(), or if the process has crashed and the page hasn’t been reattached to the new process yet. Indeed, it just should not allow send IPC messages if web process is not running any more. Most of WebPageProxy methods check isValid() before sending and return if it returns false, some methods are trying to re-launch the web process (for instance loadURL()) but this is not the desired behaviour for WebPageProxy::setThemePath() I guess. 838569 7 mikhail.pozdnyakov 2013-02-21 10:43:01 -0800 Could please anyone review it? 847879 8 188519 webkit.review.bot 2013-03-05 11:52:01 -0800 Comment on attachment 188519 patch Clearing flags on attachment: 188519 Committed r144794: <http://trac.webkit.org/changeset/144794> 847880 9 webkit.review.bot 2013-03-05 11:52:07 -0800 All reviewed patches have been landed. Closing bug. 188519 2013-02-15 02:20:21 -0800 2013-03-05 11:52:01 -0800 patch bug109917 text/plain 1451 mikhail.pozdnyakov Y29tbWl0IGQ2MzBhYjg1ZTQ0N2M1MzE3ZTAyMjA3YTA3YTYzMmJmYjdjZGU0OGYKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg RnJpIEZlYiAxNSAxMjoxNToxOSAyMDEzICswMjAwCgogICAgYnVnMTA5OTE3CgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmlu ZGV4IGZiMTY5NGYuLjBmMjI3NmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMy0w Mi0xNSAgTWlraGFpbCBQb3pkbnlha292ICA8bWlraGFpbC5wb3pkbnlha292QGludGVsLmNvbT4K KworICAgICAgICBbV0syXVtFRkxdIFdlYlBhZ2VQcm94eTo6c2V0VGhlbWVQYXRoKCkgc2hvdWxk IGNoZWNrIHRoYXQgdGhlIHBhZ2UgaXMgdmFsaWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTkxNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdlYlBhZ2VQcm94eTo6c2V0VGhlbWVQYXRoKCkgc2hvdWxk IGNoZWNrIHRoYXQgdGhlIHBhZ2UgaXMgdmFsaWQgYmVmb3JlCisgICAgICAgIHNlbmRpbmcgSVBD IG1lc3NhZ2UuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvZWZsL1dlYlBhZ2VQcm94eUVmbC5jcHA6 CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6c2V0VGhlbWVQYXRoKToKKwogMjAxMy0w Mi0xNCAgSHVhbmcgRG9uZ3N1bmcgIDxsdXh0ZWxsYUBjb21wYW55MTAwLm5ldD4KIAogICAgICAg ICBbV0syXSBSZW5hbWUgZnJvbSBzY3JvbGxPZmZzZXQgdG8gc2Nyb2xsRGVsdGEgaW4gV2ViQ2hy b21lQ2xpZW50LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9XZWJQ YWdlUHJveHlFZmwuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9XZWJQYWdlUHJv eHlFZmwuY3BwCmluZGV4IGRlNzBjYTEuLmI2NmY1NzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9lZmwvV2ViUGFnZVByb3h5RWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvZWZsL1dlYlBhZ2VQcm94eUVmbC5jcHAKQEAgLTgyLDYgKzgyLDkgQEAgdm9p ZCBXZWJQYWdlUHJveHk6OmxvYWRSZWNlbnRTZWFyY2hlcyhjb25zdCBTdHJpbmcmLCBWZWN0b3I8 U3RyaW5nPiYpCiAKIHZvaWQgV2ViUGFnZVByb3h5OjpzZXRUaGVtZVBhdGgoY29uc3QgU3RyaW5n JiB0aGVtZVBhdGgpCiB7CisgICAgaWYgKCFpc1ZhbGlkKCkpCisgICAgICAgIHJldHVybjsKKwog ICAgIHByb2Nlc3MoKS0+c2VuZChNZXNzYWdlczo6V2ViUGFnZTo6U2V0VGhlbWVQYXRoKHRoZW1l UGF0aCksIG1fcGFnZUlELCAwKTsKIH0KIAo=