109907 2013-02-15 00:29:11 -0800 Web Inspector: Redo in text editor should always collapse selection to end. 2013-02-15 06:57:36 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 vsevik vsevik apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 833767 0 vsevik 2013-02-15 00:29:11 -0800 Patch to follow. 833769 1 188498 vsevik 2013-02-15 00:33:49 -0800 Created attachment 188498 Patch 833944 2 188498 pfeldman 2013-02-15 06:12:12 -0800 Comment on attachment 188498 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188498&action=review > Source/WebCore/inspector/front-end/TextEditorModel.js:507 > + return range ? range.collapseToEnd() : null; Consider moving this to the call site. 833986 3 188498 webkit.review.bot 2013-02-15 06:57:33 -0800 Comment on attachment 188498 Patch Clearing flags on attachment: 188498 Committed r142994: <http://trac.webkit.org/changeset/142994> 833987 4 webkit.review.bot 2013-02-15 06:57:36 -0800 All reviewed patches have been landed. Closing bug. 188498 2013-02-15 00:33:49 -0800 2013-02-15 06:57:32 -0800 Patch bug-109907-20130215123015.patch text/plain 3005 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyOTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmI5YTNiNTZkODM1ZWRj MTYzZWFhNTMzMGIxMDU3YjJkMDcwZTcwNC4uOWY3ODFlMTRhNDNhMGQzMjU5ZmY4MmMwZTU3N2Ez ODlhOWIyZTRiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAyLTE1ICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFJlZG8gaW4gdGV4dCBlZGl0b3Igc2hvdWxkIGFsd2F5cyBjb2xsYXBzZSBzZWxlY3Rpb24g dG8gZW5kLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTA5OTA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBpbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRFZGl0b3JNb2RlbC5qczoKKyAgICAgICAgKFdlYklu c3BlY3Rvci5UZXh0RWRpdG9yTW9kZWwuZW5kc1dpdGhCcmFja2V0UmVnZXguKToKKwogMjAxMy0w Mi0xNCAgVnNldm9sb2QgVmxhc292ICA8dnNldmlrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBX ZWIgSW5zcGVjdG9yOiBDb3B5LXBhc3Rpbmcgc2VsZWN0ZWQgdGV4dCBvdmVyIGl0c2VsZiBzaG91 bGQgYmUgYW4gdW5kb2FibGUgc3RhdGUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL1RleHRFZGl0b3JNb2RlbC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvVGV4dEVkaXRvck1vZGVsLmpzCmluZGV4IDBhMTM4NjhhMjQzZDVkMDYx MjUzZjFjZDVhY2Q4ZGJkNTczNmUzNmUuLmU2YTllYzIzZWZmMzlkOWMyNzE2MmQzZjRkNGQ2Mzdj MTljNzBhNzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv VGV4dEVkaXRvck1vZGVsLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvVGV4dEVkaXRvck1vZGVsLmpzCkBAIC01MDQsNyArNTA0LDcgQEAgV2ViSW5zcGVjdG9yLlRl eHRFZGl0b3JNb2RlbC5wcm90b3R5cGUgPSB7CiAgICAgICAgIHZhciByYW5nZSA9IHRoaXMuX2Rv VW5kbyh0aGlzLl9yZWRvU3RhY2spOwogICAgICAgICBkZWxldGUgdGhpcy5faW5SZWRvOwogCi0g ICAgICAgIHJldHVybiByYW5nZTsKKyAgICAgICAgcmV0dXJuIHJhbmdlID8gcmFuZ2UuY29sbGFw c2VUb0VuZCgpIDogbnVsbDsKICAgICB9LAogCiAgICAgLyoqCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZGQ4MjVkNDMyOTE0 YTk3NGRjNDhlYzQ5YzNjYjlhM2M3NTQ3NTE5My4uNjc5ZjM2NWUwZDU4ZmVmMjE0NjI4YTU2ZmM1 YzVkYzIyNmMzOGM0OCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEzLTAyLTE1ICBWc2V2b2xv ZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6 IFJlZG8gaW4gdGV4dCBlZGl0b3Igc2hvdWxkIGFsd2F5cyBjb2xsYXBzZSBzZWxlY3Rpb24gdG8g ZW5kLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5 OTA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBp bnNwZWN0b3IvZWRpdG9yL3RleHQtZWRpdG9yLXVuZG8tcmVkby1leHBlY3RlZC50eHQ6CisKIDIw MTMtMDItMTQgIFZzZXZvbG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgV2ViIEluc3BlY3RvcjogQ29weS1wYXN0aW5nIHNlbGVjdGVkIHRleHQgb3ZlciBpdHNlbGYg c2hvdWxkIGJlIGFuIHVuZG9hYmxlIHN0YXRlLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5z cGVjdG9yL2VkaXRvci90ZXh0LWVkaXRvci11bmRvLXJlZG8tZXhwZWN0ZWQudHh0IGIvTGF5b3V0 VGVzdHMvaW5zcGVjdG9yL2VkaXRvci90ZXh0LWVkaXRvci11bmRvLXJlZG8tZXhwZWN0ZWQudHh0 CmluZGV4IDVkNzQ3NGEwMTk5MzcyNDEyNmUxZWY1Yzk3MTU4MjYzODI2MjEzNzMuLmY1Mzg5NmYw MDA2OGUxZjhiOGFlYWU1NTdlM2JjNTdlNWYyZDkxMTMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L2luc3BlY3Rvci9lZGl0b3IvdGV4dC1lZGl0b3ItdW5kby1yZWRvLWV4cGVjdGVkLnR4dAorKysg Yi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZWRpdG9yL3RleHQtZWRpdG9yLXVuZG8tcmVkby1leHBl Y3RlZC50eHQKQEAgLTE5LDcgKzE5LDcgQEAgVGV4dCBhZnRlciB1bmRvOgogCiBUZXh0IGFmdGVy IHJlZG86CiAxCi0+CTwyCisJfDIKIDMKIAogCkBAIC02MCwxNCArNjAsMTQgQEAgZnVuY3Rpb24g Zm9vKCkKIFRleHQgYWZ0ZXIgZmlyc3QgcmVkbzoKIGZ1bmN0aW9uIGZvbygpCiB7Ci0gICAgYmFy KCk+OzwKKyAgICBiYXIoKTt8CiB9CiAKIFRleHQgYWZ0ZXIgc2Vjb25kIHJlZG86CiBmdW5jdGlv biBmb28oKQogewogICAgIGJhcigpOwotICAgIGJheigpPjs8CisgICAgYmF6KCk7fAogfQogCiBU ZXh0IGFmdGVyIHRoaXJkIHJlZG86CkBAIC03NSw3ICs3NSw3IEBAIGZ1bmN0aW9uIGZvbygpCiB7 CiAgICAgYmFyKCk7CiAgICAgYmF6KCk7Ci0gICAgZm9vKCk+OzwKKyAgICBmb28oKTt8CiB9CiAK IApAQCAtMTIyLDE1ICsxMjIsMTUgQEAgZnVuY3Rpb24gZm9vKCkKIHsKICAgICBiYXIoKTsKICAg ICBiYXooKTsKLSAgICBmb28oKT47PAorICAgIGZvbygpO3wKIH0KIAogVGV4dCBhZnRlciBzZWNv bmQgcmVkbzoKIGZ1bmN0aW9uIGZvbygpCiB7CiAgICAgYmFyKCk7Ci0+ICAgIGJheigpOwotPCAg ICBmb28oKTsKKyAgICBiYXooKTsKK3wgICAgZm9vKCk7CiB9CiAKIAo=