109895 2013-02-14 23:08:47 -0800 [V8] An "EvenTarget" type in IDL should be converted to EventTarget*, not to Node* 2013-02-15 17:25:47 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 833720 0 haraken 2013-02-14 23:08:47 -0800 Currently an "EventTarget" type in IDL is converted to Node*. This is wrong because there are non-Node interfaces that inherit a EventTarget. We should convert an "EventTarget" type to EventTarget*. This will fix FIXMEs in CodeGeneratorV8.pm. 833722 1 188484 haraken 2013-02-14 23:10:00 -0800 Created attachment 188484 Patch 834075 2 188484 abarth 2013-02-15 09:06:34 -0800 Comment on attachment 188484 Patch Ah, glad toEventTarget was useful! 834534 3 188484 webkit.review.bot 2013-02-15 17:25:44 -0800 Comment on attachment 188484 Patch Clearing flags on attachment: 188484 Committed r143075: <http://trac.webkit.org/changeset/143075> 834535 4 webkit.review.bot 2013-02-15 17:25:47 -0800 All reviewed patches have been landed. Closing bug. 188484 2013-02-14 23:10:00 -0800 2013-02-15 17:25:43 -0800 Patch bug-109895-20130215160627.patch text/plain 2613 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyOTY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjI2MzUwMTk0NmZkOGVk OTdkODkzYzczMTc4NDM5M2FiM2NiYjFjMy4uZmFjNjAxZWQwNTE3NjBmZjIxN2RlMGYxMTBlZTQw NjVjZjkwYjRiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAyLTE0ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIEFuICJFdmVu VGFyZ2V0IiB0eXBlIGluIElETCBzaG91bGQgYmUgY29udmVydGVkIHRvIEV2ZW50VGFyZ2V0Kiwg bm90IHRvIE5vZGUqCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMDk4OTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBDdXJyZW50bHkgYW4gIkV2ZW50VGFyZ2V0IiB0eXBlIGluIElETCBpcyBjb252ZXJ0ZWQg dG8gTm9kZSouCisgICAgICAgIFRoaXMgaXMgd3JvbmcgYmVjYXVzZSB0aGVyZSBhcmUgbm9uLU5v ZGUgaW50ZXJmYWNlcyB0aGF0IGluaGVyaXQKKyAgICAgICAgYSBFdmVudFRhcmdldC4gV2Ugc2hv dWxkIGNvbnZlcnQgYW4gIkV2ZW50VGFyZ2V0IiB0eXBlIHRvIEV2ZW50VGFyZ2V0Ki4KKyAgICAg ICAgVGhpcyB3aWxsIGZpeCBGSVhNRXMgaW4gQ29kZUdlbmVyYXRvclY4LnBtLgorCisgICAgICAg ICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG06CisgICAgICAgIChHZXROYXRp dmVUeXBlKToKKyAgICAgICAgKEpTVmFsdWVUb05hdGl2ZSk6CisKIDIwMTMtMDItMTQgIEFuZHJl eSBBZGFpa2luICA8YWFuZHJleUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVXNlIEdMIHR5cGVk ZWZzIGluIFdlYkdMUmVuZGVyaW5nQ29udGV4dC5pZGwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KaW5kZXggNmZmMmMwNTJmZDg2YTI2 NzAzOWFhZTFlNGQ2NmM5ODIyZDA0NWZkYi4uMWQwYjgyNTU4YTg2YzE3MzdmNzQ1NTEwNmJkZDhi ODdkNTM4YjM5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9D b2RlR2VuZXJhdG9yVjgucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9D b2RlR2VuZXJhdG9yVjgucG0KQEAgLTM4MzAsMTEgKzM4MzAsNiBAQCBzdWIgR2V0TmF0aXZlVHlw ZQogICAgIHJldHVybiAiUmFuZ2U6OkNvbXBhcmVIb3ciIGlmICR0eXBlIGVxICJDb21wYXJlSG93 IjsKICAgICByZXR1cm4gIkRPTVRpbWVTdGFtcCIgaWYgJHR5cGUgZXEgIkRPTVRpbWVTdGFtcCI7 CiAgICAgcmV0dXJuICJkb3VibGUiIGlmICR0eXBlIGVxICJEYXRlIjsKLQotICAgICMgRklYTUU6 IFdoZW4gRXZlbnRUYXJnZXQgaXMgYW4gaW50ZXJmYWNlIGFuZCBub3QgYSBtaXhpbiwgZml4IHRo aXMgc28gdGhhdAotICAgICMgRXZlbnRUYXJnZXQgY2FuIGJlIHBhc3NlZCBhcyBhIHBhcmFtZXRl ci4KLSAgICByZXR1cm4gIk5vZGUqIiBpZiAkdHlwZSBlcSAiRXZlbnRUYXJnZXQiIGFuZCAkaXNQ YXJhbWV0ZXI7Ci0KICAgICByZXR1cm4gIlNjcmlwdFZhbHVlIiBpZiAkdHlwZSBlcSAiYW55IjsK ICAgICByZXR1cm4gIkRpY3Rpb25hcnkiIGlmICR0eXBlIGVxICJEaWN0aW9uYXJ5IjsKIApAQCAt Mzk0MCwxNCArMzkzNSw4IEBAIHN1YiBKU1ZhbHVlVG9OYXRpdmUKICAgICAgICAgcmV0dXJuICJN ZWRpYVF1ZXJ5TGlzdExpc3RlbmVyOjpjcmVhdGUoIiAuICR2YWx1ZSAuICIpIjsKICAgICB9CiAK LSAgICAjIERlZmF1bHQsIGFzc3VtZSBhdXRvZ2VuZXJhdGVkIHR5cGUgY29udmVyc2lvbiByb3V0 aW5lcwotICAgICMgRklYTUU6IFdoZW4gRXZlbnRUYXJnZXQgaXMgYW4gaW50ZXJmYWNlIGFuZCBu b3QgYSBtaXhpbiwgZml4IHRoaXMgdG8gdXNlCi0gICAgIyBWOEV2ZW50VGFyZ2V0OjpIYXNJbnN0 YW5jZSBldGMuCiAgICAgaWYgKCR0eXBlIGVxICJFdmVudFRhcmdldCIpIHsKLSAgICAgICAgQWRk VG9JbXBsSW5jbHVkZXMoIlY4Tm9kZS5oIik7Ci0KLSAgICAgICAgIyBFdmVudFRhcmdldCBpcyBu b3QgaW4gRE9NIGhpZXJhcmNoeSwgYnV0IGFsbCBOb2RlcyBhcmUgRXZlbnRUYXJnZXQuCi0gICAg ICAgIHJldHVybiAiVjhOb2RlOjpIYXNJbnN0YW5jZSgkdmFsdWUsICRnZXRJc29sYXRlKSA/IFY4 Tm9kZTo6dG9OYXRpdmUodjg6OkhhbmRsZTx2ODo6T2JqZWN0Pjo6Q2FzdCgkdmFsdWUpKSA6IDAi OworICAgICAgICByZXR1cm4gIlY4RE9NV3JhcHBlcjo6aXNET01XcmFwcGVyKCR2YWx1ZSkgPyB0 b1dyYXBwZXJUeXBlSW5mbyh2ODo6SGFuZGxlPHY4OjpPYmplY3Q+OjpDYXN0KCR2YWx1ZSkpLT50 b0V2ZW50VGFyZ2V0KHY4OjpIYW5kbGU8djg6Ok9iamVjdD46OkNhc3QoJHZhbHVlKSkgOiAwIjsK ICAgICB9CiAKICAgICBpZiAoJHR5cGUgZXEgIlhQYXRoTlNSZXNvbHZlciIpIHsK