109893 2013-02-14 22:54:43 -0800 Remove unnecessary public method DrawingAreaImpl::createGraphicsContext() 2013-02-17 21:54:57 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 jaepark webkit-unassigned andersca webkit.review.bot oldest_to_newest 833712 0 jaepark 2013-02-14 22:54:43 -0800 DrawingAreaImpl::createGraphicsContext() is unnecessary since createGraphicsContext can be called directly using ShareableBitmap. 833713 1 188482 jaepark 2013-02-14 22:56:11 -0800 Created attachment 188482 Patch 835122 2 188482 webkit.review.bot 2013-02-17 21:54:54 -0800 Comment on attachment 188482 Patch Clearing flags on attachment: 188482 Committed r143146: <http://trac.webkit.org/changeset/143146> 835123 3 webkit.review.bot 2013-02-17 21:54:57 -0800 All reviewed patches have been landed. Closing bug. 188482 2013-02-14 22:56:11 -0800 2013-02-17 21:54:54 -0800 Patch bug-109893-20130214225328.patch text/plain 2689 jaepark U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyOTY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDkwZTQwMDg3ZDhmYTU5 MDA2OWYxMDhlODBiMDg1NDQxZmExMzVlMC4uZGM4MTU1NTFiOTU0NzdlMGZlMGEyZjlmODUyZTBl YWY2Y2MzZjVlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAyLTE0ICBKYWUg SHl1biBQYXJrICA8amFlLnBhcmtAY29tcGFueTEwMC5uZXQ+CisKKyAgICAgICAgUmVtb3ZlIHVu bmVjZXNzYXJ5IHB1YmxpYyBtZXRob2QgRHJhd2luZ0FyZWFJbXBsOjpjcmVhdGVHcmFwaGljc0Nv bnRleHQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTA5ODkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg RHJhd2luZ0FyZWFJbXBsOjpjcmVhdGVHcmFwaGljc0NvbnRleHQoKSBpcyB1bm5lY2Vzc2FyeSBz aW5jZQorICAgICAgICBjcmVhdGVHcmFwaGljc0NvbnRleHQgY2FuIGJlIGNhbGxlZCBkaXJlY3Rs eSB1c2luZyBTaGFyZWFibGVCaXRtYXAuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2Uv RHJhd2luZ0FyZWFJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6RHJhd2luZ0FyZWFJbXBsOjpk aXNwbGF5KToKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWFJbXBsLmg6 CisgICAgICAgIChEcmF3aW5nQXJlYUltcGwpOgorCiAyMDEzLTAyLTE0ICBBbGV4ZXkgUHJvc2t1 cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMzE2MTcw MD4gUkVHUkVTU0lPTjogU2FmYXJpIGlzIHVuYWJsZSB0byBtYWtlIFNTTCBjb25uZWN0aW9ucwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVh SW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWFJ bXBsLmNwcAppbmRleCA0YWYxNTNkZDYwYmJmYzMzMTJhMjkyY2FlMGQzYmI5NjA0OWNhMDM5Li4z ZjQ2ZTNjMDM0ZjUxMWEyNjFhYzUyYTdhZjU3YzVjZjg5ODRjOGMzIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWFJbXBsLmNwcAorKysgYi9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWFJbXBsLmNwcApAQCAt NjUyLDExICs2NTIsNiBAQCBzdGF0aWMgYm9vbCBzaG91bGRQYWludEJvdW5kc1JlY3QoY29uc3Qg SW50UmVjdCYgYm91bmRzLCBjb25zdCBWZWN0b3I8SW50UmVjdD4mCiAgICAgcmV0dXJuIHdhc3Rl ZFNwYWNlIDw9IHdhc3RlZFNwYWNlVGhyZXNob2xkOwogfQogCi1QYXNzT3duUHRyPEdyYXBoaWNz Q29udGV4dD4gRHJhd2luZ0FyZWFJbXBsOjpjcmVhdGVHcmFwaGljc0NvbnRleHQoU2hhcmVhYmxl Qml0bWFwKiBiaXRtYXApCi17Ci0gICAgcmV0dXJuIGJpdG1hcC0+Y3JlYXRlR3JhcGhpY3NDb250 ZXh0KCk7Ci19Ci0KIHZvaWQgRHJhd2luZ0FyZWFJbXBsOjpkaXNwbGF5KFVwZGF0ZUluZm8mIHVw ZGF0ZUluZm8pCiB7CiAgICAgQVNTRVJUKCFtX2lzUGFpbnRpbmdTdXNwZW5kZWQpOwpAQCAtNzA3 LDcgKzcwMiw3IEBAIHZvaWQgRHJhd2luZ0FyZWFJbXBsOjpkaXNwbGF5KFVwZGF0ZUluZm8mIHVw ZGF0ZUluZm8pCiAgICAgbV9zY3JvbGxSZWN0ID0gSW50UmVjdCgpOwogICAgIG1fc2Nyb2xsT2Zm c2V0ID0gSW50U2l6ZSgpOwogCi0gICAgT3duUHRyPEdyYXBoaWNzQ29udGV4dD4gZ3JhcGhpY3ND b250ZXh0ID0gY3JlYXRlR3JhcGhpY3NDb250ZXh0KGJpdG1hcC5nZXQoKSk7CisgICAgT3duUHRy PEdyYXBoaWNzQ29udGV4dD4gZ3JhcGhpY3NDb250ZXh0ID0gYml0bWFwLT5jcmVhdGVHcmFwaGlj c0NvbnRleHQoKTsKICAgICBncmFwaGljc0NvbnRleHQtPmFwcGx5RGV2aWNlU2NhbGVGYWN0b3Io ZGV2aWNlU2NhbGVGYWN0b3IpOwogICAgIAogICAgIHVwZGF0ZUluZm8udXBkYXRlUmVjdEJvdW5k cyA9IGJvdW5kczsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFn ZS9EcmF3aW5nQXJlYUltcGwuaCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9E cmF3aW5nQXJlYUltcGwuaAppbmRleCBjNmJmYjcxOTY0MzBiY2U0MDk4ZGEyMGE1MDQxNGI5ZGZi YTliYjExLi4zYzRlZDQ2OGNmOGVkMWUxYjRiNzcwZmM0ZTEwNTllZGQxNmNjYTczIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWFJbXBsLmgK KysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhSW1wbC5o CkBAIC0xMDEsNyArMTAxLDYgQEAgcHJpdmF0ZToKICAgICB2b2lkIGRpc3BsYXlUaW1lckZpcmVk KCk7CiAgICAgdm9pZCBkaXNwbGF5KCk7CiAgICAgdm9pZCBkaXNwbGF5KFVwZGF0ZUluZm8mKTsK LSAgICBQYXNzT3duUHRyPFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dD4gY3JlYXRlR3JhcGhpY3ND b250ZXh0KFNoYXJlYWJsZUJpdG1hcCopOwogCiAgICAgdWludDY0X3QgbV9iYWNraW5nU3RvcmVT dGF0ZUlEOwogCg==