109892 2013-02-14 22:52:45 -0800 Fix inconsistency in WebGLRenderingContext.idl for getAttribLocation 2013-02-15 08:28:24 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aandrey aandrey haraken kbr webkit.review.bot zmo oldest_to_newest 833710 0 aandrey 2013-02-14 22:52:45 -0800 getAttribLocation should return long (GLint) instead of int. 834027 1 188571 aandrey 2013-02-15 07:51:48 -0800 Created attachment 188571 Patch 834028 2 aandrey 2013-02-15 07:52:55 -0800 Only generator CPP will produce a different result: diff --git a/tmp/bindings-golden/WebKitDOMWebGLRenderingContext.cpp b/tmp/bindings/WebKitDOMWebGLRenderingContext.cpp index dcfdd19..d10052d 100644 --- a/tmp/bindings-golden/WebKitDOMWebGLRenderingContext.cpp +++ b/tmp/bindings/WebKitDOMWebGLRenderingContext.cpp @@ -1119,7 +1119,7 @@ webkit_dom_web_gl_rendering_context_get_active_uniform(WebKitDOMWebGLRenderingCo #endif /* ENABLE(WEBGL) */ } -gint +glong webkit_dom_web_gl_rendering_context_get_attrib_location(WebKitDOMWebGLRenderingContext* self, WebKitDOMWebGLProgram* program, const gchar* name) { #if ENABLE(WEBGL) @@ -1130,11 +1130,11 @@ webkit_dom_web_gl_rendering_context_get_attrib_location(WebKitDOMWebGLRenderingC WebCore::WebGLRenderingContext* item = WebKit::core(self); WebCore::WebGLProgram* convertedProgram = WebKit::core(program); WTF::String convertedName = WTF::String::fromUTF8(name); - gint result = item->getAttribLocation(convertedProgram, convertedName); + glong result = item->getAttribLocation(convertedProgram, convertedName); return result; #else WEBKIT_WARN_FEATURE_NOT_PRESENT("Webgl") - return static_cast<gint>(0); + return static_cast<glong>(0); #endif /* ENABLE(WEBGL) */ } diff --git a/tmp/bindings-golden/WebKitDOMWebGLRenderingContext.h b/tmp/bindings/WebKitDOMWebGLRenderingContext.h index 3573ea3..5cae547 100644 --- a/tmp/bindings-golden/WebKitDOMWebGLRenderingContext.h +++ b/tmp/bindings/WebKitDOMWebGLRenderingContext.h @@ -793,7 +793,7 @@ webkit_dom_web_gl_rendering_context_get_active_uniform(WebKitDOMWebGLRenderingCo * Returns: * **/ -WEBKIT_API gint +WEBKIT_API glong webkit_dom_web_gl_rendering_context_get_attrib_location(WebKitDOMWebGLRenderingContext* self, WebKitDOMWebGLProgram* program, const gchar* name); /** 834033 3 188571 haraken 2013-02-15 07:58:12 -0800 Comment on attachment 188571 Patch OK. int is deprecated n the Web IDL spec. 834049 4 188571 webkit.review.bot 2013-02-15 08:28:21 -0800 Comment on attachment 188571 Patch Clearing flags on attachment: 188571 Committed r143003: <http://trac.webkit.org/changeset/143003> 834050 5 webkit.review.bot 2013-02-15 08:28:24 -0800 All reviewed patches have been landed. Closing bug. 188571 2013-02-15 07:51:48 -0800 2013-02-15 08:28:21 -0800 Patch bug-109892-20130215194814.patch text/plain 1631 aandrey U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyOTk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTEwNDI5MmI4YzczMGMy ZmNhMjhjY2IxMDQ5ODdjNGZhMDJlYzAzOS4uMzI2ZmExMmI5ZjQxY2UxNWE3YzhjNjlmMTlkOGFj OTlkMGI3N2E3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEzLTAyLTE1ICBBbmRy ZXkgQWRhaWtpbiAgPGFhbmRyZXlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZpeCBpbmNvbnNp c3RlbmN5IGluIFdlYkdMUmVuZGVyaW5nQ29udGV4dC5pZGwgZm9yIGdldEF0dHJpYkxvY2F0aW9u CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDk4OTIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0bWwv Y2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5pZGw6CisKIDIwMTMtMDItMTUgIEpvZSBNYXNv biAgPGptYXNvbkByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBSZW1vdmUgcmVkdW5k YW50IHJlcXVpcmVBdXRoIHBhcmFtZXRlciBvZiBOZXR3b3JrSm9iOjpub3RpZnlBdXRoUmVjZWl2 ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5n Q29udGV4dC5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0Nv bnRleHQuaWRsCmluZGV4IGU4MDQxNDA3ZTQwNWFhNjNmYWJjYmRkOTU0N2NkZjJiYTgwMWU0MWIu LjkyODIzY2MyYTUzNDI2MGYzZjExMjI1NjcwZDJmNWVjNmIxMzBlMDAgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5pZGwKKysrIGIv U291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmlkbApAQCAt NTM2LDggKzUzNiw3IEBAIHR5cGVkZWYgLyp1bnJlc3RyaWN0ZWQqLyBmbG9hdCBHTGNsYW1wZjsK IAogICAgIFtTdHJpY3RUeXBlQ2hlY2tpbmcsIEN1c3RvbV0gdm9pZCBnZXRBdHRhY2hlZFNoYWRl cnMoaW4gV2ViR0xQcm9ncmFtIHByb2dyYW0pIHJhaXNlcyAoRE9NRXhjZXB0aW9uKTsKIAotICAg IC8vIEZJWE1FOiB0aGlzIGRpZmZlcnMgZnJvbSB0aGUgY3VycmVudCBXZWJHTCBzcGVjIChzaG91 bGQgcmV0dXJuIEdMaW50L2xvbmcpCi0gICAgW1N0cmljdFR5cGVDaGVja2luZ10gaW50ICAgICAg ICAgIGdldEF0dHJpYkxvY2F0aW9uKGluIFdlYkdMUHJvZ3JhbSBwcm9ncmFtLCBpbiBET01TdHJp bmcgbmFtZSk7CisgICAgW1N0cmljdFR5cGVDaGVja2luZ10gR0xpbnQgICAgICAgIGdldEF0dHJp YkxvY2F0aW9uKGluIFdlYkdMUHJvZ3JhbSBwcm9ncmFtLCBpbiBET01TdHJpbmcgbmFtZSk7CiAK ICAgICAvLyBhbnkgZ2V0QnVmZmVyUGFyYW1ldGVyKGluIEdMZW51bSB0YXJnZXQsIGluIEdMZW51 bSBwbmFtZSkgcmFpc2VzKERPTUV4Y2VwdGlvbik7CiAgICAgW1N0cmljdFR5cGVDaGVja2luZywg Q3VzdG9tXSB2b2lkIGdldEJ1ZmZlclBhcmFtZXRlcigpOwo=