109872 2013-02-14 16:06:09 -0800 Inspector doesn't show rules from pluginsStyleSheet 2013-02-14 17:22:15 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino apavlov joepeck keishi loislo macpherson menard ojan.autocc pfeldman pmuellr timothy vsevik web-inspector-bugs webkit-bug-importer webkit.review.bot yurys oldest_to_newest 833517 0 dino 2013-02-14 16:06:09 -0800 The inspector doesn't collect the rules from the plugins style sheet. 833519 1 webkit-bug-importer 2013-02-14 16:06:49 -0800 <rdar://problem/13220679> 833522 2 188446 dino 2013-02-14 16:09:19 -0800 Created attachment 188446 Patch 833563 3 188446 darin 2013-02-14 16:44:28 -0800 Comment on attachment 188446 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188446&action=review > Source/WebCore/css/InspectorCSSOMWrappers.cpp:127 > + collectFromStyleSheetContents(m_styleSheetCSSOMWrapperSet, CSSDefaultStyleSheets::plugInsStyleSheet); No #ifdef needed? 833584 4 188446 dino 2013-02-14 17:13:37 -0800 Comment on attachment 188446 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188446&action=review >> Source/WebCore/css/InspectorCSSOMWrappers.cpp:127 >> + collectFromStyleSheetContents(m_styleSheetCSSOMWrapperSet, CSSDefaultStyleSheets::plugInsStyleSheet); > > No #ifdef needed? Nope - these default stylesheets are always around (although possibly empty, and can have different content on different ports thanks to #ifdefs in CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement). 833587 5 dino 2013-02-14 17:22:15 -0800 Committed r142944: <http://trac.webkit.org/changeset/142944> 188446 2013-02-14 16:09:19 -0800 2013-02-14 17:13:37 -0800 Patch bug-109872-20130215110546.patch text/plain 1980 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyODQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTlhNDczODk3MzQ4MDMw NDM1NzI4MjNiZTNiZGQyYzRlNTc3MzljZi4uMjgzNDA1YmYwYTVkOTM2MTA5N2VkNzViMmRlNzFi YWY0YTBiZDY3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAyLTE0ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBJbnNwZWN0b3IgZG9lc24ndCBz aG93IHJ1bGVzIGZyb20gcGx1Z2luc1N0eWxlU2hlZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTg3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ugc3VyZSBnZXRXcmFwcGVyRm9yUnVsZUluU2hl ZXRzIGNvbGxlY3RzIHRoZSBydWxlcworICAgICAgICBmcm9tIENTU0RlZmF1bHRTdHlsZVNoZWV0 czo6cGx1Z0luc1N0eWxlU2hlZXQuCisKKyAgICAgICAgTWFraW5nIGEgdGVzdCBmb3IgdGhpcyBp cyBkaWZmaWN1bHQgYmVjYXVzZSB0aGUgcnVsZXMgaW4KKyAgICAgICAgdGhpcyBzaGVldCBvbmx5 IGFwcGx5IHRvIHNuYXBzaG90dGVkIHBsdWdpbnMgYXQgdGhlIG1vbWVudCwKKyAgICAgICAgd2hp Y2ggYXJlIGRpc2FibGVkIGluIERSVCwgYW5kIHdvdWxkIHJlcXVpcmUgYSBmYWlybHkgbG9uZwor ICAgICAgICB0aW1lb3V0IGluIHRoZSB0ZXN0LgorCisgICAgICAgICogY3NzL0luc3BlY3RvckNT U09NV3JhcHBlcnMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yQ1NTT01XcmFwcGVy czo6Z2V0V3JhcHBlckZvclJ1bGVJblNoZWV0cyk6CisKIDIwMTMtMDItMTMgIEFkYW0gQmFydGgg IDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBTdGFydFRhZ1NjYW5uZXIgc2hvdWxkIGJl IHRocmVhZC1zYWZlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvSW5zcGVjdG9yQ1NT T01XcmFwcGVycy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvSW5zcGVjdG9yQ1NTT01XcmFwcGVy cy5jcHAKaW5kZXggMjZkMWZlZjJjMGVlNjYyOTU3OWY2NGYwOWJhMTBjM2I5YjJiZTNkZS4uZTZh Yzk2MzBiMTM4MzRmMWM5MTRlMjZhMGEyNDA5MzlmN2JhZjRkMyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvY3NzL0luc3BlY3RvckNTU09NV3JhcHBlcnMuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2Nzcy9JbnNwZWN0b3JDU1NPTVdyYXBwZXJzLmNwcApAQCAtMTI0LDYgKzEyNCw3IEBAIENT U1N0eWxlUnVsZSogSW5zcGVjdG9yQ1NTT01XcmFwcGVyczo6Z2V0V3JhcHBlckZvclJ1bGVJblNo ZWV0cyhTdHlsZVJ1bGUqIHJ1bGUsCiAgICAgICAgIGNvbGxlY3RGcm9tU3R5bGVTaGVldENvbnRl bnRzKG1fc3R5bGVTaGVldENTU09NV3JhcHBlclNldCwgQ1NTRGVmYXVsdFN0eWxlU2hlZXRzOjpt YXRoTUxTdHlsZVNoZWV0KTsKICAgICAgICAgY29sbGVjdEZyb21TdHlsZVNoZWV0Q29udGVudHMo bV9zdHlsZVNoZWV0Q1NTT01XcmFwcGVyU2V0LCBDU1NEZWZhdWx0U3R5bGVTaGVldHM6Om1lZGlh Q29udHJvbHNTdHlsZVNoZWV0KTsKICAgICAgICAgY29sbGVjdEZyb21TdHlsZVNoZWV0Q29udGVu dHMobV9zdHlsZVNoZWV0Q1NTT01XcmFwcGVyU2V0LCBDU1NEZWZhdWx0U3R5bGVTaGVldHM6OmZ1 bGxzY3JlZW5TdHlsZVNoZWV0KTsKKyAgICAgICAgY29sbGVjdEZyb21TdHlsZVNoZWV0Q29udGVu dHMobV9zdHlsZVNoZWV0Q1NTT01XcmFwcGVyU2V0LCBDU1NEZWZhdWx0U3R5bGVTaGVldHM6OnBs dWdJbnNTdHlsZVNoZWV0KTsKIAogICAgICAgICBjb2xsZWN0RnJvbURvY3VtZW50U3R5bGVTaGVl dENvbGxlY3Rpb24oc3R5bGVTaGVldENvbGxlY3Rpb24pOwogICAgIH0K