109811 2013-02-14 04:24:44 -0800 Web Inspector: don't create static local string for program literal in InspectorTimelineAgent 2013-02-14 05:21:00 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys yurys apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 832946 0 yurys 2013-02-14 04:24:44 -0800 InspectorTimelineAgent::innerAddRecordToTimeline contains the following declaration DEFINE_STATIC_LOCAL(String, program, (TimelineRecordType::Program)); Since there may be timeline agent on worker thread there is a risk of leaking the string in case of concurrent initialization. I think it was introduced to avoid creating wrappers each time for TimelineRecordType::Program C-string but there is overloaded operator==(cons String&, const char*) so the performance shouldn't suffer if compare type string with the constant directly. 832948 1 188317 yurys 2013-02-14 04:26:10 -0800 Created attachment 188317 Patch 832992 2 188317 webkit.review.bot 2013-02-14 05:20:57 -0800 Comment on attachment 188317 Patch Clearing flags on attachment: 188317 Committed r142873: <http://trac.webkit.org/changeset/142873> 832993 3 webkit.review.bot 2013-02-14 05:21:00 -0800 All reviewed patches have been landed. Closing bug. 188317 2013-02-14 04:26:10 -0800 2013-02-14 05:20:57 -0800 Patch bug-109811-20130214162237.patch text/plain 1950 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyODYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWM2ZmIzYTQ3MTE0Yzdl YzViZDNhOWJiN2QyNWU5OWY2ODhjZTY5Ny4uZDg3NTBiN2Y5NWQ4YmFiMDhjYjRmMDU1NWI5ZDFh ZGNjM2Y0MGVmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDEzLTAyLTE0ICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgogCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGRvbid0IGNyZWF0ZSBzdGF0aWMgbG9jYWwgc3RyaW5nIGZvciBwcm9ncmFtIGxpdGVyYWwg aW4gSW5zcGVjdG9yVGltZWxpbmVBZ2VudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTA5ODExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVXNlIGNvbnN0IGNoYXIqIGNvbnN0YW50IHZhbHVlIGluc3RlYWQg b2YgY3JlYXRpbmcgU3RyaW5nIGZyb20gaXQgaW4gdGhyZWFkLXVuc2FmZQorICAgICAgICBzdGF0 aWMgbG9jYWwgdmFyaWFibGUuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yVGltZWxp bmVBZ2VudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JUaW1lbGluZUFnZW50Ojpp bm5lckFkZFJlY29yZFRvVGltZWxpbmUpOgorCisyMDEzLTAyLTE0ICBZdXJ5IFNlbWlraGF0c2t5 ICA8eXVyeXNAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IGV4dHJhY3Qg RE9NIGNvdW50ZXJzIGdyYXBoIGltcGxlbWVudGF0aW9uIGludG8gaXRzIG93biBjbGFzcwogICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5Nzk2CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JUaW1lbGluZUFnZW50 LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JUaW1lbGluZUFnZW50LmNw cAppbmRleCA3Y2RlOGY5NzZmOGJmY2FkYWQxZjZkMTEzNWI1YTMxMTI1ZDQ4OTc0Li45N2UxNDY5 N2YzMTc2ODE1ZDA5OWE2MjE4NjAzNGM3NGJjMmNlYmE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yVGltZWxpbmVBZ2VudC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclRpbWVsaW5lQWdlbnQuY3BwCkBAIC00OTksMTMgKzQ5 OSwxMSBAQCB2b2lkIEluc3BlY3RvclRpbWVsaW5lQWdlbnQ6OmFkZFJlY29yZFRvVGltZWxpbmUo UGFzc1JlZlB0cjxJbnNwZWN0b3JPYmplY3Q+IHJlYwogCiB2b2lkIEluc3BlY3RvclRpbWVsaW5l QWdlbnQ6OmlubmVyQWRkUmVjb3JkVG9UaW1lbGluZShQYXNzUmVmUHRyPEluc3BlY3Rvck9iamVj dD4gcHJwUmVjb3JkLCBjb25zdCBTdHJpbmcmIHR5cGUsIGNvbnN0IFN0cmluZyYgZnJhbWVJZCkK IHsKLSAgICBERUZJTkVfU1RBVElDX0xPQ0FMKFN0cmluZywgcHJvZ3JhbSwgKFRpbWVsaW5lUmVj b3JkVHlwZTo6UHJvZ3JhbSkpOwotCiAgICAgUmVmUHRyPEluc3BlY3Rvck9iamVjdD4gcmVjb3Jk KHBycFJlY29yZCk7CiAgICAgcmVjb3JkLT5zZXRTdHJpbmcoInR5cGUiLCB0eXBlKTsKICAgICBp ZiAoIWZyYW1lSWQuaXNFbXB0eSgpKQogICAgICAgICByZWNvcmQtPnNldFN0cmluZygiZnJhbWVJ ZCIsIGZyYW1lSWQpOwotICAgIGlmICh0eXBlID09IHByb2dyYW0pCisgICAgaWYgKHR5cGUgPT0g VGltZWxpbmVSZWNvcmRUeXBlOjpQcm9ncmFtKQogICAgICAgICBzZXROYXRpdmVIZWFwU3RhdGlz dGljcyhyZWNvcmQuZ2V0KCkpOwogICAgIGVsc2UKICAgICAgICAgc2V0RE9NQ291bnRlcnMocmVj b3JkLmdldCgpKTsK