109788 2013-02-13 23:38:15 -0800 [V8] CodeGeneratorV8.pm can assume that DOMWindow has [CheckSecurity] 2013-02-14 16:40:02 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 832766 0 haraken 2013-02-13 23:38:15 -0800 There is code like this: if ($extendedAttr{"CheckSecurity"} || $interfaceName eq "DOMWindow") This check is redundant. DOMWindow has [CheckSecurity]. 832767 1 188269 haraken 2013-02-13 23:39:25 -0800 Created attachment 188269 Patch 833557 2 188269 webkit.review.bot 2013-02-14 16:39:59 -0800 Comment on attachment 188269 Patch Clearing flags on attachment: 188269 Committed r142939: <http://trac.webkit.org/changeset/142939> 833558 3 webkit.review.bot 2013-02-14 16:40:02 -0800 All reviewed patches have been landed. Closing bug. 188269 2013-02-13 23:39:25 -0800 2013-02-14 16:39:59 -0800 Patch bug-109788-20130214163553.patch text/plain 3967 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyODQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjc1Y2IzYjYxMzgyYTk1 MGY1MTNlYzZmMzE3MTgwNjZmMmRhNWVjZC4uMzg2MzI2ODJmZWRlOWRmNjkxMDY4NjQ2Yjk2NDkz NGM5NjUwNjU0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3IEBACiAyMDEzLTAyLTEzICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdIENvZGVHZW5l cmF0b3JWOC5wbSBjYW4gYXNzdW1lIHRoYXQgRE9NV2luZG93IGhhcyBbQ2hlY2tTZWN1cml0eV0K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTc4OAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIGlz IGNvZGUgbGlrZSB0aGlzOgorCisgICAgICAgICAgaWYgKCRleHRlbmRlZEF0dHJ7IkNoZWNrU2Vj dXJpdHkifSB8fCAkaW50ZXJmYWNlTmFtZSBlcSAiRE9NV2luZG93IikKKworICAgICAgICBUaGlz IGNoZWNrIGlzIHJlZHVuZGFudC4gRE9NV2luZG93IGhhcyBbQ2hlY2tTZWN1cml0eV0uIFdlIGNh biByZW1vdmUgdGhlCisgICAgICAgIERPTVdpbmRvdyBjaGVjay4KKworICAgICAgICBObyB0ZXN0 cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9D b2RlR2VuZXJhdG9yVjgucG06CisgICAgICAgIChHZW5lcmF0ZVJlcGxhY2VhYmxlQXR0clNldHRl cik6CisgICAgICAgIChHZW5lcmF0ZUZ1bmN0aW9uQ2FsbGJhY2spOgorICAgICAgICAoR2VuZXJh dGVOb25TdGFuZGFyZEZ1bmN0aW9uKToKKyAgICAgICAgKEdlbmVyYXRlSW1wbGVtZW50YXRpb24p OgorCisyMDEzLTAyLTEzICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKwog ICAgICAgICBbVjhdIEdlbmVyYXRlIHdyYXBwZXIgbWV0aG9kcyBmb3IgY3VzdG9tIG1ldGhvZHMK ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTY3OAog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0 b3JWOC5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4 LnBtCmluZGV4IDA1ZjY1ODljN2FmYmQ1YzViNzQ0MjFmOGQwMmE3MzE2ZWQyMGMwMzEuLjZjZWNl N2QyMDc0YTQwMTMwNWZiMDIwYWVlMzA1NjM4ZTY3ZjliYzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCkBAIC0xMTUwLDcgKzEx NTAsNyBAQCBzdGF0aWMgdm9pZCAke2ludGVyZmFjZU5hbWV9UmVwbGFjZWFibGVBdHRyU2V0dGVy KHY4OjpMb2NhbDx2ODo6U3RyaW5nPiBuYW1lLCB2OAogRU5ECiAgICAgcHVzaChAaW1wbENvbnRl bnREZWNscywgR2VuZXJhdGVGZWF0dXJlT2JzZXJ2YXRpb24oJGludGVyZmFjZS0+ZXh0ZW5kZWRB dHRyaWJ1dGVzLT57IlY4TWVhc3VyZUFzIn0pKTsKIAotICAgIGlmICgkaW50ZXJmYWNlTmFtZSBl cSAiRE9NV2luZG93IiB8fCAkaW50ZXJmYWNlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiQ2hlY2tT ZWN1cml0eSJ9KSB7CisgICAgaWYgKCRpbnRlcmZhY2UtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJD aGVja1NlY3VyaXR5In0pIHsKICAgICAgICAgQWRkVG9JbXBsSW5jbHVkZXMoIkZyYW1lLmgiKTsK ICAgICAgICAgcHVzaChAaW1wbENvbnRlbnREZWNscywgPDxFTkQpOwogICAgICR7aW50ZXJmYWNl TmFtZX0qIGltcCA9IFY4JHtpbnRlcmZhY2VOYW1lfTo6dG9OYXRpdmUoaW5mby5Ib2xkZXIoKSk7 CkBAIC0xNjAwLDkgKzE2MDAsNyBAQCBFTkQKICAgICB9CiAKICAgICAjIENoZWNrIGRvbWFpbiBz ZWN1cml0eSBpZiBuZWVkZWQKLSAgICBpZiAoKCRpbnRlcmZhY2UtPmV4dGVuZGVkQXR0cmlidXRl cy0+eyJDaGVja1NlY3VyaXR5In0KLSAgICAgICAgfHwgJGludGVyZmFjZU5hbWUgZXEgIkRPTVdp bmRvdyIpCi0gICAgICAgICYmICEkZnVuY3Rpb24tPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1 dGVzLT57IkRvTm90Q2hlY2tTZWN1cml0eSJ9KSB7CisgICAgaWYgKCRpbnRlcmZhY2UtPmV4dGVu ZGVkQXR0cmlidXRlcy0+eyJDaGVja1NlY3VyaXR5In0gJiYgISRmdW5jdGlvbi0+c2lnbmF0dXJl LT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiRG9Ob3RDaGVja1NlY3VyaXR5In0pIHsKICAgICAgICAg IyBXZSBoYXZlIG5vdCBmaW5kIHJlYWwgdXNlIGNhc2VzIHlldC4KICAgICAgICAgQWRkVG9JbXBs SW5jbHVkZXMoIkZyYW1lLmgiKTsKICAgICAgICAgcHVzaChAaW1wbENvbnRlbnREZWNscywgPDxF TkQpOwpAQCAtMjQxMiw4ICsyNDEwLDcgQEAgc3ViIEdlbmVyYXRlTm9uU3RhbmRhcmRGdW5jdGlv bgogICAgICAgICAkY29uZGl0aW9uYWwgPSAiaWYgKCR7ZW5hYmxlX2Z1bmN0aW9ufShpbXBsLT5k b2N1bWVudCgpKSlcbiAgICAgICAgIjsKICAgICB9CiAKLSAgICBpZiAoJGF0dHJFeHQtPnsiRG9O b3RDaGVja1NlY3VyaXR5In0gJiYKLSAgICAgICAgKCRpbnRlcmZhY2UtPmV4dGVuZGVkQXR0cmli dXRlcy0+eyJDaGVja1NlY3VyaXR5In0gfHwgJGludGVyZmFjZU5hbWUgZXEgIkRPTVdpbmRvdyIp KSB7CisgICAgaWYgKCRpbnRlcmZhY2UtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDaGVja1NlY3Vy aXR5In0gJiYgJGF0dHJFeHQtPnsiRG9Ob3RDaGVja1NlY3VyaXR5In0pIHsKICAgICAgICAgIyBG dW5jdGlvbnMgdGhhdCBhcmUgbWFya2VkIERvTm90Q2hlY2tTZWN1cml0eSBhcmUgYWx3YXlzIHJl YWRhYmxlIGJ1dCBpZiB0aGV5IGFyZSBjaGFuZ2VkCiAgICAgICAgICMgYW5kIHRoZW4gYWNjZXNz ZWQgb24gYSBkaWZmZXJlbnQgZG9tYWluIHdlIGRvIG5vdCByZXR1cm4gdGhlIHVuZGVybHlpbmcg dmFsdWUgYnV0IGluc3RlYWQKICAgICAgICAgIyByZXR1cm4gYSBuZXcgY29weSBvZiB0aGUgb3Jp Z2luYWwgZnVuY3Rpb24uIFRoaXMgaXMgYWNoaWV2ZWQgYnkgc3RvcmluZyB0aGUgY2hhbmdlZCB2 YWx1ZQpAQCAtMjc5MCw3ICsyNzg3LDcgQEAgRU5ECiAgICAgICAgICMgSWYgdGhlIGZ1bmN0aW9u IGRvZXMgbm90IG5lZWQgZG9tYWluIHNlY3VyaXR5IGNoZWNrLCB3ZSBuZWVkIHRvCiAgICAgICAg ICMgZ2VuZXJhdGUgYW4gYWNjZXNzIGdldHRlciB0aGF0IHJldHVybnMgZGlmZmVyZW50IGZ1bmN0 aW9uIG9iamVjdHMKICAgICAgICAgIyBmb3IgZGlmZmVyZW50IGNhbGxpbmcgY29udGV4dC4KLSAg ICAgICAgaWYgKCgkaW50ZXJmYWNlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiQ2hlY2tTZWN1cml0 eSJ9IHx8ICgkaW50ZXJmYWNlTmFtZSBlcSAiRE9NV2luZG93IikpICYmICRmdW5jdGlvbi0+c2ln bmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiRG9Ob3RDaGVja1NlY3VyaXR5In0pIHsKKyAg ICAgICAgaWYgKCRpbnRlcmZhY2UtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDaGVja1NlY3VyaXR5 In0gJiYgJGZ1bmN0aW9uLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJEb05vdENo ZWNrU2VjdXJpdHkifSkgewogICAgICAgICAgICAgaWYgKCFIYXNDdXN0b21NZXRob2QoJGZ1bmN0 aW9uLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcykgfHwgJGZ1bmN0aW9uLT57b3Zlcmxv YWRJbmRleH0gPT0gMSkgewogICAgICAgICAgICAgICAgIEdlbmVyYXRlRG9tYWluU2FmZUZ1bmN0 aW9uR2V0dGVyKCRmdW5jdGlvbiwgJGludGVyZmFjZU5hbWUpOwogICAgICAgICAgICAgICAgICRu ZWVkc0RvbWFpblNhZmVGdW5jdGlvblNldHRlciA9IDE7Cg==