109780 2013-02-13 19:37:28 -0800 [Regression] After r142831 collection-null-like-arguments.html layout test failing 2013-02-19 01:05:00 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 code.vineet code.vineet abarth haraken webkit.review.bot oldest_to_newest 832671 0 code.vineet 2013-02-13 19:37:28 -0800 After r142831: LayoutTests/fast/dom/collection-null-like-arguments.html is failing for JSC bindings. 832681 1 188251 code.vineet 2013-02-13 19:52:13 -0800 Created attachment 188251 patch As per specification only for namedItem() it should return null if collection is empty. @r142831 caused regression because it was returning null from getNamedItems() directly. 832683 2 188251 haraken 2013-02-13 19:54:10 -0800 Comment on attachment 188251 patch Looks reasonable. Thanks for the quick fix. 832697 3 188251 webkit.review.bot 2013-02-13 20:19:20 -0800 Comment on attachment 188251 patch Clearing flags on attachment: 188251 Committed r142846: <http://trac.webkit.org/changeset/142846> 832698 4 webkit.review.bot 2013-02-13 20:19:23 -0800 All reviewed patches have been landed. Closing bug. 188251 2013-02-13 19:52:13 -0800 2013-02-13 20:19:20 -0800 patch namedItem_002.diff text/plain 4371 code.vineet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0Mjg0NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEzLTAyLTEzICAgVmluZWV0 IENoYXVkaGFyeSAgPHJnZjc0OEBtb3Rvcm9sYS5jb20+CisKKyAgICAgICAgW1JlZ3Jlc3Npb25d IEFmdGVyIHIxNDI4MzEgIGNvbGxlY3Rpb24tbnVsbC1saWtlLWFyZ3VtZW50cy5odG1sIGxheW91 dCB0ZXN0IGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwOTc4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE5vIG5ldyB0ZXN0cy4gTGF5b3V0VGVzdHMvZmFzdC9kb20vY29sbGVjdGlvbi1udWxs LWxpa2UtYXJndW1lbnRzLmh0bWwKKyAgICAgICAgU2hvdWxkIHBhc3Mgbm93LgorCisgICAgICAg ICogYmluZGluZ3MvanMvSlNIVE1MQWxsQ29sbGVjdGlvbkN1c3RvbS5jcHA6IFJldHVybiBudWxs IGZvciBuYW1lZEl0ZW0oKSBvbmx5LgorICAgICAgICAoV2ViQ29yZTo6Z2V0TmFtZWRJdGVtcyk6 CisgICAgICAgIChXZWJDb3JlOjpKU0hUTUxBbGxDb2xsZWN0aW9uOjpuYW1lZEl0ZW0pOgorICAg ICAgICAqIGJpbmRpbmdzL2pzL0pTSFRNTEZvcm1Db250cm9sc0NvbGxlY3Rpb25DdXN0b20uY3Bw OiBEaXR0by4KKyAgICAgICAgKFdlYkNvcmU6OmdldE5hbWVkSXRlbXMpOgorICAgICAgICAoV2Vi Q29yZTo6SlNIVE1MRm9ybUNvbnRyb2xzQ29sbGVjdGlvbjo6bmFtZWRJdGVtKToKKyAgICAgICAg KiBiaW5kaW5ncy9qcy9KU0hUTUxPcHRpb25zQ29sbGVjdGlvbkN1c3RvbS5jcHA6IERpdHRvLgor ICAgICAgICAoV2ViQ29yZTo6Z2V0TmFtZWRJdGVtcyk6CisgICAgICAgIChXZWJDb3JlOjpKU0hU TUxPcHRpb25zQ29sbGVjdGlvbjo6bmFtZWRJdGVtKToKKwogMjAxMy0wMi0xMyAgQWRhbSBCYXJ0 aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFRva2VuUHJlbG9hZFNjYW5uZXIgc2hv dWxkIGJlIChtb3N0bHkhKSB0aHJlYWQtc2FmZQpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvanMvSlNIVE1MQWxsQ29sbGVjdGlvbkN1c3RvbS5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvYmluZGluZ3MvanMvSlNIVE1MQWxsQ29sbGVjdGlvbkN1c3RvbS5jcHAJKHJldmlz aW9uIDE0MjgzOSkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTSFRNTEFsbENvbGxl Y3Rpb25DdXN0b20uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00Niw3ICs0Niw3IEBAIHN0YXRpYyBK U1ZhbHVlIGdldE5hbWVkSXRlbXMoRXhlY1N0YXRlKgogICAgIGNvbGxlY3Rpb24tPmltcGwoKS0+ bmFtZWRJdGVtcyhwcm9wZXJ0eU5hbWVUb0F0b21pY1N0cmluZyhwcm9wZXJ0eU5hbWUpLCBuYW1l ZEl0ZW1zKTsKIAogICAgIGlmIChuYW1lZEl0ZW1zLmlzRW1wdHkoKSkKLSAgICAgICAgcmV0dXJu IGpzTnVsbCgpOworICAgICAgICByZXR1cm4ganNVbmRlZmluZWQoKTsKICAgICBpZiAobmFtZWRJ dGVtcy5zaXplKCkgPT0gMSkKICAgICAgICAgcmV0dXJuIHRvSlMoZXhlYywgY29sbGVjdGlvbi0+ Z2xvYmFsT2JqZWN0KCksIG5hbWVkSXRlbXNbMF0uZ2V0KCkpOwogCkBAIC0xMTYsNyArMTE2LDgg QEAgSlNWYWx1ZSBKU0hUTUxBbGxDb2xsZWN0aW9uOjppdGVtKEV4ZWNTdAogCiBKU1ZhbHVlIEpT SFRNTEFsbENvbGxlY3Rpb246Om5hbWVkSXRlbShFeGVjU3RhdGUqIGV4ZWMpCiB7Ci0gICAgcmV0 dXJuIGdldE5hbWVkSXRlbXMoZXhlYywgdGhpcywgSWRlbnRpZmllcihleGVjLCBleGVjLT5hcmd1 bWVudCgwKS50b1N0cmluZyhleGVjKS0+dmFsdWUoZXhlYykpKTsKKyAgICBKU1ZhbHVlIHZhbHVl ID0gZ2V0TmFtZWRJdGVtcyhleGVjLCB0aGlzLCBJZGVudGlmaWVyKGV4ZWMsIGV4ZWMtPmFyZ3Vt ZW50KDApLnRvU3RyaW5nKGV4ZWMpLT52YWx1ZShleGVjKSkpOworICAgIHJldHVybiB2YWx1ZS5p c1VuZGVmaW5lZCgpID8ganNOdWxsKCkgOiB2YWx1ZTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2Vi Q29yZQpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNIVE1MRm9ybUNvbnRyb2xz Q29sbGVjdGlvbkN1c3RvbS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvanMvSlNIVE1MRm9ybUNvbnRyb2xzQ29sbGVjdGlvbkN1c3RvbS5jcHAJKHJldmlzaW9uIDE0 MjgzOSkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTSFRNTEZvcm1Db250cm9sc0Nv bGxlY3Rpb25DdXN0b20uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NCw3ICs0NCw3IEBAIHN0YXRp YyBKU1ZhbHVlIGdldE5hbWVkSXRlbXMoRXhlY1N0YXRlKgogICAgIGNvbGxlY3Rpb24tPmltcGwo KS0+bmFtZWRJdGVtcyhuYW1lLCBuYW1lZEl0ZW1zKTsKIAogICAgIGlmIChuYW1lZEl0ZW1zLmlz RW1wdHkoKSkKLSAgICAgICAgcmV0dXJuIGpzTnVsbCgpOworICAgICAgICByZXR1cm4ganNVbmRl ZmluZWQoKTsKICAgICBpZiAobmFtZWRJdGVtcy5zaXplKCkgPT0gMSkKICAgICAgICAgcmV0dXJu IHRvSlMoZXhlYywgY29sbGVjdGlvbi0+Z2xvYmFsT2JqZWN0KCksIG5hbWVkSXRlbXNbMF0uZ2V0 KCkpOwogCkBAIC02NSw3ICs2NSw4IEBAIEpTVmFsdWUgSlNIVE1MRm9ybUNvbnRyb2xzQ29sbGVj dGlvbjo6bmEKIAogSlNWYWx1ZSBKU0hUTUxGb3JtQ29udHJvbHNDb2xsZWN0aW9uOjpuYW1lZEl0 ZW0oRXhlY1N0YXRlKiBleGVjKQogewotICAgIHJldHVybiBnZXROYW1lZEl0ZW1zKGV4ZWMsIHRo aXMsIElkZW50aWZpZXIoZXhlYywgZXhlYy0+YXJndW1lbnQoMCkudG9TdHJpbmcoZXhlYyktPnZh bHVlKGV4ZWMpKSk7CisgICAgSlNWYWx1ZSB2YWx1ZSA9IGdldE5hbWVkSXRlbXMoZXhlYywgdGhp cywgSWRlbnRpZmllcihleGVjLCBleGVjLT5hcmd1bWVudCgwKS50b1N0cmluZyhleGVjKS0+dmFs dWUoZXhlYykpKTsKKyAgICByZXR1cm4gdmFsdWUuaXNVbmRlZmluZWQoKSA/IGpzTnVsbCgpIDog dmFsdWU7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL2pzL0pTSFRNTE9wdGlvbnNDb2xsZWN0aW9uQ3VzdG9tLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0hUTUxPcHRpb25zQ29sbGVjdGlvbkN1 c3RvbS5jcHAJKHJldmlzaW9uIDE0MjgzOSkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pz L0pTSFRNTE9wdGlvbnNDb2xsZWN0aW9uQ3VzdG9tLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDQs NyArNDQsNyBAQCBzdGF0aWMgSlNWYWx1ZSBnZXROYW1lZEl0ZW1zKEV4ZWNTdGF0ZSoKICAgICBj b2xsZWN0aW9uLT5pbXBsKCktPm5hbWVkSXRlbXMobmFtZSwgbmFtZWRJdGVtcyk7CiAKICAgICBp ZiAobmFtZWRJdGVtcy5pc0VtcHR5KCkpCi0gICAgICAgIHJldHVybiBqc051bGwoKTsKKyAgICAg ICAgcmV0dXJuIGpzVW5kZWZpbmVkKCk7CiAgICAgaWYgKG5hbWVkSXRlbXMuc2l6ZSgpID09IDEp CiAgICAgICAgIHJldHVybiB0b0pTKGV4ZWMsIGNvbGxlY3Rpb24tPmdsb2JhbE9iamVjdCgpLCBu YW1lZEl0ZW1zWzBdLmdldCgpKTsKIApAQCAtNjUsNyArNjUsOCBAQCBKU1ZhbHVlIEpTSFRNTE9w dGlvbnNDb2xsZWN0aW9uOjpuYW1lR2V0CiAKIEpTVmFsdWUgSlNIVE1MT3B0aW9uc0NvbGxlY3Rp b246Om5hbWVkSXRlbShFeGVjU3RhdGUqIGV4ZWMpCiB7Ci0gICAgcmV0dXJuIGdldE5hbWVkSXRl bXMoZXhlYywgdGhpcywgSWRlbnRpZmllcihleGVjLCBleGVjLT5hcmd1bWVudCgwKS50b1N0cmlu ZyhleGVjKS0+dmFsdWUoZXhlYykpKTsKKyAgICBKU1ZhbHVlIHZhbHVlID0gZ2V0TmFtZWRJdGVt cyhleGVjLCB0aGlzLCBJZGVudGlmaWVyKGV4ZWMsIGV4ZWMtPmFyZ3VtZW50KDApLnRvU3RyaW5n KGV4ZWMpLT52YWx1ZShleGVjKSkpOworICAgIHJldHVybiB2YWx1ZS5pc1VuZGVmaW5lZCgpID8g anNOdWxsKCkgOiB2YWx1ZTsKIH0KIAogdm9pZCBKU0hUTUxPcHRpb25zQ29sbGVjdGlvbjo6c2V0 TGVuZ3RoKEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSB2YWx1ZSkK