109763 2013-02-13 16:00:52 -0800 Make WebKit2 Derived Sources work with SDK identifiers too 2013-02-13 17:32:44 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac All RESOLVED FIXED P3 Minor --- 1 dfarler dfarler ddkilzer mrowe webkit.review.bot oldest_to_newest 832455 0 dfarler 2013-02-13 16:00:52 -0800 Similar to https://bugs.webkit.org/show_bug.cgi?id=109324, Source/WebCore/DerivedSources.make invokes CC with -isysroot $(SDKROOT), which won't work if you use an SDK identifier instead of an absolute path in Xcode. Where necessary, we should use pass SDKROOT=${SDKROOT} to make as we did in WebCore. This will let us use SDK identifiers when building with the makefiles. 832461 1 dfarler 2013-02-13 16:06:09 -0800 Source/WebKit2 I should say. 832495 2 188217 dfarler 2013-02-13 16:29:17 -0800 Created attachment 188217 Patch 832553 3 188217 ddkilzer 2013-02-13 17:04:52 -0800 Comment on attachment 188217 Patch r=me 832592 4 188217 webkit.review.bot 2013-02-13 17:32:41 -0800 Comment on attachment 188217 Patch Clearing flags on attachment: 188217 Committed r142830: <http://trac.webkit.org/changeset/142830> 832593 5 webkit.review.bot 2013-02-13 17:32:44 -0800 All reviewed patches have been landed. Closing bug. 188217 2013-02-13 16:29:17 -0800 2013-02-13 17:32:40 -0800 Patch bug-109763-20130213162546.patch text/plain 2125 dfarler U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyODE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDU4NjBiZDMwNDNjYTJm ZmFlYjI4YzhmMTUxYjYwN2Y5ZDE3MTQ5Yy4uM2IzZWRmNmY5ZDcxYTcwZDI4NTc3NmNhNDc3NmYy MzQxNjFjOTY2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEzLTAyLTEzICBEYXZp ZCBGYXJsZXIgIDxkZmFybGVyQGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIFdlYktpdDIgRGVy aXZlZCBTb3VyY2VzIHdvcmsgd2l0aCBTREsgaWRlbnRpZmllcnMgdG9vCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDk3NjMKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYktpdDIueGNvZGVwcm9qL3By b2plY3QucGJ4cHJvajogUGFzcyBTREtST09UPSR7U0RLUk9PVH0gdG8gRGVyaXZlZFNvdXJjZXMu bWFrZQorCiAyMDEzLTAyLTEzICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+ CiAKICAgICAgICAgT25lIG1vcmUgYnVpbGRmaXggZm9yICFFTkFCTEUoUExVR0lOX1BST0NFU1Mp IHBsYXRmb3Jtcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYktpdDIueGNvZGVwcm9q L3Byb2plY3QucGJ4cHJvaiBiL1NvdXJjZS9XZWJLaXQyL1dlYktpdDIueGNvZGVwcm9qL3Byb2pl Y3QucGJ4cHJvagppbmRleCA3ZWFhMTk0NTY4YjJjZDU1Yjc1NDI5ZmJkMzhmMDJlMjdhZGIxZWZk Li5lZTY4NGM3ZmQ5YzlhNDA3MjIzMThiZDJlOGJmMTNkMTVmMzFkNGIyIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9XZWJLaXQyLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oKKysrIGIvU291 cmNlL1dlYktpdDIvV2ViS2l0Mi54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCkBAIC02MTc5LDcg KzYxNzksNyBAQAogCQkJKTsKIAkJCXJ1bk9ubHlGb3JEZXBsb3ltZW50UG9zdHByb2Nlc3Npbmcg PSAwOwogCQkJc2hlbGxQYXRoID0gL2Jpbi9zaDsKLQkJCXNoZWxsU2NyaXB0ID0gIm1rZGlyIC1w IFwiJHtCVUlMVF9QUk9EVUNUU19ESVJ9L0Rlcml2ZWRTb3VyY2VzL1dlYktpdDJcIlxuY2QgXCIk e0JVSUxUX1BST0RVQ1RTX0RJUn0vRGVyaXZlZFNvdXJjZXMvV2ViS2l0MlwiXG5cbmV4cG9ydCBX ZWJLaXQyPVwiJHtTUkNST09UfVwiXG5cbmlmIFsgISAkQ0MgXTsgdGhlblxuICAgIGV4cG9ydCBD Qz1cImB4Y3J1biAtZmluZCBjbGFuZ2BcIlxuZmlcblxuaWYgWyBcIiR7QUNUSU9OfVwiID0gXCJi dWlsZFwiIC1vIFwiJHtBQ1RJT059XCIgPSBcImluc3RhbGxcIiAtbyBcIiR7QUNUSU9OfVwiID0g XCJpbnN0YWxsaGRyc1wiIF07IHRoZW5cbiAgICBtYWtlIC0tbm8tYnVpbHRpbi1ydWxlcyAtZiBc IiR7V2ViS2l0Mn0vRGVyaXZlZFNvdXJjZXMubWFrZVwiIC1qIGAvdXNyL3NiaW4vc3lzY3RsIC1u IGh3LmF2YWlsY3B1YFxuZmlcbiI7CisJCQlzaGVsbFNjcmlwdCA9ICJta2RpciAtcCBcIiR7QlVJ TFRfUFJPRFVDVFNfRElSfS9EZXJpdmVkU291cmNlcy9XZWJLaXQyXCJcbmNkIFwiJHtCVUlMVF9Q Uk9EVUNUU19ESVJ9L0Rlcml2ZWRTb3VyY2VzL1dlYktpdDJcIlxuXG5leHBvcnQgV2ViS2l0Mj1c IiR7U1JDUk9PVH1cIlxuXG5pZiBbICEgJENDIF07IHRoZW5cbiAgICBleHBvcnQgQ0M9XCJgeGNy dW4gLWZpbmQgY2xhbmdgXCJcbmZpXG5cbmlmIFsgXCIke0FDVElPTn1cIiA9IFwiYnVpbGRcIiAt byBcIiR7QUNUSU9OfVwiID0gXCJpbnN0YWxsXCIgLW8gXCIke0FDVElPTn1cIiA9IFwiaW5zdGFs bGhkcnNcIiBdOyB0aGVuXG4gICAgbWFrZSAtLW5vLWJ1aWx0aW4tcnVsZXMgLWYgXCIke1dlYktp dDJ9L0Rlcml2ZWRTb3VyY2VzLm1ha2VcIiAtaiBgL3Vzci9zYmluL3N5c2N0bCAtbiBody5hdmFp bGNwdWAgU0RLUk9PVD0ke1NES1JPT1R9XG5maVxuIjsKIAkJfTsKIAkJRTE0RTk5RkExNEQ4NzlE QjAwMUQyMjFGIC8qIEFkZCBFbnRpdGxlbWVudHMgKi8gPSB7CiAJCQlpc2EgPSBQQlhTaGVsbFNj cmlwdEJ1aWxkUGhhc2U7Cg==