109762 2013-02-13 16:00:03 -0800 IndexedDB: Add a few more histogram calls 2013-02-14 10:19:37 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dgrogan dgrogan alecflett jsbell tony webkit.review.bot oldest_to_newest 832452 0 dgrogan 2013-02-13 16:00:03 -0800 IndexedDB: Add a few more uma logging calls 832454 1 188208 dgrogan 2013-02-13 16:00:41 -0800 Created attachment 188208 Patch 832456 2 dgrogan 2013-02-13 16:01:32 -0800 Josh, could you prereview this? 832467 3 webkit.review.bot 2013-02-13 16:12:06 -0800 Attachment 188208 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp']" exit_code: 1 Source/WebCore/ChangeLog:7: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 832470 4 188209 dgrogan 2013-02-13 16:13:15 -0800 Created attachment 188209 Patch 832538 5 188209 jsbell 2013-02-13 16:58:43 -0800 Comment on attachment 188209 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188209&action=review lgtm > Source/WebCore/ChangeLog:3 > + IndexedDB: Add a few more uma logging calls Nit: UMA is Google/Chromium-specific terminology, Histogram is the generic WebKit API being used, so I'd refer to it that way. > Source/WebCore/ChangeLog:8 > + A few places where commits could fail weren't being logged. Whoah, how'd we miss these? :( 832599 6 188235 dgrogan 2013-02-13 17:42:54 -0800 Created attachment 188235 Patch 832600 7 dgrogan 2013-02-13 17:43:46 -0800 Tony, could you review this? 833203 8 188235 webkit.review.bot 2013-02-14 10:19:34 -0800 Comment on attachment 188235 Patch Clearing flags on attachment: 188235 Committed r142890: <http://trac.webkit.org/changeset/142890> 833204 9 webkit.review.bot 2013-02-14 10:19:37 -0800 All reviewed patches have been landed. Closing bug. 188208 2013-02-13 16:00:41 -0800 2013-02-13 16:13:14 -0800 Patch bug-109762-20130213155710.patch text/plain 2182 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyODE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDk2ZDRjNzEzZjNlZmU0 NmFiMjZkNjY4ZDlhZTI2NWJhM2MzOWIyOS4uYzNkZDdmMjViZmY2YmQzNDg3Zjc0ZTc2Mjc4OTYw M2IyYWRjYjgzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAyLTEzICBEYXZp ZCBHcm9nYW4gIDxkZ3JvZ2FuQGNocm9taXVtLm9yZz4KKworICAgICAgICBJbmRleGVkREI6IEFk ZCBhIGZldyBtb3JlIHVtYSBsb2dnaW5nIGNhbGxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDk3NjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKwkKKyAgICAgICAgQSBmZXcgcGxhY2VzIHdoZXJlIGNvbW1pdHMgY291bGQg ZmFpbCB3ZXJlbid0IGJlaW5nIGxvZ2dlZC4KKworICAgICAgICAqIE1vZHVsZXMvaW5kZXhlZGRi L0lEQkJhY2tpbmdTdG9yZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJREJCYWNraW5nU3RvcmU6 OmRlbGV0ZURhdGFiYXNlKToKKyAgICAgICAgKFdlYkNvcmU6OklEQkJhY2tpbmdTdG9yZTo6VHJh bnNhY3Rpb246OmNvbW1pdCk6CisKIDIwMTMtMDItMTMgIEFiaGlzaGVrIEFyeWEgIDxpbmZlcm5v QGNocm9taXVtLm9yZz4KIAogICAgICAgICBBU1NFUlRJT04gRkFJTEVEOiAhb2JqZWN0IHx8IG9i amVjdC0+aXNCb3goKSwgQmFkIGNhc3QgaW4gUmVuZGVyQm94Ojpjb21wdXRlTG9naWNhbEhlaWdo dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCQmFja2lu Z1N0b3JlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkJhY2tpbmdT dG9yZS5jcHAKaW5kZXggNWEyY2UxNDNmMzgwZGIzODdkMzU0ZTk0NjdiYjcxMzY5MWY4YzIyMy4u MjcwNzZmMWI5ZmM1NTFjYjVmYWY5OTIxZjJkMTNmZDM4MjNmZjkzMiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCQmFja2luZ1N0b3JlLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJCYWNraW5nU3RvcmUuY3BwCkBAIC03 MSw2ICs3MSw4IEBAIGVudW0gSURCQmFja2luZ1N0b3JlRXJyb3JTb3VyY2UgewogICAgIEdldE5l d0RhdGFiYXNlSWQsCiAgICAgR2V0TmV3VmVyc2lvbk51bWJlciwKICAgICBDcmVhdGVJREJEYXRh YmFzZU1ldGFEYXRhLAorICAgIERlbGV0ZURhdGFiYXNlLAorICAgIFRyYW5zYWN0aW9uQ29tbWl0 LAogICAgIElEQkxldmVsREJCYWNraW5nU3RvcmVJbnRlcm5hbEVycm9yTWF4LAogfTsKIApAQCAt NTg3LDcgKzU4OSwxMSBAQCBib29sIElEQkJhY2tpbmdTdG9yZTo6ZGVsZXRlRGF0YWJhc2UoY29u c3QgU3RyaW5nJiBuYW1lKQogICAgIGNvbnN0IFZlY3RvcjxjaGFyPiBrZXkgPSBEYXRhYmFzZU5h bWVLZXk6OmVuY29kZShtX2lkZW50aWZpZXIsIG5hbWUpOwogICAgIHRyYW5zYWN0aW9uLT5yZW1v dmUoa2V5KTsKIAotICAgIHJldHVybiB0cmFuc2FjdGlvbi0+Y29tbWl0KCk7CisgICAgaWYgKCF0 cmFuc2FjdGlvbi0+Y29tbWl0KCkpIHsKKyAgICAgICAgSU5URVJOQUxfV1JJVEVfRVJST1IoRGVs ZXRlRGF0YWJhc2UpOworICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgfQorICAgIHJldHVybiB0 cnVlOwogfQogCiBzdGF0aWMgYm9vbCBjaGVja09iamVjdFN0b3JlQW5kTWV0YURhdGFUeXBlKGNv bnN0IExldmVsREJJdGVyYXRvciogaXQsIGNvbnN0IFZlY3RvcjxjaGFyPiYgc3RvcEtleSwgaW50 NjRfdCBvYmplY3RTdG9yZUlkLCBpbnQ2NF90IG1ldGFEYXRhVHlwZSkKQEAgLTE4NDMsNiArMTg0 OSw4IEBAIGJvb2wgSURCQmFja2luZ1N0b3JlOjpUcmFuc2FjdGlvbjo6Y29tbWl0KCkKICAgICBB U1NFUlQobV90cmFuc2FjdGlvbik7CiAgICAgYm9vbCByZXN1bHQgPSBtX3RyYW5zYWN0aW9uLT5j b21taXQoKTsKICAgICBtX3RyYW5zYWN0aW9uLmNsZWFyKCk7CisgICAgaWYgKCFyZXN1bHQpCisg ICAgICAgIElOVEVSTkFMX1dSSVRFX0VSUk9SKFRyYW5zYWN0aW9uQ29tbWl0KTsKICAgICByZXR1 cm4gcmVzdWx0OwogfQogCg== 188209 2013-02-13 16:13:15 -0800 2013-02-13 17:42:52 -0800 Patch bug-109762-20130213160944.patch text/plain 2181 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyODE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDk2ZDRjNzEzZjNlZmU0 NmFiMjZkNjY4ZDlhZTI2NWJhM2MzOWIyOS4uOGM5ZjU1ZDY3NTdjNTg3ZTdlNzk0MDM5NGE0NWRi NjQ5Yzc3OWRkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAyLTEzICBEYXZp ZCBHcm9nYW4gIDxkZ3JvZ2FuQGNocm9taXVtLm9yZz4KKworICAgICAgICBJbmRleGVkREI6IEFk ZCBhIGZldyBtb3JlIHVtYSBsb2dnaW5nIGNhbGxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDk3NjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBIGZldyBwbGFjZXMgd2hlcmUgY29tbWl0cyBjb3VsZCBm YWlsIHdlcmVuJ3QgYmVpbmcgbG9nZ2VkLgorCisgICAgICAgICogTW9kdWxlcy9pbmRleGVkZGIv SURCQmFja2luZ1N0b3JlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OklEQkJhY2tpbmdTdG9yZTo6 ZGVsZXRlRGF0YWJhc2UpOgorICAgICAgICAoV2ViQ29yZTo6SURCQmFja2luZ1N0b3JlOjpUcmFu c2FjdGlvbjo6Y29tbWl0KToKKwogMjAxMy0wMi0xMyAgQWJoaXNoZWsgQXJ5YSAgPGluZmVybm9A Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIEFTU0VSVElPTiBGQUlMRUQ6ICFvYmplY3QgfHwgb2Jq ZWN0LT5pc0JveCgpLCBCYWQgY2FzdCBpbiBSZW5kZXJCb3g6OmNvbXB1dGVMb2dpY2FsSGVpZ2h0 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJCYWNraW5n U3RvcmUuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCQmFja2luZ1N0 b3JlLmNwcAppbmRleCA1YTJjZTE0M2YzODBkYjM4N2QzNTRlOTQ2N2JiNzEzNjkxZjhjMjIzLi4y NzA3NmYxYjlmYzU1MWNiNWZhZjk5MjFmMmQxM2ZkMzgyM2ZmOTMyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJCYWNraW5nU3RvcmUuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkJhY2tpbmdTdG9yZS5jcHAKQEAgLTcx LDYgKzcxLDggQEAgZW51bSBJREJCYWNraW5nU3RvcmVFcnJvclNvdXJjZSB7CiAgICAgR2V0TmV3 RGF0YWJhc2VJZCwKICAgICBHZXROZXdWZXJzaW9uTnVtYmVyLAogICAgIENyZWF0ZUlEQkRhdGFi YXNlTWV0YURhdGEsCisgICAgRGVsZXRlRGF0YWJhc2UsCisgICAgVHJhbnNhY3Rpb25Db21taXQs CiAgICAgSURCTGV2ZWxEQkJhY2tpbmdTdG9yZUludGVybmFsRXJyb3JNYXgsCiB9OwogCkBAIC01 ODcsNyArNTg5LDExIEBAIGJvb2wgSURCQmFja2luZ1N0b3JlOjpkZWxldGVEYXRhYmFzZShjb25z dCBTdHJpbmcmIG5hbWUpCiAgICAgY29uc3QgVmVjdG9yPGNoYXI+IGtleSA9IERhdGFiYXNlTmFt ZUtleTo6ZW5jb2RlKG1faWRlbnRpZmllciwgbmFtZSk7CiAgICAgdHJhbnNhY3Rpb24tPnJlbW92 ZShrZXkpOwogCi0gICAgcmV0dXJuIHRyYW5zYWN0aW9uLT5jb21taXQoKTsKKyAgICBpZiAoIXRy YW5zYWN0aW9uLT5jb21taXQoKSkgeworICAgICAgICBJTlRFUk5BTF9XUklURV9FUlJPUihEZWxl dGVEYXRhYmFzZSk7CisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9CisgICAgcmV0dXJuIHRy dWU7CiB9CiAKIHN0YXRpYyBib29sIGNoZWNrT2JqZWN0U3RvcmVBbmRNZXRhRGF0YVR5cGUoY29u c3QgTGV2ZWxEQkl0ZXJhdG9yKiBpdCwgY29uc3QgVmVjdG9yPGNoYXI+JiBzdG9wS2V5LCBpbnQ2 NF90IG9iamVjdFN0b3JlSWQsIGludDY0X3QgbWV0YURhdGFUeXBlKQpAQCAtMTg0Myw2ICsxODQ5 LDggQEAgYm9vbCBJREJCYWNraW5nU3RvcmU6OlRyYW5zYWN0aW9uOjpjb21taXQoKQogICAgIEFT U0VSVChtX3RyYW5zYWN0aW9uKTsKICAgICBib29sIHJlc3VsdCA9IG1fdHJhbnNhY3Rpb24tPmNv bW1pdCgpOwogICAgIG1fdHJhbnNhY3Rpb24uY2xlYXIoKTsKKyAgICBpZiAoIXJlc3VsdCkKKyAg ICAgICAgSU5URVJOQUxfV1JJVEVfRVJST1IoVHJhbnNhY3Rpb25Db21taXQpOwogICAgIHJldHVy biByZXN1bHQ7CiB9CiAK 188235 2013-02-13 17:42:54 -0800 2013-02-14 10:19:33 -0800 Patch bug-109762-20130213173923.patch text/plain 2179 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyODE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDk2ZDRjNzEzZjNlZmU0 NmFiMjZkNjY4ZDlhZTI2NWJhM2MzOWIyOS4uMjU5MzkxNWFjMmRiMjAxMmZlZTk0M2EzZTkzNTY4 M2MyZmI2MDk4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAyLTEzICBEYXZp ZCBHcm9nYW4gIDxkZ3JvZ2FuQGNocm9taXVtLm9yZz4KKworICAgICAgICBJbmRleGVkREI6IEFk ZCBhIGZldyBtb3JlIGhpc3RvZ3JhbSBjYWxscworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5NzYyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQSBmZXcgcGxhY2VzIHdoZXJlIGNvbW1pdHMgY291bGQgZmFp bCB3ZXJlbid0IGJlaW5nIGxvZ2dlZC4KKworICAgICAgICAqIE1vZHVsZXMvaW5kZXhlZGRiL0lE QkJhY2tpbmdTdG9yZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJREJCYWNraW5nU3RvcmU6OmRl bGV0ZURhdGFiYXNlKToKKyAgICAgICAgKFdlYkNvcmU6OklEQkJhY2tpbmdTdG9yZTo6VHJhbnNh Y3Rpb246OmNvbW1pdCk6CisKIDIwMTMtMDItMTMgIEFiaGlzaGVrIEFyeWEgIDxpbmZlcm5vQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBBU1NFUlRJT04gRkFJTEVEOiAhb2JqZWN0IHx8IG9iamVj dC0+aXNCb3goKSwgQmFkIGNhc3QgaW4gUmVuZGVyQm94Ojpjb21wdXRlTG9naWNhbEhlaWdodApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCQmFja2luZ1N0 b3JlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkJhY2tpbmdTdG9y ZS5jcHAKaW5kZXggNWEyY2UxNDNmMzgwZGIzODdkMzU0ZTk0NjdiYjcxMzY5MWY4YzIyMy4uMjcw NzZmMWI5ZmM1NTFjYjVmYWY5OTIxZjJkMTNmZDM4MjNmZjkzMiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCQmFja2luZ1N0b3JlLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJCYWNraW5nU3RvcmUuY3BwCkBAIC03MSw2 ICs3MSw4IEBAIGVudW0gSURCQmFja2luZ1N0b3JlRXJyb3JTb3VyY2UgewogICAgIEdldE5ld0Rh dGFiYXNlSWQsCiAgICAgR2V0TmV3VmVyc2lvbk51bWJlciwKICAgICBDcmVhdGVJREJEYXRhYmFz ZU1ldGFEYXRhLAorICAgIERlbGV0ZURhdGFiYXNlLAorICAgIFRyYW5zYWN0aW9uQ29tbWl0LAog ICAgIElEQkxldmVsREJCYWNraW5nU3RvcmVJbnRlcm5hbEVycm9yTWF4LAogfTsKIApAQCAtNTg3 LDcgKzU4OSwxMSBAQCBib29sIElEQkJhY2tpbmdTdG9yZTo6ZGVsZXRlRGF0YWJhc2UoY29uc3Qg U3RyaW5nJiBuYW1lKQogICAgIGNvbnN0IFZlY3RvcjxjaGFyPiBrZXkgPSBEYXRhYmFzZU5hbWVL ZXk6OmVuY29kZShtX2lkZW50aWZpZXIsIG5hbWUpOwogICAgIHRyYW5zYWN0aW9uLT5yZW1vdmUo a2V5KTsKIAotICAgIHJldHVybiB0cmFuc2FjdGlvbi0+Y29tbWl0KCk7CisgICAgaWYgKCF0cmFu c2FjdGlvbi0+Y29tbWl0KCkpIHsKKyAgICAgICAgSU5URVJOQUxfV1JJVEVfRVJST1IoRGVsZXRl RGF0YWJhc2UpOworICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgfQorICAgIHJldHVybiB0cnVl OwogfQogCiBzdGF0aWMgYm9vbCBjaGVja09iamVjdFN0b3JlQW5kTWV0YURhdGFUeXBlKGNvbnN0 IExldmVsREJJdGVyYXRvciogaXQsIGNvbnN0IFZlY3RvcjxjaGFyPiYgc3RvcEtleSwgaW50NjRf dCBvYmplY3RTdG9yZUlkLCBpbnQ2NF90IG1ldGFEYXRhVHlwZSkKQEAgLTE4NDMsNiArMTg0OSw4 IEBAIGJvb2wgSURCQmFja2luZ1N0b3JlOjpUcmFuc2FjdGlvbjo6Y29tbWl0KCkKICAgICBBU1NF UlQobV90cmFuc2FjdGlvbik7CiAgICAgYm9vbCByZXN1bHQgPSBtX3RyYW5zYWN0aW9uLT5jb21t aXQoKTsKICAgICBtX3RyYW5zYWN0aW9uLmNsZWFyKCk7CisgICAgaWYgKCFyZXN1bHQpCisgICAg ICAgIElOVEVSTkFMX1dSSVRFX0VSUk9SKFRyYW5zYWN0aW9uQ29tbWl0KTsKICAgICByZXR1cm4g cmVzdWx0OwogfQogCg==