109756 2013-02-13 15:16:19 -0800 Remove Element::getAttributeItem() overload that returned a mutable Attribute*. 2013-02-13 17:14:10 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 109505 1 kling kling cmarcelo d-r fmalita kling mifenton ojan.autocc pdr schenney tkent webkit.review.bot oldest_to_newest 832404 0 kling 2013-02-13 15:16:19 -0800 It's a bit goofy to have an Element::getAttributeItem() that converts m_elementData to UniqueElementData. This happens unintentionally in a few places where callers simply want to read an attribute value but are calling through an Element*. 832406 1 188195 kling 2013-02-13 15:18:24 -0800 Created attachment 188195 Patch 832488 2 188195 koivisto 2013-02-13 16:24:21 -0800 Comment on attachment 188195 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188195&action=review > Source/WebCore/dom/Element.h:287 > const Attribute* getAttributeItem(const QualifiedName&) const; Some day these should get WebKit style names. 832566 3 kling 2013-02-13 17:14:10 -0800 Committed r142827: <http://trac.webkit.org/changeset/142827> 188195 2013-02-13 15:18:24 -0800 2013-02-13 16:24:21 -0800 Patch bug-109756.diff text/plain 5223 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2NTI1MjYwLi5hNDE0MzQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjkg QEAKIDIwMTMtMDItMTMgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCisgICAg ICAgIFJlbW92ZSBFbGVtZW50OjpnZXRBdHRyaWJ1dGVJdGVtKCkgb3ZlcmxvYWQgdGhhdCByZXR1 cm5lZCBhIG11dGFibGUgQXR0cmlidXRlKi4KKyAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2Iv MTA5NzU2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFJlbW92ZSB0aGlzIHRvIHByZXZlbnQgY2FsbGVycyBmcm9tIGFjY2lkZW50YWxseSBjYXVzaW5n IGVsZW1lbnRzIHRvIGNvbnZlcnQgdG8gVW5pcXVlRWxlbWVudERhdGEuCisgICAgICAgIFRoZXJl IGFyZSB0d28gY2FsbCBzaXRlcyAoQXR0ciBhbmQgSFRNTFNlbGVjdEVsZW1lbnQpIHRoYXQgbGVn aXRpbWF0ZWx5IG5lZWQgdG8gbXV0YXRlIEF0dHJpYnV0ZQorICAgICAgICBvYmplY3RzIGluLXBs YWNlLCB0aGV5IG5vdyB1c2UgRWxlbWVudDo6ZW5zdXJlVW5pcXVlRWxlbWVudERhdGEoKS0+Z2V0 QXR0cmlidXRlSXRlbSgpIGRpcmVjdGx5IGluc3RlYWQuCisKKyAgICAgICAgU21hbGwgcHJvZ3Jl c3Npb24gb24gTWVtYnVzdGVyMywgbW9zdGx5IGZvciBwZWFjZSBvZiBtaW5kLgorCisgICAgICAg ICogZG9tL0F0dHIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXR0cjo6ZWxlbWVudEF0dHJpYnV0 ZSk6CisgICAgICAgICogZG9tL0VsZW1lbnQuaDoKKyAgICAgICAgKEVsZW1lbnQpOgorICAgICAg ICAqIGh0bWwvSFRNTElucHV0RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MSW5w dXRFbGVtZW50Ojp1cGRhdGVUeXBlKToKKyAgICAgICAgKiBodG1sL0hUTUxTZWxlY3RFbGVtZW50 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxTZWxlY3RFbGVtZW50OjpwYXJzZUF0dHJpYnV0 ZSk6CisgICAgICAgICogc3ZnL1NWR1N0eWxlZEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6U1ZHU3R5bGVkRWxlbWVudDo6Z2V0UHJlc2VudGF0aW9uQXR0cmlidXRlKToKKworMjAxMy0w Mi0xMyAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CisKICAgICAgICAgU3Ryb25n ZXIgRWxlbWVudERhdGEgcG9pbnRlciB0eXBpbmcuCiAgICAgICAgIDxodHRwOi8vd2Via2l0Lm9y Zy9iLzEwOTc1Mj4KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0F0dHIuY3BwIGIv U291cmNlL1dlYkNvcmUvZG9tL0F0dHIuY3BwCmluZGV4IGIxMzAxYmEuLjZlMWE4YWMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9BdHRyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9k b20vQXR0ci5jcHAKQEAgLTIxMSw3ICsyMTEsNyBAQCBBdHRyaWJ1dGUmIEF0dHI6OmVsZW1lbnRB dHRyaWJ1dGUoKQogewogICAgIEFTU0VSVChtX2VsZW1lbnQpOwogICAgIEFTU0VSVChtX2VsZW1l bnQtPmVsZW1lbnREYXRhKCkpOwotICAgIHJldHVybiAqbV9lbGVtZW50LT5nZXRBdHRyaWJ1dGVJ dGVtKHF1YWxpZmllZE5hbWUoKSk7CisgICAgcmV0dXJuICptX2VsZW1lbnQtPmVuc3VyZVVuaXF1 ZUVsZW1lbnREYXRhKCktPmdldEF0dHJpYnV0ZUl0ZW0ocXVhbGlmaWVkTmFtZSgpKTsKIH0KIAog dm9pZCBBdHRyOjpkZXRhY2hGcm9tRWxlbWVudFdpdGhWYWx1ZShjb25zdCBBdG9taWNTdHJpbmcm IHZhbHVlKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaCBiL1NvdXJj ZS9XZWJDb3JlL2RvbS9FbGVtZW50LmgKaW5kZXggMmZhNDMwYS4uNGYxNDMyZSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20v RWxlbWVudC5oCkBAIC0yODUsNyArMjg1LDYgQEAgcHVibGljOgogICAgIHNpemVfdCBhdHRyaWJ1 dGVDb3VudCgpIGNvbnN0OwogICAgIGNvbnN0IEF0dHJpYnV0ZSogYXR0cmlidXRlSXRlbSh1bnNp Z25lZCBpbmRleCkgY29uc3Q7CiAgICAgY29uc3QgQXR0cmlidXRlKiBnZXRBdHRyaWJ1dGVJdGVt KGNvbnN0IFF1YWxpZmllZE5hbWUmKSBjb25zdDsKLSAgICBBdHRyaWJ1dGUqIGdldEF0dHJpYnV0 ZUl0ZW0oY29uc3QgUXVhbGlmaWVkTmFtZSYpOwogICAgIHNpemVfdCBnZXRBdHRyaWJ1dGVJdGVt SW5kZXgoY29uc3QgUXVhbGlmaWVkTmFtZSYgbmFtZSkgY29uc3QgeyByZXR1cm4gZWxlbWVudERh dGEoKS0+Z2V0QXR0cmlidXRlSXRlbUluZGV4KG5hbWUpOyB9CiAgICAgc2l6ZV90IGdldEF0dHJp YnV0ZUl0ZW1JbmRleChjb25zdCBBdG9taWNTdHJpbmcmIG5hbWUsIGJvb2wgc2hvdWxkSWdub3Jl QXR0cmlidXRlQ2FzZSkgY29uc3QgeyByZXR1cm4gZWxlbWVudERhdGEoKS0+Z2V0QXR0cmlidXRl SXRlbUluZGV4KG5hbWUsIHNob3VsZElnbm9yZUF0dHJpYnV0ZUNhc2UpOyB9CiAKQEAgLTkwNCwx MiArOTAzLDYgQEAgaW5saW5lIGNvbnN0IEF0dHJpYnV0ZSogRWxlbWVudDo6Z2V0QXR0cmlidXRl SXRlbShjb25zdCBRdWFsaWZpZWROYW1lJiBuYW1lKSBjb24KICAgICByZXR1cm4gZWxlbWVudERh dGEoKS0+Z2V0QXR0cmlidXRlSXRlbShuYW1lKTsKIH0KIAotaW5saW5lIEF0dHJpYnV0ZSogRWxl bWVudDo6Z2V0QXR0cmlidXRlSXRlbShjb25zdCBRdWFsaWZpZWROYW1lJiBuYW1lKQotewotICAg IEFTU0VSVChlbGVtZW50RGF0YSgpKTsKLSAgICByZXR1cm4gZW5zdXJlVW5pcXVlRWxlbWVudERh dGEoKS0+Z2V0QXR0cmlidXRlSXRlbShuYW1lKTsKLX0KLQogaW5saW5lIHZvaWQgRWxlbWVudDo6 dXBkYXRlSW52YWxpZEF0dHJpYnV0ZXMoKSBjb25zdAogewogICAgIGlmICghZWxlbWVudERhdGEo KSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCmluZGV4IDFhOTdiZjYu LjEyZjQ2MDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVu dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcApAQCAt NTE2LDExICs1MTYsMTEgQEAgdm9pZCBIVE1MSW5wdXRFbGVtZW50Ojp1cGRhdGVUeXBlKCkKIAog ICAgIGlmIChkaWRSZXNwZWN0SGVpZ2h0QW5kV2lkdGggIT0gbV9pbnB1dFR5cGUtPnNob3VsZFJl c3BlY3RIZWlnaHRBbmRXaWR0aEF0dHJpYnV0ZXMoKSkgewogICAgICAgICBBU1NFUlQoZWxlbWVu dERhdGEoKSk7Ci0gICAgICAgIGlmIChBdHRyaWJ1dGUqIGhlaWdodCA9IGdldEF0dHJpYnV0ZUl0 ZW0oaGVpZ2h0QXR0cikpCisgICAgICAgIGlmIChjb25zdCBBdHRyaWJ1dGUqIGhlaWdodCA9IGdl dEF0dHJpYnV0ZUl0ZW0oaGVpZ2h0QXR0cikpCiAgICAgICAgICAgICBhdHRyaWJ1dGVDaGFuZ2Vk KGhlaWdodEF0dHIsIGhlaWdodC0+dmFsdWUoKSk7Ci0gICAgICAgIGlmIChBdHRyaWJ1dGUqIHdp ZHRoID0gZ2V0QXR0cmlidXRlSXRlbSh3aWR0aEF0dHIpKQorICAgICAgICBpZiAoY29uc3QgQXR0 cmlidXRlKiB3aWR0aCA9IGdldEF0dHJpYnV0ZUl0ZW0od2lkdGhBdHRyKSkKICAgICAgICAgICAg IGF0dHJpYnV0ZUNoYW5nZWQod2lkdGhBdHRyLCB3aWR0aC0+dmFsdWUoKSk7Ci0gICAgICAgIGlm IChBdHRyaWJ1dGUqIGFsaWduID0gZ2V0QXR0cmlidXRlSXRlbShhbGlnbkF0dHIpKQorICAgICAg ICBpZiAoY29uc3QgQXR0cmlidXRlKiBhbGlnbiA9IGdldEF0dHJpYnV0ZUl0ZW0oYWxpZ25BdHRy KSkKICAgICAgICAgICAgIGF0dHJpYnV0ZUNoYW5nZWQoYWxpZ25BdHRyLCBhbGlnbi0+dmFsdWUo KSk7CiAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RF bGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQuY3BwCmlu ZGV4IGY5N2VjODMuLjQ3ODdmM2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TFNlbGVjdEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNlbGVjdEVs ZW1lbnQuY3BwCkBAIC0yOTEsNyArMjkxLDcgQEAgdm9pZCBIVE1MU2VsZWN0RWxlbWVudDo6cGFy c2VBdHRyaWJ1dGUoY29uc3QgUXVhbGlmaWVkTmFtZSYgbmFtZSwgY29uc3QgQXRvbWljU3QKICAg ICAgICAgU3RyaW5nIGF0dHJTaXplID0gU3RyaW5nOjpudW1iZXIoc2l6ZSk7CiAgICAgICAgIGlm IChhdHRyU2l6ZSAhPSB2YWx1ZSkgewogICAgICAgICAgICAgLy8gRklYTUU6IFRoaXMgaXMgaG9y cmlibHkgZmFjdG9yZWQuCi0gICAgICAgICAgICBpZiAoQXR0cmlidXRlKiBzaXplQXR0cmlidXRl ID0gZ2V0QXR0cmlidXRlSXRlbShzaXplQXR0cikpCisgICAgICAgICAgICBpZiAoQXR0cmlidXRl KiBzaXplQXR0cmlidXRlID0gZW5zdXJlVW5pcXVlRWxlbWVudERhdGEoKS0+Z2V0QXR0cmlidXRl SXRlbShzaXplQXR0cikpCiAgICAgICAgICAgICAgICAgc2l6ZUF0dHJpYnV0ZS0+c2V0VmFsdWUo YXR0clNpemUpOwogICAgICAgICB9CiAgICAgICAgIHNpemUgPSBtYXgoc2l6ZSwgMSk7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHU3R5bGVkRWxlbWVudC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9zdmcvU1ZHU3R5bGVkRWxlbWVudC5jcHAKaW5kZXggYmVlNGVmMS4uYjkxZjU2YSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1N0eWxlZEVsZW1lbnQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdTdHlsZWRFbGVtZW50LmNwcApAQCAtNDAwLDcgKzQwMCw3 IEBAIFBhc3NSZWZQdHI8Q1NTVmFsdWU+IFNWR1N0eWxlZEVsZW1lbnQ6OmdldFByZXNlbnRhdGlv bkF0dHJpYnV0ZShjb25zdCBTdHJpbmcmIG5hCiAgICAgICAgIHJldHVybiAwOwogCiAgICAgUXVh bGlmaWVkTmFtZSBhdHRyaWJ1dGVOYW1lKG51bGxBdG9tLCBuYW1lLCBudWxsQXRvbSk7Ci0gICAg QXR0cmlidXRlKiBhdHRyID0gZ2V0QXR0cmlidXRlSXRlbShhdHRyaWJ1dGVOYW1lKTsKKyAgICBj b25zdCBBdHRyaWJ1dGUqIGF0dHIgPSBnZXRBdHRyaWJ1dGVJdGVtKGF0dHJpYnV0ZU5hbWUpOwog ICAgIGlmICghYXR0cikKICAgICAgICAgcmV0dXJuIDA7CiAK