109742 2013-02-13 13:21:47 -0800 CSSPreloadScanner should not depend on HTMLToken 2013-02-13 14:42:12 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 106127 1 abarth abarth eric ojan.autocc tonyg webkit.review.bot oldest_to_newest 832256 0 abarth 2013-02-13 13:21:47 -0800 CSSPreloadScanner should not depend on HTMLToken 832258 1 188162 abarth 2013-02-13 13:23:02 -0800 Created attachment 188162 Patch 832270 2 188162 eric 2013-02-13 13:27:48 -0800 Comment on attachment 188162 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188162&action=review > Source/WebCore/html/parser/CSSPreloadScanner.cpp:61 > +void CSSPreloadScanner::scan(const LChar* begin, const LChar* end, Vector<OwnPtr<PreloadRequest> >& requests) This is just a template. :) > Source/WebCore/html/parser/CSSPreloadScanner.h:44 > + void scan(const LChar* begin, const LChar* end, Vector<OwnPtr<PreloadRequest> >&); This isn't currently used, or? 832271 3 abarth 2013-02-13 13:28:35 -0800 (In reply to comment #2) > (From update of attachment 188162 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=188162&action=review > > > Source/WebCore/html/parser/CSSPreloadScanner.cpp:61 > > +void CSSPreloadScanner::scan(const LChar* begin, const LChar* end, Vector<OwnPtr<PreloadRequest> >& requests) > > This is just a template. :) Yes. ;) > > Source/WebCore/html/parser/CSSPreloadScanner.h:44 > > + void scan(const LChar* begin, const LChar* end, Vector<OwnPtr<PreloadRequest> >&); > > This isn't currently used, or? Current unused. I can add it later when we need it if you like. 832368 4 188162 webkit.review.bot 2013-02-13 14:42:08 -0800 Comment on attachment 188162 Patch Clearing flags on attachment: 188162 Committed r142803: <http://trac.webkit.org/changeset/142803> 832369 5 webkit.review.bot 2013-02-13 14:42:12 -0800 All reviewed patches have been landed. Closing bug. 188162 2013-02-13 13:23:02 -0800 2013-02-13 14:42:08 -0800 Patch bug-109742-20130213131930.patch text/plain 4879 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyNzc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDQxOTVmYzNmMmQzMTkz OGY2ZjdhNjQ1OWI4NzMwNGRkODg4Y2IwYi4uMWI4OGYwNzBiZDhiNDgwZjQ3NjQ0OTFiNzRkOGU5 NzMyNzM4M2YzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDEzLTAyLTEzICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKKyAgICAgICAgQ1NTUHJlbG9hZFNjYW5uZXIg c2hvdWxkIG5vdCBkZXBlbmQgb24gSFRNTFRva2VuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDk3NDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSdzIG5vIG5lZWQgZm9yIHRoZSBDU1NQcmVsb2Fk U2Nhbm5lciB0byBkZXBlbmQgb24gSFRNTFRva2VuLiBPbgorICAgICAgICB0aGUgYmFja2dyb3Vu ZCB0aHJlYWQsIHdlJ2xsIGxpa2VseSB3YW50IHRvIHVzZSBhIENvbXBhY3RIVE1MVG9rZW4gZm9y CisgICAgICAgIHByZWxvYWQgc2Nhbm5pbmcsIHNvIHRoaXMgZGVwZW5kZW5jeSBpcyBwcm9ibGVt YXRpYy4gVGhpcyBwYXRjaCBhbHNvCisgICAgICAgIHRlYWNoZXMgdGhlIENTU1ByZWxvYWRTY2Fu bmVyIGhvdyB0byBzY2FuIExDaGFycy4KKworICAgICAgICAqIGh0bWwvcGFyc2VyL0NTU1ByZWxv YWRTY2FubmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1ByZWxvYWRTY2FubmVyOjp+Q1NT UHJlbG9hZFNjYW5uZXIpOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpD U1NQcmVsb2FkU2Nhbm5lcjo6c2Nhbik6CisgICAgICAgICogaHRtbC9wYXJzZXIvQ1NTUHJlbG9h ZFNjYW5uZXIuaDoKKyAgICAgICAgKENTU1ByZWxvYWRTY2FubmVyKToKKyAgICAgICAgKiBodG1s L3BhcnNlci9IVE1MUHJlbG9hZFNjYW5uZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFBy ZWxvYWRTY2FubmVyOjpwcm9jZXNzVG9rZW4pOgorCisyMDEzLTAyLTEzICBBZGFtIEJhcnRoICA8 YWJhcnRoQHdlYmtpdC5vcmc+CisKICAgICAgICAgQ2xlYW4gdXAgc29tZSBzdHlsZSBuaXRzIGlu IEhUTUxQcmVsb2FkU2Nhbm5lcgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTA5NzM4CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFy c2VyL0NTU1ByZWxvYWRTY2FubmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0NT U1ByZWxvYWRTY2FubmVyLmNwcAppbmRleCAzYmZlODE2OGIxOGFjMTc5ZDcyYmNhODhlZDg5YjE3 ZTM5OGRkMzg5Li45NTc3MDc5MzY3ZTVkNGI4MjdhODRiYWI3MzZiZTk2ZWM5YzcwNzg0IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9DU1NQcmVsb2FkU2Nhbm5lci5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvQ1NTUHJlbG9hZFNjYW5uZXIuY3BwCkBA IC0yOCwxNCArMjgsOCBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkNTU1ByZWxv YWRTY2FubmVyLmgiCiAKLSNpbmNsdWRlICJDYWNoZWRDU1NTdHlsZVNoZWV0LmgiCi0jaW5jbHVk ZSAiQ2FjaGVkUmVzb3VyY2VMb2FkZXIuaCIKLSNpbmNsdWRlICJDYWNoZWRSZXNvdXJjZVJlcXVl c3QuaCIKICNpbmNsdWRlICJDYWNoZWRSZXNvdXJjZVJlcXVlc3RJbml0aWF0b3JzLmgiCiAjaW5j bHVkZSAiSFRNTFBhcnNlcklkaW9tcy5oIgotI2luY2x1ZGUgIkhUTUxUb2tlbi5oIgotI2luY2x1 ZGUgPHd0Zi9GdW5jdGlvbmFsLmg+Ci0jaW5jbHVkZSA8d3RmL01haW5UaHJlYWQuaD4KIAogbmFt ZXNwYWNlIFdlYkNvcmUgewogCkBAIC00NSw2ICszOSwxMCBAQCBDU1NQcmVsb2FkU2Nhbm5lcjo6 Q1NTUHJlbG9hZFNjYW5uZXIoKQogewogfQogCitDU1NQcmVsb2FkU2Nhbm5lcjo6fkNTU1ByZWxv YWRTY2FubmVyKCkKK3sKK30KKwogdm9pZCBDU1NQcmVsb2FkU2Nhbm5lcjo6cmVzZXQoKQogewog ICAgIG1fc3RhdGUgPSBJbml0aWFsOwpAQCAtNTIsMTIgKzUwLDE5IEBAIHZvaWQgQ1NTUHJlbG9h ZFNjYW5uZXI6OnJlc2V0KCkKICAgICBtX3J1bGVWYWx1ZS5jbGVhcigpOwogfQogCi12b2lkIENT U1ByZWxvYWRTY2FubmVyOjpzY2FuKGNvbnN0IEhUTUxUb2tlbiYgdG9rZW4sIFZlY3RvcjxPd25Q dHI8UHJlbG9hZFJlcXVlc3Q+ID4mIHJlcXVlc3RzKQordm9pZCBDU1NQcmVsb2FkU2Nhbm5lcjo6 c2Nhbihjb25zdCBVQ2hhciogYmVnaW4sIGNvbnN0IFVDaGFyKiBlbmQsIFZlY3RvcjxPd25QdHI8 UHJlbG9hZFJlcXVlc3Q+ID4mIHJlcXVlc3RzKQoreworICAgIG1fcmVxdWVzdHMgPSAmcmVxdWVz dHM7CisgICAgZm9yIChjb25zdCBVQ2hhciogaXQgPSBiZWdpbjsgaXQgIT0gZW5kICYmIG1fc3Rh dGUgIT0gRG9uZVBhcnNpbmdJbXBvcnRSdWxlczsgKytpdCkKKyAgICAgICAgdG9rZW5pemUoKml0 KTsKKyAgICBtX3JlcXVlc3RzID0gMDsKK30KKwordm9pZCBDU1NQcmVsb2FkU2Nhbm5lcjo6c2Nh bihjb25zdCBMQ2hhciogYmVnaW4sIGNvbnN0IExDaGFyKiBlbmQsIFZlY3RvcjxPd25QdHI8UHJl bG9hZFJlcXVlc3Q+ID4mIHJlcXVlc3RzKQogewogICAgIG1fcmVxdWVzdHMgPSAmcmVxdWVzdHM7 Ci0gICAgY29uc3QgSFRNTFRva2VuOjpEYXRhVmVjdG9yJiBjaGFyYWN0ZXJzID0gdG9rZW4uY2hh cmFjdGVycygpOwotICAgIGZvciAoSFRNTFRva2VuOjpEYXRhVmVjdG9yOjpjb25zdF9pdGVyYXRv ciBpdGVyID0gY2hhcmFjdGVycy5iZWdpbigpOyBpdGVyICE9IGNoYXJhY3RlcnMuZW5kKCkgJiYg bV9zdGF0ZSAhPSBEb25lUGFyc2luZ0ltcG9ydFJ1bGVzOyArK2l0ZXIpCi0gICAgICAgIHRva2Vu aXplKCppdGVyKTsKKyAgICBmb3IgKGNvbnN0IExDaGFyKiBpdCA9IGJlZ2luOyBpdCAhPSBlbmQg JiYgbV9zdGF0ZSAhPSBEb25lUGFyc2luZ0ltcG9ydFJ1bGVzOyArK2l0KQorICAgICAgICB0b2tl bml6ZSgqaXQpOwogICAgIG1fcmVxdWVzdHMgPSAwOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9odG1sL3BhcnNlci9DU1NQcmVsb2FkU2Nhbm5lci5oIGIvU291cmNlL1dlYkNvcmUv aHRtbC9wYXJzZXIvQ1NTUHJlbG9hZFNjYW5uZXIuaAppbmRleCBmZjk0OTZmYTU3ZjE5YWI1Njc5 ZjViNTU3MjJkZTJmOTgzYjM0NzIxLi4yMmY2ZmE4NjljYTUyNDUyODgxYjZhODgxYmQ1MWU2N2U3 NmZlYjRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9DU1NQcmVsb2Fk U2Nhbm5lci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0NTU1ByZWxvYWRTY2Fu bmVyLmgKQEAgLTI4LDIwICsyOCwyMCBAQAogI2RlZmluZSBDU1NQcmVsb2FkU2Nhbm5lcl9oCiAK ICNpbmNsdWRlICJIVE1MUmVzb3VyY2VQcmVsb2FkZXIuaCIKLSNpbmNsdWRlIDx3dGYvV2Vha1B0 ci5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1N0cmluZ0J1aWxkZXIuaD4KIAogbmFtZXNwYWNlIFdl YkNvcmUgewogCi1jbGFzcyBIVE1MVG9rZW47Ci0KIGNsYXNzIENTU1ByZWxvYWRTY2FubmVyIHsK ICAgICBXVEZfTUFLRV9OT05DT1BZQUJMRShDU1NQcmVsb2FkU2Nhbm5lcik7CiBwdWJsaWM6Ci0g ICAgZXhwbGljaXQgQ1NTUHJlbG9hZFNjYW5uZXIoKTsKKyAgICBDU1NQcmVsb2FkU2Nhbm5lcigp OworICAgIH5DU1NQcmVsb2FkU2Nhbm5lcigpOwogCiAgICAgdm9pZCByZXNldCgpOwotICAgIHZv aWQgc2Nhbihjb25zdCBIVE1MVG9rZW4mLCBWZWN0b3I8T3duUHRyPFByZWxvYWRSZXF1ZXN0PiA+ JiByZXF1ZXN0cyk7CisKKyAgICB2b2lkIHNjYW4oY29uc3QgVUNoYXIqIGJlZ2luLCBjb25zdCBV Q2hhciogZW5kLCBWZWN0b3I8T3duUHRyPFByZWxvYWRSZXF1ZXN0PiA+Jik7CisgICAgdm9pZCBz Y2FuKGNvbnN0IExDaGFyKiBiZWdpbiwgY29uc3QgTENoYXIqIGVuZCwgVmVjdG9yPE93blB0cjxQ cmVsb2FkUmVxdWVzdD4gPiYpOwogCiBwcml2YXRlOgogICAgIGVudW0gU3RhdGUgewpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFByZWxvYWRTY2FubmVyLmNwcCBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxQcmVsb2FkU2Nhbm5lci5jcHAKaW5kZXgg ZjMwYTViMmRlOTI0NDkzZDM4Mjk2YTE2NTQ3ZTE0ZjlhMzkzOTI3ZS4uYzVhMzEwNGRhN2UwZDk1 NjUyMTAyZmIxNTQ2MjQ0NTkwZDUyNWNkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRt bC9wYXJzZXIvSFRNTFByZWxvYWRTY2FubmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L3BhcnNlci9IVE1MUHJlbG9hZFNjYW5uZXIuY3BwCkBAIC0yODMsNyArMjgzLDggQEAgdm9pZCBI VE1MUHJlbG9hZFNjYW5uZXI6OnByb2Nlc3NUb2tlbihjb25zdCBIVE1MVG9rZW4mIHRva2VuLCBW ZWN0b3I8T3duUHRyPFByZWwKICAgICBpZiAobV9pblN0eWxlKSB7CiAgICAgICAgIGlmICh0b2tl bi50eXBlKCkgIT0gSFRNTFRva2VuOjpDaGFyYWN0ZXIpCiAgICAgICAgICAgICByZXR1cm47Ci0g ICAgICAgIHJldHVybiBtX2Nzc1NjYW5uZXIuc2Nhbih0b2tlbiwgcmVxdWVzdHMpOworICAgICAg ICBjb25zdCBIVE1MVG9rZW46OkRhdGFWZWN0b3ImIGNoYXJhY3RlcnMgPSB0b2tlbi5jaGFyYWN0 ZXJzKCk7CisgICAgICAgIHJldHVybiBtX2Nzc1NjYW5uZXIuc2NhbihjaGFyYWN0ZXJzLmJlZ2lu KCksIGNoYXJhY3RlcnMuZW5kKCksIHJlcXVlc3RzKTsKICAgICB9CiAgICAgaWYgKCFpc1N0YXJ0 T3JFbmRUYWcodG9rZW4pKQogICAgICAgICByZXR1cm47Cg==