109740 2013-02-13 13:07:34 -0800 Fix debug assertion being triggered 2013-02-13 15:45:42 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 shawnsingh shawnsingh eric jamesr ojan.autocc simon.fraser webkit.review.bot oldest_to_newest 832239 0 shawnsingh 2013-02-13 13:07:34 -0800 A debug assertion in RenderLayer.h is being hit when trying to access the normalFlowList when it is dirty. Most likely this is caused by a new recursion that I added in , but I overlooked the need to call updateLayerListsIfNeeded() recursively as well. Patch coming in a moment. I'll ask for review later, after having a chance to verify that it stops triggering the assertion. 832268 1 188166 shawnsingh 2013-02-13 13:26:34 -0800 Created attachment 188166 Patch 832298 2 simon.fraser 2013-02-13 13:45:41 -0800 I see an assertion about dirty z-order lists in a hit testing code path when bringing up the inspector too. Probably unrelated, but would be nice to fix. 832395 3 188166 shawnsingh 2013-02-13 15:06:06 -0800 Comment on attachment 188166 Patch Didn't reproduce any debug assertion on chromium's inspector. I'm building debug webkit now to try there - is there something specific that has to be done to reproduce the assertion? 832431 4 188166 webkit.review.bot 2013-02-13 15:45:39 -0800 Comment on attachment 188166 Patch Clearing flags on attachment: 188166 Committed r142815: <http://trac.webkit.org/changeset/142815> 832432 5 webkit.review.bot 2013-02-13 15:45:42 -0800 All reviewed patches have been landed. Closing bug. 188166 2013-02-13 13:26:34 -0800 2013-02-13 15:45:39 -0800 Patch bug-109740-20130213132303.patch text/plain 2636 shawnsingh U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyNzYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2NmZWRhMDMyNjE2OWEz ODg2NGZmZWE5MTIyOWY0ODhmYTZmZThiZC4uMzM3N2I5MmY4MWE5YTZkODJiMGQ2YjViYTg3M2Rl OTg0MzY3MDYyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAyLTEzICBTaGF3 biBTaW5naCAgPHNoYXduc2luZ2hAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZpeCBkZWJ1ZyBh c3NlcnRpb24gYmVpbmcgdHJpZ2dlcmVkIGJlY2F1c2Ugd2UgbWF5IGFjY2VzcyBkaXJ0eSBub3Jt YWxGbG93TGlzdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwOTc0MAorCisgICAgICAgIEEgZGVidWcgYXNzZXJ0aW9uIGluIFJlbmRlckxheWVyLmgg aXMgYmVpbmcgaGl0IHdoZW4gdHJ5aW5nIHRvCisgICAgICAgIGFjY2VzcyB0aGUgbm9ybWFsRmxv d0xpc3Qgd2hlbiBpdCBpcyBkaXJ0eS4gIFRoaXMgaXMgY2F1c2VkIGJ5IGEKKyAgICAgICAgbmV3 IHJlY3Vyc2lvbiB0aGF0IEkgYWRkZWQgaW4gUmVuZGVyTGF5ZXJCYWNraW5nOjpoYXNWaXNpYmxl Tm9uQ29tcG9zaXRpbmdEZXNjZW5kYW50KCksCisgICAgICAgIGJ1dCBJIG92ZXJsb29rZWQgdGhl IG5lZWQgdG8gY2FsbCB1cGRhdGVMYXllckxpc3RzSWZOZWVkZWQoKQorICAgICAgICByZWN1cnNp dmVseSBhcyB3ZWxsLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE5vIHRlc3QsIGJlY2F1c2UgdGhlcmUncyBubyByZWxpYWJsZSB3YXkgdG8gdGVzdCB0 aGlzIChzYW1lIGFzIGJ1ZyA4NTUxMikuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5 ZXJCYWNraW5nLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Omhhc1Zpc2libGVOb25Db21wb3NpdGlu Z0Rlc2NlbmRhbnQpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJCYWNraW5nOjpoYXNW aXNpYmxlTm9uQ29tcG9zaXRpbmdEZXNjZW5kYW50TGF5ZXJzKToKKwogMjAxMy0wMi0xMyAgTWFy dGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gUmVt b3ZlIHJlbWFpbmluZyBkZWFkIGNvZGUgZnJvbSB0aGUgR0xpYiB1bmljb2RlIGJhY2tlbmQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3Bw IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAKaW5kZXgg N2ExMjYwYzM1ZjVmNWE3YTg4Y2FjMTZkOWVlZmZjMTZjZWRjYzMzMi4uNDgxNGZkM2Q3Nzk3MTNh YWRlZTljMjJmYjdlYzhjZTA0YjM2MjNmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAKQEAgLTE0MzEsNiArMTQzMSwxMyBAQCBib29sIFJl bmRlckxheWVyQmFja2luZzo6aXNTaW1wbGVDb250YWluZXJDb21wb3NpdGluZ0xheWVyKCkgY29u c3QKIAogc3RhdGljIGJvb2wgaGFzVmlzaWJsZU5vbkNvbXBvc2l0aW5nRGVzY2VuZGFudChSZW5k ZXJMYXllciogcGFyZW50KQogeworICAgIC8vIEZJWE1FOiBXZSBzaG91bGRuJ3QgYmUgY2FsbGVk IHdpdGggYSBzdGFsZSB6LW9yZGVyIGxpc3RzLiBTZWUgYnVnIDg1NTEyLgorICAgIHBhcmVudC0+ dXBkYXRlTGF5ZXJMaXN0c0lmTmVlZGVkKCk7CisKKyNpZiAhQVNTRVJUX0RJU0FCTEVECisgICAg TGF5ZXJMaXN0TXV0YXRpb25EZXRlY3RvciBtdXRhdGlvbkNoZWNrZXIocGFyZW50KTsKKyNlbmRp ZgorCiAgICAgaWYgKFZlY3RvcjxSZW5kZXJMYXllcio+KiBub3JtYWxGbG93TGlzdCA9IHBhcmVu dC0+bm9ybWFsRmxvd0xpc3QoKSkgewogICAgICAgICBzaXplX3QgbGlzdFNpemUgPSBub3JtYWxG bG93TGlzdC0+c2l6ZSgpOwogICAgICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IGxpc3RTaXpl OyArK2kpIHsKQEAgLTE0NzMsMTMgKzE0ODAsNiBAQCBzdGF0aWMgYm9vbCBoYXNWaXNpYmxlTm9u Q29tcG9zaXRpbmdEZXNjZW5kYW50KFJlbmRlckxheWVyKiBwYXJlbnQpCiAvLyBDb25zZXJ2YXRp dmUgdGVzdCBmb3IgaGF2aW5nIG5vIHJlbmRlcmVkIGNoaWxkcmVuLgogYm9vbCBSZW5kZXJMYXll ckJhY2tpbmc6Omhhc1Zpc2libGVOb25Db21wb3NpdGluZ0Rlc2NlbmRhbnRMYXllcnMoKSBjb25z dAogewotICAgIC8vIEZJWE1FOiBXZSBzaG91bGRuJ3QgYmUgY2FsbGVkIHdpdGggYSBzdGFsZSB6 LW9yZGVyIGxpc3RzLiBTZWUgYnVnIDg1NTEyLgotICAgIG1fb3duaW5nTGF5ZXItPnVwZGF0ZUxh eWVyTGlzdHNJZk5lZWRlZCgpOwotCi0jaWYgIUFTU0VSVF9ESVNBQkxFRAotICAgIExheWVyTGlz dE11dGF0aW9uRGV0ZWN0b3IgbXV0YXRpb25DaGVja2VyKG1fb3duaW5nTGF5ZXIpOwotI2VuZGlm Ci0KICAgICByZXR1cm4gaGFzVmlzaWJsZU5vbkNvbXBvc2l0aW5nRGVzY2VuZGFudChtX293bmlu Z0xheWVyKTsKIH0KIAo=