109726 2013-02-13 11:55:58 -0800 ForwardInt32ToDouble is not in DFG::MinifiedNode's list of relevant node types 2013-02-13 14:38:01 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mario mark.lam mhahnenberg oliver sam oldest_to_newest 832140 0 fpizlo 2013-02-13 11:55:58 -0800 Patch forthcoming. 832247 1 fpizlo 2013-02-13 13:16:03 -0800 This is asymptomatic because ForwardInt32ToDouble is only used in SetLocals, in which case the value is already stored to the stack. Still, we should fix this. 832250 2 fpizlo 2013-02-13 13:16:56 -0800 Reviewed by Gavin in person. 832251 3 fpizlo 2013-02-13 13:17:30 -0800 Landed in http://trac.webkit.org/changeset/142780 832344 4 fpizlo 2013-02-13 14:22:35 -0800 This is causing run-javascriptcore-tests failures. Fix on the way. 832347 5 188183 fpizlo 2013-02-13 14:29:02 -0800 Created attachment 188183 fix 832354 6 188183 mhahnenberg 2013-02-13 14:35:29 -0800 Comment on attachment 188183 fix View in context: https://bugs.webkit.org/attachment.cgi?id=188183&action=review r=me with ChangeLog fix. > Source/JavaScriptCore/ChangeLog:23 > +2013-02-13 Filip Pizlo <fpizlo@apple.com> > + > + Need a short description (OOPS!). > + Need the bug URL (OOPS!). > + > + Reviewed by NOBODY (OOPS!). > + > + * dfg/DFGMinifiedNode.h: > + (JSC::DFG::MinifiedNode::hasChild): ??? 832356 7 fpizlo 2013-02-13 14:36:46 -0800 (In reply to comment #6) > (From update of attachment 188183 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=188183&action=review > > r=me with ChangeLog fix. > > > Source/JavaScriptCore/ChangeLog:23 > > +2013-02-13 Filip Pizlo <fpizlo@apple.com> > > + > > + Need a short description (OOPS!). > > + Need the bug URL (OOPS!). > > + > > + Reviewed by NOBODY (OOPS!). > > + > > + * dfg/DFGMinifiedNode.h: > > + (JSC::DFG::MinifiedNode::hasChild): > > ??? Removed. I dunno what happened there. 832358 8 fpizlo 2013-02-13 14:38:01 -0800 Landed in http://trac.webkit.org/changeset/142800 188183 2013-02-13 14:29:02 -0800 2013-02-13 14:35:29 -0800 fix the.patch text/plain 1599 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQyNzk4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBA CisyMDEzLTAyLTEzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg Rm9yd2FyZEludDMyVG9Eb3VibGUgaXMgbm90IGluIERGRzo6TWluaWZpZWROb2RlJ3MgbGlzdCBv ZiByZWxldmFudCBub2RlIHR5cGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDk3MjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKyAgICAgICAgCisgICAgICAgIElmIHlvdSBhZGQgaXQgdG8gdGhlIGxpc3Qgb2YgcmVsZXZh bnQgbm9kZSB0eXBlcywgeW91IGFsc28gbmVlZCB0byBtYWtlIHN1cmUKKyAgICAgICAgaXQncyBs aXN0ZWQgYXMgZWl0aGVyIGhhc0NoaWxkIG9yIG9uZSBvZiB0aGUgb3RoZXIga2luZHMuIE90aGVy d2lzZSB5b3UgZ2V0CisgICAgICAgIGFuIGFzc2VydGlvbi4gVGhpcyBpcyBjYXVzaW5nIHRlc3Qg ZmFpbHVyZXMgaW4gcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzLgorCisgICAgICAgICogZGZnL0RG R01pbmlmaWVkTm9kZS5oOgorICAgICAgICAoSlNDOjpERkc6Ok1pbmlmaWVkTm9kZTo6aGFzQ2hp bGQpOgorCisyMDEzLTAyLTEzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAg ICAgICAgTmVlZCBhIHNob3J0IGRlc2NyaXB0aW9uIChPT1BTISkuCisgICAgICAgIE5lZWQgdGhl IGJ1ZyBVUkwgKE9PUFMhKS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIGRmZy9ERkdNaW5pZmllZE5vZGUuaDoKKyAgICAgICAgKEpTQzo6REZHOjpN aW5pZmllZE5vZGU6Omhhc0NoaWxkKToKKwogMjAxMy0wMi0xMyAgT2xpdmVyIEh1bnQgIDxvbGl2 ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEJ1aWxkIGZpeC4KSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHTWluaWZpZWROb2RlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL2RmZy9ERkdNaW5pZmllZE5vZGUuaAkocmV2aXNpb24gMTQyNzk4KQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdNaW5pZmllZE5vZGUuaAkod29ya2luZyBjb3B5KQpA QCAtMTAyLDYgKzEwMiw3IEBAIHByaXZhdGU6CiAgICAgICAgIHN3aXRjaCAodHlwZSkgewogICAg ICAgICBjYXNlIFZhbHVlVG9JbnQzMjoKICAgICAgICAgY2FzZSBJbnQzMlRvRG91YmxlOgorICAg ICAgICBjYXNlIEZvcndhcmRJbnQzMlRvRG91YmxlOgogICAgICAgICBjYXNlIFVJbnQzMlRvTnVt YmVyOgogICAgICAgICBjYXNlIERvdWJsZUFzSW50MzI6CiAgICAgICAgICAgICByZXR1cm4gdHJ1 ZTsK