109713 2013-02-13 10:42:19 -0800 [CSS Exclusions] Enable shape-inside support for circles 2013-02-21 09:58:46 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 89707 1 giles_joplin giles_joplin betravis eric krit ojan.autocc rniwa webkit.review.bot oldest_to_newest 832051 0 giles_joplin 2013-02-13 10:42:19 -0800 Enable shape-inside support for shapes specified with the circle function. 833211 1 188379 giles_joplin 2013-02-14 10:26:27 -0800 Created attachment 188379 Patch Using the EWS to verify that supixel layout differences don't have an impact on the new test. 834098 2 188379 krit 2013-02-15 09:26:52 -0800 Comment on attachment 188379 Patch LGTM. r=me. 834103 3 188379 webkit.review.bot 2013-02-15 09:33:20 -0800 Comment on attachment 188379 Patch Clearing flags on attachment: 188379 Committed r143010: <http://trac.webkit.org/changeset/143010> 834104 4 webkit.review.bot 2013-02-15 09:33:23 -0800 All reviewed patches have been landed. Closing bug. 835815 5 rniwa 2013-02-18 16:14:30 -0800 It seems like this patch caused 16+ patches to crash on ML2 test bots? http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK2%20%28Tests%29/builds/6075 836437 6 krit 2013-02-19 08:45:56 -0800 (In reply to comment #5) > It seems like this patch caused 16+ patches to crash on ML2 test bots? > > http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK2%20%28Tests%29/builds/6075 Are you sure that this is this patch causing the errors? Here is a list of the failing tests: Regressions: Unexpected crashes (15) accessibility/accessibility-node-memory-management.html [ Crash ] accessibility/accessibility-node-reparent.html [ Crash ] animations/3d/matrix-transform-type-animation.html [ Crash ] animations/additive-transform-animations.html [ Crash ] animations/animation-add-events-in-handler.html [ Crash ] animations/animation-border-overflow.html [ Crash ] animations/animation-controller-drt-api.html [ Crash ] animations/animation-css-rule-types.html [ Crash ] canvas/philip/tests/2d.canvas.reference.html [ Crash ] canvas/philip/tests/2d.clearRect+fillRect.alpha0.5.html [ Crash ] compositing/absolute-inside-out-of-view-fixed.html [ Crash ] compositing/absolute-position-changed-in-composited-layer.html [ Crash ] compositing/video/video-poster.html [ Crash ] http/tests/cache/cached-main-resource.html [ Crash ] media/video-controls-captions-trackmenu.html [ Crash ] I did not investigate yet, but a big chunk (all?) of the tests is independent of layout code that was touched by this patch. 838532 7 giles_joplin 2013-02-21 09:58:46 -0800 *** Bug 96670 has been marked as a duplicate of this bug. *** 188379 2013-02-14 10:26:27 -0800 2013-02-15 09:33:20 -0800 Patch tmp.patch text/plain 5279 giles_joplin ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5MWM5ZDY0Li5kMzc2MjY1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDIt MTQgIEhhbnMgTXVsbGVyICA8aG11bGxlckBhZG9iZS5jb20+CisKKyAgICAgICAgW0NTUyBFeGNs dXNpb25zXSBFbmFibGUgc2hhcGUtaW5zaWRlIHN1cHBvcnQgZm9yIGNpcmNsZXMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTcxMworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIGEgdGVzdCBmb3Ig Y2lyY2xlIHNoYXBlLWluc2lkZSB2YWx1ZXMuCisKKyAgICAgICAgKiBmYXN0L2V4Y2x1c2lvbnMv c2hhcGUtaW5zaWRlL3NoYXBlLWluc2lkZS1jaXJjbGUtZXhwZWN0ZWQuaHRtbDogQWRkZWQuCisg ICAgICAgICogZmFzdC9leGNsdXNpb25zL3NoYXBlLWluc2lkZS9zaGFwZS1pbnNpZGUtY2lyY2xl Lmh0bWw6IEFkZGVkLgorCiAyMDEzLTAyLTE0ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcu Ym90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTQyODIw LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9leGNsdXNpb25zL3NoYXBlLWluc2lkZS9z aGFwZS1pbnNpZGUtY2lyY2xlLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2V4Y2x1 c2lvbnMvc2hhcGUtaW5zaWRlL3NoYXBlLWluc2lkZS1jaXJjbGUtZXhwZWN0ZWQuaHRtbApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5jZTgyZGYwCi0tLSAvZGV2L251bGwKKysr IGIvTGF5b3V0VGVzdHMvZmFzdC9leGNsdXNpb25zL3NoYXBlLWluc2lkZS9zaGFwZS1pbnNpZGUt Y2lyY2xlLWV4cGVjdGVkLmh0bWwKQEAgLTAsMCArMSw0MSBAQAorPCFET0NUWVBFIGh0bWw+Cis8 aHRtbD4KKzxoZWFkPgorPHN0eWxlPgorICAgICNzaGFwZS1pbnNpZGUgeworICAgICAgICBwb3Np dGlvbjogcmVsYXRpdmU7CisgICAgfQorCisgICAgI3NoYXBlLW91dGxpbmUgeworICAgICAgICBw b3NpdGlvbjogYWJzb2x1dGU7CisgICAgICAgIHRvcDogMHB4OworICAgICAgICBsZWZ0OiAwcHg7 CisgICAgICAgIHdpZHRoOiA0MDBweDsKKyAgICAgICAgaGVpZ2h0OiA0MDBweDsKKyAgICB9CisK KyAgICAvKiBUaGUgc2l6ZSBvZiBhIHNxdWFyZSB0aGF0IGp1c3QgZml0cyB3aXRoaW4gYSBjaXJj bGUgb2YgcmFkaXVzIHIgaXMgciAqIHNxcnQoMikuICBJbiB0aGlzCisgICAgICAgY2FzZSB0aGF0 J3MgdGhlIHNpemUgb2Ygb25lIEFoZW0gY2hhcmFjdGVyOiAxMDAgKiBzcXJ0KDIpID09IDE0MS40 Mi4KKworICAgICAgIFRoZSBsZWZ0IGFuZCB0b3AgZWRnZXMgb2YgYSBzcXVhcmUgdGhhdCBqdXN0 IGZpdHMgd2l0aGluIGEgY2lyY2xlIG9mIHJhZGl1cyByIGFyZSBvZmZzZXQKKyAgICAgICBieSBy IC0gKHIgKiBzcXJ0KDIpKSAvIDIsIHdoaWNoIGlzIDI5LjI4OSBmb3IgciA9IDEwMC4gIFRoZSBj ZW50ZXIgb2YgdGhlIGNpcmNsZSBpcyBhdCAyMDAsMjAwCisgICAgICAgc28gdGhlIHRvcCBhbmQg bGVmdCBlZGdlcyBvZiB0aGUgc3F1YXJlIGFyZSAxMjkuMjg5LgorICAgICovCisgICAgI3NoYXBl LWNvbnRlbnQgeworICAgICAgICBwb3NpdGlvbjogYWJzb2x1dGU7CisgICAgICAgIHRvcDogMTI5 LjI4OXB4OworICAgICAgICBsZWZ0OiAxMjkuMjg5cHg7CisgICAgICAgIGZvbnQ6IDE0MS40MnB4 LzEgQWhlbSwgc2Fucy1zZXJpZjsKKyAgICAgICAgY29sb3I6IGdyZWVuOworICAgIH0KKzwvc3R5 bGU+Cis8L2hlYWQ+Cis8Ym9keT4KKyAgICA8ZGl2IGlkPSJzaGFwZS1pbnNpZGUiPgorICAgICAg ICA8ZGl2IGlkPSJzaGFwZS1jb250ZW50Ij5YPC9kaXY+CisgICAgICAgIDxzdmcgaWQ9InNoYXBl LW91dGxpbmUiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyI+CisgICAgICAgICAg ICA8Y2lyY2xlIGN4PSIyMDAiIGN5PSIyMDAiIHI9IjEwMCIgc3Ryb2tlPSJibHVlIiBmaWxsPSJu b25lIi8+CisgICAgICAgIDwvc3ZnPgorICAgIDwvZGl2PgorPC9ib2R5PgorPC9odG1sPgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9leGNsdXNpb25zL3NoYXBlLWluc2lkZS9zaGFwZS1p bnNpZGUtY2lyY2xlLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2V4Y2x1c2lvbnMvc2hhcGUtaW5z aWRlL3NoYXBlLWluc2lkZS1jaXJjbGUuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwLi5hNThhYTAzCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9leGNs dXNpb25zL3NoYXBlLWluc2lkZS9zaGFwZS1pbnNpZGUtY2lyY2xlLmh0bWwKQEAgLTAsMCArMSwz OSBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdD4KKyAgICBpZiAo d2luZG93LmludGVybmFscykKKyAgICAgICAgd2luZG93LmludGVybmFscy5zZXR0aW5ncy5zZXRD U1NFeGNsdXNpb25zRW5hYmxlZCh0cnVlKTsKKzwvc2NyaXB0PgorPHN0eWxlPgorICAgIC8qIFRo ZSBzaXplIG9mIGEgc3F1YXJlIHRoYXQganVzdCBmaXRzIHdpdGhpbiBhIGNpcmNsZSBvZiByYWRp dXMgciBpcyByICogc3FydCgyKS4gIEluIHRoaXMKKyAgICAgICBjYXNlIHRoYXQncyB0aGUgc2l6 ZSBvZiBvbmUgQWhlbSBjaGFyYWN0ZXI6IDEwMCAqIHNxcnQoMikgPT0gMTQxLjQyLgorICAgICov CisgICAgI3NoYXBlLWluc2lkZSB7CisgICAgICAgIHBvc2l0aW9uOiByZWxhdGl2ZTsKKyAgICAg ICAgd2lkdGg6IDQwMHB4OworICAgICAgICBoZWlnaHQ6IDQwMHB4OworICAgICAgICAtd2Via2l0 LXNoYXBlLWluc2lkZTogY2lyY2xlKDIwMHB4LCAyMDBweCwgMTAwcHgpOworICAgICAgICBmb250 OiAxNDEuNDJweC8xIEFoZW0sIHNhbnMtc2VyaWY7CisKKyAgICAgICAgY29sb3I6IGdyZWVuOwor ICAgIH0KKworICAgICNzaGFwZS1vdXRsaW5lIHsKKyAgICAgICAgcG9zaXRpb246IGFic29sdXRl OworICAgICAgICB0b3A6IDBweDsKKyAgICAgICAgbGVmdDogMHB4OworICAgICAgICB3aWR0aDog NDAwcHg7CisgICAgICAgIGhlaWdodDogNDAwcHg7CisgICAgfQorPC9zdHlsZT4KKzwvaGVhZD4K Kzxib2R5PgorICAgIDxkaXYgaWQ9InNoYXBlLWluc2lkZSI+CisgICAgICAgIDxzdmcgaWQ9InNo YXBlLW91dGxpbmUiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyI+CisgICAgICAg ICAgICA8Y2lyY2xlIGN4PSIyMDAiIGN5PSIyMDAiIHI9IjEwMCIgc3Ryb2tlPSJibHVlIiBmaWxs PSJub25lIi8+CisgICAgICAgIDwvc3ZnPgorICAgICAgICBYCisgICAgPC9kaXY+Cis8L2JvZHk+ Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWUzOWRiNS4uODQwYjgwYSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE5IEBACisyMDEzLTAyLTE0ICBIYW5zIE11bGxlciAgPGhtdWxsZXJAYWRvYmUuY29t PgorCisgICAgICAgIFtDU1MgRXhjbHVzaW9uc10gRW5hYmxlIHNoYXBlLWluc2lkZSBzdXBwb3J0 IGZvciBjaXJjbGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMDk3MTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBSZW1vdmVkIHRoZSB0ZXN0IHRoYXQgZGlzYWJsZWQgY2lyY2xlIHZhbHVlcyBmb3Igc2hh cGUtaW5zaWRlLgorICAgICAgICBUaGUgcmVtYWluaW5nIHN1cHBvcnQgZm9yIGNpcmNsZXMsIHdo aWNoIGlzIGJhc2VkIG9uIHJvdW5kZWQgcmVjdGFuZ2xlcworICAgICAgICB3aG9zZSB3aWR0aC9o ZWlnaHQgaXMgZXF1YWwgdG8gdGhlaXIgcmFkaXVzWC9yYWRpdXNZLCBoYXMgbm90IGNoYW5nZWQu CisKKyAgICAgICAgVGVzdDogZmFzdC9leGNsdXNpb25zL3NoYXBlLWluc2lkZS9zaGFwZS1pbnNp ZGUtY2lyY2xlLmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9FeGNsdXNpb25TaGFwZUluc2lk ZUluZm8uaDoKKyAgICAgICAgKFdlYkNvcmU6OkV4Y2x1c2lvblNoYXBlSW5zaWRlSW5mbzo6aXNF bmFibGVkRm9yKTogTm93IG9ubHkgZGlzYWxsb3dzIGVsbGlwc2UuCisKIDIwMTMtMDItMTQgIFNo ZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2 aWV3ZWQsIHJvbGxpbmcgb3V0IHIxNDI4MjAuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvRXhjbHVzaW9uU2hhcGVJbnNpZGVJbmZvLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvRXhjbHVzaW9uU2hhcGVJbnNpZGVJbmZvLmgKaW5kZXggN2I3MWI3My4uZGEzYzQ3ZSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0V4Y2x1c2lvblNoYXBlSW5zaWRl SW5mby5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9FeGNsdXNpb25TaGFwZUluc2lk ZUluZm8uaApAQCAtNjEsNyArNjEsNyBAQCBwdWJsaWM6CiAgICAgICAgIC8vIEZJWE1FOiBCdWcg ODk3MDc6IEVuYWJsZSBzaGFwZSBpbnNpZGUgZm9yIG5vbi1yZWN0YW5ndWxhciBzaGFwZXMKICAg ICAgICAgRXhjbHVzaW9uU2hhcGVWYWx1ZSogc2hhcGVWYWx1ZSA9IHJlbmRlcmVyLT5zdHlsZSgp LT5zaGFwZUluc2lkZSgpOwogICAgICAgICBCYXNpY1NoYXBlKiBzaGFwZSA9IChzaGFwZVZhbHVl ICYmIHNoYXBlVmFsdWUtPnR5cGUoKSA9PSBFeGNsdXNpb25TaGFwZVZhbHVlOjpTSEFQRSkgPyBz aGFwZVZhbHVlLT5zaGFwZSgpIDogMDsKLSAgICAgICAgcmV0dXJuIHNoYXBlICYmIChzaGFwZS0+ dHlwZSgpID09IEJhc2ljU2hhcGU6OkJBU0lDX1NIQVBFX1JFQ1RBTkdMRSB8fCBzaGFwZS0+dHlw ZSgpID09IEJhc2ljU2hhcGU6OkJBU0lDX1NIQVBFX1BPTFlHT04pOworICAgICAgICByZXR1cm4g c2hhcGUgJiYgc2hhcGUtPnR5cGUoKSAhPSBCYXNpY1NoYXBlOjpCQVNJQ19TSEFQRV9FTExJUFNF OwogICAgIH0KICAgICBib29sIGxpbmVPdmVybGFwc1NoYXBlQm91bmRzKCkgY29uc3QgeyByZXR1 cm4gbG9naWNhbExpbmVUb3AoKSA8IHNoYXBlTG9naWNhbEJvdHRvbSgpICYmIGxvZ2ljYWxMaW5l Qm90dG9tKCkgPj0gc2hhcGVMb2dpY2FsVG9wKCk7IH0KIAo=