109701 2013-02-13 08:21:35 -0800 EME: MediaPlayer::keyNeede() should return a bool indicating whether an event listener was triggered. 2013-02-13 16:03:55 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jer.noble jer.noble ddorwin eric.carlson feature-media-reviews ojan.autocc webkit.review.bot oldest_to_newest 831928 0 jer.noble 2013-02-13 08:21:35 -0800 EME: MediaPlayer::keyNeede() should return a bool indicating whether an event listener was triggered. 831999 1 188103 jer.noble 2013-02-13 09:55:44 -0800 Created attachment 188103 Patch Now with missing changes to HTMLMediaElement.cpp 832457 2 188103 webkit.review.bot 2013-02-13 16:03:51 -0800 Comment on attachment 188103 Patch Clearing flags on attachment: 188103 Committed r142819: <http://trac.webkit.org/changeset/142819> 832458 3 webkit.review.bot 2013-02-13 16:03:55 -0800 All reviewed patches have been landed. Closing bug. 188103 2013-02-13 09:55:44 -0800 2013-02-13 16:03:51 -0800 Patch bug-109701-20130213095213.patch text/plain 4647 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyMzI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGViNzgxOWNmODlkNmU0 ZmIwNzg4YzMyYmY3ZWQ0ZTUyMjZlMTU2Ny4uNGYyODU2OTc3OTg4NjBkNzc1ZDdjYjY4NWU5OWVm MzU1Zjg0Yzc3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAyLTEzICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIEVNRTogTWVkaWFQbGF5ZXI6 OmtleU5lZWRlKCkgc2hvdWxkIHJldHVybiBhIGJvb2wgaW5kaWNhdGluZyB3aGV0aGVyIGFuIGV2 ZW50IGxpc3RlbmVyIHdhcyB0cmlnZ2VyZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMDk3MDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBDbGllbnRzIG9mIE1lZGlhUGxheWVyIG1heSBuZWVkIHRvIGRv IGNsZWFudXAgaWYgY2FsbGluZyBrZXlOZWVkZWQoKQorICAgICAgICByZXN1bHRzIGluIG5vIGV2 ZW50IGxpc3RlbmVyIGJlaW5nIHRyaWdnZXJlZC4gUmV0dXJuIGEgYm9vbCAobGlrZSB0aGUKKyAg ICAgICAgdjEgZXF1aXZhbGVudCBrZXlOZWVkZWQgbWV0aG9kKSB0byBpbmRpY2F0ZSB0aGlzLgor CisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkhUTUxNZWRpYUVsZW1lbnQ6Om1lZGlhUGxheWVyS2V5TmVlZGVkKToKKyAgICAgICAgKiBodG1s L0hUTUxNZWRpYUVsZW1lbnQuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBs YXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllcjo6a2V5TmVlZGVkKToKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5oOgorICAgICAgICAoV2ViQ29y ZTo6TWVkaWFQbGF5ZXJDbGllbnQ6Om1lZGlhUGxheWVyS2V5TmVlZGVkKToKKwogMjAxMy0wMi0x MiAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBNZWRpYUtleVNl c3Npb24gc2hvdWxkIG5vdCBiZSBHQ2Qgd2hpbGUgZmlyaW5nIGV2ZW50IGxpc3RlbmVycyBvciB3 aXRoIGN1c3RvbSBwcm9wZXJ0aWVzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MTWVkaWFFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVu dC5jcHAKaW5kZXggNmJkNTlmNDE5MDMzMDRiN2U0MjVkNTVhYmMyMDI2MzQ4ZDRjYzhjNi4uODMz YTliMmM0MzkzNmRiNzgyOTVhNWM5OWFkZmE1Y2ZjYjM3NGU3MSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCkBAIC0xOTcyLDggKzE5NzIsMTQgQEAgYm9vbCBIVE1M TWVkaWFFbGVtZW50OjptZWRpYVBsYXllcktleU5lZWRlZChNZWRpYVBsYXllciosIGNvbnN0IFN0 cmluZyYga2V5U3lzdGUKICNlbmRpZgogCiAjaWYgRU5BQkxFKEVOQ1JZUFRFRF9NRURJQV9WMikK LXZvaWQgSFRNTE1lZGlhRWxlbWVudDo6bWVkaWFQbGF5ZXJLZXlOZWVkZWQoTWVkaWFQbGF5ZXIq LCBVaW50OEFycmF5KiBpbml0RGF0YSkKK2Jvb2wgSFRNTE1lZGlhRWxlbWVudDo6bWVkaWFQbGF5 ZXJLZXlOZWVkZWQoTWVkaWFQbGF5ZXIqLCBVaW50OEFycmF5KiBpbml0RGF0YSkKIHsKKyAgICBp ZiAoIWhhc0V2ZW50TGlzdGVuZXJzKCJ3ZWJraXRuZWVka2V5IikpIHsKKyAgICAgICAgbV9lcnJv ciA9IE1lZGlhRXJyb3I6OmNyZWF0ZShNZWRpYUVycm9yOjpNRURJQV9FUlJfRU5DUllQVEVEKTsK KyAgICAgICAgc2NoZWR1bGVFdmVudChldmVudE5hbWVzKCkuZXJyb3JFdmVudCk7CisgICAgICAg IHJldHVybiBmYWxzZTsKKyAgICB9CisKICAgICBNZWRpYUtleU5lZWRlZEV2ZW50SW5pdCBpbml0 aWFsaXplcjsKICAgICBpbml0aWFsaXplci5pbml0RGF0YSA9IGluaXREYXRhOwogICAgIGluaXRp YWxpemVyLmJ1YmJsZXMgPSBmYWxzZTsKQEAgLTE5ODIsNiArMTk4OCw4IEBAIHZvaWQgSFRNTE1l ZGlhRWxlbWVudDo6bWVkaWFQbGF5ZXJLZXlOZWVkZWQoTWVkaWFQbGF5ZXIqLCBVaW50OEFycmF5 KiBpbml0RGF0YSkKICAgICBSZWZQdHI8RXZlbnQ+IGV2ZW50ID0gTWVkaWFLZXlOZWVkZWRFdmVu dDo6Y3JlYXRlKGV2ZW50TmFtZXMoKS53ZWJraXRuZWVka2V5RXZlbnQsIGluaXRpYWxpemVyKTsK ICAgICBldmVudC0+c2V0VGFyZ2V0KHRoaXMpOwogICAgIG1fYXN5bmNFdmVudFF1ZXVlLT5lbnF1 ZXVlRXZlbnQoZXZlbnQucmVsZWFzZSgpKTsKKworICAgIHJldHVybiB0cnVlOwogfQogCiB2b2lk IEhUTUxNZWRpYUVsZW1lbnQ6OnNldE1lZGlhS2V5cyhNZWRpYUtleXMqIG1lZGlhS2V5cykKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oIGIvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmgKaW5kZXggOGZmMTJkMWI1NDlkOGNlMmRi NGI2ODJiYjk0NThlMmI0MjNhYTI4Ni4uNjA2ZWZkMDY4NDZmNTY0ZWZmOTIzOWMyNThjY2FjNWY3 NDBmMDkzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50 LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmgKQEAgLTQ1NSw3 ICs0NTUsNyBAQCBwcml2YXRlOgogI2VuZGlmCiAKICNpZiBFTkFCTEUoRU5DUllQVEVEX01FRElB X1YyKQotICAgIHZpcnR1YWwgdm9pZCBtZWRpYVBsYXllcktleU5lZWRlZChNZWRpYVBsYXllcios IFVpbnQ4QXJyYXkqKTsKKyAgICB2aXJ0dWFsIGJvb2wgbWVkaWFQbGF5ZXJLZXlOZWVkZWQoTWVk aWFQbGF5ZXIqLCBVaW50OEFycmF5Kik7CiAjZW5kaWYKIAogICAgIHZpcnR1YWwgU3RyaW5nIG1l ZGlhUGxheWVyUmVmZXJyZXIoKSBjb25zdCBPVkVSUklERTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmNwcAppbmRleCAwM2QzOTFjNjEzNmQ3NjJl OWY3ZTE2NWE4Y2UwNDg2YjJjYzE2NDMwLi4wYjI1NDRmOTIxNjE4ZjJlMTMxMDU4OWIwOTZhNjFm OGIwNWY2OTkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9N ZWRpYVBsYXllci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvTWVk aWFQbGF5ZXIuY3BwCkBAIC0xMDgyLDEwICsxMDgyLDExIEBAIGJvb2wgTWVkaWFQbGF5ZXI6Omtl eU5lZWRlZChjb25zdCBTdHJpbmcmIGtleVN5c3RlbSwgY29uc3QgU3RyaW5nJiBzZXNzaW9uSWQs IGNvCiAjZW5kaWYKIAogI2lmIEVOQUJMRShFTkNSWVBURURfTUVESUFfVjIpCi12b2lkIE1lZGlh UGxheWVyOjprZXlOZWVkZWQoVWludDhBcnJheSogaW5pdERhdGEpCitib29sIE1lZGlhUGxheWVy OjprZXlOZWVkZWQoVWludDhBcnJheSogaW5pdERhdGEpCiB7CiAgICAgaWYgKG1fbWVkaWFQbGF5 ZXJDbGllbnQpCi0gICAgICAgIG1fbWVkaWFQbGF5ZXJDbGllbnQtPm1lZGlhUGxheWVyS2V5TmVl ZGVkKHRoaXMsIGluaXREYXRhKTsKKyAgICAgICAgcmV0dXJuIG1fbWVkaWFQbGF5ZXJDbGllbnQt Pm1lZGlhUGxheWVyS2V5TmVlZGVkKHRoaXMsIGluaXREYXRhKTsKKyAgICByZXR1cm4gZmFsc2U7 CiB9CiAjZW5kaWYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvTWVkaWFQbGF5ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlh UGxheWVyLmgKaW5kZXggY2I1NTc4YjgxNTA5OGE2NDM3MTIzMzEzYzZkMzAzYzIxZjhjYjA4Yy4u NjNjZTA5Zjc5Yjg2ZjRiYjA4MGY5YTc5MzYyOTgxNDc3NmVhNzgxNyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5oCkBAIC0xOTQsNyArMTk0LDcg QEAgcHVibGljOgogI2VuZGlmCiAKICNpZiBFTkFCTEUoRU5DUllQVEVEX01FRElBX1YyKQotICAg IHZpcnR1YWwgdm9pZCBtZWRpYVBsYXllcktleU5lZWRlZChNZWRpYVBsYXllciosIFVpbnQ4QXJy YXkqKSB7IH0KKyAgICB2aXJ0dWFsIGJvb2wgbWVkaWFQbGF5ZXJLZXlOZWVkZWQoTWVkaWFQbGF5 ZXIqLCBVaW50OEFycmF5KikgeyByZXR1cm4gZmFsc2U7IH0KICNlbmRpZgogICAgIAogICAgIHZp cnR1YWwgU3RyaW5nIG1lZGlhUGxheWVyUmVmZXJyZXIoKSBjb25zdCB7IHJldHVybiBTdHJpbmco KTsgfQpAQCAtNDM1LDcgKzQzNSw3IEBAIHB1YmxpYzoKICNlbmRpZgogCiAjaWYgRU5BQkxFKEVO Q1JZUFRFRF9NRURJQV9WMikKLSAgICB2b2lkIGtleU5lZWRlZChVaW50OEFycmF5KiBpbml0RGF0 YSk7CisgICAgYm9vbCBrZXlOZWVkZWQoVWludDhBcnJheSogaW5pdERhdGEpOwogI2VuZGlmCiAK ICAgICBTdHJpbmcgcmVmZXJyZXIoKSBjb25zdDsK